coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: mb/google/rambi/Kconfig: Reorder selects alphabetically
by Felix Singer (Code Review) 24 Dec '21

24 Dec '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60346 ) Change subject: mb/google/rambi/Kconfig: Reorder selects alphabetically ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60346 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22e189dfa9b8944341aafcafe4e97dca65558937 Gerrit-Change-Number: 60346 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 24 Dec 2021 21:20:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/rambi: Select board-specific options per board
by Felix Singer (Code Review) 24 Dec '21

24 Dec '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60364 ) Change subject: mb/google/rambi: Select board-specific options per board ...................................................................... mb/google/rambi: Select board-specific options per board Move board-specific selects out of common configuration and add them to each board where necessary. Change-Id: I20d79d4b42908314dbf7021a67b92e5fd2b79556 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/google/rambi/Kconfig 1 file changed, 29 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/60364/1 diff --git a/src/mainboard/google/rambi/Kconfig b/src/mainboard/google/rambi/Kconfig index 5bd268a..d513672 100644 --- a/src/mainboard/google/rambi/Kconfig +++ b/src/mainboard/google/rambi/Kconfig @@ -9,60 +9,87 @@ select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE select HAVE_SPD_IN_CBFS - select INTEL_GMA_HAVE_VBT if !BOARD_GOOGLE_RAMBI select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_LPC_TPM select MAINBOARD_HAS_TPM1 select SOC_INTEL_BAYTRAIL - select SYSTEM_TYPE_LAPTOP if !BOARD_GOOGLE_NINJA && !BOARD_GOOGLE_SUMO config BOARD_GOOGLE_BANJO select BOARD_GOOGLE_BASEBOARD_RAMBI + select INTEL_GMA_HAVE_VBT + select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_CANDY select BOARD_GOOGLE_BASEBOARD_RAMBI + select INTEL_GMA_HAVE_VBT + select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_CLAPPER select BOARD_GOOGLE_BASEBOARD_RAMBI + select INTEL_GMA_HAVE_VBT + select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_ENGUARDE select BOARD_GOOGLE_BASEBOARD_RAMBI + select INTEL_GMA_HAVE_VBT + select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_GLIMMER select BOARD_GOOGLE_BASEBOARD_RAMBI + select INTEL_GMA_HAVE_VBT + select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_GNAWTY select BOARD_GOOGLE_BASEBOARD_RAMBI + select INTEL_GMA_HAVE_VBT + select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_HELI select BOARD_GOOGLE_BASEBOARD_RAMBI + select INTEL_GMA_HAVE_VBT + select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_KIP select BOARD_GOOGLE_BASEBOARD_RAMBI + select INTEL_GMA_HAVE_VBT + select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_NINJA select BOARD_GOOGLE_BASEBOARD_RAMBI + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_ORCO select BOARD_GOOGLE_BASEBOARD_RAMBI + select INTEL_GMA_HAVE_VBT + select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_QUAWKS select BOARD_GOOGLE_BASEBOARD_RAMBI + select INTEL_GMA_HAVE_VBT + select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_SQUAWKS select BOARD_GOOGLE_BASEBOARD_RAMBI + select INTEL_GMA_HAVE_VBT + select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_RAMBI select BOARD_GOOGLE_BASEBOARD_RAMBI + select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_SUMO select BOARD_GOOGLE_BASEBOARD_RAMBI + select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_SWANKY select BOARD_GOOGLE_BASEBOARD_RAMBI + select INTEL_GMA_HAVE_VBT + select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_WINKY select BOARD_GOOGLE_BASEBOARD_RAMBI + select INTEL_GMA_HAVE_VBT + select SYSTEM_TYPE_LAPTOP if BOARD_GOOGLE_BASEBOARD_RAMBI -- To view, visit https://review.coreboot.org/c/coreboot/+/60364 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20d79d4b42908314dbf7021a67b92e5fd2b79556 Gerrit-Change-Number: 60364 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/rambi: Move selects from Kconfig.name to Kconfig
by Felix Singer (Code Review) 24 Dec '21

24 Dec '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60363 ) Change subject: mb/google/rambi: Move selects from Kconfig.name to Kconfig ...................................................................... mb/google/rambi: Move selects from Kconfig.name to Kconfig Move selects from Kconfig.name to Kconfig so that the configuration is at one place and not distributed over two files. Change-Id: Ibd78e1c42d6184127277c1b5dea66150027444fe Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/google/rambi/Kconfig M src/mainboard/google/rambi/Kconfig.name 2 files changed, 48 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/60363/1 diff --git a/src/mainboard/google/rambi/Kconfig b/src/mainboard/google/rambi/Kconfig index 69fb843..5bd268a 100644 --- a/src/mainboard/google/rambi/Kconfig +++ b/src/mainboard/google/rambi/Kconfig @@ -16,6 +16,54 @@ select SOC_INTEL_BAYTRAIL select SYSTEM_TYPE_LAPTOP if !BOARD_GOOGLE_NINJA && !BOARD_GOOGLE_SUMO +config BOARD_GOOGLE_BANJO + select BOARD_GOOGLE_BASEBOARD_RAMBI + +config BOARD_GOOGLE_CANDY + select BOARD_GOOGLE_BASEBOARD_RAMBI + +config BOARD_GOOGLE_CLAPPER + select BOARD_GOOGLE_BASEBOARD_RAMBI + +config BOARD_GOOGLE_ENGUARDE + select BOARD_GOOGLE_BASEBOARD_RAMBI + +config BOARD_GOOGLE_GLIMMER + select BOARD_GOOGLE_BASEBOARD_RAMBI + +config BOARD_GOOGLE_GNAWTY + select BOARD_GOOGLE_BASEBOARD_RAMBI + +config BOARD_GOOGLE_HELI + select BOARD_GOOGLE_BASEBOARD_RAMBI + +config BOARD_GOOGLE_KIP + select BOARD_GOOGLE_BASEBOARD_RAMBI + +config BOARD_GOOGLE_NINJA + select BOARD_GOOGLE_BASEBOARD_RAMBI + +config BOARD_GOOGLE_ORCO + select BOARD_GOOGLE_BASEBOARD_RAMBI + +config BOARD_GOOGLE_QUAWKS + select BOARD_GOOGLE_BASEBOARD_RAMBI + +config BOARD_GOOGLE_SQUAWKS + select BOARD_GOOGLE_BASEBOARD_RAMBI + +config BOARD_GOOGLE_RAMBI + select BOARD_GOOGLE_BASEBOARD_RAMBI + +config BOARD_GOOGLE_SUMO + select BOARD_GOOGLE_BASEBOARD_RAMBI + +config BOARD_GOOGLE_SWANKY + select BOARD_GOOGLE_BASEBOARD_RAMBI + +config BOARD_GOOGLE_WINKY + select BOARD_GOOGLE_BASEBOARD_RAMBI + if BOARD_GOOGLE_BASEBOARD_RAMBI config VBOOT diff --git a/src/mainboard/google/rambi/Kconfig.name b/src/mainboard/google/rambi/Kconfig.name index fe26faa..bae223e 100644 --- a/src/mainboard/google/rambi/Kconfig.name +++ b/src/mainboard/google/rambi/Kconfig.name @@ -2,64 +2,48 @@ config BOARD_GOOGLE_BANJO bool "-> Banjo (Acer Chromebook 15 (CB3-531))" - select BOARD_GOOGLE_BASEBOARD_RAMBI config BOARD_GOOGLE_CANDY bool "-> Candy (Dell Chromebook 11 3120)" - select BOARD_GOOGLE_BASEBOARD_RAMBI config BOARD_GOOGLE_CLAPPER bool "-> Clapper (Lenovo N20 Chromebook)" - select BOARD_GOOGLE_BASEBOARD_RAMBI config BOARD_GOOGLE_ENGUARDE bool "-> Enguarde" - select BOARD_GOOGLE_BASEBOARD_RAMBI config BOARD_GOOGLE_GLIMMER bool "-> Glimmer (Lenovo ThinkPad 11e Chromebook)" - select BOARD_GOOGLE_BASEBOARD_RAMBI config BOARD_GOOGLE_GNAWTY bool "-> Gnawty (Acer Chromebook 11 (CB3-111/131,C730/C730E/C735))" - select BOARD_GOOGLE_BASEBOARD_RAMBI config BOARD_GOOGLE_HELI bool "-> Heli (Haier Chromebook G2)" - select BOARD_GOOGLE_BASEBOARD_RAMBI config BOARD_GOOGLE_KIP bool "-> Kip (HP Chromebook 11 G3 / G4 / G4 EE)" - select BOARD_GOOGLE_BASEBOARD_RAMBI config BOARD_GOOGLE_NINJA bool "-> Ninja (AOpen Chromebox Commercial)" - select BOARD_GOOGLE_BASEBOARD_RAMBI config BOARD_GOOGLE_ORCO bool "-> Orco (Lenovo 100S Chromebook)" - select BOARD_GOOGLE_BASEBOARD_RAMBI config BOARD_GOOGLE_QUAWKS bool "-> Quawks (ASUS Chromebook C300)" - select BOARD_GOOGLE_BASEBOARD_RAMBI config BOARD_GOOGLE_SQUAWKS bool "-> Squawks (ASUS Chromebook C200)" - select BOARD_GOOGLE_BASEBOARD_RAMBI config BOARD_GOOGLE_RAMBI bool "-> Rambi" - select BOARD_GOOGLE_BASEBOARD_RAMBI config BOARD_GOOGLE_SUMO bool "-> Sumo (AOpen Chromebase Commercial)" - select BOARD_GOOGLE_BASEBOARD_RAMBI config BOARD_GOOGLE_SWANKY bool "-> Swanky (Toshiba Chromebook 2)" - select BOARD_GOOGLE_BASEBOARD_RAMBI config BOARD_GOOGLE_WINKY bool "-> Winky (Samsung Chromebook 2 (XE500C12))" - select BOARD_GOOGLE_BASEBOARD_RAMBI -- To view, visit https://review.coreboot.org/c/coreboot/+/60363 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd78e1c42d6184127277c1b5dea66150027444fe Gerrit-Change-Number: 60363 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/octopus: Drop unnecessary option
by Felix Singer (Code Review) 24 Dec '21

24 Dec '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60345 ) Change subject: mb/google/octopus: Drop unnecessary option ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60345 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia3d220401eeaa4255d6a4472eeed15c51f6a81a9 Gerrit-Change-Number: 60345 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 24 Dec 2021 21:10:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/octopus: Move selects from Kconfig.name to Kconfig
by Felix Singer (Code Review) 24 Dec '21

24 Dec '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60344 ) Change subject: mb/google/octopus: Move selects from Kconfig.name to Kconfig ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60344 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5949fc474c4923beb1f41a40876f03e5c70fc5b1 Gerrit-Change-Number: 60344 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 24 Dec 2021 21:09:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/octopus/Kconfig: Reorder selects alphabetically
by Felix Singer (Code Review) 24 Dec '21

24 Dec '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60343 ) Change subject: mb/google/octopus/Kconfig: Reorder selects alphabetically ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60343 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I545a1111e24f45f732f1c325c808737dfb6bcae6 Gerrit-Change-Number: 60343 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 24 Dec 2021 21:09:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Allow variants to choose CAR setup configuration
by Subrata Banik (Code Review) 24 Dec '21

24 Dec '21

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59272 ) Change subject: mb/google/brya: Allow variants to choose CAR setup configuration ...................................................................... mb/google/brya: Allow variants to choose CAR setup configuration Lists of changes: 1. Create choice config to let ADL mb variants to pick the desire CAR setup configuration between NEM and eNEM, where NEM and eNEM Kconfig have selected its required IA SoC common CAR Kconfig to able to perform the early boot configuration using CAR. 2. Lists of variants (kano, redrix, and felwinter) to drop INTEL_CAR_NEM Kconfig select and choose eNEM. 3. Default CAR configuration for ADL mb is still NEM due to still using older SoC skus without eNEM support enabled. BUG=b:168820083 TEST=Able to build and boot P2 boards using eNEM mode. Change-Id: Ibe94e6b82739ec65829859271622d904d75e978d Signed-off-by: subratabanik <subratabanik(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/59272 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Reviewed-by: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> --- M src/mainboard/google/brya/Kconfig 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified EricR Lai: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index fa618b9..02ca38f 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -51,7 +51,6 @@ select SOC_INTEL_ALDERLAKE_PCH_P select SOC_INTEL_COMMON_BLOCK_PCIE_RTD3 select SOC_INTEL_CSE_LITE_SKU - select INTEL_CAR_NEM #TODO - Enable INTEL_CAR_NEM_ENHANCED config BASEBOARD_DIR string @@ -172,4 +171,19 @@ config USE_PM_ACPI_TIMER default n +choice + prompt "Cache as RAM (CAR) setup configuration to use" + default USE_ADL_ENEM if BOARD_GOOGLE_KANO || BOARD_GOOGLE_FELWINTER || BOARD_GOOGLE_REDRIX + default USE_ADL_NEM + +config USE_ADL_ENEM + bool "eNEM: when selected, the variant will use eNEM instead of regular NEM." + select INTEL_CAR_NEM_ENHANCED + +config USE_ADL_NEM + bool "NEM: when selected, the variant will use regular NEM." + select INTEL_CAR_NEM + +endchoice + endif # BOARD_GOOGLE_BASEBOARD_BRYA || BOARD_GOOGLE_BASEBOARD_BRASK -- To view, visit https://review.coreboot.org/c/coreboot/+/59272 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe94e6b82739ec65829859271622d904d75e978d Gerrit-Change-Number: 59272 Gerrit-PatchSet: 6 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: David Wu <david_wu(a)quantatw.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/brya: Allow variants to choose CAR setup configuration
by Subrata Banik (Code Review) 24 Dec '21

24 Dec '21

Attention is currently required from: David Wu, Subrata Banik, Maulik V Vaghela, Chen Wisley. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59272 ) Change subject: mb/google/brya: Allow variants to choose CAR setup configuration ...................................................................... Patch Set 5: (1 comment) File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/59272/comment/b26485c3_d20c992e PS3, Line 134: BOARD_GOOGLE_BRYA0 > resolved offline. Will again take a look into this next week if any other variants has adopted QS samples then we have to add additional board with eNEM support enable. -- To view, visit https://review.coreboot.org/c/coreboot/+/59272 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe94e6b82739ec65829859271622d904d75e978d Gerrit-Change-Number: 59272 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: David Wu <david_wu(a)quantatw.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Attention: David Wu <david_wu(a)quantatw.com> Gerrit-Attention: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Comment-Date: Fri, 24 Dec 2021 20:26:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subi.banik(a)gmail.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8186: adjust usage of SRAM L2C
by Paul Menzel (Code Review) 24 Dec '21

24 Dec '21

Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60316 ) Change subject: soc/mediatek/mt8186: adjust usage of SRAM L2C ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60316/comment/84738c5c_4e2bcfc9 PS4, Line 8: Please describe the problem at hand. https://review.coreboot.org/c/coreboot/+/60316/comment/03339845_76d598dc PS4, Line 9: However the BootROM : has configured only half of L2/L3 cache as SRAM. Is that a bug? Can the BootROM be fixed? -- To view, visit https://review.coreboot.org/c/coreboot/+/60316 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6041767a1ac0a48ecdda29a0c35d90acf6ad0ef2 Gerrit-Change-Number: 60316 Gerrit-PatchSet: 4 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Comment-Date: Fri, 24 Dec 2021 20:23:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/hatch: Move selects from Kconfig.name to Kconfig
by 9elements QA (Code Review) 24 Dec '21

24 Dec '21

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60155 ) Change subject: mb/google/hatch: Move selects from Kconfig.name to Kconfig ...................................................................... Patch Set 7: Automatic boot test returned (PASS/FAIL/TOTAL): 7 / 1 / 8 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/85680 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/85679 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/85678 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/85677 PASS: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/85676 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/85675 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/85674 FAIL: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/85673 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/60155 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idb7fcaaa175eb5b6e953ad0d5e2c5757d18838e4 Gerrit-Change-Number: 60155 Gerrit-PatchSet: 7 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 24 Dec 2021 19:55:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021