coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: mb/google/volteer: Select board-specific options per board
by Felix Singer (Code Review) 25 Dec '21

25 Dec '21

Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60370 ) Change subject: mb/google/volteer: Select board-specific options per board ...................................................................... mb/google/volteer: Select board-specific options per board Move board-specific selects out of common configuration and add them to each board where necessary. Change-Id: I6c5305a764b7a362f9f381580a1cd2c20a8f2e9d Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/google/volteer/Kconfig 1 file changed, 19 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/60370/1 diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig index ced8d9d..df2d4a5 100644 --- a/src/mainboard/google/volteer/Kconfig +++ b/src/mainboard/google/volteer/Kconfig @@ -28,8 +28,6 @@ select HAVE_SPD_IN_CBFS select INTEL_LPSS_UART_FOR_CONSOLE select MAINBOARD_HAS_CHROMEOS - select MAINBOARD_HAS_I2C_TPM_CR50 if BOARD_GOOGLE_VOLTEER2_TI50 - select MAINBOARD_HAS_SPI_TPM_CR50 if !BOARD_GOOGLE_VOLTEER2_TI50 select MAINBOARD_HAS_TPM2 select SOC_INTEL_COMMON_BLOCK_TCSS select SOC_INTEL_CSE_LITE_SKU @@ -38,13 +36,16 @@ config BOARD_GOOGLE_DELBIN select BOARD_GOOGLE_BASEBOARD_VOLTEER select DRIVERS_GENESYSLOGIC_GL9755 + select MAINBOARD_HAS_SPI_TPM_CR50 config BOARD_GOOGLE_ELDRID select BOARD_GOOGLE_BASEBOARD_VOLTEER + select MAINBOARD_HAS_SPI_TPM_CR50 config BOARD_GOOGLE_HALVOR select BOARD_GOOGLE_BASEBOARD_VOLTEER select INTEL_CAR_NEM + select MAINBOARD_HAS_SPI_TPM_CR50 config BOARD_GOOGLE_LINDAR select BOARD_GOOGLE_BASEBOARD_VOLTEER @@ -52,25 +53,31 @@ select DRIVERS_GENERIC_BAYHUB_LV2 select DRIVERS_I2C_RT1011 select INTEL_CAR_NEM + select MAINBOARD_HAS_SPI_TPM_CR50 config BOARD_GOOGLE_MALEFOR select BOARD_GOOGLE_BASEBOARD_VOLTEER select INTEL_CAR_NEM + select MAINBOARD_HAS_SPI_TPM_CR50 config BOARD_GOOGLE_TERRADOR select BOARD_GOOGLE_BASEBOARD_VOLTEER + select MAINBOARD_HAS_SPI_TPM_CR50 config BOARD_GOOGLE_TODOR select BOARD_GOOGLE_BASEBOARD_VOLTEER select INTEL_CAR_NEM + select MAINBOARD_HAS_SPI_TPM_CR50 config BOARD_GOOGLE_TRONDO select BOARD_GOOGLE_BASEBOARD_VOLTEER select INTEL_CAR_NEM + select MAINBOARD_HAS_SPI_TPM_CR50 config BOARD_GOOGLE_VOLTEER select BOARD_GOOGLE_BASEBOARD_VOLTEER select INTEL_CAR_NEM + select MAINBOARD_HAS_SPI_TPM_CR50 select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES select VARIANT_HAS_MIPI_CAMERA @@ -78,6 +85,7 @@ select BOARD_GOOGLE_BASEBOARD_VOLTEER select DRIVER_I2C_TPM_ACPI select DRIVERS_GENESYSLOGIC_GL9755 + select MAINBOARD_HAS_SPI_TPM_CR50 select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES select VARIANT_HAS_MIPI_CAMERA @@ -85,6 +93,7 @@ select BOARD_GOOGLE_BASEBOARD_VOLTEER select DRIVER_I2C_TPM_ACPI select DRIVERS_GENESYSLOGIC_GL9755 + select MAINBOARD_HAS_I2C_TPM_CR50 select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES select VARIANT_HAS_MIPI_CAMERA @@ -92,31 +101,39 @@ select BOARD_GOOGLE_BASEBOARD_VOLTEER select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES + select MAINBOARD_HAS_SPI_TPM_CR50 config BOARD_GOOGLE_ELEMI select BOARD_GOOGLE_BASEBOARD_VOLTEER + select MAINBOARD_HAS_SPI_TPM_CR50 config BOARD_GOOGLE_VOEMA select BOARD_GOOGLE_BASEBOARD_VOLTEER + select MAINBOARD_HAS_SPI_TPM_CR50 select VARIANT_HAS_MIPI_CAMERA config BOARD_GOOGLE_DROBIT select BOARD_GOOGLE_BASEBOARD_VOLTEER select DRIVERS_GENESYSLOGIC_GL9755 + select MAINBOARD_HAS_SPI_TPM_CR50 select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES config BOARD_GOOGLE_COPANO select BOARD_GOOGLE_BASEBOARD_VOLTEER + select MAINBOARD_HAS_SPI_TPM_CR50 select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES config BOARD_GOOGLE_COLLIS select BOARD_GOOGLE_BASEBOARD_VOLTEER + select MAINBOARD_HAS_SPI_TPM_CR50 config BOARD_GOOGLE_VOLET select BOARD_GOOGLE_BASEBOARD_VOLTEER + select MAINBOARD_HAS_SPI_TPM_CR50 config BOARD_GOOGLE_CHRONICLER select BOARD_GOOGLE_BASEBOARD_VOLTEER + select MAINBOARD_HAS_SPI_TPM_CR50 if BOARD_GOOGLE_BASEBOARD_VOLTEER -- To view, visit https://review.coreboot.org/c/coreboot/+/60370 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6c5305a764b7a362f9f381580a1cd2c20a8f2e9d Gerrit-Change-Number: 60370 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/volteer: Move selects from Kconfig.name to Kconfig
by Felix Singer (Code Review) 25 Dec '21

25 Dec '21

Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60369 ) Change subject: mb/google/volteer: Move selects from Kconfig.name to Kconfig ...................................................................... mb/google/volteer: Move selects from Kconfig.name to Kconfig Move selects from Kconfig.name to Kconfig so that the configuration is at one place and not distributed over two files. Change-Id: I72c0e0c3968cb2e92b35381691762148f4c270e4 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/google/volteer/Kconfig M src/mainboard/google/volteer/Kconfig.name 2 files changed, 83 insertions(+), 45 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/60369/1 diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig index 8a605ca..ced8d9d 100644 --- a/src/mainboard/google/volteer/Kconfig +++ b/src/mainboard/google/volteer/Kconfig @@ -35,6 +35,89 @@ select SOC_INTEL_CSE_LITE_SKU select SOC_INTEL_TIGERLAKE +config BOARD_GOOGLE_DELBIN + select BOARD_GOOGLE_BASEBOARD_VOLTEER + select DRIVERS_GENESYSLOGIC_GL9755 + +config BOARD_GOOGLE_ELDRID + select BOARD_GOOGLE_BASEBOARD_VOLTEER + +config BOARD_GOOGLE_HALVOR + select BOARD_GOOGLE_BASEBOARD_VOLTEER + select INTEL_CAR_NEM + +config BOARD_GOOGLE_LINDAR + select BOARD_GOOGLE_BASEBOARD_VOLTEER + select CHROMEOS_DSM_CALIB if CHROMEOS + select DRIVERS_GENERIC_BAYHUB_LV2 + select DRIVERS_I2C_RT1011 + select INTEL_CAR_NEM + +config BOARD_GOOGLE_MALEFOR + select BOARD_GOOGLE_BASEBOARD_VOLTEER + select INTEL_CAR_NEM + +config BOARD_GOOGLE_TERRADOR + select BOARD_GOOGLE_BASEBOARD_VOLTEER + +config BOARD_GOOGLE_TODOR + select BOARD_GOOGLE_BASEBOARD_VOLTEER + select INTEL_CAR_NEM + +config BOARD_GOOGLE_TRONDO + select BOARD_GOOGLE_BASEBOARD_VOLTEER + select INTEL_CAR_NEM + +config BOARD_GOOGLE_VOLTEER + select BOARD_GOOGLE_BASEBOARD_VOLTEER + select INTEL_CAR_NEM + select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES + select VARIANT_HAS_MIPI_CAMERA + +config BOARD_GOOGLE_VOLTEER2 + select BOARD_GOOGLE_BASEBOARD_VOLTEER + select DRIVER_I2C_TPM_ACPI + select DRIVERS_GENESYSLOGIC_GL9755 + select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES + select VARIANT_HAS_MIPI_CAMERA + +config BOARD_GOOGLE_VOLTEER2_TI50 + select BOARD_GOOGLE_BASEBOARD_VOLTEER + select DRIVER_I2C_TPM_ACPI + select DRIVERS_GENESYSLOGIC_GL9755 + select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES + select VARIANT_HAS_MIPI_CAMERA + +config BOARD_GOOGLE_VOXEL + select BOARD_GOOGLE_BASEBOARD_VOLTEER + select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR + select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES + +config BOARD_GOOGLE_ELEMI + select BOARD_GOOGLE_BASEBOARD_VOLTEER + +config BOARD_GOOGLE_VOEMA + select BOARD_GOOGLE_BASEBOARD_VOLTEER + select VARIANT_HAS_MIPI_CAMERA + +config BOARD_GOOGLE_DROBIT + select BOARD_GOOGLE_BASEBOARD_VOLTEER + select DRIVERS_GENESYSLOGIC_GL9755 + select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES + +config BOARD_GOOGLE_COPANO + select BOARD_GOOGLE_BASEBOARD_VOLTEER + select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES + +config BOARD_GOOGLE_COLLIS + select BOARD_GOOGLE_BASEBOARD_VOLTEER + +config BOARD_GOOGLE_VOLET + select BOARD_GOOGLE_BASEBOARD_VOLTEER + +config BOARD_GOOGLE_CHRONICLER + select BOARD_GOOGLE_BASEBOARD_VOLTEER + if BOARD_GOOGLE_BASEBOARD_VOLTEER config CHROMEOS diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name index be82d32..d868e52 100644 --- a/src/mainboard/google/volteer/Kconfig.name +++ b/src/mainboard/google/volteer/Kconfig.name @@ -2,103 +2,58 @@ config BOARD_GOOGLE_DELBIN bool "-> Delbin (ASUS Chromebook Flip CX5)" - select BOARD_GOOGLE_BASEBOARD_VOLTEER - select DRIVERS_GENESYSLOGIC_GL9755 config BOARD_GOOGLE_ELDRID bool "-> Eldrid" - select BOARD_GOOGLE_BASEBOARD_VOLTEER config BOARD_GOOGLE_HALVOR bool "-> Halvor" - select BOARD_GOOGLE_BASEBOARD_VOLTEER - select INTEL_CAR_NEM config BOARD_GOOGLE_LINDAR bool "-> Lindar" - select BOARD_GOOGLE_BASEBOARD_VOLTEER - select CHROMEOS_DSM_CALIB if CHROMEOS - select DRIVERS_GENERIC_BAYHUB_LV2 - select DRIVERS_I2C_RT1011 - select INTEL_CAR_NEM config BOARD_GOOGLE_MALEFOR bool "-> Malefor" - select BOARD_GOOGLE_BASEBOARD_VOLTEER - select INTEL_CAR_NEM config BOARD_GOOGLE_TERRADOR bool "-> Terrador" - select BOARD_GOOGLE_BASEBOARD_VOLTEER config BOARD_GOOGLE_TODOR bool "-> Todor" - select BOARD_GOOGLE_BASEBOARD_VOLTEER - select INTEL_CAR_NEM config BOARD_GOOGLE_TRONDO bool "-> Trondo" - select BOARD_GOOGLE_BASEBOARD_VOLTEER - select INTEL_CAR_NEM config BOARD_GOOGLE_VOLTEER bool "-> Volteer" - select BOARD_GOOGLE_BASEBOARD_VOLTEER - select INTEL_CAR_NEM - select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES - select VARIANT_HAS_MIPI_CAMERA config BOARD_GOOGLE_VOLTEER2 bool "-> Volteer2" - select BOARD_GOOGLE_BASEBOARD_VOLTEER - select DRIVER_I2C_TPM_ACPI - select DRIVERS_GENESYSLOGIC_GL9755 - select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES - select VARIANT_HAS_MIPI_CAMERA # Reworked Volteer2 prototype, Haven chip replaced with Dauntless demo board config BOARD_GOOGLE_VOLTEER2_TI50 bool "-> Volteer2_Ti50" - select BOARD_GOOGLE_BASEBOARD_VOLTEER - select DRIVER_I2C_TPM_ACPI - select DRIVERS_GENESYSLOGIC_GL9755 - select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES - select VARIANT_HAS_MIPI_CAMERA config BOARD_GOOGLE_VOXEL bool "-> Voxel (Acer Chromebook Spin 713 (CP713-3W))" - select BOARD_GOOGLE_BASEBOARD_VOLTEER - select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR - select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES config BOARD_GOOGLE_ELEMI bool "-> Elemi (HP Pro c640 G2 Chromebook)" - select BOARD_GOOGLE_BASEBOARD_VOLTEER config BOARD_GOOGLE_VOEMA bool "-> Voema" - select BOARD_GOOGLE_BASEBOARD_VOLTEER - select VARIANT_HAS_MIPI_CAMERA config BOARD_GOOGLE_DROBIT bool "-> Drobit (ASUS Chromebook CX9400)" - select BOARD_GOOGLE_BASEBOARD_VOLTEER - select DRIVERS_GENESYSLOGIC_GL9755 - select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES config BOARD_GOOGLE_COPANO bool "-> Copano (ASUS Chromebook Flip CX5400)" - select BOARD_GOOGLE_BASEBOARD_VOLTEER - select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES config BOARD_GOOGLE_COLLIS bool "-> Collis" - select BOARD_GOOGLE_BASEBOARD_VOLTEER config BOARD_GOOGLE_VOLET bool "-> Volet" - select BOARD_GOOGLE_BASEBOARD_VOLTEER config BOARD_GOOGLE_CHRONICLER bool "-> Chronicler" - select BOARD_GOOGLE_BASEBOARD_VOLTEER -- To view, visit https://review.coreboot.org/c/coreboot/+/60369 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72c0e0c3968cb2e92b35381691762148f4c270e4 Gerrit-Change-Number: 60369 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/volteer/Kconfig: Reorder selects alphabetically
by Felix Singer (Code Review) 25 Dec '21

25 Dec '21

Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60368 ) Change subject: mb/google/volteer/Kconfig: Reorder selects alphabetically ...................................................................... mb/google/volteer/Kconfig: Reorder selects alphabetically Change-Id: I2416456bd447a6296ca3fac6cf90aa2e78f6de57 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/google/volteer/Kconfig M src/mainboard/google/volteer/Kconfig.name 2 files changed, 16 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/60368/1 diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig index 0c77a79..8a605ca 100644 --- a/src/mainboard/google/volteer/Kconfig +++ b/src/mainboard/google/volteer/Kconfig @@ -6,34 +6,34 @@ select DRIVERS_GENESYSLOGIC_GL9763E select DRIVERS_I2C_GENERIC select DRIVERS_I2C_HID + select DRIVERS_I2C_MAX98373 select DRIVERS_I2C_SX9310 select DRIVERS_INTEL_DPTF select DRIVERS_INTEL_PMC - select DRIVERS_INTEL_USB4_RETIMER - select DRIVERS_I2C_MAX98373 select DRIVERS_INTEL_SOUNDWIRE - select DRIVERS_SPI_ACPI + select DRIVERS_INTEL_USB4_RETIMER select DRIVERS_SOUNDWIRE_ALC5682 select DRIVERS_SOUNDWIRE_MAX98373 + select DRIVERS_SPI_ACPI select DRIVERS_USB_ACPI select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC_BOARDID - select EC_GOOGLE_CHROMEEC_SKUID select EC_GOOGLE_CHROMEEC_LPC + select EC_GOOGLE_CHROMEEC_SKUID select FW_CONFIG select FW_CONFIG_SOURCE_CHROMEEC_CBI select GOOGLE_SMBIOS_MAINBOARD_VERSION select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES + select HAVE_SPD_IN_CBFS select INTEL_LPSS_UART_FOR_CONSOLE select MAINBOARD_HAS_CHROMEOS - select MAINBOARD_HAS_SPI_TPM_CR50 if !BOARD_GOOGLE_VOLTEER2_TI50 select MAINBOARD_HAS_I2C_TPM_CR50 if BOARD_GOOGLE_VOLTEER2_TI50 + select MAINBOARD_HAS_SPI_TPM_CR50 if !BOARD_GOOGLE_VOLTEER2_TI50 select MAINBOARD_HAS_TPM2 select SOC_INTEL_COMMON_BLOCK_TCSS select SOC_INTEL_CSE_LITE_SKU select SOC_INTEL_TIGERLAKE - select HAVE_SPD_IN_CBFS if BOARD_GOOGLE_BASEBOARD_VOLTEER @@ -41,13 +41,13 @@ select CHROMEOS_CSE_BOARD_RESET_OVERRIDE select CHROMEOS_DRAM_PART_NUMBER_IN_CBI select EC_GOOGLE_CHROMEEC_SWITCHES - select GBB_FLAG_FORCE_DEV_SWITCH_ON - select GBB_FLAG_FORCE_DEV_BOOT_USB select GBB_FLAG_FORCE_DEV_BOOT_ALTFW + select GBB_FLAG_FORCE_DEV_BOOT_USB + select GBB_FLAG_FORCE_DEV_SWITCH_ON select GBB_FLAG_FORCE_MANUAL_RECOVERY select HAS_RECOVERY_MRC_CACHE - select VBOOT_LID_SWITCH select VBOOT_EARLY_EC_SYNC + select VBOOT_LID_SWITCH config CHROMEOS_WIFI_SAR bool "Enable SAR options for Chrome OS build" diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name index 84b6c8b..be82d32 100644 --- a/src/mainboard/google/volteer/Kconfig.name +++ b/src/mainboard/google/volteer/Kconfig.name @@ -17,10 +17,10 @@ config BOARD_GOOGLE_LINDAR bool "-> Lindar" select BOARD_GOOGLE_BASEBOARD_VOLTEER - select INTEL_CAR_NEM select CHROMEOS_DSM_CALIB if CHROMEOS - select DRIVERS_I2C_RT1011 select DRIVERS_GENERIC_BAYHUB_LV2 + select DRIVERS_I2C_RT1011 + select INTEL_CAR_NEM config BOARD_GOOGLE_MALEFOR bool "-> Malefor" @@ -44,26 +44,26 @@ config BOARD_GOOGLE_VOLTEER bool "-> Volteer" select BOARD_GOOGLE_BASEBOARD_VOLTEER - select VARIANT_HAS_MIPI_CAMERA select INTEL_CAR_NEM select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES + select VARIANT_HAS_MIPI_CAMERA config BOARD_GOOGLE_VOLTEER2 bool "-> Volteer2" select BOARD_GOOGLE_BASEBOARD_VOLTEER - select VARIANT_HAS_MIPI_CAMERA - select DRIVERS_GENESYSLOGIC_GL9755 select DRIVER_I2C_TPM_ACPI + select DRIVERS_GENESYSLOGIC_GL9755 select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES + select VARIANT_HAS_MIPI_CAMERA # Reworked Volteer2 prototype, Haven chip replaced with Dauntless demo board config BOARD_GOOGLE_VOLTEER2_TI50 bool "-> Volteer2_Ti50" select BOARD_GOOGLE_BASEBOARD_VOLTEER - select VARIANT_HAS_MIPI_CAMERA - select DRIVERS_GENESYSLOGIC_GL9755 select DRIVER_I2C_TPM_ACPI + select DRIVERS_GENESYSLOGIC_GL9755 select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES + select VARIANT_HAS_MIPI_CAMERA config BOARD_GOOGLE_VOXEL bool "-> Voxel (Acer Chromebook Spin 713 (CP713-3W))" -- To view, visit https://review.coreboot.org/c/coreboot/+/60368 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2416456bd447a6296ca3fac6cf90aa2e78f6de57 Gerrit-Change-Number: 60368 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/deltaur: Select board-specific options per board
by Felix Singer (Code Review) 25 Dec '21

25 Dec '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60367 ) Change subject: mb/google/deltaur: Select board-specific options per board ...................................................................... mb/google/deltaur: Select board-specific options per board Move board-specific selects out of common configuration and add them to each board where necessary. Change-Id: I71f22100fe56a8b88321d220f98ac03887ce6bd7 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/google/deltaur/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/60367/1 diff --git a/src/mainboard/google/deltaur/Kconfig b/src/mainboard/google/deltaur/Kconfig index 45e8258..8a5cf3c 100644 --- a/src/mainboard/google/deltaur/Kconfig +++ b/src/mainboard/google/deltaur/Kconfig @@ -14,13 +14,13 @@ select MAINBOARD_HAS_I2C_TPM_CR50 select MAINBOARD_HAS_TPM2 select MAINBOARD_USES_IFD_EC_REGION - select MAINBOARD_USES_IFD_GBE_REGION if BOARD_GOOGLE_DELTAN select SOC_INTEL_COMMON_BLOCK_HDA_VERB select SOC_INTEL_TIGERLAKE select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_DELTAN select BOARD_GOOGLE_BASEBOARD_DELTAUR + select MAINBOARD_USES_IFD_GBE_REGION config BOARD_GOOGLE_DELTAUR select BOARD_GOOGLE_BASEBOARD_DELTAUR -- To view, visit https://review.coreboot.org/c/coreboot/+/60367 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I71f22100fe56a8b88321d220f98ac03887ce6bd7 Gerrit-Change-Number: 60367 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/deltaur: Move selects from Kconfig.name to Kconfig
by Felix Singer (Code Review) 25 Dec '21

25 Dec '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60366 ) Change subject: mb/google/deltaur: Move selects from Kconfig.name to Kconfig ...................................................................... mb/google/deltaur: Move selects from Kconfig.name to Kconfig Move selects from Kconfig.name to Kconfig so that the configuration is at one place and not distributed over two files. Change-Id: I9b523ebee2d2af8585736588306ca687dfe16003 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/google/deltaur/Kconfig M src/mainboard/google/deltaur/Kconfig.name 2 files changed, 6 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/60366/1 diff --git a/src/mainboard/google/deltaur/Kconfig b/src/mainboard/google/deltaur/Kconfig index e1874e3..45e8258 100644 --- a/src/mainboard/google/deltaur/Kconfig +++ b/src/mainboard/google/deltaur/Kconfig @@ -19,6 +19,12 @@ select SOC_INTEL_TIGERLAKE select SYSTEM_TYPE_LAPTOP +config BOARD_GOOGLE_DELTAN + select BOARD_GOOGLE_BASEBOARD_DELTAUR + +config BOARD_GOOGLE_DELTAUR + select BOARD_GOOGLE_BASEBOARD_DELTAUR + if BOARD_GOOGLE_BASEBOARD_DELTAUR config CHROMEOS diff --git a/src/mainboard/google/deltaur/Kconfig.name b/src/mainboard/google/deltaur/Kconfig.name index 5c4c12b..2e04d67 100644 --- a/src/mainboard/google/deltaur/Kconfig.name +++ b/src/mainboard/google/deltaur/Kconfig.name @@ -2,8 +2,6 @@ config BOARD_GOOGLE_DELTAN bool "-> Deltan" - select BOARD_GOOGLE_BASEBOARD_DELTAUR config BOARD_GOOGLE_DELTAUR bool "-> Deltaur" - select BOARD_GOOGLE_BASEBOARD_DELTAUR -- To view, visit https://review.coreboot.org/c/coreboot/+/60366 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b523ebee2d2af8585736588306ca687dfe16003 Gerrit-Change-Number: 60366 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/deltaur/Kconfig: Reorder selects alphabetically
by Felix Singer (Code Review) 25 Dec '21

25 Dec '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60365 ) Change subject: mb/google/deltaur/Kconfig: Reorder selects alphabetically ...................................................................... mb/google/deltaur/Kconfig: Reorder selects alphabetically Change-Id: I36a02f8d509ef39983b4162188abc0cbc3d570cf Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/google/deltaur/Kconfig 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/60365/1 diff --git a/src/mainboard/google/deltaur/Kconfig b/src/mainboard/google/deltaur/Kconfig index 644e488..e1874e3 100644 --- a/src/mainboard/google/deltaur/Kconfig +++ b/src/mainboard/google/deltaur/Kconfig @@ -14,18 +14,18 @@ select MAINBOARD_HAS_I2C_TPM_CR50 select MAINBOARD_HAS_TPM2 select MAINBOARD_USES_IFD_EC_REGION - select SOC_INTEL_TIGERLAKE - select SYSTEM_TYPE_LAPTOP select MAINBOARD_USES_IFD_GBE_REGION if BOARD_GOOGLE_DELTAN select SOC_INTEL_COMMON_BLOCK_HDA_VERB + select SOC_INTEL_TIGERLAKE + select SYSTEM_TYPE_LAPTOP if BOARD_GOOGLE_BASEBOARD_DELTAUR config CHROMEOS select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC - select GBB_FLAG_FORCE_DEV_SWITCH_ON - select GBB_FLAG_FORCE_DEV_BOOT_USB select GBB_FLAG_FORCE_DEV_BOOT_ALTFW + select GBB_FLAG_FORCE_DEV_BOOT_USB + select GBB_FLAG_FORCE_DEV_SWITCH_ON config DIMM_SPD_SIZE default 512 -- To view, visit https://review.coreboot.org/c/coreboot/+/60365 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36a02f8d509ef39983b4162188abc0cbc3d570cf Gerrit-Change-Number: 60365 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/beltino/Kconfig: Reorder selects alphabetically
by build bot (Jenkins) (Code Review) 25 Dec '21

25 Dec '21

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60356 ) Change subject: mb/google/beltino/Kconfig: Reorder selects alphabetically ...................................................................... Patch Set 3: Verified+1 (1 comment) File src/mainboard/google/beltino/Kconfig: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136211): https://review.coreboot.org/c/coreboot/+/60356/comment/aa1a96e5_77dae494 PS3, Line 15: select SUPERIO_ITE_IT8772F 'SUPERIO' may be misspelled - perhaps ''? -- To view, visit https://review.coreboot.org/c/coreboot/+/60356 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4ba4b2a7a358ad86b547b16a12593b912f9bd8f Gerrit-Change-Number: 60356 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 24 Dec 2021 22:27:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/jecht/Kconfig: Reorder selects alphabetically
by build bot (Jenkins) (Code Review) 25 Dec '21

25 Dec '21

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60354 ) Change subject: mb/google/jecht/Kconfig: Reorder selects alphabetically ...................................................................... Patch Set 3: Verified+1 (1 comment) File src/mainboard/google/jecht/Kconfig: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136207): https://review.coreboot.org/c/coreboot/+/60354/comment/f712b0fe_2280dd7f PS3, Line 13: select SUPERIO_ITE_IT8772F 'SUPERIO' may be misspelled - perhaps ''? -- To view, visit https://review.coreboot.org/c/coreboot/+/60354 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2287ae1357e0f02a42ebd770ee799613fd29c033 Gerrit-Change-Number: 60354 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 24 Dec 2021 22:22:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/storo: Generate SPD ID for Samsung K4U6E3S4AA-MGCR
by Paul Menzel (Code Review) 24 Dec '21

24 Dec '21

Attention is currently required from: Zhi Li, Karthik Ramasubramanian. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60337 ) Change subject: mb/google/dedede/var/storo: Generate SPD ID for Samsung K4U6E3S4AA-MGCR ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/60337 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic436db8fe3ef6fb8379ec629b128c05c691ea6fe Gerrit-Change-Number: 60337 Gerrit-PatchSet: 3 Gerrit-Owner: Zhi Li <lizhi7(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Zhi Li <lizhi7(a)huaqin.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 24 Dec 2021 21:53:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8186: Enable VRF12 software control for MT6366
by Paul Menzel (Code Review) 24 Dec '21

24 Dec '21

Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60340 ) Change subject: soc/mediatek/mt8186: Enable VRF12 software control for MT6366 ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60340/comment/1dbaab02_799a6289 PS1, Line 9: PS8640 What kind of device is that exactly? -- To view, visit https://review.coreboot.org/c/coreboot/+/60340 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I87d6a94b6fb343590d563ac1554ff87b11c01549 Gerrit-Change-Number: 60340 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Comment-Date: Fri, 24 Dec 2021 21:52:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021