Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58657 )
Change subject: drivers/net/r8168.c: Guard against generating power resource
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58657/comment/e98fff8e_d449bcf0
PS3, Line 12: weak empty function
> What function? Doesn't this change obsolete it?
Yes removing it was the motivation for this change: CB:58649
--
To view, visit https://review.coreboot.org/c/coreboot/+/58657
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I82289aa7e6e82318417f3b827b86182891dfc2a6
Gerrit-Change-Number: 58657
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Tue, 02 Nov 2021 07:28:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: comment
Attention is currently required from: Sean Rhodes.
Hello Matt DeVillier,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/edk2/+/58802
to look at the new patch set (#2).
Change subject: UefiPayloadPkg: Allow below 4GB memory
......................................................................
UefiPayloadPkg: Allow below 4GB memory
Add function to reserve memory below 4GB for EDKII Modules. This causes the
DXE to dispatch everything under 4GB and allows Operating System's that
require EFI_LOADED_IMAGE to be under 4GB to start.
e.g. Xen hypervisor used in Qubes
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
Change-Id: Ic600e08c9d46d0a291b8b119a3c268e432267cdf
---
M UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c
M UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf
M UefiPayloadPkg/UefiPayloadPkg.dec
M UefiPayloadPkg/UefiPayloadPkg.dsc
4 files changed, 54 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/edk2 refs/changes/02/58802/2
--
To view, visit https://review.coreboot.org/c/edk2/+/58802
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: edk2
Gerrit-Branch: master
Gerrit-Change-Id: Ic600e08c9d46d0a291b8b119a3c268e432267cdf
Gerrit-Change-Number: 58802
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-MessageType: newpatchset
Attention is currently required from: Raul Rangel.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58806 )
Change subject: tests/Makefile: Remove ./ prefix when running tests
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
Thanks for fixing it :)
--
To view, visit https://review.coreboot.org/c/coreboot/+/58806
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c3638b1af7531dbe8e956dcbe168250a235ead4
Gerrit-Change-Number: 58806
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Comment-Date: Tue, 02 Nov 2021 07:16:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Werner Zeh.
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58740 )
Change subject: mb/siemens/mc_ehl1: Adjust PCIe clock settings in devicetree
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/58740
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2beea76ff8fefd79f476bef343d13495b45cdfcf
Gerrit-Change-Number: 58740
Gerrit-PatchSet: 3
Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Tue, 02 Nov 2021 07:11:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment