coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in edk2[coreboot-stable202108]: UefiPayloadPkg: Enable boot logo
by Patrick Georgi (Code Review) 05 Nov '21

05 Nov '21

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/edk2/+/58782 ) Change subject: UefiPayloadPkg: Enable boot logo ...................................................................... UefiPayloadPkg: Enable boot logo Clear the screen and show the boot logo. Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Change-Id: I058dc1c2a148ee79d4c7fb465e3c6a63ee764f96 Reviewed-on: https://review.coreboot.org/c/edk2/+/58782 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> --- M UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c M UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf M UefiPayloadPkg/UefiPayloadPkg.dsc M UefiPayloadPkg/UefiPayloadPkg.fdf 4 files changed, 8 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved diff --git a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c index 20be2d7..2d5f8bf 100644 --- a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c +++ b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c @@ -218,6 +218,9 @@ Black.Blue = Black.Green = Black.Red = Black.Reserved = 0; White.Blue = White.Green = White.Red = White.Reserved = 0xFF; + gST->ConOut->ClearScreen (gST->ConOut); + BootLogoEnableLogo (); + EfiBootManagerConnectAll (); EfiBootManagerRefreshAllBootOption (); diff --git a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf index 9c4a9da..8749297 100644 --- a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf +++ b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf @@ -39,6 +39,7 @@ UefiRuntimeServicesTableLib UefiLib UefiBootManagerLib + BootLogoLib PcdLib DxeServicesLib MemoryAllocationLib diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc index 4aab59e..01bdc37 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.dsc +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc @@ -193,6 +193,7 @@ CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf + BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf FrameBufferBltLib|MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf @@ -446,6 +447,7 @@ MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf UefiCpuPkg/CpuDxe/CpuDxe.inf MdeModulePkg/Universal/BdsDxe/BdsDxe.inf + MdeModulePkg/Logo/LogoDxe.inf MdeModulePkg/Application/UiApp/UiApp.inf { <LibraryClasses> NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf b/UefiPayloadPkg/UefiPayloadPkg.fdf index 9278226..cd69247 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.fdf +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf @@ -127,6 +127,8 @@ INF UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf INF MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf +INF MdeModulePkg/Logo/LogoDxe.inf + # # PCI Support # 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/edk2/+/58782 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: edk2 Gerrit-Branch: coreboot-stable202108 Gerrit-Change-Id: I058dc1c2a148ee79d4c7fb465e3c6a63ee764f96 Gerrit-Change-Number: 58782 Gerrit-PatchSet: 4 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Crawford <tcrawford(a)system76.com> Gerrit-MessageType: merged

1 0

Change in edk2[coreboot-stable202108]: UefiPayloadPkg: Map ESC to Boot Manager
by Patrick Georgi (Code Review) 05 Nov '21

05 Nov '21

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/edk2/+/58780 ) Change subject: UefiPayloadPkg: Map ESC to Boot Manager ...................................................................... UefiPayloadPkg: Map ESC to Boot Manager Change menu key from F2 to ESC. Remove use of Enter key to boot directly. Remove prompt text from console output. Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Change-Id: I401144d619434faa37bc2fe2e6eeec22cbb32c2b Reviewed-on: https://review.coreboot.org/c/edk2/+/58780 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Tim Crawford <tcrawford(a)system76.com> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> --- M UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c 1 file changed, 5 insertions(+), 30 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Tim Crawford: Looks good to me, but someone else must approve diff --git a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c index c4d317f..20be2d7 100644 --- a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c +++ b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c @@ -157,9 +157,7 @@ VOID ) { - EFI_INPUT_KEY Enter; - EFI_INPUT_KEY F2; - EFI_INPUT_KEY Down; + EFI_INPUT_KEY Escape; EFI_BOOT_MANAGER_LOAD_OPTION BootOption; EFI_STATUS Status; @@ -173,27 +171,12 @@ } // - // Register ENTER as CONTINUE key + // Map Escape to Boot Manager Menu // - Enter.ScanCode = SCAN_NULL; - Enter.UnicodeChar = CHAR_CARRIAGE_RETURN; - EfiBootManagerRegisterContinueKeyOption (0, &Enter, NULL); - - // - // Map F2 to Boot Manager Menu - // - F2.ScanCode = SCAN_F2; - F2.UnicodeChar = CHAR_NULL; + Escape.ScanCode = SCAN_ESC; + Escape.UnicodeChar = CHAR_NULL; EfiBootManagerGetBootManagerMenu (&BootOption); - EfiBootManagerAddKeyOptionVariable (NULL, (UINT16) BootOption.OptionNumber, 0, &F2, NULL); - - // - // Also add Down key to Boot Manager Menu since some serial terminals don't support F2 key. - // - Down.ScanCode = SCAN_DOWN; - Down.UnicodeChar = CHAR_NULL; - EfiBootManagerGetBootManagerMenu (&BootOption); - EfiBootManagerAddKeyOptionVariable (NULL, (UINT16) BootOption.OptionNumber, 0, &Down, NULL); + EfiBootManagerAddKeyOptionVariable (NULL, (UINT16) BootOption.OptionNumber, 0, &Escape, NULL); // // Install ready to lock. @@ -242,14 +225,6 @@ // Register UEFI Shell // PlatformRegisterFvBootOption (PcdGetPtr (PcdShellFile), L"UEFI Shell", LOAD_OPTION_ACTIVE); - - Print ( - L"\n" - L"F2 or Down to enter Boot Manager Menu.\n" - L"ENTER to boot directly.\n" - L"\n" - ); - } /** -- To view, visit https://review.coreboot.org/c/edk2/+/58780 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: edk2 Gerrit-Branch: coreboot-stable202108 Gerrit-Change-Id: I401144d619434faa37bc2fe2e6eeec22cbb32c2b Gerrit-Change-Number: 58780 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in edk2[coreboot-stable202108]: UefiPayloadPkg: Map ESC to Boot Manager
by Patrick Georgi (Code Review) 05 Nov '21

05 Nov '21

Attention is currently required from: Matt DeVillier. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/edk2/+/58780 ) Change subject: UefiPayloadPkg: Map ESC to Boot Manager ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/edk2/+/58780 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: edk2 Gerrit-Branch: coreboot-stable202108 Gerrit-Change-Id: I401144d619434faa37bc2fe2e6eeec22cbb32c2b Gerrit-Change-Number: 58780 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Fri, 05 Nov 2021 22:33:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in edk2[coreboot-stable202108]: UefiPayloadPkg: Enable PS2 keyboard by default
by Patrick Georgi (Code Review) 05 Nov '21

05 Nov '21

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/edk2/+/58778 ) Change subject: UefiPayloadPkg: Enable PS2 keyboard by default ...................................................................... UefiPayloadPkg: Enable PS2 keyboard by default Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Change-Id: I33cc1654fbe2e578aa8f1485d755fc19b4db780d Reviewed-on: https://review.coreboot.org/c/edk2/+/58778 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Sean Rhodes <admin(a)starlabs.systems> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> --- M UefiPayloadPkg/UefiPayloadPkg.dsc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Sean Rhodes: Looks good to me, but someone else must approve diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc index 856d5ea..4aab59e 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.dsc +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc @@ -27,7 +27,7 @@ PCD_DYNAMIC_AS_DYNAMICEX = TRUE DEFINE SOURCE_DEBUG_ENABLE = FALSE - DEFINE PS2_KEYBOARD_ENABLE = FALSE + DEFINE PS2_KEYBOARD_ENABLE = TRUE DEFINE UNIVERSAL_PAYLOAD = FALSE # 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/edk2/+/58778 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: edk2 Gerrit-Branch: coreboot-stable202108 Gerrit-Change-Id: I33cc1654fbe2e578aa8f1485d755fc19b4db780d Gerrit-Change-Number: 58778 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Crawford <tcrawford(a)system76.com> Gerrit-MessageType: merged

1 0

Change in edk2[coreboot-stable202108]: UefiPayloadPkg: Increase FV size to 8MB
by Patrick Georgi (Code Review) 05 Nov '21

05 Nov '21

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/edk2/+/58630 ) Change subject: UefiPayloadPkg: Increase FV size to 8MB ...................................................................... UefiPayloadPkg: Increase FV size to 8MB The following commits need additional space. Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> Change-Id: I6b757f73fe4e90282b4bfb84469545ab1af9d1bb Reviewed-on: https://review.coreboot.org/c/edk2/+/58630 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M UefiPayloadPkg/UefiPayloadPkg.fdf 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf b/UefiPayloadPkg/UefiPayloadPkg.fdf index 5871d71..9278226 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.fdf +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf @@ -17,8 +17,8 @@ DEFINE NUM_BLOCKS = 0x850 !else -DEFINE FD_SIZE = 0x00410000 -DEFINE NUM_BLOCKS = 0x410 +DEFINE FD_SIZE = 0x00800000 +DEFINE NUM_BLOCKS = 0x800 !endif ################################################################################ -- To view, visit https://review.coreboot.org/c/edk2/+/58630 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: edk2 Gerrit-Branch: coreboot-stable202108 Gerrit-Change-Id: I6b757f73fe4e90282b4bfb84469545ab1af9d1bb Gerrit-Change-Number: 58630 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: soc/amd/cezanne: Add ASYNC_FILE_LOADING
by Felix Held (Code Review) 05 Nov '21

05 Nov '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Julius Werner, Rob Barnes, Karthik Ramasubramanian. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58861 ) Change subject: soc/amd/cezanne: Add ASYNC_FILE_LOADING ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie839e54fa38b81a5d18715f190c0c92467bd9371 Gerrit-Change-Number: 58861 Gerrit-PatchSet: 4 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 05 Nov 2021 22:27:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: Add preload_fspm and preload_fsps
by Tim Wawrzynczak (Code Review) 05 Nov '21

05 Nov '21

Attention is currently required from: Raul Rangel, Andrey Petrov, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58987 ) Change subject: drivers/intel/fsp2_0: Add preload_fspm and preload_fsps ...................................................................... Patch Set 2: Code-Review+1 (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/58987/comment/a1a1bb70_0fa475ed PS2, Line 8: : FSP is normally memmapped and then decompressed. nit: this is only true in the non-XIP world, it cannot be decompressed "in-place" on Intel platforms. File src/drivers/intel/fsp2_0/memory_init.c: https://review.coreboot.org/c/coreboot/+/58987/comment/cfb1bf1d_ec7f9067 PS2, Line 349: nit: extra blank line File src/drivers/intel/fsp2_0/silicon_init.c: https://review.coreboot.org/c/coreboot/+/58987/comment/ef61c93e_54c2b635 PS2, Line 239: same -- To view, visit https://review.coreboot.org/c/coreboot/+/58987 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I28d7530ae9e50f743e3d6c86a5a29b1fa85cacb6 Gerrit-Change-Number: 58987 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 05 Nov 2021 21:56:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: Allow FSP-M to be relocated
by Tim Wawrzynczak (Code Review) 05 Nov '21

05 Nov '21

Attention is currently required from: Raul Rangel, Andrey Petrov, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58984 ) Change subject: drivers/intel/fsp2_0: Allow FSP-M to be relocated ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: seems fine to me, all intel FSP2.0 platforms are forced to use FSP-M XIP, so if that works for AMD 👍 -- To view, visit https://review.coreboot.org/c/coreboot/+/58984 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I797fb319333c53ad0bbf7340924f7d07dfc7de30 Gerrit-Change-Number: 58984 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 05 Nov 2021 21:54:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: Add FSP_ALIGNMENT_FSP_X option
by Tim Wawrzynczak (Code Review) 05 Nov '21

05 Nov '21

Attention is currently required from: Raul Rangel, Andrey Petrov, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58986 ) Change subject: drivers/intel/fsp2_0: Add FSP_ALIGNMENT_FSP_X option ...................................................................... Patch Set 2: (2 comments) File src/drivers/intel/fsp2_0/Makefile.inc: https://review.coreboot.org/c/coreboot/+/58986/comment/7cfbd3b2_efd41b66 PS2, Line 69: alignment Unless I missed a change in this train, shouldn't this be `-align` ? https://review.coreboot.org/c/coreboot/+/58986/comment/2d32c695_441e6a9d PS2, Line 82: alignment same? -- To view, visit https://review.coreboot.org/c/coreboot/+/58986 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4533f6c9d56bea6520aa3aa87dd49f2144a23850 Gerrit-Change-Number: 58986 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 05 Nov 2021 21:51:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/{cezanne,picasso}: Stop passing base for fspm.bin
by Felix Held (Code Review) 05 Nov '21

05 Nov '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Rob Barnes, Karthik Ramasubramanian. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58985 ) Change subject: soc/amd/{cezanne,picasso}: Stop passing base for fspm.bin ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: also still works with this on a mandolin with picasso apu. without having checked, i assume that we now can rip out everything around FSP_M_ADDR in soc/amd, so it would be good if you could look into that. that ould also avoid the problem that we need to reserve the maximum amount of memory a debug build of the fsp-m needs even though the release builds are significantly smaller -- To view, visit https://review.coreboot.org/c/coreboot/+/58985 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibef849d5b3f0290cb7b7c5ff18aabe002bf53344 Gerrit-Change-Number: 58985 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 05 Nov 2021 21:42:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021