coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: console/printk: Add console_mutex
by Raul Rangel (Code Review) 05 Nov '21

05 Nov '21

Attention is currently required from: Julius Werner, Rob Barnes. Hello Julius Werner, Rob Barnes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58981 to look at the new patch set (#2). Change subject: console/printk: Add console_mutex ...................................................................... console/printk: Add console_mutex Cooperative multitasking has only been used in ramstage. ramstage has spin locks enabled, while romstage and earlier don't. This means we can't rely on the console spin lock. This change adds a console mutex so printing can work correctly between threads in romstage. BUG=b:179699789 TEST=Start a thread in romstage and verify console output is not garbled Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: I5858bb18723f32f6b1e6ef0ed31906d7c79d3fec --- M src/console/printk.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/58981/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58981 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5858bb18723f32f6b1e6ef0ed31906d7c79d3fec Gerrit-Change-Number: 58981 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Documentation/releases: Update 4.15 release notes
by Felix Singer (Code Review) 05 Nov '21

05 Nov '21

Attention is currently required from: Martin Roth, Jason Glenesk. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58974 ) Change subject: Documentation/releases: Update 4.15 release notes ...................................................................... Patch Set 1: (1 comment) File Documentation/releases/coreboot-4.15-relnotes.md: https://review.coreboot.org/c/coreboot/+/58974/comment/041db9da_e4687b72 PS1, Line 16: from every 6 months, to every 3 months Huh? Just wondering, why that? -- To view, visit https://review.coreboot.org/c/coreboot/+/58974 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie4d47456cce38e7ec4329f8cb839167017c7e26b Gerrit-Change-Number: 58974 Gerrit-PatchSet: 1 Gerrit-Owner: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Fri, 05 Nov 2021 22:46:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation/releases/4.15: Add more System76 boards
by Felix Singer (Code Review) 05 Nov '21

05 Nov '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/58868 ) Change subject: Documentation/releases/4.15: Add more System76 boards ...................................................................... Documentation/releases/4.15: Add more System76 boards Most of the System76 boards have now been merged. Change-Id: I0353b28c1df3da8be961cb43225dcf9e30b47d16 Signed-off-by: Tim Crawford <tcrawford(a)system76.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/58868 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> --- M Documentation/releases/coreboot-4.15-relnotes.md 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Jason Glenesk: Looks good to me, but someone else must approve diff --git a/Documentation/releases/coreboot-4.15-relnotes.md b/Documentation/releases/coreboot-4.15-relnotes.md index 97ed37c..184b5de 100644 --- a/Documentation/releases/coreboot-4.15-relnotes.md +++ b/Documentation/releases/coreboot-4.15-relnotes.md @@ -23,11 +23,19 @@ * Siemens mc_ehl * SuperMicro x9sae * System76 addw1 +* System76 addw2 +* System76 bonw14 * System76 darp6 * System76 darp7 +* System76 galp2 +* System76 galp3 +* System76 galp3-b * System76 galp4 * System76 galp5 +* System76 gaze14 * System76 lemp10 +* System76 oryp7 +* System76 oryp8 Removed mainboards ------------------ -- To view, visit https://review.coreboot.org/c/coreboot/+/58868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0353b28c1df3da8be961cb43225dcf9e30b47d16 Gerrit-Change-Number: 58868 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: Documentation/releases/4.15: Add more System76 boards
by Felix Singer (Code Review) 05 Nov '21

05 Nov '21

Attention is currently required from: Tim Crawford, Martin Roth. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58868 ) Change subject: Documentation/releases/4.15: Add more System76 boards ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0353b28c1df3da8be961cb43225dcf9e30b47d16 Gerrit-Change-Number: 58868 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Fri, 05 Nov 2021 22:42:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in edk2[coreboot-stable202108]: MdeModulePkg: load boot logo into BGRT table
by Patrick Georgi (Code Review) 05 Nov '21

05 Nov '21

Attention is currently required from: Patrick Rudolph, Matt DeVillier. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/edk2/+/58786 ) Change subject: MdeModulePkg: load boot logo into BGRT table ...................................................................... Patch Set 6: (1 comment) Patchset: PS5: > done. If there's official code already: how much effort is it to backport it? That would make this commit disappear automatically on rebase. -- To view, visit https://review.coreboot.org/c/edk2/+/58786 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: edk2 Gerrit-Branch: coreboot-stable202108 Gerrit-Change-Id: I726fd7a9deb9ba5f8e351ce24834fc627acc4542 Gerrit-Change-Number: 58786 Gerrit-PatchSet: 6 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Fri, 05 Nov 2021 22:34:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: Allow FSP-M to be relocated
by Felix Held (Code Review) 05 Nov '21

05 Nov '21

Attention is currently required from: Raul Rangel, Andrey Petrov, Patrick Rudolph. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58984 ) Change subject: drivers/intel/fsp2_0: Allow FSP-M to be relocated ...................................................................... Patch Set 2: (1 comment) File src/commonlib/Makefile.inc: https://review.coreboot.org/c/coreboot/+/58984/comment/5fa2f2d0_8902892d PS2, Line 25: romstage-$(CONFIG_PLATFORM_USES_FSP2_0) += fsp_relocate.c probably wouldn't be a one-liner any more, but i'd guard that with both CONFIG_PLATFORM_USES_FSP2_0 and !CONFIG_FSP_M_XIP -- To view, visit https://review.coreboot.org/c/coreboot/+/58984 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I797fb319333c53ad0bbf7340924f7d07dfc7de30 Gerrit-Change-Number: 58984 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 05 Nov 2021 22:34:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in edk2[coreboot-stable202108]: BmpSupportLib: fix BMP validation
by Patrick Georgi (Code Review) 05 Nov '21

05 Nov '21

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/edk2/+/58785 ) Change subject: BmpSupportLib: fix BMP validation ...................................................................... BmpSupportLib: fix BMP validation BMP files by tools other than MS paint can have a variable number of padding bytes, which results in the DataSize being less than (ImageSize - HeaderSize). Fix the check to be less stringent. Test: use BMP created by/saved by Photoshop Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Change-Id: I97d2e90aef7043a28b3bdda2eab52cb19e086930 Reviewed-on: https://review.coreboot.org/c/edk2/+/58785 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> --- M MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved diff --git a/MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c b/MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c index 3ac31f6..944d01f 100644 --- a/MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c +++ b/MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c @@ -213,7 +213,7 @@ if ((BmpHeader->Size != BmpImageSize) || (BmpHeader->Size < BmpHeader->ImageOffset) || - (BmpHeader->Size - BmpHeader->ImageOffset != DataSize)) { + (BmpHeader->Size - BmpHeader->ImageOffset < DataSize)) { DEBUG ((DEBUG_ERROR, "TranslateBmpToGopBlt: invalid BmpImage... \n")); DEBUG ((DEBUG_ERROR, " BmpHeader->Size: 0x%x\n", BmpHeader->Size)); 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/edk2/+/58785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: edk2 Gerrit-Branch: coreboot-stable202108 Gerrit-Change-Id: I97d2e90aef7043a28b3bdda2eab52cb19e086930 Gerrit-Change-Number: 58785 Gerrit-PatchSet: 4 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sean Rhodes <admin(a)starlabs.systems> Gerrit-MessageType: merged

1 0

Change in edk2[coreboot-stable202108]: MdeModulePkg/BootLogoLib: Center logo 38.2% from top of screen
by Patrick Georgi (Code Review) 05 Nov '21

05 Nov '21

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/edk2/+/58784 ) Change subject: MdeModulePkg/BootLogoLib: Center logo 38.2% from top of screen ...................................................................... MdeModulePkg/BootLogoLib: Center logo 38.2% from top of screen Use Microsoft's recommended positioning [1] for the boot logo. > We recommend that the logo is placed with its center at 38.2% from the > screen's top edge. This positioning is based on the golden ratio's > visual aesthetics and matches the Windows 10 design proportions. [1]: https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/boot-scre… Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Change-Id: Ia357e59626dc8bec0827763e803ac0c8939f0acf Reviewed-on: https://review.coreboot.org/c/edk2/+/58784 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> --- M MdeModulePkg/Library/BootLogoLib/BootLogoLib.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c index 134660f..76255b6 100644 --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c @@ -175,7 +175,7 @@ break; case EdkiiPlatformLogoDisplayAttributeCenter: DestX = (SizeOfX - Image.Width) / 2; - DestY = (SizeOfY - Image.Height) / 2; + DestY = (SizeOfY * 382) / 1000 - Image.Height / 2; break; case EdkiiPlatformLogoDisplayAttributeCenterRight: DestX = SizeOfX - Image.Width; 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/edk2/+/58784 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: edk2 Gerrit-Branch: coreboot-stable202108 Gerrit-Change-Id: Ia357e59626dc8bec0827763e803ac0c8939f0acf Gerrit-Change-Number: 58784 Gerrit-PatchSet: 4 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Crawford <tcrawford(a)system76.com> Gerrit-MessageType: merged

1 0

Change in edk2[coreboot-stable202108]: MdeModulePkg: Use coreboot logo as boot splash
by Patrick Georgi (Code Review) 05 Nov '21

05 Nov '21

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/edk2/+/58783 ) Change subject: MdeModulePkg: Use coreboot logo as boot splash ...................................................................... MdeModulePkg: Use coreboot logo as boot splash Use coreboot logo vs edk2 logo as default boot splash. Can be overriden by user selection via coreboot Kconfig. Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Change-Id: Icf3c61938ae9aeec55889c969bcbc4b3e943a870 Reviewed-on: https://review.coreboot.org/c/edk2/+/58783 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Sean Rhodes <admin(a)starlabs.systems> Reviewed-by: Tim Crawford <tcrawford(a)system76.com> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> --- M MdeModulePkg/Logo/Logo.bmp 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Tim Crawford: Looks good to me, but someone else must approve Sean Rhodes: Looks good to me, but someone else must approve diff --git a/MdeModulePkg/Logo/Logo.bmp b/MdeModulePkg/Logo/Logo.bmp index 3e85229..3997e96 100644 --- a/MdeModulePkg/Logo/Logo.bmp +++ b/MdeModulePkg/Logo/Logo.bmp Binary files differ 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/edk2/+/58783 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: edk2 Gerrit-Branch: coreboot-stable202108 Gerrit-Change-Id: Icf3c61938ae9aeec55889c969bcbc4b3e943a870 Gerrit-Change-Number: 58783 Gerrit-PatchSet: 4 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in edk2[coreboot-stable202108]: UefiPayloadPkg: Show boot menu prompt as progress text
by Patrick Georgi (Code Review) 05 Nov '21

05 Nov '21

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/edk2/+/58781 ) Change subject: UefiPayloadPkg: Show boot menu prompt as progress text ...................................................................... UefiPayloadPkg: Show boot menu prompt as progress text Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Change-Id: I005c1c8ab23d405410ca9ba01903995337ccb6e3 Reviewed-on: https://review.coreboot.org/c/edk2/+/58781 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> --- M UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved diff --git a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c index 2d5f8bf..1c4952a 100644 --- a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c +++ b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c @@ -228,6 +228,16 @@ // Register UEFI Shell // PlatformRegisterFvBootOption (PcdGetPtr (PcdShellFile), L"UEFI Shell", LOAD_OPTION_ACTIVE); + + // Show prompt at bottom center + BootLogoUpdateProgress ( + White, + Black, + L"Press ESC for Boot Options/Settings", + White, + 0, + 0 + ); } /** 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/edk2/+/58781 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: edk2 Gerrit-Branch: coreboot-stable202108 Gerrit-Change-Id: I005c1c8ab23d405410ca9ba01903995337ccb6e3 Gerrit-Change-Number: 58781 Gerrit-PatchSet: 4 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Crawford <tcrawford(a)system76.com> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021