coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: src/mb/brya: Enable crashlog on brya
by Tim Wawrzynczak (Code Review) 23 Nov '21

23 Nov '21

Attention is currently required from: Gaggery Tsai, Francois Toguo Fotso, Kane Chen. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59486 ) Change subject: src/mb/brya: Enable crashlog on brya ...................................................................... Patch Set 6: (1 comment) File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/59486/comment/5526ee9a_dadbbc55 PS6, Line 51: SOC_INTEL_CRASHLOG Actually … [View More]

1 0

Change in coreboot[master]: soc/intel/alderlake: remove tmp bar assignment for cpu crashlog
by Tim Wawrzynczak (Code Review) 23 Nov '21

23 Nov '21

Attention is currently required from: Kane Chen, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59355 ) Change subject: soc/intel/alderlake: remove tmp bar assignment for cpu crashlog ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59355 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.… [View More]

1 0

Change in coreboot[master]: acpi,Makefile: Add preload_acpi_dsdt
by Raul Rangel (Code Review) 23 Nov '21

23 Nov '21

Attention is currently required from: Lance Zhao, Patrick Georgi, Martin Roth. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59504 ) Change subject: acpi,Makefile: Add preload_acpi_dsdt ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Sorry, I won't hold up the patch forever (boot time is an important metric), I just share the same c […] For now yeah... See https://review.… [View More]

1 0

Change in coreboot[master]: drivers/genesyslogic/gl9750: Add driver for Genesys Logic GL9750
by Tim Wawrzynczak (Code Review) 23 Nov '21

23 Nov '21

Attention is currently required from: Ben Chuang. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59429 ) Change subject: drivers/genesyslogic/gl9750: Add driver for Genesys Logic GL9750 ...................................................................... Patch Set 2: Code-Review+2 (2 comments) Patchset: PS2: Thanks Ben! File src/drivers/genesyslogic/gl9750/Kconfig: https://review.coreboot.org/c/coreboot/+/59429/comment/… [View More]

1 0

Change in coreboot[master]: lib: Add a mutex
by Raul Rangel (Code Review) 22 Nov '21

22 Nov '21

Attention is currently required from: Julius Werner, Kyösti Mälkki, Rob Barnes, Karthik Ramasubramanian. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59320 ) Change subject: lib: Add a mutex ...................................................................... Patch Set 8: (1 comment) File src/include/mutex.h: https://review.coreboot.org/c/coreboot/+/59320/comment/363f53c4_36ad82b0 PS7, Line 22: else if (CONFIG(COOP_MULTITASKING)) > This … [View More]

1 0

Change in coreboot[master]: acpi,Makefile: Add preload_acpi_dsdt
by Tim Wawrzynczak (Code Review) 22 Nov '21

22 Nov '21

Attention is currently required from: Lance Zhao, Raul Rangel, Patrick Georgi, Martin Roth. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59504 ) Change subject: acpi,Makefile: Add preload_acpi_dsdt ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: Sorry, I won't hold up the patch forever (boot time is an important metric), I just share the same concerns stated … [View More]

1 0

Change in coreboot[master]: rules.h, thread.h, lib/cbfs: Add ENV_STAGE_SUPPORTS_COOP
by Raul Rangel (Code Review) 22 Nov '21

22 Nov '21

Attention is currently required from: Julius Werner. Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59550 ) Change subject: rules.h, thread.h, lib/cbfs: Add ENV_STAGE_SUPPORTS_COOP ...................................................................... rules.h, thread.h, lib/cbfs: Add ENV_STAGE_SUPPORTS_COOP This change consolidates the COOP rules. Co-op in theory works in all x86 stages now, but it hasn't been enabled yet. BUG=b:179699789 TEST=… [View More]Boot guybrush to OS and verify preloads still work Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: I1197406d1d36391998b08e3076146bb2fff59d00 --- M src/include/rules.h M src/include/thread.h M src/lib/cbfs.c 3 files changed, 9 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/59550/1 diff --git a/src/include/rules.h b/src/include/rules.h index d08929c..02b55c5 100644 --- a/src/include/rules.h +++ b/src/include/rules.h @@ -303,6 +303,13 @@ /* When set <arch/smp/spinlock.h> is included for the spinlock implementation. */ #define ENV_STAGE_SUPPORTS_SMP (CONFIG(SMP) && STAGE_HAS_SPINLOCKS) +#if ENV_X86 && CONFIG(COOP_MULTITASKING) && (ENV_RAMSTAGE || ENV_ROMSTAGE) +/* TODO: Enable in all x86 stages */ +#define ENV_STAGE_SUPPORTS_COOP 1 +#else +#define ENV_STAGE_SUPPORTS_COOP 0 +#endif + /** * For pre-DRAM stages and post-CAR always build with simple device model, ie. * PCI, PNP and CPU functions operate without use of devicetree. The reason diff --git a/src/include/thread.h b/src/include/thread.h index 19b69fa..4f10782 100644 --- a/src/include/thread.h +++ b/src/include/thread.h @@ -38,7 +38,7 @@ /* Waits until the thread has terminated and returns the error code */ enum cb_err thread_join(struct thread_handle *handle); -#if (ENV_RAMSTAGE || ENV_ROMSTAGE) && CONFIG(COOP_MULTITASKING) +#if ENV_STAGE_SUPPORTS_COOP struct thread { int id; diff --git a/src/lib/cbfs.c b/src/lib/cbfs.c index 1ffc695..d1930a9 100644 --- a/src/lib/cbfs.c +++ b/src/lib/cbfs.c @@ -380,7 +380,7 @@ enum cb_err err; struct cbfs_preload_context *context; - if (!CONFIG(CBFS_PRELOAD) || (!ENV_RAMSTAGE && !ENV_ROMSTAGE)) + if (!CONFIG(CBFS_PRELOAD) || !ENV_STAGE_SUPPORTS_COOP) return CB_ERR_ARG; context = find_cbfs_preload_context(name); -- To view, visit https://review.coreboot.org/c/coreboot/+/59550 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1197406d1d36391998b08e3076146bb2fff59d00 Gerrit-Change-Number: 59550 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: newchange [View Less]

1 0

Change in coreboot[master]: lib: Add a mutex
by Raul Rangel (Code Review) 22 Nov '21

22 Nov '21

Attention is currently required from: Julius Werner, Kyösti Mälkki, Rob Barnes, Karthik Ramasubramanian. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59320 ) Change subject: lib: Add a mutex ...................................................................... Patch Set 8: (1 comment) File src/include/mutex.h: https://review.coreboot.org/c/coreboot/+/59320/comment/d109c109_509dbb89 PS2, Line 11: void mutex_unlock(struct mutex *mutex); > … [View More]

1 0

Change in coreboot[master]: lib: Add a mutex
by Raul Rangel (Code Review) 22 Nov '21

22 Nov '21

Attention is currently required from: Julius Werner, Kyösti Mälkki, Rob Barnes, Karthik Ramasubramanian. Hello build bot (Jenkins), Julius Werner, Rob Barnes, Kyösti Mälkki, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59320 to look at the new patch set (#8). Change subject: lib: Add a mutex ...................................................................... lib: Add a mutex We currently have two synchronization … [View More]

1 0

Change in coreboot[master]: arch/{arm,arm64,ppc64,riscv}: Add noop cpu_relax
by Raul Rangel (Code Review) 22 Nov '21

22 Nov '21

Attention is currently required from: Philipp Hug, Julius Werner, Ron Minnich. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59546 ) Change subject: arch/{arm,arm64,ppc64,riscv}: Add noop cpu_relax ...................................................................... Patch Set 2: (2 comments) File src/arch/arm/include/armv4/arch/cpu.h: https://review.coreboot.org/c/coreboot/+/59546/comment/f33eda28_1c21c416 PS1, Line 6: __always_inline > … [View More]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021