coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: timestamp: Add new helper functions
by Subrata Banik (Code Review) 23 Nov '21

23 Nov '21

Attention is currently required from: Bora Guvendik, Furquan Shaikh, Selma Bensaid, Tim Wawrzynczak, Julius Werner, Angel Pons, Aaron Durbin. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51445 ) Change subject: timestamp: Add new helper functions ...................................................................... Patch Set 8: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/51445/comment/e8485632_a3c0b8dd PS3, Line 7: Add helper fucntions > Julius, please see the following 2 patches, I implemented your suggestion (hope understood correctly). > https://review.coreboot.org/c/coreboot/+/59554/1 > https://review.coreboot.org/c/coreboot/+/59555/2 > > I think it ended up being more complicated than this rewind api. > > 0:1st timestamp 0 > 944:CSE sent 'Boot Stall Done' to PMC 296,000 > 945:CSE started to handle ICC configuration 303,000 (7,000) > 946:CSE sent 'Host BIOS Prep Done' to PMC 308,000 (5,000) > 947:CSE received 'CPU Reset Done Ack sent' from PMC 1,074,000 (766,000) > 11:start of bootblock 1,101,606 (27,606) > 12:end of bootblock 1,161,989 (60,382) > > I had to qsort a second time because below is what it looks like after the initial qsort, the largest negative shows up first. Yes, this is what I thought too while commenting because it will consider higher negative value as least timestamp entry. > > 0:1st timestamp 0 > 947:CSE received 'CPU Reset Done Ack sent' from PMC 1,074,000 > 946:CSE sent 'Host BIOS Prep Done' to PMC 308,000 (18,483,711,495,936,957) > 945:CSE started to handle ICC configuration 303,000 (18,483,711,496,697,957) > 944:CSE sent 'Boot Stall Done' to PMC 296,000 (18,483,711,496,695,957) > 11:start of bootblock 1,101,606 (805,606) > 12:end of bootblock 1,161,989 (60,382) -- To view, visit https://review.coreboot.org/c/coreboot/+/51445 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b7065ed26e231fc898ae44bcc15cba6fb42b308 Gerrit-Change-Number: 51445 Gerrit-PatchSet: 8 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Tue, 23 Nov 2021 04:53:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bora Guvendik <bora.guvendik(a)intel.com> Comment-In-Reply-To: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/kano: set power limits for thermal
by Sumeet R Pawnikar (Code Review) 23 Nov '21

23 Nov '21

Attention is currently required from: David Wu, Peter Ou. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59091 ) Change subject: mb/google/brya/var/kano: set power limits for thermal ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/brya/variants/kano/ramstage.c: https://review.coreboot.org/c/coreboot/+/59091/comment/0f1977ba_10c49e1d PS1, Line 8: bug:191906315 comment #10 > Sorry, we will remove it. Thanks. Can you check if performance config values suits your system design and battery specs ? -- To view, visit https://review.coreboot.org/c/coreboot/+/59091 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25cf9be68f8981d8307b4c15ab9f65b59058fb19 Gerrit-Change-Number: 59091 Gerrit-PatchSet: 2 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Paul Yang <paul.f.yang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Tue, 23 Nov 2021 04:51:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: David Wu <david_wu(a)quanta.corp-partner.google.com> Comment-In-Reply-To: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/zork/var/shuboz: Add fw_config probe for ALC5682-VD & VS
by build bot (Jenkins) (Code Review) 23 Nov '21

23 Nov '21

1 0

Change in coreboot[master]: mb/google/zork/var/shuboz: Add fw_config probe for ALC5682-VD & VS
by build bot (Jenkins) (Code Review) 23 Nov '21

23 Nov '21

Attention is currently required from: Kane Chen. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59558 ) Change subject: mb/google/zork/var/shuboz: Add fw_config probe for ALC5682-VD & VS ...................................................................... Patch Set 3: (6 comments) File src/mainboard/google/zork/variants/shuboz/variant.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134077): https://review.coreboot.org/c/coreboot/+/59558/comment/4a3ae7e2_9e1b56ac PS3, Line 84: ARRAY_SIZE(machine_dev_path)); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134077): https://review.coreboot.org/c/coreboot/+/59558/comment/ac80f4fe_2760fa42 PS3, Line 84: ARRAY_SIZE(machine_dev_path)); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134077): https://review.coreboot.org/c/coreboot/+/59558/comment/d432410a_ab2b8703 PS3, Line 88: &drivers_amd_i2s_machine_dev_ops) || !machine_dev->chip_info) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134077): https://review.coreboot.org/c/coreboot/+/59558/comment/091eacee_84f37862 PS3, Line 88: &drivers_amd_i2s_machine_dev_ops) || !machine_dev->chip_info) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134077): https://review.coreboot.org/c/coreboot/+/59558/comment/3f708abe_43ce019a PS3, Line 99: machine_dev_config->hid); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134077): https://review.coreboot.org/c/coreboot/+/59558/comment/be9f5761_509c976f PS3, Line 99: machine_dev_config->hid); please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/59558 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c78aa166010ffa4d0cacc8a11d418d5a6906749 Gerrit-Change-Number: 59558 Gerrit-PatchSet: 3 Gerrit-Owner: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Comment-Date: Tue, 23 Nov 2021 04:45:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/zork/var/shuboz: Add fw_config probe for ALC5682-VD & VS
by build bot (Jenkins) (Code Review) 23 Nov '21

23 Nov '21

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59558 ) Change subject: mb/google/zork/var/shuboz: Add fw_config probe for ALC5682-VD & VS ...................................................................... Patch Set 2: (7 comments) File src/mainboard/google/zork/variants/shuboz/variant.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134076): https://review.coreboot.org/c/coreboot/+/59558/comment/a52544e9_c1bec26e PS2, Line 84: ARRAY_SIZE(machine_dev_path)); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134076): https://review.coreboot.org/c/coreboot/+/59558/comment/86114da9_8577bba7 PS2, Line 84: ARRAY_SIZE(machine_dev_path)); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134076): https://review.coreboot.org/c/coreboot/+/59558/comment/36f34ed7_2cca0297 PS2, Line 87: if (!machine_dev || (machine_dev->chip_ops != trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134076): https://review.coreboot.org/c/coreboot/+/59558/comment/943d510f_8d7298e2 PS2, Line 88: &drivers_amd_i2s_machine_dev_ops) || !machine_dev->chip_info) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134076): https://review.coreboot.org/c/coreboot/+/59558/comment/943ab940_90b7fb87 PS2, Line 88: &drivers_amd_i2s_machine_dev_ops) || !machine_dev->chip_info) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134076): https://review.coreboot.org/c/coreboot/+/59558/comment/de79708c_c1bfb99e PS2, Line 99: machine_dev_config->hid); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134076): https://review.coreboot.org/c/coreboot/+/59558/comment/667dd7ec_15119628 PS2, Line 99: machine_dev_config->hid); please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/59558 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c78aa166010ffa4d0cacc8a11d418d5a6906749 Gerrit-Change-Number: 59558 Gerrit-PatchSet: 2 Gerrit-Owner: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 23 Nov 2021 04:44:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/zork/var/shuboz: Add fw_config probe for ALC5682-VD & VS
by build bot (Jenkins) (Code Review) 23 Nov '21

23 Nov '21

1 0

Change in coreboot[master]: mb/google/zork/var/shuboz: Add fw_config probe for ALC5682-VD & VS
by Kane Chen (Code Review) 23 Nov '21

23 Nov '21

Kane Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59558 ) Change subject: mb/google/zork/var/shuboz: Add fw_config probe for ALC5682-VD & VS ...................................................................... mb/google/zork/var/shuboz: Add fw_config probe for ALC5682-VD & VS ALC5682-VD/ALC5682I-VS load different kernel driver by different hid name. Update hid name and machine_dev depending on the AUDIO_CODEC_SOURCE field of fw_config. Define FW_CONFIG bits 36 - 37 (SSFC bits 4 - 5) for codec selection. ALC5682-VD: _HID = "10EC5682" ALC5682I-VS: _HID = "RTL5682" BUG=b:198689479 BRANCH=zork TEST=ALC5682-VD/ALC5682I-VS audio codec can work Signed-off-by: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Change-Id: I0c78aa166010ffa4d0cacc8a11d418d5a6906749 --- M src/mainboard/google/zork/variants/baseboard/helpers.c M src/mainboard/google/zork/variants/shuboz/overridetree.cb M src/mainboard/google/zork/variants/shuboz/variant.c 3 files changed, 65 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/59558/1 diff --git a/src/mainboard/google/zork/variants/baseboard/helpers.c b/src/mainboard/google/zork/variants/baseboard/helpers.c index d6c5e48..7057a48 100644 --- a/src/mainboard/google/zork/variants/baseboard/helpers.c +++ b/src/mainboard/google/zork/variants/baseboard/helpers.c @@ -55,6 +55,9 @@ /* Audio AMP type */ FW_CONFIG_MASK_AUDIO_AMP = 0x1, FW_CONFIG_SHIFT_AUDIO_AMP = 35, + /* Audio codec type */ + FW_CONFIG_MASK_AUDIO_CODEC_SOURCE = 0x3, + FW_CONFIG_SHIFT_AUDIO_CODEC_SOURCE = 36, }; static int get_fw_config(uint64_t *val) diff --git a/src/mainboard/google/zork/variants/shuboz/overridetree.cb b/src/mainboard/google/zork/variants/shuboz/overridetree.cb index c3cc9e6..0b31a77 100644 --- a/src/mainboard/google/zork/variants/shuboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/shuboz/overridetree.cb @@ -1,4 +1,10 @@ # SPDX-License-Identifier: GPL-2.0-or-later +fw_config + field AUDIO_CODEC_SOURCE 36 37 + option AUDIO_CODEC_ALC5682 0 + option AUDIO_CODEC_ALC5682I_VS 1 + end +end chip soc/amd/picasso diff --git a/src/mainboard/google/zork/variants/shuboz/variant.c b/src/mainboard/google/zork/variants/shuboz/variant.c index 9907c72..c5e6581 100644 --- a/src/mainboard/google/zork/variants/shuboz/variant.c +++ b/src/mainboard/google/zork/variants/shuboz/variant.c @@ -3,6 +3,12 @@ #include <baseboard/variants.h> #include <soc/pci_devs.h> #include "chip.h" +#include <fw_config.h> +#include <drivers/i2c/generic/chip.h> +#include <drivers/amd/i2s_machine_dev/chip.h> +#include <device/device.h> +#include <device/path.h> +#include <console/console.h> uint32_t usb_oc_map_override[USB_PORT_COUNT] = { USB_OC_PIN_0, @@ -42,6 +48,55 @@ *ddi_num = ARRAY_SIZE(hdmi_ddi_descriptors); } +extern struct chip_operations drivers_i2c_generic_ops; +extern struct chip_operations drivers_amd_i2s_machine_dev_ops; + +static void audio_codec_update(void) +{ + const struct device_path codec_path[] = { + {.type = DEVICE_PATH_PCI, .pci.devfn = LPC_DEVFN}, + {.type = DEVICE_PATH_PNP, .pnp.port = 0xc09, .pnp.device = 0}, + {.type = DEVICE_PATH_GENERIC, .generic.id = 0}, + {.type = DEVICE_PATH_I2C, .i2c.device = 0x1a, .i2c.mode_10bit = I2C_MODE_7_BIT } + }; + const struct device_path machine_dev_path[] = { + {.type = DEVICE_PATH_PCI, .pci.devfn = PCIE_GPP_A_DEVFN}, + {.type = DEVICE_PATH_PCI, .pci.devfn = AUDIO_DEVFN}, + {.type = DEVICE_PATH_GENERIC, .generic.id = 0, .generic.subid = 0} + }; + const struct device *codec = + find_dev_nested_path(pci_root_bus(), codec_path, ARRAY_SIZE(codec_path)); + struct drivers_i2c_generic_config *config; + + if (!codec || (codec->chip_ops != &drivers_i2c_generic_ops) || !codec->chip_info) + return; + + config = codec->chip_info; + + if (fw_config_probe(FW_CONFIG(AUDIO_CODEC_SOURCE, AUDIO_CODEC_ALC5682))) + config->hid = "10EC5682"; + else if (fw_config_probe(FW_CONFIG(AUDIO_CODEC_SOURCE, AUDIO_CODEC_ALC5682I_VS))) + config->hid = "RTL5682"; + printk(BIOS_INFO, "Configure audio codec, config->hid %s\n", config->hid); + + const struct device *machine_dev = + find_dev_nested_path(pci_root_bus(), machine_dev_path, ARRAY_SIZE(machine_dev_path)); + struct drivers_amd_i2s_machine_dev_config *machine_dev_config; + + if (!machine_dev || (machine_dev->chip_ops != &drivers_amd_i2s_machine_dev_ops) || !machine_dev->chip_info) { + machine_dev_config = machine_dev->chip_info; + return; + } + machine_dev_config = machine_dev->chip_info; + + if (fw_config_probe(FW_CONFIG(AUDIO_CODEC_SOURCE, AUDIO_CODEC_ALC5682))) + machine_dev_config->hid = "AMDI5682"; + else if (fw_config_probe(FW_CONFIG(AUDIO_CODEC_SOURCE, AUDIO_CODEC_ALC5682I_VS))) + machine_dev_config->hid = "10029835"; + printk(BIOS_INFO, "Configure i2s device, machine_dev_config->hid %s\n", machine_dev_config->hid); + +} + void variant_devtree_update(void) { struct soc_amd_picasso_config *soc_cfg; @@ -56,4 +111,5 @@ for (i = 0; i < USB_PORT_COUNT; i++) soc_cfg->usb_port_overcurrent_pin[i] = usb_oc_map_override[i]; } + audio_codec_update(); } -- To view, visit https://review.coreboot.org/c/coreboot/+/59558 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c78aa166010ffa4d0cacc8a11d418d5a6906749 Gerrit-Change-Number: 59558 Gerrit-PatchSet: 1 Gerrit-Owner: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/brya/var/kano: set power limits for thermal
by David Wu (Code Review) 23 Nov '21

23 Nov '21

Attention is currently required from: Sumeet R Pawnikar, Peter Ou. David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59091 ) Change subject: mb/google/brya/var/kano: set power limits for thermal ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/59091/comment/f8d762e1_2c82ba6a PS1, Line 12: build pass > Share test results with power limits value for reference here. Hi Peter, could you share test results with power limits value to issue 205648035 for reference here? Thanks. File src/mainboard/google/brya/variants/kano/ramstage.c: https://review.coreboot.org/c/coreboot/+/59091/comment/12672fdb_1929fc21 PS1, Line 8: bug:191906315 comment #10 > Does this applicable to Kano system as well ? Sorry, we will remove it. Thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/59091 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25cf9be68f8981d8307b4c15ab9f65b59058fb19 Gerrit-Change-Number: 59091 Gerrit-PatchSet: 2 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Paul Yang <paul.f.yang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Tue, 23 Nov 2021 04:19:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer/var/delbin: Add fw_config probe for ALC5682-VD & VS
by build bot (Jenkins) (Code Review) 23 Nov '21

23 Nov '21

Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59557 ) Change subject: mb/google/volteer/var/delbin: Add fw_config probe for ALC5682-VD & VS ...................................................................... Patch Set 2: (2 comments) File src/mainboard/google/volteer/variants/delbin/variant.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134072): https://review.coreboot.org/c/coreboot/+/59557/comment/46b96cea_a4c6c9c9 PS2, Line 2: #include <fw_config.h> trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134072): https://review.coreboot.org/c/coreboot/+/59557/comment/b72e8ec2_22230ea9 PS2, Line 24: config->hid = "RTL5682"; trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/59557 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieef638f78edd3428e572a76f06fb9c8757278971 Gerrit-Change-Number: 59557 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 23 Nov 2021 04:14:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer/var/delbin: Add fw_config probe for ALC5682-VD & VS
by build bot (Jenkins) (Code Review) 23 Nov '21

23 Nov '21

Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59557 ) Change subject: mb/google/volteer/var/delbin: Add fw_config probe for ALC5682-VD & VS ...................................................................... Patch Set 1: (2 comments) File src/mainboard/google/volteer/variants/delbin/variant.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134071): https://review.coreboot.org/c/coreboot/+/59557/comment/64ad6192_abcc5705 PS1, Line 2: #include <fw_config.h> trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134071): https://review.coreboot.org/c/coreboot/+/59557/comment/4ac7d6a4_255e6b79 PS1, Line 24: config->hid = "RTL5682"; trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/59557 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieef638f78edd3428e572a76f06fb9c8757278971 Gerrit-Change-Number: 59557 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 23 Nov 2021 04:11:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021