Attention is currently required from: Anson Tseng, Tim Wawrzynczak, Nick Vaccaro, Zhuohao Lee.
Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59557 )
Change subject: mb/google/volteer/var/delbin: Add fw_config probe for ALC5682-VD & VS
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/59557
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieef638f78edd3428e572a76f06fb9c8757278971
Gerrit-Change-Number: 59557
Gerrit-PatchSet: 6
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com>
Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Anson Tseng <ansontseng(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Comment-Date: Tue, 23 Nov 2021 08:28:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Anson Tseng, Tim Wawrzynczak, Nick Vaccaro, Zhuohao Lee.
Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59557 )
Change subject: mb/google/volteer/var/delbin: Add fw_config probe for ALC5682-VD & VS
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/volteer/variants/delbin/variant.c:
https://review.coreboot.org/c/coreboot/+/59557/comment/bb7f4888_27e9a30b
PS5, Line 1: #include <baseboard/variants.h>
> You may want to refer to https://review.coreboot. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/59557
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieef638f78edd3428e572a76f06fb9c8757278971
Gerrit-Change-Number: 59557
Gerrit-PatchSet: 6
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Anson Tseng <ansontseng(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Comment-Date: Tue, 23 Nov 2021 08:27:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anson Tseng <ansontseng(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Frank Chu, Tim Wawrzynczak, Nick Vaccaro, Zhuohao Lee.
Anson Tseng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59557 )
Change subject: mb/google/volteer/var/delbin: Add fw_config probe for ALC5682-VD & VS
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/volteer/variants/delbin/variant.c:
https://review.coreboot.org/c/coreboot/+/59557/comment/29557f0d_32544b3a
PS5, Line 1: #include <baseboard/variants.h>
> Try to add /* SPDX-License-Identifier: GPL-2.0-or-later */ in the first line.
You may want to refer to https://review.coreboot.org/c/coreboot/+/56930
--
To view, visit https://review.coreboot.org/c/coreboot/+/59557
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieef638f78edd3428e572a76f06fb9c8757278971
Gerrit-Change-Number: 59557
Gerrit-PatchSet: 5
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Comment-Date: Tue, 23 Nov 2021 08:21:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anson Tseng <ansontseng(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Frank Chu, Tim Wawrzynczak, Nick Vaccaro, Zhuohao Lee.
Anson Tseng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59557 )
Change subject: mb/google/volteer/var/delbin: Add fw_config probe for ALC5682-VD & VS
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/volteer/variants/delbin/variant.c:
https://review.coreboot.org/c/coreboot/+/59557/comment/6630e852_b3814ea6
PS5, Line 1: #include <baseboard/variants.h>
Try to add /* SPDX-License-Identifier: GPL-2.0-or-later */ in the first line.
--
To view, visit https://review.coreboot.org/c/coreboot/+/59557
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieef638f78edd3428e572a76f06fb9c8757278971
Gerrit-Change-Number: 59557
Gerrit-PatchSet: 5
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Comment-Date: Tue, 23 Nov 2021 08:19:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Sean Rhodes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59564 )
Change subject: Documentation/releases: Update 4.16 release notes
......................................................................
Documentation/releases: Update 4.16 release notes
* Add StarBook Mk V as new mainboard
* Add option to disable Intel Management Engine via HECI
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
Change-Id: I9675a6a8960d93ae6de285d8b25ffc48a763483e
---
M Documentation/releases/coreboot-4.16-relnotes.md
1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/59564/1
diff --git a/Documentation/releases/coreboot-4.16-relnotes.md b/Documentation/releases/coreboot-4.16-relnotes.md
index a4c7af2..8a51347 100644
--- a/Documentation/releases/coreboot-4.16-relnotes.md
+++ b/Documentation/releases/coreboot-4.16-relnotes.md
@@ -13,7 +13,18 @@
* The chip and board additions and removals will be updated right
before the release, so those do not need to be added.
+New mainboards
+--------------
+* StarBook Mk V
+
Significant changes
-------------------
### Add significant changes here
+
+### Option to disable Intel Management Engine
+Disable the Intel (CS)Management Engine via HECI based on Intel Core processors
+from Skylake to Alderlake. State is set baed on a cmos value of `me_state`. A
+value of `0` will result in a (CS)ME state of `0` (working) and value of `1`
+will result in a (CS)ME state of `3` (disabled). For an example cmos layout and
+more info, see [cse.c](../../src/soc/intel/common/block/cse/cse.c).
--
To view, visit https://review.coreboot.org/c/coreboot/+/59564
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9675a6a8960d93ae6de285d8b25ffc48a763483e
Gerrit-Change-Number: 59564
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-MessageType: newchange
Attention is currently required from: Tim Wawrzynczak.
Malik Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59563 )
Change subject: mb/google/brya/variants/primus: update gpios for power consumption
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/google/brya/variants/primus/variant.c:
https://review.coreboot.org/c/coreboot/+/59563/comment/4f3fde86_47794068
PS3, Line 50: if ( sku == 1 )
> space prohibited before that close parenthesis ')'
Please fix.
https://review.coreboot.org/c/coreboot/+/59563/comment/ff750521_0344e8aa
PS3, Line 50: if ( sku == 1 )
> space prohibited after that open parenthesis '('
Please fix.
--
To view, visit https://review.coreboot.org/c/coreboot/+/59563
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I753e41dec1825299e6cd437b5f67e2d957bc6148
Gerrit-Change-Number: 59563
Gerrit-PatchSet: 4
Gerrit-Owner: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Tue, 23 Nov 2021 07:28:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59563 )
Change subject: mb/google/brya/variants/primus: update gpios for power consumption
......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/brya/variants/primus/variant.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134090):
https://review.coreboot.org/c/coreboot/+/59563/comment/87dc60d7_95dcf7de
PS3, Line 50: if ( sku == 1 )
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134090):
https://review.coreboot.org/c/coreboot/+/59563/comment/52b38865_40793790
PS3, Line 50: if ( sku == 1 )
space prohibited before that close parenthesis ')'
--
To view, visit https://review.coreboot.org/c/coreboot/+/59563
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I753e41dec1825299e6cd437b5f67e2d957bc6148
Gerrit-Change-Number: 59563
Gerrit-PatchSet: 3
Gerrit-Owner: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Tue, 23 Nov 2021 07:23:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59563 )
Change subject: mb/google/brya/variants/primus: update gpios for power consumption
......................................................................
Patch Set 2:
(3 comments)
File src/mainboard/google/brya/variants/primus/variant.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134089):
https://review.coreboot.org/c/coreboot/+/59563/comment/fdc920f9_eca43ac8
PS2, Line 48: int sku = gpio_get(GPP_T2);
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134089):
https://review.coreboot.org/c/coreboot/+/59563/comment/1af67a41_9b5a28e3
PS2, Line 50: if ( sku == 1 )
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134089):
https://review.coreboot.org/c/coreboot/+/59563/comment/5386c716_850fe3b1
PS2, Line 50: if ( sku == 1 )
space prohibited before that close parenthesis ')'
--
To view, visit https://review.coreboot.org/c/coreboot/+/59563
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I753e41dec1825299e6cd437b5f67e2d957bc6148
Gerrit-Change-Number: 59563
Gerrit-PatchSet: 2
Gerrit-Owner: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Tue, 23 Nov 2021 07:21:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak.
Hello Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/59563
to look at the new patch set (#2).
Change subject: mb/google/brya/variants/primus: update gpios for power consumption
......................................................................
mb/google/brya/variants/primus: update gpios for power consumption
In different sku, some unused GPIO pins are processed by NC for power
consumption.
BUG=b:196790249
TEST=emerge-brya coreboot chromeos-bootimage and check power
Signed-off-by: Malik_Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Change-Id: I753e41dec1825299e6cd437b5f67e2d957bc6148
---
M src/mainboard/google/brya/variants/primus/variant.c
1 file changed, 27 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/59563/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/59563
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I753e41dec1825299e6cd437b5f67e2d957bc6148
Gerrit-Change-Number: 59563
Gerrit-PatchSet: 2
Gerrit-Owner: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: newpatchset