Attention is currently required from: Saurabh Gorecha, Shelley Chen, Ravi kumar.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/qc_blobs/+/59635 )
Change subject: sc7280 qcsec and qtiseclib blob update
......................................................................
Patch Set 2: Verified+1
--
To view, visit https://review.coreboot.org/c/qc_blobs/+/59635
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: qc_blobs
Gerrit-Branch: master
Gerrit-Change-Id: Icd2706e8b108751fa4f415794512752c53abf7fb
Gerrit-Change-Number: 59635
Gerrit-PatchSet: 2
Gerrit-Owner: Saurabh Gorecha <quic_sgorecha(a)quicinc.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-CC: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-CC: mturney mturney <quic_mturney(a)quicinc.com>
Gerrit-Attention: Saurabh Gorecha <quic_sgorecha(a)quicinc.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Comment-Date: Wed, 24 Nov 2021 18:50:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Shelley Chen, Ravi kumar, Julius Werner.
Saurabh Gorecha has removed mturney mturney from this change. ( https://review.coreboot.org/c/qc_blobs/+/59635 )
Change subject: sc7280 qcsec and qtiseclib blob update
......................................................................
Removed reviewer mturney mturney.
--
To view, visit https://review.coreboot.org/c/qc_blobs/+/59635
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: qc_blobs
Gerrit-Branch: master
Gerrit-Change-Id: Icd2706e8b108751fa4f415794512752c53abf7fb
Gerrit-Change-Number: 59635
Gerrit-PatchSet: 2
Gerrit-Owner: Saurabh Gorecha <quic_sgorecha(a)quicinc.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: deleteReviewer
Attention is currently required from: Nico Huber, Patrick Georgi, Branden Waldner, Idwer Vollering, Paul Menzel, Jacob Garber, Werner Zeh, Iru Cai, Harshit Sharma.
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59636 )
Change subject: Revert "util/crossgcc: Update gcc to 11.2"
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Lets find the solution together in this follow-up of CB:54050
--
To view, visit https://review.coreboot.org/c/coreboot/+/59636
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09a789f9ccb284ac7cad32b12bbf60ecb82efb44
Gerrit-Change-Number: 59636
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Branden Waldner <scruffy99(a)gmail.com>
Gerrit-Reviewer: Harshit Sharma <harshitsharmajs(a)gmail.com>
Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com>
Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Attention: Branden Waldner <scruffy99(a)gmail.com>
Gerrit-Attention: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jacob Garber <jgarber1(a)ualberta.ca>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Iru Cai <mytbk920423(a)gmail.com>
Gerrit-Attention: Harshit Sharma <harshitsharmajs(a)gmail.com>
Gerrit-Attention: Iru Cai <mytbk920423(a)gmail.com>
Gerrit-Comment-Date: Wed, 24 Nov 2021 18:42:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: YH Lin, Marco Chen, Mark Hsieh, Zhuohao Lee, Felix Held.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59580 )
Change subject: mb/google/brya/var/gimble: Swap TPM I2C with touchscreen I2C
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/59580/comment/99ebc59d_fae66802
PS5, Line 75: default 0x1
this will break all of the other boards, see CB:59560
--
To view, visit https://review.coreboot.org/c/coreboot/+/59580
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I26d059a7ea5a3fdf00de260214c00d3bba9aa7f7
Gerrit-Change-Number: 59580
Gerrit-PatchSet: 5
Gerrit-Owner: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Marco Chen <marcochen(a)google.com>
Gerrit-Reviewer: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com>
Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com>
Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com>
Gerrit-CC: Will Tsai <will_tsai(a)wistron.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Marco Chen <marcochen(a)google.com>
Gerrit-Attention: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 24 Nov 2021 18:38:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59636 )
Change subject: Revert "util/crossgcc: Update gcc to 11.2"
......................................................................
Revert "util/crossgcc: Update gcc to 11.2"
This reverts commit b0d87f753c9c517ba906115362d32aa4422fd188.
Unfortunately this gcc 11.2 is causing problems for some boards:
in example, AMD Lenovo G505S can't boot to Linux. If built with
exactly the same config but this commit reverted, it boots fine.
Tried comparing the good vs bad logs (obtained using USB FT232H)
but only the timestamps are different, without any other hints.
Of course it will be nice to fix this newer gcc 11.2 for G505S,
so I will happily test your suggestions - i.e. compiler flags.
Signed-off-by: Mike Banon <mikebdp2(a)gmail.com>
Change-Id: I09a789f9ccb284ac7cad32b12bbf60ecb82efb44
---
M util/crossgcc/buildgcc
R util/crossgcc/patches/gcc-8.3.0_ada-musl_workaround.patch
R util/crossgcc/patches/gcc-8.3.0_asan_shadow_offset_callback.patch
A util/crossgcc/patches/gcc-8.3.0_gnat-bad_constant.patch
R util/crossgcc/patches/gcc-8.3.0_gnat.patch
A util/crossgcc/patches/gcc-8.3.0_gnat_eh.patch
R util/crossgcc/patches/gcc-8.3.0_libcpp.patch
R util/crossgcc/patches/gcc-8.3.0_libgcc.patch
A util/crossgcc/patches/gcc-8.3.0_nds32_ite.patch
D util/crossgcc/sum/gcc-11.2.0.tar.xz.cksum
A util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum
11 files changed, 21,485 insertions(+), 25 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/59636/1
--
To view, visit https://review.coreboot.org/c/coreboot/+/59636
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09a789f9ccb284ac7cad32b12bbf60ecb82efb44
Gerrit-Change-Number: 59636
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: David Wu.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59560 )
Change subject: mb/google/brya/var/kano: swap TPM i2c with touchscreen i2c for EVT
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/59560
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I500f0721689ca66b65b8fb1deb79bef2bd988465
Gerrit-Change-Number: 59560
Gerrit-PatchSet: 4
Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 24 Nov 2021 18:38:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: David Wu.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59560 )
Change subject: mb/google/brya/var/kano: swap TPM i2c with touchscreen i2c for EVT
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59560/comment/5306b4c8_b942fb38
PS4, Line 7: EVT
we usually try not to mention specific build phases, but rather just say "for the next build phase"
--
To view, visit https://review.coreboot.org/c/coreboot/+/59560
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I500f0721689ca66b65b8fb1deb79bef2bd988465
Gerrit-Change-Number: 59560
Gerrit-PatchSet: 4
Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 24 Nov 2021 18:38:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment