coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: src/mb/brya: Enable crashlog on brya0
by Tim Wawrzynczak (Code Review) 24 Nov '21

24 Nov '21

Attention is currently required from: Gaggery Tsai, Francois Toguo Fotso, Kane Chen. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59486 ) Change subject: src/mb/brya: Enable crashlog on brya0 ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59486 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib4bbe5d7cece0c6c5fc170460d55ac820054abb9 Gerrit-Change-Number: 59486 Gerrit-PatchSet: 7 Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Attention: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Wed, 24 Nov 2021 20:52:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: emulation/qemu-i440fx: Use a 4MB ROM by default
by Simon Glass (Code Review) 24 Nov '21

24 Nov '21

Attention is currently required from: Simon Glass. Hello build bot (Jenkins), Arthur Heymans, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59604 to look at the new patch set (#2). Change subject: emulation/qemu-i440fx: Use a 4MB ROM by default ...................................................................... emulation/qemu-i440fx: Use a 4MB ROM by default At present the default ROM for for QEMU is too small for U-Boot to fit. Add a condition to catch this and expand it to a 1MB ROM. This allows booting U-Boot under emulation. It also matches the size used by other emulation boards. Signed-off-by: Simon Glass <sjg(a)chromium.org> Change-Id: Ia1a8c1109e3ece5fec56255173a2d19d4a130bcb --- M src/mainboard/emulation/qemu-i440fx/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/59604/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia1a8c1109e3ece5fec56255173a2d19d4a130bcb Gerrit-Change-Number: 59604 Gerrit-PatchSet: 2 Gerrit-Owner: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Simon Glass <sjg(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Makefile: Defer normalizing configuration for reproducible builds
by Patrick Georgi (Code Review) 24 Nov '21

24 Nov '21

Patrick Georgi has restored this change. ( https://review.coreboot.org/c/coreboot/+/52292 ) Change subject: Makefile: Defer normalizing configuration for reproducible builds ...................................................................... Restored -- To view, visit https://review.coreboot.org/c/coreboot/+/52292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7afd32bd120e5405e65825144b0c30d69931a22 Gerrit-Change-Number: 52292 Gerrit-PatchSet: 8 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: restore

1 0

Change in coreboot[master]: Revert "util/crossgcc: Update gcc to 11.2"
by Mike Banon (Code Review) 24 Nov '21

24 Nov '21

Attention is currently required from: Nico Huber, Branden Waldner, Idwer Vollering, Paul Menzel, Arthur Heymans, Jacob Garber, Werner Zeh, Iru Cai, Harshit Sharma. Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59636 ) Change subject: Revert "util/crossgcc: Update gcc to 11.2" ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/59636/comment/8ff17ec5_6e33b8e8 PS1, Line 11: Unfortunately this gcc 11.2 is causing problems for some boards: : in example, AMD Lenovo G505S can't boot to Linux. > Can you be more specific about this? What payload and what version are you using? Is this a payload […] I'm using a SeaBIOS master. As for "payload problem or a coreboot problem" - after lots of testing, I am sure that something compiles badly with a new gcc, but don't know if it's in a coreboot or SeaBIOS; if that could help, I may try building a mixed "coreboot with old gcc, SeaBIOS with new gcc" > What does Linux output with earlyprintk. Will reply if I could get this output. Although, my first idea is to compare the compiler flags of gcc 8.3.0 vs 11.2 (i.e. if some flag got added and has an unpleasant default), or if some workaround patch = which has been dropped during a gcc upgrade - is still needed and should be rebased). -- To view, visit https://review.coreboot.org/c/coreboot/+/59636 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09a789f9ccb284ac7cad32b12bbf60ecb82efb44 Gerrit-Change-Number: 59636 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Branden Waldner <scruffy99(a)gmail.com> Gerrit-Reviewer: Harshit Sharma <harshitsharmajs(a)gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Branden Waldner <scruffy99(a)gmail.com> Gerrit-Attention: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Attention: Harshit Sharma <harshitsharmajs(a)gmail.com> Gerrit-Attention: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Comment-Date: Wed, 24 Nov 2021 20:33:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer/var/delbin: Add fw_config probe for ALC5682-VD & VS
by Tim Wawrzynczak (Code Review) 24 Nov '21

24 Nov '21

Attention is currently required from: Anson Tseng, Frank Chu, Nick Vaccaro, Zhuohao Lee. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59557 ) Change subject: mb/google/volteer/var/delbin: Add fw_config probe for ALC5682-VD & VS ...................................................................... Patch Set 6: (1 comment) File src/mainboard/google/volteer/variants/delbin/variant.c: https://review.coreboot.org/c/coreboot/+/59557/comment/9f410436_5d225865 PS6, Line 7: : extern struct chip_operations drivers_i2c_generic_ops; : static void audio_codec_update(void) : { : const struct device_path codec_path[] = { : {.type = DEVICE_PATH_PCI, .pci.devfn = PCH_DEVFN_I2C0}, : {.type = DEVICE_PATH_I2C, .i2c.device = 0x1a} : }; : const struct device *codec = : find_dev_nested_path(pci_root_bus(), codec_path, ARRAY_SIZE(codec_path)); : struct drivers_i2c_generic_config *config; : : if (!codec || (codec->chip_ops != &drivers_i2c_generic_ops) || !codec->chip_info) : return; : config = codec->chip_info; : : if (fw_config_probe(FW_CONFIG(AUDIO_CODEC_SOURCE, AUDIO_CODEC_ALC5682))) : config->hid = "10EC5682"; : else if (fw_config_probe(FW_CONFIG(AUDIO_CODEC_SOURCE, AUDIO_CODEC_ALC5682I_VS))) : config->hid = "RTL5682"; > https://chromium-review.googlesource. […] +Nick, do you want to cherry-pick the stack starting https://review.coreboot.org/c/coreboot/+/57657 into the volteer branch to make this simpler going forward? -- To view, visit https://review.coreboot.org/c/coreboot/+/59557 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieef638f78edd3428e572a76f06fb9c8757278971 Gerrit-Change-Number: 59557 Gerrit-PatchSet: 6 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com> Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Anson Tseng <ansontseng(a)google.com> Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Comment-Date: Wed, 24 Nov 2021 20:20:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "util/crossgcc: Update gcc to 11.2"
by Patrick Georgi (Code Review) 24 Nov '21

24 Nov '21

Attention is currently required from: Nico Huber, Branden Waldner, Idwer Vollering, Paul Menzel, Mike Banon, Jacob Garber, Werner Zeh, Iru Cai, Harshit Sharma. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59636 ) Change subject: Revert "util/crossgcc: Update gcc to 11.2" ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: It might help to get the timestamp logs as well the full build-directories of both builds. If there's any significant movement in the timestamps, that might indicate where to look, while the full build directories allow selectively checking out individual object files (headers, later disassembly) to see what's going on. -- To view, visit https://review.coreboot.org/c/coreboot/+/59636 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09a789f9ccb284ac7cad32b12bbf60ecb82efb44 Gerrit-Change-Number: 59636 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Branden Waldner <scruffy99(a)gmail.com> Gerrit-Reviewer: Harshit Sharma <harshitsharmajs(a)gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Branden Waldner <scruffy99(a)gmail.com> Gerrit-Attention: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Attention: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Attention: Harshit Sharma <harshitsharmajs(a)gmail.com> Gerrit-Attention: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Comment-Date: Wed, 24 Nov 2021 20:18:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads/U-Boot: Move to v2021.10
by Arthur Heymans (Code Review) 24 Nov '21

24 Nov '21

Attention is currently required from: Martin Roth, Stefan Reinauer, Simon Glass. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59606 ) Change subject: payloads/U-Boot: Move to v2021.10 ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59606 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I33fcfc3135e55d16b0dcd8135217bd5adcef2099 Gerrit-Change-Number: 59606 Gerrit-PatchSet: 3 Gerrit-Owner: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Simon Glass <sjg(a)chromium.org> Gerrit-Comment-Date: Wed, 24 Nov 2021 20:18:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads/U-Boot: Enable the frame buffer
by Arthur Heymans (Code Review) 24 Nov '21

24 Nov '21

Attention is currently required from: Martin Roth, Stefan Reinauer, Simon Glass. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59605 ) Change subject: payloads/U-Boot: Enable the frame buffer ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59605 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5684c6ead30076689f43034675ff9f3531970fe Gerrit-Change-Number: 59605 Gerrit-PatchSet: 3 Gerrit-Owner: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Simon Glass <sjg(a)chromium.org> Gerrit-Comment-Date: Wed, 24 Nov 2021 20:17:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: emulation/qemu-i440fx: Use a 1MB ROM by default with U-Boot
by Arthur Heymans (Code Review) 24 Nov '21

24 Nov '21

Attention is currently required from: Simon Glass. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59604 ) Change subject: emulation/qemu-i440fx: Use a 1MB ROM by default with U-Boot ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: All other emulation boards besides Q35 use 4M. A big use case for emulation boards is to test payloads and 256K is too small for that. I'd just increase it regardless of the payload. -- To view, visit https://review.coreboot.org/c/coreboot/+/59604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia1a8c1109e3ece5fec56255173a2d19d4a130bcb Gerrit-Change-Number: 59604 Gerrit-PatchSet: 1 Gerrit-Owner: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Simon Glass <sjg(a)chromium.org> Gerrit-Comment-Date: Wed, 24 Nov 2021 20:17:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/testing: Give meaningful error if intel-sec-tools aren't around
by Patrick Georgi (Code Review) 24 Nov '21

24 Nov '21

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/57527 ) Change subject: util/testing: Give meaningful error if intel-sec-tools aren't around ...................................................................... util/testing: Give meaningful error if intel-sec-tools aren't around Without manual handling, when 3rdparty/intel-sec-tools isn't around, `make what-jenkins-does` reports only go: go.mod file not found in current directory or any parent directory; see 'go help modules' which isn't meaningful or actionable. Instead check that the go.mod file exists and bail out with a better error message before trying to run `go mod vendor`. Change-Id: I035747746ca5fd54841bd67352044dde12a28185 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/57527 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> --- M util/testing/Makefile.inc 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Arthur Heymans: Looks good to me, approved diff --git a/util/testing/Makefile.inc b/util/testing/Makefile.inc index 4de3307..0b93425 100644 --- a/util/testing/Makefile.inc +++ b/util/testing/Makefile.inc @@ -85,6 +85,11 @@ util/lint/lint lint-stable --junit util/lint/lint lint-extended --junit endif + if [ ! -f 3rdparty/intel-sec-tools/go.mod ]; then \ + echo "Please download 3rdparty/intel-sec-tools/:"; \ + echo "git submodule update --init 3rdparty/intel-sec-tools"; \ + exit 1; \ + fi cd 3rdparty/intel-sec-tools/ ; go mod vendor util/abuild/abuild -o $(COREBOOT_BUILD_DIR)/chromeos $(ABUILD_OPTIONS) -x -X $(top)/abuild-chromeos.xml util/abuild/abuild -o $(COREBOOT_BUILD_DIR)/default $(ABUILD_OPTIONS) -- To view, visit https://review.coreboot.org/c/coreboot/+/57527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I035747746ca5fd54841bd67352044dde12a28185 Gerrit-Change-Number: 57527 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021