coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: mb/google/brya/redrix: Add _HID for privacy screen device
by Nick Vaccaro (Code Review) 29 Nov '21

29 Nov '21

Attention is currently required from: Chen Wisley, Tim Wawrzynczak, Rajat Jain. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59731 ) Change subject: mb/google/brya/redrix: Add _HID for privacy screen device ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59731 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If988ca94b6c70d08a7b07cc9f6bbb077fac84e5b Gerrit-Change-Number: 59731 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Rajat Jain <rajatja(a)google.com> Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Rajat Jain <rajatja(a)google.com> Gerrit-Comment-Date: Mon, 29 Nov 2021 20:34:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/stoneyridge/psp: use PSP_MAILBOX_BAR define
by Felix Held (Code Review) 29 Nov '21

29 Nov '21

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59700 ) Change subject: soc/amd/stoneyridge/psp: use PSP_MAILBOX_BAR define ...................................................................... soc/amd/stoneyridge/psp: use PSP_MAILBOX_BAR define PSP_MAILBOX_BAR is defined as PCI_BASE_ADDRESS_4, so use it instead of PCI_BASE_ADDRESS_4 in the code. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I8658b674b9adea85dfc71d7036ccf3ae17464b58 Reviewed-on: https://review.coreboot.org/c/coreboot/+/59700 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> Reviewed-by: Raul Rangel <rrangel(a)chromium.org> --- M src/soc/amd/stoneyridge/psp.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Raul Rangel: Looks good to me, approved diff --git a/src/soc/amd/stoneyridge/psp.c b/src/soc/amd/stoneyridge/psp.c index 8d6290f..b001d5f 100644 --- a/src/soc/amd/stoneyridge/psp.c +++ b/src/soc/amd/stoneyridge/psp.c @@ -51,7 +51,7 @@ return 0; } } else { - psp_mmio = pci_read_config32(SOC_PSP_DEV, PCI_BASE_ADDRESS_4) & + psp_mmio = pci_read_config32(SOC_PSP_DEV, PSP_MAILBOX_BAR) & ~PCI_BASE_ADDRESS_MEM_ATTR_MASK; } -- To view, visit https://review.coreboot.org/c/coreboot/+/59700 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8658b674b9adea85dfc71d7036ccf3ae17464b58 Gerrit-Change-Number: 59700 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: soc/amd/common/block/psp/psp_def: drop PSPV2_STATUS_* defines
by Felix Held (Code Review) 29 Nov '21

29 Nov '21

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59699 ) Change subject: soc/amd/common/block/psp/psp_def: drop PSPV2_STATUS_* defines ...................................................................... soc/amd/common/block/psp/psp_def: drop PSPV2_STATUS_* defines PSPV2_STATUS_ERROR and PSPV2_STATUS_RECOVERY aren't used and the bit definitions are also wrong, so drop those defines. For the PSP mailbox interface version 2, struct pspv2_mbox is used to access the correct status bits. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I8e2aadfde00e2f7b0f99b462b8e3d6954959a584 Reviewed-on: https://review.coreboot.org/c/coreboot/+/59699 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Raul Rangel <rrangel(a)chromium.org> --- M src/soc/amd/common/block/psp/psp_def.h 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved diff --git a/src/soc/amd/common/block/psp/psp_def.h b/src/soc/amd/common/block/psp/psp_def.h index 38d6206..4d3aca5 100644 --- a/src/soc/amd/common/block/psp/psp_def.h +++ b/src/soc/amd/common/block/psp/psp_def.h @@ -30,10 +30,6 @@ #define PSPV1_STATUS_HALT BIT(3) #define PSPV1_STATUS_RECOVERY BIT(4) -/* generic PSP interface status, v2 */ -#define PSPV2_STATUS_ERROR BIT(30) -#define PSPV2_STATUS_RECOVERY BIT(31) - /* psp_mbox consists of hardware registers beginning at PSPx000070 * mbox_command: BIOS->PSP command, cleared by PSP when complete * mbox_status: BIOS->PSP interface status -- To view, visit https://review.coreboot.org/c/coreboot/+/59699 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8e2aadfde00e2f7b0f99b462b8e3d6954959a584 Gerrit-Change-Number: 59699 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/brya/redrix: Add _HID for privacy screen device
by Tim Wawrzynczak (Code Review) 29 Nov '21

29 Nov '21

Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59731 ) Change subject: mb/google/brya/redrix: Add _HID for privacy screen device ...................................................................... mb/google/brya/redrix: Add _HID for privacy screen device The ChromeOS kernel platform driver is adding support for a ChromeOS privacy screen device, and in order to locate that device, the driver uses the GOOG0010 reserved HID for this. BUG=b:206850071 TEST=dump SSDT, see _HID instead of _ADR Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Change-Id: If988ca94b6c70d08a7b07cc9f6bbb077fac84e5b --- M src/mainboard/google/brya/variants/redrix/overridetree.cb 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/59731/1 diff --git a/src/mainboard/google/brya/variants/redrix/overridetree.cb b/src/mainboard/google/brya/variants/redrix/overridetree.cb index 67cb7f3..9531e5e 100644 --- a/src/mainboard/google/brya/variants/redrix/overridetree.cb +++ b/src/mainboard/google/brya/variants/redrix/overridetree.cb @@ -87,6 +87,8 @@ chip drivers/gfx/generic register "device_count" = "1" register "device[0].name" = ""LCD"" + # Use Chrome OS privacy screen _HID + register "device[0].hid" = ""GOOG0010"" # Internal panel on the first port of the graphics chip register "device[0].addr" = "0x80010400" register "device[0].privacy.enabled" = "1" -- To view, visit https://review.coreboot.org/c/coreboot/+/59731 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If988ca94b6c70d08a7b07cc9f6bbb077fac84e5b Gerrit-Change-Number: 59731 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/gfx/generic: Add optional _HID for gfx devices
by Tim Wawrzynczak (Code Review) 29 Nov '21

29 Nov '21

Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59730 ) Change subject: drivers/gfx/generic: Add optional _HID for gfx devices ...................................................................... drivers/gfx/generic: Add optional _HID for gfx devices Some boards may want to use a _HID instead of an _ADR to locate a graphics device. This patch provides that option in the devicetree. BUG=b:206850071 TEST=Add `hid` entry in devicetree, dump SSDT and see _HID instead of _ADR Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Change-Id: I32be4abf5c60be1f94aabaa2e9c734215c4e291e --- M src/drivers/gfx/generic/chip.h M src/drivers/gfx/generic/generic.c 2 files changed, 7 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/59730/1 diff --git a/src/drivers/gfx/generic/chip.h b/src/drivers/gfx/generic/chip.h index becc2ed..d600823 100644 --- a/src/drivers/gfx/generic/chip.h +++ b/src/drivers/gfx/generic/chip.h @@ -29,6 +29,8 @@ struct drivers_gfx_generic_device_config { /* ACPI device name of the output device */ const char *name; + /* Value to use for _HID Name, will take precedence over _ADR */ + const char *hid; /* The address of the output device. See section A.3.2 */ unsigned int addr; /* Electronic privacy screen specific config */ diff --git a/src/drivers/gfx/generic/generic.c b/src/drivers/gfx/generic/generic.c index 98bde79..b7c030f 100644 --- a/src/drivers/gfx/generic/generic.c +++ b/src/drivers/gfx/generic/generic.c @@ -121,8 +121,11 @@ for (i = 0; i < config->device_count; i++) { acpigen_write_device(config->device[i].name); - acpigen_write_name_integer("_ADR", config->device[i].addr); - acpigen_write_name_integer("_STA", 0xF); + if (config->device[i].hid) + acpigen_write_name_string("_HID", config->device[i].hid); + else + acpigen_write_name_integer("_ADR", config->device[i].addr); + gfx_fill_privacy_screen_dsm(&config->device[i].privacy); acpigen_pop_len(); /* Device */ } -- To view, visit https://review.coreboot.org/c/coreboot/+/59730 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I32be4abf5c60be1f94aabaa2e9c734215c4e291e Gerrit-Change-Number: 59730 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: brya: add various ES variants
by YH Lin (Code Review) 29 Nov '21

29 Nov '21

Attention is currently required from: YH Lin, Nick Vaccaro, Zhuohao Lee. Hello build bot (Jenkins), Tim Wawrzynczak, Nick Vaccaro, Zhuohao Lee, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59728 to look at the new patch set (#2). Change subject: brya: add various ES variants ...................................................................... brya: add various ES variants Fork multiple "4ES" variants off some brya devices to properly support ES SoC. BRANCH=none BUG=b:201767461 TEST=emerge-brya coreboot and check the artifacts Signed-off-by: YH Lin <yueherngl(a)google.com> Change-Id: Ic9516fec591429238bde1478eca2522d8ed10127 --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Kconfig.name A src/mainboard/google/brya/variants/anahera4es/Makefile.inc A src/mainboard/google/brya/variants/anahera4es/fw_config.c A src/mainboard/google/brya/variants/anahera4es/gpio.c A src/mainboard/google/brya/variants/anahera4es/include/variant/ec.h A src/mainboard/google/brya/variants/anahera4es/include/variant/gpio.h A src/mainboard/google/brya/variants/anahera4es/memory/Makefile.inc A src/mainboard/google/brya/variants/anahera4es/memory/dram_id.generated.txt A src/mainboard/google/brya/variants/anahera4es/memory/mem_parts_used.txt A src/mainboard/google/brya/variants/anahera4es/overridetree.cb A src/mainboard/google/brya/variants/brya4es/Makefile.inc A src/mainboard/google/brya/variants/brya4es/fw_config.c A src/mainboard/google/brya/variants/brya4es/gpio.c A src/mainboard/google/brya/variants/brya4es/include/variant/ec.h A src/mainboard/google/brya/variants/brya4es/include/variant/gpio.h A src/mainboard/google/brya/variants/brya4es/memory/Makefile.inc A src/mainboard/google/brya/variants/brya4es/memory/dram_id.generated.txt A src/mainboard/google/brya/variants/brya4es/memory/mem_parts_used.txt A src/mainboard/google/brya/variants/brya4es/overridetree.cb A src/mainboard/google/brya/variants/brya4es/ramstage.c A src/mainboard/google/brya/variants/brya4es/variant.c A src/mainboard/google/brya/variants/gimble4es/Makefile.inc A src/mainboard/google/brya/variants/gimble4es/fw_config.c A src/mainboard/google/brya/variants/gimble4es/gpio.c A src/mainboard/google/brya/variants/gimble4es/include/variant/ec.h A src/mainboard/google/brya/variants/gimble4es/include/variant/gpio.h A src/mainboard/google/brya/variants/gimble4es/memory/Makefile.inc A src/mainboard/google/brya/variants/gimble4es/memory/dram_id.generated.txt A src/mainboard/google/brya/variants/gimble4es/memory/mem_parts_used.txt A src/mainboard/google/brya/variants/gimble4es/overridetree.cb A src/mainboard/google/brya/variants/gimble4es/variant.c A src/mainboard/google/brya/variants/primus4es/Makefile.inc A src/mainboard/google/brya/variants/primus4es/fw_config.c A src/mainboard/google/brya/variants/primus4es/gpio.c A src/mainboard/google/brya/variants/primus4es/include/variant/ec.h A src/mainboard/google/brya/variants/primus4es/include/variant/gpio.h A src/mainboard/google/brya/variants/primus4es/memory/Makefile.inc A src/mainboard/google/brya/variants/primus4es/memory/dram_id.generated.txt A src/mainboard/google/brya/variants/primus4es/memory/mem_parts_used.txt A src/mainboard/google/brya/variants/primus4es/overridetree.cb A src/mainboard/google/brya/variants/primus4es/variant.c A src/mainboard/google/brya/variants/redrix4es/Makefile.inc A src/mainboard/google/brya/variants/redrix4es/fw_config.c A src/mainboard/google/brya/variants/redrix4es/gpio.c A src/mainboard/google/brya/variants/redrix4es/include/variant/ec.h A src/mainboard/google/brya/variants/redrix4es/include/variant/gpio.h A src/mainboard/google/brya/variants/redrix4es/memory/Makefile.inc A src/mainboard/google/brya/variants/redrix4es/memory/dram_id.generated.txt A src/mainboard/google/brya/variants/redrix4es/memory/mem_parts_used.txt A src/mainboard/google/brya/variants/redrix4es/overridetree.cb A src/mainboard/google/brya/variants/redrix4es/variant.c A src/mainboard/google/brya/variants/taeko4es/Makefile.inc A src/mainboard/google/brya/variants/taeko4es/fw_config.c A src/mainboard/google/brya/variants/taeko4es/gpio.c A src/mainboard/google/brya/variants/taeko4es/include/variant/ec.h A src/mainboard/google/brya/variants/taeko4es/include/variant/gpio.h A src/mainboard/google/brya/variants/taeko4es/memory.c A src/mainboard/google/brya/variants/taeko4es/memory/Makefile.inc A src/mainboard/google/brya/variants/taeko4es/memory/dram_id.generated.txt A src/mainboard/google/brya/variants/taeko4es/memory/mem_parts_used.txt A src/mainboard/google/brya/variants/taeko4es/overridetree.cb 62 files changed, 4,933 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/59728/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59728 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9516fec591429238bde1478eca2522d8ed10127 Gerrit-Change-Number: 59728 Gerrit-PatchSet: 2 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: cbfs | tspi: Join hash calculation for verification and measurement
by Raul Rangel (Code Review) 29 Nov '21

29 Nov '21

Attention is currently required from: Jakub Czapiga, Christian Walter, Julius Werner, Arthur Heymans, Werner Zeh. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59681 ) Change subject: cbfs | tspi: Join hash calculation for verification and measurement ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59681 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70d7066c6768195077f083c7ffdfa30d9182b2b7 Gerrit-Change-Number: 59681 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Mon, 29 Nov 2021 20:12:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] src/drivers/intel/fsp2_0: Add FSP 2.3 support
by build bot (Jenkins) (Code Review) 29 Nov '21

29 Nov '21

Attention is currently required from: Subrata Banik, Andrey Petrov, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59324 ) Change subject: [WIP] src/drivers/intel/fsp2_0: Add FSP 2.3 support ...................................................................... Patch Set 9: (2 comments) File src/drivers/intel/fsp2_0/header_display.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134597): https://review.coreboot.org/c/coreboot/+/59324/comment/5eaec341_0b82c452 PS9, Line 23: ((ext_revision.rev.revision << 8) | revision.rev.revision), line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134597): https://review.coreboot.org/c/coreboot/+/59324/comment/d7ab8a42_504eb47b PS9, Line 24: ((ext_revision.rev.bld_num << 8) | revision.rev.bld_num)); line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/59324 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica1bd004286c785aa8a431f39d8efc69982874c1 Gerrit-Change-Number: 59324 Gerrit-PatchSet: 9 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 29 Nov 2021 20:09:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cbfs: Add unverified_area APIs
by Raul Rangel (Code Review) 29 Nov '21

29 Nov '21

Attention is currently required from: Julius Werner. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59678 ) Change subject: cbfs: Add unverified_area APIs ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I402265900f7075aa0c2f58d812c67ea63ddf2900 Gerrit-Change-Number: 59678 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Mon, 29 Nov 2021 20:06:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: brya: add various ES variants
by Tim Wawrzynczak (Code Review) 29 Nov '21

29 Nov '21

Attention is currently required from: YH Lin, Nick Vaccaro, Zhuohao Lee. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59728 ) Change subject: brya: add various ES variants ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: > Failure due to symlinks? Is it allowed? […] No they're not allowed upstream, it's one of the lint checks now ``` Regression lint.lint-stable-018-symlinks (from (junit.xml)) Failing for the past 1 build (Since #188716 ) Took 0 ms. Stacktrace src/mainboard/google/brya/variants/anahera4es src/mainboard/google/brya/variants/brya4es src/mainboard/google/brya/variants/gimble4es src/mainboard/google/brya/variants/primus4es src/mainboard/google/brya/variants/redrix4es src/mainboard/google/brya/variants/taeko4es ``` PS1: symlini -- To view, visit https://review.coreboot.org/c/coreboot/+/59728 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9516fec591429238bde1478eca2522d8ed10127 Gerrit-Change-Number: 59728 Gerrit-PatchSet: 1 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Comment-Date: Mon, 29 Nov 2021 19:59:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: YH Lin <yueherngl(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021