coreboot-gerrit October 2021

coreboot-gerrit@coreboot.org

1 participants
5514 discussions

Change in coreboot[master]: acpigen,soc/amd,cpu/intel: rework static DWORD for CPPC table
by Michael Niewöhner (Code Review) 05 Oct '21

05 Oct '21

1 0

Change in coreboot[master]: soc/amd/cezanne,soc/intel/common: rework CPPC table generation
by Michael Niewöhner (Code Review) 05 Oct '21

05 Oct '21

1 0

Change in coreboot[master]: acpigen,soc/amd,cpu/intel: rework static DWORD for CPPC table
by build bot (Jenkins) (Code Review) 05 Oct '21

05 Oct '21

Attention is currently required from: Felix Singer, Raul Rangel, Furquan Shaikh, Paul Menzel, Angel Pons, Subrata Banik, Kyösti Mälkki, Patrick Rudolph, Jason Glenesk, Matt Delco, Nico Huber, Marshall Dawson, Tim Wawrzynczak, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57886 ) Change subject: acpigen,soc/amd,cpu/intel: rework static DWORD for CPPC table ...................................................................... Patch Set 5: (109 comments) File src/acpi/acpigen.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/3763025d_5da69539 PS5, Line 1802: if (entry->type == CPPC_TYPE_DWORD) { braces {} are not necessary for any arm of this statement File src/cpu/intel/common/common_init.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/fb349aae_b0157aeb PS5, Line 108: config->entries[CPPC_HIGHEST_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 0, 8) ); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/f94994cb_e386900d PS5, Line 108: config->entries[CPPC_HIGHEST_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 0, 8) ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/9979d194_075fa92b PS5, Line 108: config->entries[CPPC_HIGHEST_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 0, 8) ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/4b3bdf4b_8c4a812b PS5, Line 109: config->entries[CPPC_NOMINAL_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_PLATFORM_INFO, 8, 8) ); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/4a54c6e9_81590b23 PS5, Line 109: config->entries[CPPC_NOMINAL_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_PLATFORM_INFO, 8, 8) ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/fd03c480_6ccbfbc6 PS5, Line 109: config->entries[CPPC_NOMINAL_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_PLATFORM_INFO, 8, 8) ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/8b90c6a3_26bf8532 PS5, Line 110: config->entries[CPPC_LOWEST_NONL_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 16, 8) ); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/a7e90eca_6ecd2e11 PS5, Line 110: config->entries[CPPC_LOWEST_NONL_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 16, 8) ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/7636ea0a_90f289d2 PS5, Line 110: config->entries[CPPC_LOWEST_NONL_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 16, 8) ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/3186d9d6_dd536edb PS5, Line 111: config->entries[CPPC_LOWEST_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 24, 8) ); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/e69886ac_d521e57c PS5, Line 111: config->entries[CPPC_LOWEST_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 24, 8) ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/c4089b01_7031b897 PS5, Line 111: config->entries[CPPC_LOWEST_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 24, 8) ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/c9353b81_bf308391 PS5, Line 112: config->entries[CPPC_GUARANTEED_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 8, 8) ); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/d0726b0e_800e53db PS5, Line 112: config->entries[CPPC_GUARANTEED_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 8, 8) ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/07a4f70f_608018c1 PS5, Line 112: config->entries[CPPC_GUARANTEED_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 8, 8) ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/4cfdc4ba_275d09e1 PS5, Line 113: config->entries[CPPC_DESIRED_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 16, 8) ); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/6f7c2111_56a49ce1 PS5, Line 113: config->entries[CPPC_DESIRED_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 16, 8) ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/da23c791_1f98c677 PS5, Line 113: config->entries[CPPC_DESIRED_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 16, 8) ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/c90a5a1d_74c5becb PS5, Line 114: config->entries[CPPC_MIN_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 0, 8) ); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/765423d5_87e63829 PS5, Line 114: config->entries[CPPC_MIN_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 0, 8) ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/429e7b1a_52380e69 PS5, Line 114: config->entries[CPPC_MIN_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 0, 8) ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/2699d88a_169039cf PS5, Line 115: config->entries[CPPC_MAX_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 8, 8) ); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/254c9dfb_6c2ecaa8 PS5, Line 115: config->entries[CPPC_MAX_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 8, 8) ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/37d46aab_001afa04 PS5, Line 115: config->entries[CPPC_MAX_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 8, 8) ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/5e38bd27_970e8498 PS5, Line 116: config->entries[CPPC_PERF_REDUCE_TOLERANCE] = CPPC_REG( ACPI_REG_UNSUPPORTED ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/86d1e194_3ad04bf9 PS5, Line 116: config->entries[CPPC_PERF_REDUCE_TOLERANCE] = CPPC_REG( ACPI_REG_UNSUPPORTED ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/68c29775_14254735 PS5, Line 117: config->entries[CPPC_TIME_WINDOW] = CPPC_REG( ACPI_REG_UNSUPPORTED ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/31336f4d_e94d78db PS5, Line 117: config->entries[CPPC_TIME_WINDOW] = CPPC_REG( ACPI_REG_UNSUPPORTED ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/f509aea4_595d4bf3 PS5, Line 118: config->entries[CPPC_COUNTER_WRAP] = CPPC_REG( ACPI_REG_UNSUPPORTED ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/5db53128_1cb47d91 PS5, Line 118: config->entries[CPPC_COUNTER_WRAP] = CPPC_REG( ACPI_REG_UNSUPPORTED ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/21d9879d_797326dc PS5, Line 119: config->entries[CPPC_REF_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(IA32_MPERF, 0, 64) ); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/5ca4c702_ac97c54b PS5, Line 119: config->entries[CPPC_REF_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(IA32_MPERF, 0, 64) ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/e4ce0424_ce11efe1 PS5, Line 119: config->entries[CPPC_REF_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(IA32_MPERF, 0, 64) ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/71381b4d_74a36489 PS5, Line 120: config->entries[CPPC_DELIVERED_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(IA32_APERF, 0, 64) ); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/d7121e6d_b421b016 PS5, Line 120: config->entries[CPPC_DELIVERED_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(IA32_APERF, 0, 64) ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/b221c018_7bb4ae5a PS5, Line 120: config->entries[CPPC_DELIVERED_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(IA32_APERF, 0, 64) ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/94febc88_dd16036f PS5, Line 121: config->entries[CPPC_PERF_LIMITED] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_STATUS, 2, 1) ); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/8a7d713e_534f1d6f PS5, Line 121: config->entries[CPPC_PERF_LIMITED] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_STATUS, 2, 1) ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/216ff305_344ba13f PS5, Line 121: config->entries[CPPC_PERF_LIMITED] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_STATUS, 2, 1) ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/5429bffe_8f162ca4 PS5, Line 122: config->entries[CPPC_ENABLE] = CPPC_REG( ACPI_REG_MSR(IA32_PM_ENABLE, 0, 1) ); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/ec359d07_dfb7be1c PS5, Line 122: config->entries[CPPC_ENABLE] = CPPC_REG( ACPI_REG_MSR(IA32_PM_ENABLE, 0, 1) ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/02712328_3bf6761d PS5, Line 122: config->entries[CPPC_ENABLE] = CPPC_REG( ACPI_REG_MSR(IA32_PM_ENABLE, 0, 1) ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/3bbb71e5_cd5044b7 PS5, Line 128: config->entries[CPPC_AUTO_ACTIVITY_WINDOW] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 32, 10) ); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/391f14a4_0f4950a6 PS5, Line 128: config->entries[CPPC_AUTO_ACTIVITY_WINDOW] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 32, 10) ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/19afa890_22650e87 PS5, Line 128: config->entries[CPPC_AUTO_ACTIVITY_WINDOW] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 32, 10) ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/be541203_75dc45bd PS5, Line 129: config->entries[CPPC_PERF_PREF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 24, 8) ); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/ef01eb55_9147eba5 PS5, Line 129: config->entries[CPPC_PERF_PREF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 24, 8) ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/e35dc658_41faf198 PS5, Line 129: config->entries[CPPC_PERF_PREF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 24, 8) ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/d1324db9_c3399a88 PS5, Line 130: config->entries[CPPC_REF_PERF] = CPPC_REG( ACPI_REG_UNSUPPORTED ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/96784e9a_580ed4c5 PS5, Line 130: config->entries[CPPC_REF_PERF] = CPPC_REG( ACPI_REG_UNSUPPORTED ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/7dc7d433_4ea5c518 PS5, Line 135: config->entries[CPPC_LOWEST_FREQ] = CPPC_REG( ACPI_REG_UNSUPPORTED ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/07749b71_8b5fe600 PS5, Line 135: config->entries[CPPC_LOWEST_FREQ] = CPPC_REG( ACPI_REG_UNSUPPORTED ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/e1ca9ed2_1c592074 PS5, Line 136: config->entries[CPPC_NOMINAL_FREQ] = CPPC_REG( ACPI_REG_UNSUPPORTED ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/c660767f_87960955 PS5, Line 136: config->entries[CPPC_NOMINAL_FREQ] = CPPC_REG( ACPI_REG_UNSUPPORTED ); space prohibited before that close parenthesis ')' File src/soc/amd/cezanne/cppc.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/78f0117f_476b7570 PS5, Line 18: config->entries[CPPC_HIGHEST_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_HIGHEST_PERF, 8) ); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/7d459ad4_bd5bc6cf PS5, Line 18: config->entries[CPPC_HIGHEST_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_HIGHEST_PERF, 8) ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/a86dbf61_9c026224 PS5, Line 18: config->entries[CPPC_HIGHEST_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_HIGHEST_PERF, 8) ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/91311e9c_e358fc97 PS5, Line 19: config->entries[CPPC_NOMINAL_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_NOMINAL_PERF, 8) ); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/91468dd8_3a5e3e34 PS5, Line 19: config->entries[CPPC_NOMINAL_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_NOMINAL_PERF, 8) ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/22810bca_8416d216 PS5, Line 19: config->entries[CPPC_NOMINAL_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_NOMINAL_PERF, 8) ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/152364c7_4c9a2625 PS5, Line 20: config->entries[CPPC_LOWEST_NONL_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOW_NON_LIN_PERF, 8) ); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/380bcf7c_e506b8d8 PS5, Line 20: config->entries[CPPC_LOWEST_NONL_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOW_NON_LIN_PERF, 8) ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/df2c9ed1_26e11d47 PS5, Line 20: config->entries[CPPC_LOWEST_NONL_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOW_NON_LIN_PERF, 8) ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/96d9be1d_a50acd11 PS5, Line 21: config->entries[CPPC_LOWEST_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOWEST_PERF, 8) ); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/7ee019a9_85d6a4ed PS5, Line 21: config->entries[CPPC_LOWEST_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOWEST_PERF, 8) ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/20490d72_b3bebdf9 PS5, Line 21: config->entries[CPPC_LOWEST_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOWEST_PERF, 8) ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/4e098528_604c5966 PS5, Line 22: config->entries[CPPC_GUARANTEED_PERF] = CPPC_REG( ACPI_REG_UNSUPPORTED ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/c4ce5f3e_67f50d7f PS5, Line 22: config->entries[CPPC_GUARANTEED_PERF] = CPPC_REG( ACPI_REG_UNSUPPORTED ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/5b693a4f_343cf131 PS5, Line 23: config->entries[CPPC_DESIRED_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_DES_PERF, 8) ); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/8534f687_aad8a65d PS5, Line 23: config->entries[CPPC_DESIRED_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_DES_PERF, 8) ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/1018401c_5ef9ecb9 PS5, Line 23: config->entries[CPPC_DESIRED_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_DES_PERF, 8) ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/db3b5470_91e0acda PS5, Line 24: config->entries[CPPC_MIN_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MIN_PERF, 8) ); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/da8ba296_f0f14093 PS5, Line 24: config->entries[CPPC_MIN_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MIN_PERF, 8) ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/cf734e73_a3072e2d PS5, Line 24: config->entries[CPPC_MIN_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MIN_PERF, 8) ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/8c09c61f_c723d580 PS5, Line 25: config->entries[CPPC_MAX_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MAX_PERF, 8) ); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/6487a621_f957f155 PS5, Line 25: config->entries[CPPC_MAX_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MAX_PERF, 8) ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/f0fbd730_b33f8257 PS5, Line 25: config->entries[CPPC_MAX_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MAX_PERF, 8) ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/dd23da08_76935c71 PS5, Line 26: config->entries[CPPC_PERF_REDUCE_TOLERANCE] = CPPC_REG( ACPI_REG_UNSUPPORTED ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/6e950615_d6531e29 PS5, Line 26: config->entries[CPPC_PERF_REDUCE_TOLERANCE] = CPPC_REG( ACPI_REG_UNSUPPORTED ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/17346bc3_43c25f9e PS5, Line 27: config->entries[CPPC_TIME_WINDOW] = CPPC_REG( ACPI_REG_UNSUPPORTED ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/386dd478_9b44e9a5 PS5, Line 27: config->entries[CPPC_TIME_WINDOW] = CPPC_REG( ACPI_REG_UNSUPPORTED ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/fde15f9d_60b1e567 PS5, Line 28: config->entries[CPPC_COUNTER_WRAP] = CPPC_REG( ACPI_REG_UNSUPPORTED ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/ba8ab5ed_e0d519f7 PS5, Line 28: config->entries[CPPC_COUNTER_WRAP] = CPPC_REG( ACPI_REG_UNSUPPORTED ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/31a826dd_ca20273f PS5, Line 29: config->entries[CPPC_REF_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(MSR_MAX_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64) ); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/ad909a55_cee1d50f PS5, Line 29: config->entries[CPPC_REF_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(MSR_MAX_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64) ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/9bbc2f52_77fc966c PS5, Line 29: config->entries[CPPC_REF_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(MSR_MAX_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64) ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/8f6fa5fa_64c4a26a PS5, Line 30: config->entries[CPPC_DELIVERED_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(MSR_ACTUAL_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64) ); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/cdc9a4fa_b7e2c258 PS5, Line 30: config->entries[CPPC_DELIVERED_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(MSR_ACTUAL_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64) ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/aa8fed01_41bbbcec PS5, Line 30: config->entries[CPPC_DELIVERED_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(MSR_ACTUAL_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64) ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/4dd22167_0cd24f78 PS5, Line 31: config->entries[CPPC_PERF_LIMITED] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_STATUS, 1, 1) ); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/0e6ce609_ac2fff71 PS5, Line 31: config->entries[CPPC_PERF_LIMITED] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_STATUS, 1, 1) ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/a230a80a_8ccdd695 PS5, Line 31: config->entries[CPPC_PERF_LIMITED] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_STATUS, 1, 1) ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/bd37f8e8_355f1af7 PS5, Line 32: config->entries[CPPC_ENABLE] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_ENABLE, 0, 1) ); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/3388c24b_88561d72 PS5, Line 32: config->entries[CPPC_ENABLE] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_ENABLE, 0, 1) ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/b348a4ad_0837ae4a PS5, Line 32: config->entries[CPPC_ENABLE] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_ENABLE, 0, 1) ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/da5c198d_7ca0d4ca PS5, Line 37: config->entries[CPPC_AUTO_SELECT] = CPPC_REG( ACPI_REG_UNSUPPORTED ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/359a68e1_7a5e82a2 PS5, Line 37: config->entries[CPPC_AUTO_SELECT] = CPPC_REG( ACPI_REG_UNSUPPORTED ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/2c1fd1fa_36c2e457 PS5, Line 38: config->entries[CPPC_AUTO_ACTIVITY_WINDOW] = CPPC_REG( ACPI_REG_UNSUPPORTED ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/dc0ebf4b_68a1cfab PS5, Line 38: config->entries[CPPC_AUTO_ACTIVITY_WINDOW] = CPPC_REG( ACPI_REG_UNSUPPORTED ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/f0aebeb2_c4c1b030 PS5, Line 39: config->entries[CPPC_PERF_PREF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_ENERGY_PERF_PREF, 8) ); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/edbba8ad_d9118b33 PS5, Line 39: config->entries[CPPC_PERF_PREF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_ENERGY_PERF_PREF, 8) ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/db1f7bf8_e0b033eb PS5, Line 39: config->entries[CPPC_PERF_PREF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_ENERGY_PERF_PREF, 8) ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/d9c85b13_5244a92a PS5, Line 40: config->entries[CPPC_REF_PERF] = CPPC_REG( ACPI_REG_UNSUPPORTED ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/ca33c04a_8d59294d PS5, Line 40: config->entries[CPPC_REF_PERF] = CPPC_REG( ACPI_REG_UNSUPPORTED ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/eff86334_2fe0505e PS5, Line 45: config->entries[CPPC_LOWEST_FREQ] = CPPC_REG( ACPI_REG_UNSUPPORTED ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/15fa305c_d6865cdc PS5, Line 45: config->entries[CPPC_LOWEST_FREQ] = CPPC_REG( ACPI_REG_UNSUPPORTED ); space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/b0f5b227_7d846c9f PS5, Line 46: config->entries[CPPC_NOMINAL_FREQ] = CPPC_REG( ACPI_REG_UNSUPPORTED ); space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129826): https://review.coreboot.org/c/coreboot/+/57886/comment/6b61318a_87afdb43 PS5, Line 46: config->entries[CPPC_NOMINAL_FREQ] = CPPC_REG( ACPI_REG_UNSUPPORTED ); space prohibited before that close parenthesis ')' -- To view, visit https://review.coreboot.org/c/coreboot/+/57886 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib853261b5c0ea87ae2424fed188f2d1872be9a06 Gerrit-Change-Number: 57886 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Matt Delco <delco(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt Delco <delco(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 05 Oct 2021 21:57:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/cezanne,soc/intel/common: rework CPPC table generation
by build bot (Jenkins) (Code Review) 05 Oct '21

05 Oct '21

Attention is currently required from: Felix Singer, Raul Rangel, Furquan Shaikh, Paul Menzel, Angel Pons, Subrata Banik, Kyösti Mälkki, Patrick Rudolph, Lance Zhao, Jason Glenesk, Matt Delco, Marshall Dawson, Tim Wawrzynczak, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57888 ) Change subject: soc/amd/cezanne,soc/intel/common: rework CPPC table generation ...................................................................... Patch Set 12: (15 comments) File src/cpu/intel/common/common_init.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129825): https://review.coreboot.org/c/coreboot/+/57888/comment/f35fd8b9_0347af49 PS12, Line 108: config->regs[CPPC_HIGHEST_PERF] = ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 0, 8); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129825): https://review.coreboot.org/c/coreboot/+/57888/comment/39def05a_09a46c4b PS12, Line 110: config->regs[CPPC_LOWEST_NONL_PERF] = ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 16, 8); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129825): https://review.coreboot.org/c/coreboot/+/57888/comment/d6854536_8027bee8 PS12, Line 111: config->regs[CPPC_LOWEST_PERF] = ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 24, 8); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129825): https://review.coreboot.org/c/coreboot/+/57888/comment/1a503513_86f10c89 PS12, Line 112: config->regs[CPPC_GUARANTEED_PERF] = ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 8, 8); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129825): https://review.coreboot.org/c/coreboot/+/57888/comment/bd213a4b_5e3c57c4 PS12, Line 135: config->regs[CPPC_AUTO_ACTIVITY_WINDOW] = ACPI_REG_MSR(IA32_HWP_REQUEST, 32, 10); line over 96 characters File src/soc/amd/cezanne/cppc.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129825): https://review.coreboot.org/c/coreboot/+/57888/comment/bec1ddde_10dfb3ca PS12, Line 18: config->regs[CPPC_HIGHEST_PERF] = ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_HIGHEST_PERF, 8); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129825): https://review.coreboot.org/c/coreboot/+/57888/comment/f035eadb_fb18a92d PS12, Line 19: config->regs[CPPC_NOMINAL_PERF] = ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_NOMINAL_PERF, 8); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129825): https://review.coreboot.org/c/coreboot/+/57888/comment/8a7bb805_1ce645b3 PS12, Line 20: config->regs[CPPC_LOWEST_NONL_PERF] = ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOW_NON_LIN_PERF, 8); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129825): https://review.coreboot.org/c/coreboot/+/57888/comment/31ed55cc_055f4d3b PS12, Line 21: config->regs[CPPC_LOWEST_PERF] = ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOWEST_PERF, 8); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129825): https://review.coreboot.org/c/coreboot/+/57888/comment/593c7e74_a1d87962 PS12, Line 23: config->regs[CPPC_DESIRED_PERF] = ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_DES_PERF, 8); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129825): https://review.coreboot.org/c/coreboot/+/57888/comment/5b6293df_f8485d76 PS12, Line 24: config->regs[CPPC_MIN_PERF] = ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MIN_PERF, 8); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129825): https://review.coreboot.org/c/coreboot/+/57888/comment/a309b9ad_6370cfad PS12, Line 25: config->regs[CPPC_MAX_PERF] = ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MAX_PERF, 8); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129825): https://review.coreboot.org/c/coreboot/+/57888/comment/1240fa15_ad87787c PS12, Line 29: config->regs[CPPC_REF_PERF_COUNTER] = ACPI_REG_MSR(MSR_MAX_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129825): https://review.coreboot.org/c/coreboot/+/57888/comment/1127debd_0b5aa7ac PS12, Line 30: config->regs[CPPC_DELIVERED_PERF_COUNTER] = ACPI_REG_MSR(MSR_ACTUAL_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129825): https://review.coreboot.org/c/coreboot/+/57888/comment/23c5ec9c_af8b5262 PS12, Line 39: config->regs[CPPC_PERF_PREF] = ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_ENERGY_PERF_PREF, 8); line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/57888 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I844d191b1134b98e409240ede71e2751e51e2159 Gerrit-Change-Number: 57888 Gerrit-PatchSet: 12 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Matt Delco <delco(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Lance Zhao Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt Delco <delco(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 05 Oct 2021 21:57:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: acpigen,soc/amd,cpu/intel: rework static DWORD for CPPC table
by Michael Niewöhner (Code Review) 05 Oct '21

05 Oct '21

Attention is currently required from: Felix Singer, Raul Rangel, Furquan Shaikh, Paul Menzel, Angel Pons, Subrata Banik, Kyösti Mälkki, Patrick Rudolph, Jason Glenesk, Matt Delco, Nico Huber, Marshall Dawson, Tim Wawrzynczak, Felix Held. Hello Felix Singer, build bot (Jenkins), Furquan Shaikh, Paul Menzel, Angel Pons, Subrata Banik, Kyösti Mälkki, Patrick Rudolph, Lance Zhao, Matt Delco, Nico Huber, Tim Wawrzynczak, Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57886 to look at the new patch set (#5). Change subject: acpigen,soc/amd,cpu/intel: rework static DWORD for CPPC table ...................................................................... acpigen,soc/amd,cpu/intel: rework static DWORD for CPPC table Some elements in the ACPI CPPC table allow static DWORDs. Instead of using a fake register resource, use a tagged union with the two types "register" and "DWORD" and respective macros for CPPC table entries. Change-Id: Ib853261b5c0ea87ae2424fed188f2d1872be9a06 Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/acpi/acpigen.c M src/cpu/intel/common/common.h M src/cpu/intel/common/common_init.c M src/include/acpi/acpigen.h M src/soc/amd/cezanne/cppc.c M src/soc/amd/cezanne/include/soc/cppc.h 6 files changed, 69 insertions(+), 55 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/57886/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/57886 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib853261b5c0ea87ae2424fed188f2d1872be9a06 Gerrit-Change-Number: 57886 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Matt Delco <delco(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt Delco <delco(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/amd/cezanne,soc/intel/common: rework CPPC table generation
by Michael Niewöhner (Code Review) 05 Oct '21

05 Oct '21

Attention is currently required from: Felix Singer, Raul Rangel, Furquan Shaikh, Paul Menzel, Angel Pons, Subrata Banik, Michael Niewöhner, Kyösti Mälkki, Patrick Rudolph, Lance Zhao, Jason Glenesk, Matt Delco, Marshall Dawson, Tim Wawrzynczak, Felix Held. Hello Felix Singer, build bot (Jenkins), Raul Rangel, Furquan Shaikh, Paul Menzel, Angel Pons, Subrata Banik, Kyösti Mälkki, Patrick Rudolph, Lance Zhao, Jason Glenesk, Matt Delco, Nico Huber, Marshall Dawson, Tim Wawrzynczak, Tim Wawrzynczak, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57888 to look at the new patch set (#12). Change subject: soc/amd/cezanne,soc/intel/common: rework CPPC table generation ...................................................................... soc/amd/cezanne,soc/intel/common: rework CPPC table generation Make use of the newly introduced ACPI macros for CPPC table generation that currently exists of a bunch of confusing assignments of structs that only get filled partly. Change-Id: I844d191b1134b98e409240ede71e2751e51e2159 Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/cpu/intel/common/common_init.c M src/include/acpi/acpi.h M src/soc/amd/cezanne/cppc.c 3 files changed, 58 insertions(+), 317 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/57888/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/57888 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I844d191b1134b98e409240ede71e2751e51e2159 Gerrit-Change-Number: 57888 Gerrit-PatchSet: 12 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Matt Delco <delco(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Lance Zhao Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt Delco <delco(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/guybrush: Override SPI Fast speeds
by Raul Rangel (Code Review) 05 Oct '21

05 Oct '21

Attention is currently required from: Furquan Shaikh, Karthik Ramasubramanian, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58117 ) Change subject: mb/google/guybrush: Override SPI Fast speeds ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/mainboard/google/guybrush/bootblock.c: https://review.coreboot.org/c/coreboot/+/58117/comment/d5e9edf6_c29801e1 PS1, Line 97: nit: extra line -- To view, visit https://review.coreboot.org/c/coreboot/+/58117 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5bf03ab8772f27aca346589e9c5662caf014d0d2 Gerrit-Change-Number: 58117 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 05 Oct 2021 21:25:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/common/block/spi: Support fast speed override
by Raul Rangel (Code Review) 05 Oct '21

05 Oct '21

Attention is currently required from: Jason Glenesk, Furquan Shaikh, Marshall Dawson, Karthik Ramasubramanian, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58116 ) Change subject: soc/amd/common/block/spi: Support fast speed override ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58116 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8ff3b3bdb53fee142527ae63aa7785945909304 Gerrit-Change-Number: 58116 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 05 Oct 2021 21:22:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/adlrvp: Add hook function to return EC in RW status
by build bot (Jenkins) (Code Review) 05 Oct '21

05 Oct '21

Attention is currently required from: Bora Guvendik, Selma Bensaid, Hsuan-ting Chen, Tim Wawrzynczak, Bernardo Perez Priego. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58099 ) Change subject: mb/adlrvp: Add hook function to return EC in RW status ...................................................................... Patch Set 5: (1 comment) File src/mainboard/intel/adlrvp/chromeos.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129822): https://review.coreboot.org/c/coreboot/+/58099/comment/01b26b26_a2792e2d PS5, Line 56: #endif adding a line without newline at end of file -- To view, visit https://review.coreboot.org/c/coreboot/+/58099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20804db450ab0b3ebe19c51ba2b294a0137d81a7 Gerrit-Change-Number: 58099 Gerrit-PatchSet: 5 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Comment-Date: Tue, 05 Oct 2021 21:22:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/adlrvp: Add hook function to return EC in RW status
by Anil Kumar K (Code Review) 05 Oct '21

05 Oct '21

Attention is currently required from: Bora Guvendik, Selma Bensaid, Hsuan-ting Chen, Tim Wawrzynczak, Bernardo Perez Priego. Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58099 ) Change subject: mb/adlrvp: Add hook function to return EC in RW status ...................................................................... Patch Set 4: (1 comment) File src/mainboard/intel/adlrvp/chromeos.c: https://review.coreboot.org/c/coreboot/+/58099/comment/e70c8654_60539525 PS4, Line 50: int get_ec_is_trusted(void) : { : /* EC is trusted if not in RW. */ : return !gpio_get(GPIO_EC_IN_RW); : } > There is nothing left in depthcharge to handle that "EC in RW" gpios. […] got it. will do. -- To view, visit https://review.coreboot.org/c/coreboot/+/58099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20804db450ab0b3ebe19c51ba2b294a0137d81a7 Gerrit-Change-Number: 58099 Gerrit-PatchSet: 4 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Comment-Date: Tue, 05 Oct 2021 21:22:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2021