Attention is currently required from: Cliff Huang, Tim Wawrzynczak, Bernardo Perez Priego, Patrick Rudolph.
Hello build bot (Jenkins), Cliff Huang, Tim Wawrzynczak, Bernardo Perez Priego, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/58083
to look at the new patch set (#9).
Change subject: southbridge/intel/common: Add an option to allow stitching of CSE binary
......................................................................
southbridge/intel/common: Add an option to allow stitching of CSE binary
In the following changes, CSE binary for some platforms will be
stitched at build time instead of adding a pre-built binary. This
change adds a new Kconfig `STITCH_ME_BIN` which allows mainboard to
select if it wants to stitch CSE binary instead of adding a pre-built
one. In this case, ME_BIN_PATH is not visible to user and instead
mainboard and/or SoC code is expected to provide the recipe for
stitching the CSE image.
Change-Id: I78ab377e110610f9ef4d86a2b6eeb4113897df85
Signed-off-by: Furquan Shaikh <furquan(a)google.com>
---
M src/southbridge/intel/common/firmware/Kconfig
M src/southbridge/intel/common/firmware/Makefile.inc
2 files changed, 25 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/58083/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/58083
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78ab377e110610f9ef4d86a2b6eeb4113897df85
Gerrit-Change-Number: 58083
Gerrit-PatchSet: 9
Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Cliff Huang, Furquan Shaikh, Martin Roth, Tim Wawrzynczak, Rizwan Qureshi, Sridhar Siricilla, Bernardo Perez Priego, Andrew McRae.
Hello build bot (Jenkins), Cliff Huang, Martin Roth, Patrick Georgi, Rizwan Qureshi, Tim Wawrzynczak, Sridhar Siricilla, Bernardo Perez Priego, Bernardo Perez Priego, Andrew McRae,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/55503
to look at the new patch set (#19).
Change subject: util/cse_serger: Add a new tool for stitching CSE components
......................................................................
util/cse_serger: Add a new tool for stitching CSE components
This change adds a new tool `cse_serger` which can be used to print,
dump and stitch together different components for the CSE region.
BUG=b:189177186
Change-Id: I90dd809b47fd16afdc80e66431312721082496aa
Signed-off-by: Furquan Shaikh <furquan(a)google.com>
---
M Makefile.inc
M util/cbfstool/Makefile
M util/cbfstool/Makefile.inc
A util/cbfstool/bpdt_formats/Makefile.inc
A util/cbfstool/bpdt_formats/bpdt_1_6.c
A util/cbfstool/bpdt_formats/bpdt_1_7.c
A util/cbfstool/bpdt_formats/subpart_entry_1.c
A util/cbfstool/bpdt_formats/subpart_hdr_1.c
A util/cbfstool/bpdt_formats/subpart_hdr_2.c
A util/cbfstool/cse_serger.c
A util/cbfstool/cse_serger.h
11 files changed, 1,960 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/55503/19
--
To view, visit https://review.coreboot.org/c/coreboot/+/55503
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I90dd809b47fd16afdc80e66431312721082496aa
Gerrit-Change-Number: 55503
Gerrit-PatchSet: 19
Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Andrew McRae <amcrae(a)google.com>
Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.corp-partner.google.com>
Gerrit-Attention: Andrew McRae <amcrae(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Cliff Huang, Martin Roth, Rizwan Qureshi, Sridhar Siricilla, Bernardo Perez Priego, Andrew McRae.
Hello build bot (Jenkins), Cliff Huang, Martin Roth, Patrick Georgi, Tim Wawrzynczak, Rizwan Qureshi, Sridhar Siricilla, Bernardo Perez Priego, Andrew McRae,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/55259
to look at the new patch set (#17).
Change subject: util/cse_fpt: Add a new tool for managing Intel CSE FPT binaries
......................................................................
util/cse_fpt: Add a new tool for managing Intel CSE FPT binaries
This change adds a new tool `cse_fpt` which can be used to print and
dump CSE partitions in Flash Partition Table (FPT) format.
BUG=b:189167923
Change-Id: I93c8d33e9baa327cbdab918a14f2f7a039953be6
Signed-off-by: Furquan Shaikh <furquan(a)google.com>
---
M Makefile.inc
M util/cbfstool/Makefile
M util/cbfstool/Makefile.inc
A util/cbfstool/cse_fpt.c
A util/cbfstool/cse_fpt.h
A util/cbfstool/fpt_formats/Makefile.inc
A util/cbfstool/fpt_formats/fpt_hdr_20.c
A util/cbfstool/fpt_formats/fpt_hdr_21.c
8 files changed, 721 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/55259/17
--
To view, visit https://review.coreboot.org/c/coreboot/+/55259
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I93c8d33e9baa327cbdab918a14f2f7a039953be6
Gerrit-Change-Number: 55259
Gerrit-PatchSet: 17
Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Andrew McRae <amcrae(a)google.com>
Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Attention: Andrew McRae <amcrae(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak, Sridhar Siricilla, Bernardo Perez Priego, Patrick Rudolph.
Hello build bot (Jenkins), Tim Wawrzynczak, Sridhar Siricilla, Bernardo Perez Priego, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/58158
to look at the new patch set (#5).
Change subject: soc/intel/common/cse: Split CSE metadata into two CBFS files
......................................................................
soc/intel/common/cse: Split CSE metadata into two CBFS files
This change splits CSE metadata structure (added to CBFS) into two
separate CBFS files (me_rw.hash and me_rw.version). Since `struct
cse_rw_metadata` is now used, it is dropped completely.
This change is being made in order to prepare for the upcoming changes
to stitch CSE binary at build time. Since the binary might not be
available pre-built, it complicates the order of operations for the
addition of CSE metadata structure and declaring hash and version as
CPPFLAGS_common. Instead rules can be enabled for individual CBFS file
targets for hash and version that ensure proper ordering as well.
TEST=Ensured that update works correctly on brya by forcing version
mismatch. In case of version match, no update is triggered.
Signed-off-by: Furquan Shaikh <furquan(a)google.com>
Change-Id: I7c9bb165e6a64415affcd0b3331628092195fa0d
---
M src/soc/intel/common/block/cse/Kconfig
M src/soc/intel/common/block/cse/Makefile.inc
M src/soc/intel/common/block/cse/cse_lite.c
M src/soc/intel/common/block/include/intelblocks/cse.h
4 files changed, 74 insertions(+), 54 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/58158/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/58158
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c9bb165e6a64415affcd0b3331628092195fa0d
Gerrit-Change-Number: 58158
Gerrit-PatchSet: 5
Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak, Sridhar Siricilla, Bernardo Perez Priego, Patrick Rudolph.
Hello build bot (Jenkins), Tim Wawrzynczak, Sridhar Siricilla, Bernardo Perez Priego, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/58158
to look at the new patch set (#4).
Change subject: soc/intel/common/cse: Split CSE metadata into two CBFS files
......................................................................
soc/intel/common/cse: Split CSE metadata into two CBFS files
This change splits CSE metadata structure (added to CBFS) into two
separate CBFS files (me_rw.hash and me_rw.version). Since `struct
cse_rw_metadata` is now used, it is dropped completely.
This change is being made in order to prepare for the upcoming changes
to stitch CSE binary at build time. Since the binary might not be
available pre-built, it complicates the order of operations for the
addition of CSE metadata structure and declaring hash and version as
CPPFLAGS_common. Instead rules can be enabled for individual CBFS file
targets for hash and version that ensure proper ordering as well.
TEST=Ensured that update works correctly on brya by forcing version
mismatch. In case of version match, no update is triggered.
Signed-off-by: Furquan Shaikh <furquan(a)google.com>
Change-Id: I7c9bb165e6a64415affcd0b3331628092195fa0d
---
M src/soc/intel/common/block/cse/Kconfig
M src/soc/intel/common/block/cse/Makefile.inc
M src/soc/intel/common/block/cse/cse_lite.c
M src/soc/intel/common/block/include/intelblocks/cse.h
4 files changed, 75 insertions(+), 54 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/58158/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/58158
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c9bb165e6a64415affcd0b3331628092195fa0d
Gerrit-Change-Number: 58158
Gerrit-PatchSet: 4
Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Fagerburg, Julius Werner, Jan Dabros, Yu-Ping Wu.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58163 )
Change subject: tests: Fix JUNIT_OUTPUT=y to write to files instead of stderr
......................................................................
Patch Set 2:
(2 comments)
File tests/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/58163/comment/ca398225_3295212e
PS2, Line 232: rm -f $(testobj)/junit-$(subst /,_,$(patsubst $(testobj)/%/,%,$(dir $^)))\(*\).xml
> would `rm -f $(testobj)/junit-*. […]
It could work, but $^ here refers to $$($$(@)-bin). We do not want to remove junit files of other tests. Am I right?
https://review.coreboot.org/c/coreboot/+/58163/comment/62e9062d_632d264f
PS2, Line 233: rm -f $(testobj)/$(subst /,_,$^).failed
> would `rm -f ${testobj)/*. […]
Same as above.
--
To view, visit https://review.coreboot.org/c/coreboot/+/58163
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09891aca923bf1271cafeaa09f89b6539022709c
Gerrit-Change-Number: 58163
Gerrit-PatchSet: 2
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Thu, 07 Oct 2021 16:49:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Julius Werner, Jan Dabros, Yu-Ping Wu.
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58163 )
Change subject: tests: Fix JUNIT_OUTPUT=y to write to files instead of stderr
......................................................................
Patch Set 2:
(2 comments)
File tests/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/58163/comment/517425e8_0034258c
PS2, Line 232: rm -f $(testobj)/junit-$(subst /,_,$(patsubst $(testobj)/%/,%,$(dir $^)))\(*\).xml
would `rm -f $(testobj)/junit-*.xml` work?
https://review.coreboot.org/c/coreboot/+/58163/comment/b5ab1783_6819f44d
PS2, Line 233: rm -f $(testobj)/$(subst /,_,$^).failed
would `rm -f ${testobj)/*.failed` work?
--
To view, visit https://review.coreboot.org/c/coreboot/+/58163
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09891aca923bf1271cafeaa09f89b6539022709c
Gerrit-Change-Number: 58163
Gerrit-PatchSet: 2
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Thu, 07 Oct 2021 15:31:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment