coreboot-gerrit October 2021

coreboot-gerrit@coreboot.org

1 participants
5513 discussions

Change in coreboot[master]: mb/siemens/mc_ehl2: Adjust Legacy IRQ routing for PCI devices
by Paul Menzel (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Mario Scheithauer. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58172 ) Change subject: mb/siemens/mc_ehl2: Adjust Legacy IRQ routing for PCI devices ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/58172/comment/942c2e9f_b0e08349 PS1, Line 17: Tested how? Maybe: Boot board and notice new info log message: PIRQ routing adapted for SOC2 File src/mainboard/siemens/mc_ehl/variants/mc_ehl2/mainboard.c: https://review.coreboot.org/c/coreboot/+/58172/comment/817f43e8_2d7f68ae PS1, Line 12: */ Please use one of the recommended multi-line comment styles [1]. [1]: https://doc.coreboot.org/contributing/coding_style.html#commenting https://review.coreboot.org/c/coreboot/+/58172/comment/b782bea9_0be8abb0 PS1, Line 14: SOC2 What is SOC2? -- To view, visit https://review.coreboot.org/c/coreboot/+/58172 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6bb8d00458c4d1e3fefd01ac3848078355868d9 Gerrit-Change-Number: 58172 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Comment-Date: Thu, 07 Oct 2021 13:21:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/siemens/mc_ehl: Add variant_mainboard_final()
by Paul Menzel (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Mario Scheithauer. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58171 ) Change subject: mb/siemens/mc_ehl: Add variant_mainboard_final() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/58171 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf9d829b19b2d26a39ad34be4658064083e9da6d Gerrit-Change-Number: 58171 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Comment-Date: Thu, 07 Oct 2021 13:18:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/siemens/mc_ehl2: Enable LPC ComB
by Paul Menzel (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Mario Scheithauer. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58170 ) Change subject: mb/siemens/mc_ehl2: Enable LPC ComB ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/58170/comment/820406e6_9d54b6f4 PS1, Line 10: Tested how? -- To view, visit https://review.coreboot.org/c/coreboot/+/58170 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ec58685a723c177df18144011934b206e6425d0 Gerrit-Change-Number: 58170 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Comment-Date: Thu, 07 Oct 2021 13:18:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: RFIM: TPCH: gfc methods implementation
by Sumeet R Pawnikar (Code Review) 07 Oct '21

07 Oct '21

Sumeet R Pawnikar has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/57531 ) Change subject: RFIM: TPCH: gfc methods implementation ...................................................................... Abandoned test patch -- To view, visit https://review.coreboot.org/c/coreboot/+/57531 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4bd84af505ff4466f395a60f9cf12bfa2010daac Gerrit-Change-Number: 57531 Gerrit-PatchSet: 2 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: mb/siemens/mc_ehl2: Disable INTEL_LPSS_UART_FOR_CONSOLE
by Paul Menzel (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Mario Scheithauer. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58169 ) Change subject: mb/siemens/mc_ehl2: Disable INTEL_LPSS_UART_FOR_CONSOLE ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/58169 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86777cf719def331f4d257ddd94e9a87125ebce8 Gerrit-Change-Number: 58169 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Comment-Date: Thu, 07 Oct 2021 13:18:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/siemens/mc_ehl2: Adjust GPIOs
by Paul Menzel (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Mario Scheithauer. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58168 ) Change subject: mb/siemens/mc_ehl2: Adjust GPIOs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/58168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I19dc24a16ee9f533b45879bf60fb441e24018cc8 Gerrit-Change-Number: 58168 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Comment-Date: Thu, 07 Oct 2021 13:17:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/siemens/mc_ehl2: Disable SATA Port 0
by Paul Menzel (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Mario Scheithauer. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58167 ) Change subject: mb/siemens/mc_ehl2: Disable SATA Port 0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/58167 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I338833f2f9bcb407599cfc676ead0b8a9d7379bd Gerrit-Change-Number: 58167 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Comment-Date: Thu, 07 Oct 2021 13:17:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/siemens/mc_ehl2: Enable SD-Card
by Paul Menzel (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Mario Scheithauer. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58166 ) Change subject: mb/siemens/mc_ehl2: Enable SD-Card ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/58166/comment/9b06d356_6ebcc39f PS1, Line 9: must should -- To view, visit https://review.coreboot.org/c/coreboot/+/58166 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c97e2dc589bf6b89713a473925e42a20278f457 Gerrit-Change-Number: 58166 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Comment-Date: Thu, 07 Oct 2021 13:16:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/siemens/mc_ehl2: Move RTC RX6110SA from SMBus to I2C2
by Paul Menzel (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Mario Scheithauer. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58112 ) Change subject: mb/siemens/mc_ehl2: Move RTC RX6110SA from SMBus to I2C2 ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/58112/comment/f9d82c05_c3e1589c PS2, Line 9: have has https://review.coreboot.org/c/coreboot/+/58112/comment/609654fc_ec574638 PS2, Line 12: Tested RTC device how? -- To view, visit https://review.coreboot.org/c/coreboot/+/58112 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I679c6397fa0d213a25eebaf8a9e0bda9941acd26 Gerrit-Change-Number: 58112 Gerrit-PatchSet: 2 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Comment-Date: Thu, 07 Oct 2021 13:16:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/siemens/mc_ehl2: Set the suitable SPD data
by Paul Menzel (Code Review) 07 Oct '21

07 Oct '21

Attention is currently required from: Mario Scheithauer. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58111 ) Change subject: mb/siemens/mc_ehl2: Set the suitable SPD data ...................................................................... Patch Set 3: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/58111/comment/4177f725_17a0d5d8 PS3, Line 7: mb/siemens/mc_ehl2: Set the suitable SPD data Update SPD for DDR4 devices https://review.coreboot.org/c/coreboot/+/58111/comment/46e06492_981b8af0 PS3, Line 9: devices Are these the memory chips (“modules”). Could you please document the concrete manufacturer and part number? https://review.coreboot.org/c/coreboot/+/58111/comment/5dac9459_20be4b4c PS3, Line 11: As you are editing a hex file, what values/options are you changing? Where did you get these from? Also, did the board not boot before? -- To view, visit https://review.coreboot.org/c/coreboot/+/58111 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icb25f418952f0c96117140863d0d9c897d814ac5 Gerrit-Change-Number: 58111 Gerrit-PatchSet: 3 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Comment-Date: Thu, 07 Oct 2021 13:15:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2021