Mario Scheithauer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/58294 )
Change subject: mb/siemens/mc_ehl2: Enable PCI devices
......................................................................
mb/siemens/mc_ehl2: Enable PCI devices
Correct the remaining PCI devices, differing from the ehl1 mainboard.
Change-Id: I8112fa5ea86e879741061798530150701b759156
Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com>
---
M src/mainboard/siemens/mc_ehl/variants/mc_ehl2/devicetree.cb
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/58294/1
diff --git a/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/devicetree.cb b/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/devicetree.cb
index 062ac5f..06fdf0a 100644
--- a/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/devicetree.cb
+++ b/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/devicetree.cb
@@ -161,7 +161,7 @@
device pci 11.6 off end # Intel PSE IS20
device pci 11.7 off end # Intel PSE IS21
- device pci 12.0 off end # GSPI2
+ device pci 12.0 on end # GSPI2
device pci 12.3 on end # Management Engine UMA Access
device pci 12.4 on end # Management Engine PTT DMA Controller
device pci 12.5 off end # UFS0
@@ -177,7 +177,7 @@
device pci 14.0 on end # USB3.1 xHCI
device pci 14.1 off end # USB3.1 xDCI (OTG)
- device pci 15.0 off end # I2C0
+ device pci 15.0 on end # I2C0
device pci 15.1 on end # I2C1
device pci 15.2 on # I2C2
# Enable external RTC chip
@@ -195,7 +195,7 @@
device i2c 0x32 on end # RTC RX6110 SA
end
end
- device pci 15.3 off end # I2C3
+ device pci 15.3 on end # I2C3
device pci 16.0 on end # Management Engine Interface 1
device pci 16.1 on end # Management Engine Interface 2
@@ -213,7 +213,7 @@
device pci 18.6 off end # Intel PSE QEP3
device pci 19.0 on end # I2C4
- device pci 19.1 off end # I2C5
+ device pci 19.1 on end # I2C5
device pci 19.2 on end # UART2
device pci 1a.0 on end # eMMC
--
To view, visit https://review.coreboot.org/c/coreboot/+/58294
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8112fa5ea86e879741061798530150701b759156
Gerrit-Change-Number: 58294
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-MessageType: newchange
Attention is currently required from: Bora Guvendik, Anil Kumar K, Selma Bensaid, Paul Menzel, Tim Wawrzynczak, Bernardo Perez Priego.
Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58099 )
Change subject: mb/intel/adlrvp: Add hook function to return EC in RW status
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/intel/adlrvp/chromeos.c:
https://review.coreboot.org/c/coreboot/+/58099/comment/d3fdc64a_e1abf60a
PS9, Line 51: get_ec_is_trusted
We decided to revert this get_ec_is_trusted() function for now, and will proceed another reland since there were some GPIOs we did not handled them properly.
(https://review.coreboot.org/c/coreboot/+/57951)
So please remove this function for now, and we will add it back once we are going to re-land get_ec_is_trusted()
But it is still okay to config the EC_IN_RW as the early_gpio in this CL, and only remove this override for now.
--
To view, visit https://review.coreboot.org/c/coreboot/+/58099
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20804db450ab0b3ebe19c51ba2b294a0137d81a7
Gerrit-Change-Number: 58099
Gerrit-PatchSet: 9
Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Comment-Date: Wed, 13 Oct 2021 08:15:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment