Denis 'GNUtoo' Carikli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/13410 )
Change subject: lenovo/x60: Enable TPM
......................................................................
Patch Set 8:
> Patch Set 8:
>
> I have rebased this, adjusted Kconfig to address comment by Philipp, and remove romstage.c as it is no longer needed.
> It compiles and boots, but does not work yet. (I got the very same log as Arthur had commented.)
>
> Would you mind if I upload new revision?
Thanks a lot for working on this. That would be great!
In general anyone should free to pickup any of my unfinished work as what's most important for me is to have the work done regardless on how it's done or who does it.
Denis.
--
To view, visit https://review.coreboot.org/c/coreboot/+/13410
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e65b37507c111af1c0c56822327d5497f58f085
Gerrit-Change-Number: 13410
Gerrit-PatchSet: 8
Gerrit-Owner: Denis Carikli <GNUtoo(a)no-log.org>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Denis 'GNUtoo' Carikli <GNUtoo(a)cyberdimension.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Masanori Ogino <mogino(a)acm.org>
Gerrit-Comment-Date: Sun, 13 Sep 2020 11:20:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Masanori Ogino has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/13410 )
Change subject: lenovo/x60: Enable TPM
......................................................................
Patch Set 8:
I have rebased this, adjusted Kconfig to address comment by Philipp, and remove romstage.c as it is no longer needed.
It compiles and boots, but does not work yet. (I got the very same log as Arthur had commented.)
Would you mind if I upload new revision?
--
To view, visit https://review.coreboot.org/c/coreboot/+/13410
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e65b37507c111af1c0c56822327d5497f58f085
Gerrit-Change-Number: 13410
Gerrit-PatchSet: 8
Gerrit-Owner: Denis Carikli <GNUtoo(a)no-log.org>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Denis 'GNUtoo' Carikli <GNUtoo(a)cyberdimension.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Masanori Ogino <mogino(a)acm.org>
Gerrit-Comment-Date: Sun, 13 Sep 2020 09:42:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Masanori Ogino has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45319 )
Change subject: .gitmodules: Clean up names and paths.
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/45319
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I56b457e6d7fa9e51ee5066136df44083487504d1
Gerrit-Change-Number: 45319
Gerrit-PatchSet: 1
Gerrit-Owner: Masanori Ogino <mogino(a)acm.org>
Gerrit-Comment-Date: Sun, 13 Sep 2020 04:50:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45310 )
Change subject: soc/amd/picasso/uart: make AOAC device ID in uart_enable unsigned
......................................................................
soc/amd/picasso/uart: make AOAC device ID in uart_enable unsigned
This change is separate from CB:45308 to only have the directly UART-
related changes in this patch train.
BRANCH=zork
Change-Id: Ie587fdbd1e6229c1374fce3568c6a361577dc6c4
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
---
M src/soc/amd/picasso/uart.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/45310/1
diff --git a/src/soc/amd/picasso/uart.c b/src/soc/amd/picasso/uart.c
index 881bc3e..2ef1979 100644
--- a/src/soc/amd/picasso/uart.c
+++ b/src/soc/amd/picasso/uart.c
@@ -97,7 +97,7 @@
/* Even though this is called enable, it gets called for both enabled and disabled devices. */
static void uart_enable(struct device *dev)
{
- int dev_id;
+ unsigned int dev_id;
switch (dev->path.mmio.addr) {
case APU_UART0_BASE:
--
To view, visit https://review.coreboot.org/c/coreboot/+/45310
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie587fdbd1e6229c1374fce3568c6a361577dc6c4
Gerrit-Change-Number: 45310
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newchange
Hello Felix Singer, build bot (Jenkins), Nico Huber, Patrick Georgi, Paul Menzel, Subrata Banik, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45210
to look at the new patch set (#10).
Change subject: soc/intel/cannonlake: rename "RSVD" GPIOs to their correct names
......................................................................
soc/intel/cannonlake: rename "RSVD" GPIOs to their correct names
The names of the GPIO_RSVD_* are documented in the PCH EDS, in Linux
(linux/drivers/pinctrl/intel/pinctrl-cannonlake.c) and other places.
Also, see soc/intel/tigerlake for reference.
Change-Id: I59df09c8fd464e75f918455aa1972765abc51459
Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de>
---
M src/soc/intel/cannonlake/acpi/gpio.asl
M src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl
M src/soc/intel/cannonlake/gpio.c
M src/soc/intel/cannonlake/gpio_cnp_h.c
M src/soc/intel/cannonlake/include/soc/gpio_soc_defs.h
M src/soc/intel/cannonlake/include/soc/gpio_soc_defs_cnp_h.h
6 files changed, 130 insertions(+), 130 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/45210/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/45210
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I59df09c8fd464e75f918455aa1972765abc51459
Gerrit-Change-Number: 45210
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset