Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45132 )
Change subject: mb/system76/lemp9: move HDA options into devicetree
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/45132
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id4fc12896f89739d0ee2a47a42173693921da14e
Gerrit-Change-Number: 45132
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 17 Sep 2020 19:18:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45484 )
Change subject: soc/intel/tigerlake: Unselect Enhanced NEM V2
......................................................................
soc/intel/tigerlake: Unselect Enhanced NEM V2
Enhanced NEM mode is only supported in certain versions of microcode,
therefore leave it up to each mainboard to choose whether or not to
enable this feature.
BUG=b:145958015
Change-Id: I66c69074260de723fa971ba0119225cc03abe1e9
Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
---
M src/soc/intel/tigerlake/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/45484/1
diff --git a/src/soc/intel/tigerlake/Kconfig b/src/soc/intel/tigerlake/Kconfig
index d92d496..a722144 100644
--- a/src/soc/intel/tigerlake/Kconfig
+++ b/src/soc/intel/tigerlake/Kconfig
@@ -25,7 +25,7 @@
select INTEL_DESCRIPTOR_MODE_CAPABLE
select HAVE_SMI_HANDLER
select IDT_IN_EVERY_STAGE
- select USE_CAR_NEM_ENHANCED_V2
+ select INTEL_CAR_NEM
select INTEL_GMA_ACPI
select INTEL_GMA_ADD_VBT if RUN_FSP_GOP
select IOAPIC
--
To view, visit https://review.coreboot.org/c/coreboot/+/45484
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I66c69074260de723fa971ba0119225cc03abe1e9
Gerrit-Change-Number: 45484
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: newchange
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45172 )
Change subject: drivers/intel/mipi_camera: Add support for dynamic SSDT generation
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45172/8/src/drivers/intel/mipi_cam…
File src/drivers/intel/mipi_camera/camera_sku.c:
https://review.coreboot.org/c/coreboot/+/45172/8/src/drivers/intel/mipi_cam…
PS8, Line 36: /* By default device will be set to enabled in alloc_dev. So calling dev_set_enabled
: is not making call to chip_ops->enable_dev as device is already enabled */
: dev_set_enabled(sensor, 0);
: dev_set_enabled(sensor, 1);
: }
This is a little confusing. You say that it's already enabled, and then you disable and re-enable it without explaining why you have to do that. Maybe reword the comment to explain why you have to disable it first, something like this?
"Disable and re-enable the device so that chip_ops->enable_dev will always get called."
--
To view, visit https://review.coreboot.org/c/coreboot/+/45172
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6a5aa6c313c026871e55bc6d067b44de4c1f1afe
Gerrit-Change-Number: 45172
Gerrit-PatchSet: 8
Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Reviewer: Andy Yeh <andy.yeh(a)intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-Reviewer: Chiasheng Lee <chiasheng.lee(a)intel.com>
Gerrit-Reviewer: Jett Rink <jettrink(a)google.com>
Gerrit-Reviewer: Justin TerAvest <teravest(a)google.com>
Gerrit-Reviewer: Marco Chen <marcochen(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: ShawnX Tu <shawnx.tu(a)intel.com>
Gerrit-Reviewer: Tomasz Figa <tfiga(a)google.com>
Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-CC: Henry Sun <henrysun(a)google.com>
Gerrit-CC: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Thu, 17 Sep 2020 17:52:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment