Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39995
to look at the new patch set (#23).
Change subject: mb/siemens/chili: Add Chili variant
......................................................................
mb/siemens/chili: Add Chili variant
This Chili mainboard is used in an all-in-one PC.
For more information see
https://www.secunet.com/fileadmin/user_upload/_temp_/importexport/Print/Fac…
Change-Id: Ic7a5dccbb0d5b7bceb154fb050cf991254475f7b
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
Signed-off-by: Felix Singer <felix.singer(a)secunet.com>
---
M src/mainboard/siemens/chili/Kconfig
M src/mainboard/siemens/chili/Kconfig.name
M src/mainboard/siemens/chili/mainboard.c
M src/mainboard/siemens/chili/romstage.c
M src/mainboard/siemens/chili/variant.h
A src/mainboard/siemens/chili/variants/chili/Makefile.inc
A src/mainboard/siemens/chili/variants/chili/board_info.txt
A src/mainboard/siemens/chili/variants/chili/data.vbt
A src/mainboard/siemens/chili/variants/chili/devicetree.cb
A src/mainboard/siemens/chili/variants/chili/gma-mainboard.ads
A src/mainboard/siemens/chili/variants/chili/gpio.c
A src/mainboard/siemens/chili/variants/chili/hda_verb.c
A src/mainboard/siemens/chili/variants/chili/romstage.c
13 files changed, 481 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/39995/23
--
To view, visit https://review.coreboot.org/c/coreboot/+/39995
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic7a5dccbb0d5b7bceb154fb050cf991254475f7b
Gerrit-Change-Number: 39995
Gerrit-PatchSet: 23
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
Jeremy Compostella has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45628 )
Change subject: libpayload: use PRIu64 type to print u64
......................................................................
libpayload: use PRIu64 type to print u64
The appropriate way to print a u64 variable regardless of the current
architecture is to use the PRI*64 macros. libpayload is mostly used
in 32 bits but when ported to other projects and compiled in 64 bits
it breaks the compilation.
Change-Id: I479fd701f992701584d77d43c5cd5910f5ab7633
Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com>
---
M payloads/libpayload/libc/time.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/45628/1
diff --git a/payloads/libpayload/libc/time.c b/payloads/libpayload/libc/time.c
index c0a3313..0a4cb06 100644
--- a/payloads/libpayload/libc/time.c
+++ b/payloads/libpayload/libc/time.c
@@ -173,7 +173,7 @@
if (hz == 0) {
hz = timer_hz();
if (hz < 1000000) {
- printf("Timer frequency %lld is too low, "
+ printf("Timer frequency %" PRIu64 " is too low, "
"must be at least 1MHz.\n", hz);
halt();
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/45628
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I479fd701f992701584d77d43c5cd5910f5ab7633
Gerrit-Change-Number: 45628
Gerrit-PatchSet: 1
Gerrit-Owner: Jeremy Compostella <jeremy.compostella(a)gmail.com>
Gerrit-MessageType: newchange
Pratikkumar V Prajapati has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45486 )
Change subject: soc/intel/tigerlake: Set TME USD based on config
......................................................................
soc/intel/tigerlake: Set TME USD based on config
Set TmeEnable FSP-M upd based on config.
Test: TME ENABLE and LOCK bits get set when Tme is enabled.
Signed-off-by: Pratik Prajapati <pratikkumar.v.prajapati(a)intel.com>
Change-Id: Ia804c88057e17844f055fd852fc0b36cfe316432
---
M src/soc/intel/tigerlake/romstage/fsp_params.c
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/45486/1
diff --git a/src/soc/intel/tigerlake/romstage/fsp_params.c b/src/soc/intel/tigerlake/romstage/fsp_params.c
index 2ba276d..70e322c 100644
--- a/src/soc/intel/tigerlake/romstage/fsp_params.c
+++ b/src/soc/intel/tigerlake/romstage/fsp_params.c
@@ -208,6 +208,9 @@
/* Skip CPU side PCIe enablement in FSP if device is disabled in devicetree */
dev = pcidev_path_on_root(SA_DEVFN_CPU_PCIE);
m_cfg->CpuPcieRpEnableMask = dev && dev->enabled;
+
+ /* Change TmeEnable UPD value according to ENABLE_TME Kconfig */
+ m_cfg->TmeEnable = CONFIG(INTEL_TME);
}
void platform_fsp_memory_init_params_cb(FSPM_UPD *mupd, uint32_t version)
--
To view, visit https://review.coreboot.org/c/coreboot/+/45486
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia804c88057e17844f055fd852fc0b36cfe316432
Gerrit-Change-Number: 45486
Gerrit-PatchSet: 1
Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newchange