coreboot-gerrit August 2020

coreboot-gerrit@coreboot.org

1 participants
2456 discussions

Change in coreboot[master]: mb/google/octopus/variants/casta: Disable xHCI compliance mode
by shkim (Code Review) 14 Aug '20

14 Aug '20

Hello SH Kim, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/44438 to review the following change. Change subject: mb/google/octopus/variants/casta: Disable xHCI compliance mode ...................................................................... mb/google/octopus/variants/casta: Disable xHCI compliance mode Disable xHCI compliance mode to prevent SS hub detection issue. BRANCH=firmware-octopus-11297.B BUG=none TEST=built Change-Id: I7a9bbc92565e752a8f8f4689519c100594596701 Signed-off-by: Seunghwan Kim <sh_.kim(a)samsung.corp-partner.google.com> --- M src/mainboard/google/octopus/variants/casta/overridetree.cb 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/44438/1 diff --git a/src/mainboard/google/octopus/variants/casta/overridetree.cb b/src/mainboard/google/octopus/variants/casta/overridetree.cb index 2f2f80b..3f2a884 100644 --- a/src/mainboard/google/octopus/variants/casta/overridetree.cb +++ b/src/mainboard/google/octopus/variants/casta/overridetree.cb @@ -139,4 +139,7 @@ end end # - I2C 6 end + + # Disable compliance mode + register "DisableComplianceMode" = "1" end -- To view, visit https://review.coreboot.org/c/coreboot/+/44438 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a9bbc92565e752a8f8f4689519c100594596701 Gerrit-Change-Number: 44438 Gerrit-PatchSet: 1 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-MessageType: newchange

3 3

Change in coreboot[master]: mb/google/octopus: Set default value of ModPhyIfValue parameter
by shkim (Code Review) 14 Aug '20

14 Aug '20

Hello SH Kim, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/44436 to review the following change. Change subject: mb/google/octopus: Set default value of ModPhyIfValue parameter ...................................................................... mb/google/octopus: Set default value of ModPhyIfValue parameter Set default value of ModPhyIfValue parameter in FSPS_UPD. Without this setting, it will be set to '0' and system may not detect USB 3.0 device. BUG=b:163382089 BRANCH=firmware-octopus-11297.B TEST=Built Change-Id: Ide3d1637f99dba28251102f771b6ce370cc5d8e4 Signed-off-by: Seunghwan Kim <sh_.kim(a)samsung.corp-partner.google.com> --- M src/mainboard/google/octopus/variants/baseboard/devicetree.cb 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/44436/1 diff --git a/src/mainboard/google/octopus/variants/baseboard/devicetree.cb b/src/mainboard/google/octopus/variants/baseboard/devicetree.cb index 80e4873..ea5325a 100644 --- a/src/mainboard/google/octopus/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/octopus/variants/baseboard/devicetree.cb @@ -285,4 +285,8 @@ # PWROKDELAY[2:0]: 000=2.5ms, 001=5.0ms, 010=10ms, 011=15ms, 100=20ms, # 101=50ms, 110=75ms, 111=100ms (default) register "PmicPmcIpcCtrl" = "0x5e4302f8" + + # FSP UPD to modify the Integrated Filter (IF) value + # 0x12(Default) for Windows, 0x16 for Chrome + register "ModPhyIfValue" = "0x16" end -- To view, visit https://review.coreboot.org/c/coreboot/+/44436 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide3d1637f99dba28251102f771b6ce370cc5d8e4 Gerrit-Change-Number: 44436 Gerrit-PatchSet: 1 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-MessageType: newchange

4 4

Change in coreboot[master]: vendercode/intel/fsp/fsp2_0/glk: Update FSP header file per v2.2.0
by shkim (Code Review) 14 Aug '20

14 Aug '20

Hello SH Kim, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/44435 to review the following change. Change subject: vendercode/intel/fsp/fsp2_0/glk: Update FSP header file per v2.2.0 ...................................................................... vendercode/intel/fsp/fsp2_0/glk: Update FSP header file per v2.2.0 Update FSP header file to match GLK FSP v2.2.0 BUG=none BRANCH=none TEST=none Change-Id: I515b4c44439e3404d3b06d587f0846457000fdb4 Signed-off-by: Seunghwan Kim <sh_.kim(a)samsung.corp-partner.google.com> --- M src/vendorcode/intel/fsp/fsp2_0/glk/FspsUpd.h 1 file changed, 15 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/44435/1 diff --git a/src/vendorcode/intel/fsp/fsp2_0/glk/FspsUpd.h b/src/vendorcode/intel/fsp/fsp2_0/glk/FspsUpd.h index 97a40b6..0d3902d 100644 --- a/src/vendorcode/intel/fsp/fsp2_0/glk/FspsUpd.h +++ b/src/vendorcode/intel/fsp/fsp2_0/glk/FspsUpd.h @@ -1715,33 +1715,33 @@ **/ UINT8 SkipSpiPCP; -/** Offset 0x03AB - PMIC PCH_PWROK delay configuration - IPC Configuration - Upd for changing PCH_PWROK delay configuration : I2C_Slave_Address (31:24) + Register_Offset - (23:16) + OR Value (15:8) + AND Value (7:0) -**/ - UINT32 PmicPmcIpcCtrl; - -/** Offset 0x03AF - ModPhyIfValue +/** Offset 0x03AB - ModPhyIfValue Upd To modify the Integrated Filter (IF) value as 0x12(Default) for WIN and 0x16 for Chrome **/ UINT8 ModPhyIfValue; -/** Offset 0x03B0 - ModPhyVoltageBump - ModPhyVoltageBump. 1: enable, 0: disable - $EN_DIS +/** Offset 0x03AC - PMIC PCH_PWROK delay configuration - IPC Configuration + Upd for changing PCH_PWROK delay configuration : I2C_Slave_Address (31:24) + Register_Offset + (23:16) + OR Value (15:8) + AND Value (7:0) **/ - UINT8 ModPhyVoltageBump; + UINT32 PmicPmcIpcCtrl; -/** Offset 0x03B1 - Vdd2 Voltage configuration +/** Offset 0x03B0 - Vdd2 Voltage configuration Upd for changing Vdd2 Voltage configuration : I2C_Slave_Address (31:23) + Register_Offset (23:16) + OR Value (15:8) + AND Value (7:0) **/ UINT32 PmicVdd2Voltage; +/** Offset 0x03B4 - ModPhyVoltageBump + ModPhyVoltageBump. 1: enable, 0: disable + $EN_DIS +**/ + UINT8 ModPhyVoltageBump; + /** Offset 0x03B5 **/ - UINT8 ReservedFspsUpd[1]; + UINT8 ReservedFspsUpd[3]; } FSP_S_CONFIG; /** Fsp S SGX Configuration @@ -1810,9 +1810,9 @@ **/ FSP_S_CONFIG FspsConfig; -/** Offset 0x03B6 +/** Offset 0x03B8 **/ - UINT8 UnusedUpdSpace7[10]; + UINT8 UnusedUpdSpace7[8]; /** Offset 0x03C0 **/ -- To view, visit https://review.coreboot.org/c/coreboot/+/44435 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I515b4c44439e3404d3b06d587f0846457000fdb4 Gerrit-Change-Number: 44435 Gerrit-PatchSet: 1 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-MessageType: newchange

5 8

Change in coreboot[master]: soc/intel/jasperlake: Add IGD Device ID
by Subrata Banik (Code Review) 14 Aug '20

14 Aug '20

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44000 ) Change subject: soc/intel/jasperlake: Add IGD Device ID ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/44000 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab3ba286f36afbf9533ac3cc62891fa390ca2441 Gerrit-Change-Number: 44000 Gerrit-PatchSet: 3 Gerrit-Owner: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Comment-Date: Fri, 14 Aug 2020 05:11:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/jasperlake: Add IGD Device ID
by Krishna P Bhat D (Code Review) 14 Aug '20

14 Aug '20

Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44000 ) Change subject: soc/intel/jasperlake: Add IGD Device ID ...................................................................... Patch Set 3: (6 comments) https://review.coreboot.org/c/coreboot/+/44000/2//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/44000/2//COMMIT_MSG@7 PS2, Line 7: new > don't need this word here, its enough to say Add IGD device id Done https://review.coreboot.org/c/coreboot/+/44000/2//COMMIT_MSG@9 PS2, Line 9: new > same Done https://review.coreboot.org/c/coreboot/+/44000/2//COMMIT_MSG@9 PS2, Line 9: jasperlake > Jasperlake Done https://review.coreboot.org/c/coreboot/+/44000/2//COMMIT_MSG@10 PS2, Line 10: Reference is taken from jasperlake EDS volume 1 chapter 13.3 > possible to give doc number is enough than chapter Done https://review.coreboot.org/c/coreboot/+/44000/2//COMMIT_MSG@12 PS2, Line 12: BRANCH=None : BUG=None > don't need Done https://review.coreboot.org/c/coreboot/+/44000/2//COMMIT_MSG@14 PS2, Line 14: jasperlake > Jasperlake Done -- To view, visit https://review.coreboot.org/c/coreboot/+/44000 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab3ba286f36afbf9533ac3cc62891fa390ca2441 Gerrit-Change-Number: 44000 Gerrit-PatchSet: 3 Gerrit-Owner: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Comment-Date: Fri, 14 Aug 2020 05:11:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/jasperlake: Add IGD Device ID
by Krishna P Bhat D (Code Review) 14 Aug '20

14 Aug '20

Hello V Sowmya, Varshit B Pandya, Maulik V Vaghela, Subrata Banik, Aamir Bohra, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/44000 to look at the new patch set (#3). Change subject: soc/intel/jasperlake: Add IGD Device ID ...................................................................... soc/intel/jasperlake: Add IGD Device ID Add IGD Device ID for Jasperlake. Reference is taken from Jasperlake EDS volume 1(Document Number: 613601). TEST=Build and boot Jasperlake platform. Change-Id: Iab3ba286f36afbf9533ac3cc62891fa390ca2441 Signed-off-by: Krishna Prasad Bhat <krishna.p.bhat.d(a)intel.com> --- M src/include/device/pci_ids.h M src/soc/intel/common/block/graphics/graphics.c M src/soc/intel/jasperlake/bootblock/report_platform.c 3 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/44000/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/44000 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab3ba286f36afbf9533ac3cc62891fa390ca2441 Gerrit-Change-Number: 44000 Gerrit-PatchSet: 3 Gerrit-Owner: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/jasperlake: Add new IGD Device ID
by Subrata Banik (Code Review) 14 Aug '20

14 Aug '20

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44000 ) Change subject: soc/intel/jasperlake: Add new IGD Device ID ...................................................................... Patch Set 2: (6 comments) https://review.coreboot.org/c/coreboot/+/44000/2//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/44000/2//COMMIT_MSG@7 PS2, Line 7: new don't need this word here, its enough to say Add IGD device id https://review.coreboot.org/c/coreboot/+/44000/2//COMMIT_MSG@9 PS2, Line 9: new same https://review.coreboot.org/c/coreboot/+/44000/2//COMMIT_MSG@9 PS2, Line 9: jasperlake Jasperlake https://review.coreboot.org/c/coreboot/+/44000/2//COMMIT_MSG@10 PS2, Line 10: Reference is taken from jasperlake EDS volume 1 chapter 13.3 possible to give doc number is enough than chapter https://review.coreboot.org/c/coreboot/+/44000/2//COMMIT_MSG@12 PS2, Line 12: BRANCH=None : BUG=None don't need https://review.coreboot.org/c/coreboot/+/44000/2//COMMIT_MSG@14 PS2, Line 14: jasperlake Jasperlake -- To view, visit https://review.coreboot.org/c/coreboot/+/44000 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab3ba286f36afbf9533ac3cc62891fa390ca2441 Gerrit-Change-Number: 44000 Gerrit-PatchSet: 2 Gerrit-Owner: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Comment-Date: Fri, 14 Aug 2020 04:55:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/jasperlake: Add new IGD Device ID
by V Sowmya (Code Review) 14 Aug '20

14 Aug '20

V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44000 ) Change subject: soc/intel/jasperlake: Add new IGD Device ID ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/44000 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab3ba286f36afbf9533ac3cc62891fa390ca2441 Gerrit-Change-Number: 44000 Gerrit-PatchSet: 2 Gerrit-Owner: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Comment-Date: Fri, 14 Aug 2020 04:44:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/system76/lemp9: enable TPM
by Felix Singer (Code Review) 14 Aug '20

14 Aug '20

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43641 ) Change subject: mb/system76/lemp9: enable TPM ...................................................................... Patch Set 14: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/43641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I26d3b396fe1e99368e18fd3a6a9f02e3585b9f6e Gerrit-Change-Number: 43641 Gerrit-PatchSet: 14 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 14 Aug 2020 03:40:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/system76/lemp9: gpio: disable internal SATAXPCIE pull-ups
by Felix Singer (Code Review) 14 Aug '20

14 Aug '20

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43645 ) Change subject: mb/system76/lemp9: gpio: disable internal SATAXPCIE pull-ups ...................................................................... Patch Set 18: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/43645 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6be716620695ac38c44a17abe1c4de97b099b8d7 Gerrit-Change-Number: 43645 Gerrit-PatchSet: 18 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 14 Aug 2020 02:51:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2020