Johnny Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44437 )
Change subject: mb/ocp/deltalake: Select CONSOLE_POST
......................................................................
mb/ocp/deltalake: Select CONSOLE_POST
Tested=On OCP Deltak Lake, BMC SOL can see POST codes
Change-Id: I2c27055475e6dadcd4282cd1bf191a1b83150f02
Signed-off-by: Johnny Lin <johnny_lin(a)wiwynn.com>
---
M src/mainboard/ocp/deltalake/Kconfig
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/44437/1
diff --git a/src/mainboard/ocp/deltalake/Kconfig b/src/mainboard/ocp/deltalake/Kconfig
index 8897b9f..fbdb067 100644
--- a/src/mainboard/ocp/deltalake/Kconfig
+++ b/src/mainboard/ocp/deltalake/Kconfig
@@ -47,4 +47,8 @@
int
default 6
+config CONSOLE_POST
+ bool
+ default y
+
endif # BOARD_OCP_DELTALAKE
--
To view, visit https://review.coreboot.org/c/coreboot/+/44437
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2c27055475e6dadcd4282cd1bf191a1b83150f02
Gerrit-Change-Number: 44437
Gerrit-PatchSet: 1
Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-MessageType: newchange
Hello SH Kim,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/44438
to review the following change.
Change subject: mb/google/octopus/variants/casta: Disable xHCI compliance mode
......................................................................
mb/google/octopus/variants/casta: Disable xHCI compliance mode
Disable xHCI compliance mode to prevent SS hub detection issue.
BRANCH=firmware-octopus-11297.B
BUG=none
TEST=built
Change-Id: I7a9bbc92565e752a8f8f4689519c100594596701
Signed-off-by: Seunghwan Kim <sh_.kim(a)samsung.corp-partner.google.com>
---
M src/mainboard/google/octopus/variants/casta/overridetree.cb
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/44438/1
diff --git a/src/mainboard/google/octopus/variants/casta/overridetree.cb b/src/mainboard/google/octopus/variants/casta/overridetree.cb
index 2f2f80b..3f2a884 100644
--- a/src/mainboard/google/octopus/variants/casta/overridetree.cb
+++ b/src/mainboard/google/octopus/variants/casta/overridetree.cb
@@ -139,4 +139,7 @@
end
end # - I2C 6
end
+
+ # Disable compliance mode
+ register "DisableComplianceMode" = "1"
end
--
To view, visit https://review.coreboot.org/c/coreboot/+/44438
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a9bbc92565e752a8f8f4689519c100594596701
Gerrit-Change-Number: 44438
Gerrit-PatchSet: 1
Gerrit-Owner: shkim <sh_.kim(a)samsung.com>
Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com>
Gerrit-MessageType: newchange
Hello SH Kim,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/44436
to review the following change.
Change subject: mb/google/octopus: Set default value of ModPhyIfValue parameter
......................................................................
mb/google/octopus: Set default value of ModPhyIfValue parameter
Set default value of ModPhyIfValue parameter in FSPS_UPD.
Without this setting, it will be set to '0' and system may not detect
USB 3.0 device.
BUG=b:163382089
BRANCH=firmware-octopus-11297.B
TEST=Built
Change-Id: Ide3d1637f99dba28251102f771b6ce370cc5d8e4
Signed-off-by: Seunghwan Kim <sh_.kim(a)samsung.corp-partner.google.com>
---
M src/mainboard/google/octopus/variants/baseboard/devicetree.cb
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/44436/1
diff --git a/src/mainboard/google/octopus/variants/baseboard/devicetree.cb b/src/mainboard/google/octopus/variants/baseboard/devicetree.cb
index 80e4873..ea5325a 100644
--- a/src/mainboard/google/octopus/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/octopus/variants/baseboard/devicetree.cb
@@ -285,4 +285,8 @@
# PWROKDELAY[2:0]: 000=2.5ms, 001=5.0ms, 010=10ms, 011=15ms, 100=20ms,
# 101=50ms, 110=75ms, 111=100ms (default)
register "PmicPmcIpcCtrl" = "0x5e4302f8"
+
+ # FSP UPD to modify the Integrated Filter (IF) value
+ # 0x12(Default) for Windows, 0x16 for Chrome
+ register "ModPhyIfValue" = "0x16"
end
--
To view, visit https://review.coreboot.org/c/coreboot/+/44436
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ide3d1637f99dba28251102f771b6ce370cc5d8e4
Gerrit-Change-Number: 44436
Gerrit-PatchSet: 1
Gerrit-Owner: shkim <sh_.kim(a)samsung.com>
Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com>
Gerrit-MessageType: newchange
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44000 )
Change subject: soc/intel/jasperlake: Add IGD Device ID
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/44000
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab3ba286f36afbf9533ac3cc62891fa390ca2441
Gerrit-Change-Number: 44000
Gerrit-PatchSet: 3
Gerrit-Owner: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Comment-Date: Fri, 14 Aug 2020 05:11:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Hello V Sowmya, Varshit B Pandya, Maulik V Vaghela, Subrata Banik, Aamir Bohra, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44000
to look at the new patch set (#3).
Change subject: soc/intel/jasperlake: Add IGD Device ID
......................................................................
soc/intel/jasperlake: Add IGD Device ID
Add IGD Device ID for Jasperlake.
Reference is taken from Jasperlake EDS volume 1(Document Number: 613601).
TEST=Build and boot Jasperlake platform.
Change-Id: Iab3ba286f36afbf9533ac3cc62891fa390ca2441
Signed-off-by: Krishna Prasad Bhat <krishna.p.bhat.d(a)intel.com>
---
M src/include/device/pci_ids.h
M src/soc/intel/common/block/graphics/graphics.c
M src/soc/intel/jasperlake/bootblock/report_platform.c
3 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/44000/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/44000
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab3ba286f36afbf9533ac3cc62891fa390ca2441
Gerrit-Change-Number: 44000
Gerrit-PatchSet: 3
Gerrit-Owner: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-MessageType: newpatchset
V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44000 )
Change subject: soc/intel/jasperlake: Add new IGD Device ID
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/44000
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab3ba286f36afbf9533ac3cc62891fa390ca2441
Gerrit-Change-Number: 44000
Gerrit-PatchSet: 2
Gerrit-Owner: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Comment-Date: Fri, 14 Aug 2020 04:44:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43641 )
Change subject: mb/system76/lemp9: enable TPM
......................................................................
Patch Set 14: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/43641
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I26d3b396fe1e99368e18fd3a6a9f02e3585b9f6e
Gerrit-Change-Number: 43641
Gerrit-PatchSet: 14
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 14 Aug 2020 03:40:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment