Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41036 )
Change subject: payloads/external/GRUB2: Makefile: fix check for changed files again
......................................................................
Patch Set 3: Code-Review+2
The third CR+2 for expedited merging is a bit late, but here it is.
--
To view, visit https://review.coreboot.org/c/coreboot/+/41036
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I295c67ab8d7596bf54cc69d088ef1df906f58d5f
Gerrit-Change-Number: 41036
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-Comment-Date: Mon, 04 May 2020 21:25:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40873 )
Change subject: mb/purism/librem_skl: disable serial console by default
......................................................................
mb/purism/librem_skl: disable serial console by default
Librem SKL/KBL boards do not have an exposed serial port interface.
Set board Kconfig so that a default built image with Tianocore payload
is bootable and doesn't hang due to trying to send data over a
non-existant serial port.
Test: build/boot librem 13v4 with board defaults + Tianocore
Signed-off-by: Matt DeVillier <matt.devillier(a)puri.sm>
Change-Id: I4c3f8a3c1726f804957b06b437b399291854a3f5
---
M src/mainboard/purism/librem_skl/Kconfig
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/40873/1
diff --git a/src/mainboard/purism/librem_skl/Kconfig b/src/mainboard/purism/librem_skl/Kconfig
index ca1582a..4f51d9e 100644
--- a/src/mainboard/purism/librem_skl/Kconfig
+++ b/src/mainboard/purism/librem_skl/Kconfig
@@ -73,4 +73,8 @@
config NO_POST
default y
+config CONSOLE_SERIAL
+ bool
+ default n
+
endif
--
To view, visit https://review.coreboot.org/c/coreboot/+/40873
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4c3f8a3c1726f804957b06b437b399291854a3f5
Gerrit-Change-Number: 40873
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: newchange
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41036 )
Change subject: payloads/external/GRUB2: Makefile: fix check for changed files again
......................................................................
Patch Set 3:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4
Emulation targets:
"QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/3195
"QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3194
"QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3193
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/3192
Please note: This test is under development and might not be accurate at all!
--
To view, visit https://review.coreboot.org/c/coreboot/+/41036
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I295c67ab8d7596bf54cc69d088ef1df906f58d5f
Gerrit-Change-Number: 41036
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-Comment-Date: Mon, 04 May 2020 21:00:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40912 )
Change subject: mb/purism/librem_skl: rename variant directories
......................................................................
mb/purism/librem_skl: rename variant directories
Since the same variant dirs are used by multiple versions of the
same board, drop the v2/v3 labels
Signed-off-by: Matt DeVillier <matt.devillier(a)puri.sm>
Change-Id: Id913e31ab52043e49769be9d3ebf6e71ecb0c856
---
M src/mainboard/purism/librem_skl/Kconfig
R src/mainboard/purism/librem_skl/variants/librem13/board_info.txt
R src/mainboard/purism/librem_skl/variants/librem13/overridetree.cb
R src/mainboard/purism/librem_skl/variants/librem15/board_info.txt
R src/mainboard/purism/librem_skl/variants/librem15/overridetree.cb
5 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/40912/1
diff --git a/src/mainboard/purism/librem_skl/Kconfig b/src/mainboard/purism/librem_skl/Kconfig
index be4c391..08fa4c7 100644
--- a/src/mainboard/purism/librem_skl/Kconfig
+++ b/src/mainboard/purism/librem_skl/Kconfig
@@ -20,8 +20,8 @@
config VARIANT_DIR
string
- default "librem13v2" if BOARD_PURISM_LIBREM13_V2 || BOARD_PURISM_LIBREM13_V4
- default "librem15v3" if BOARD_PURISM_LIBREM15_V3 || BOARD_PURISM_LIBREM15_V4
+ default "librem13" if BOARD_PURISM_LIBREM13_V2 || BOARD_PURISM_LIBREM13_V4
+ default "librem15" if BOARD_PURISM_LIBREM15_V3 || BOARD_PURISM_LIBREM15_V4
config MAINBOARD_FAMILY
string
diff --git a/src/mainboard/purism/librem_skl/variants/librem13v2/board_info.txt b/src/mainboard/purism/librem_skl/variants/librem13/board_info.txt
similarity index 100%
rename from src/mainboard/purism/librem_skl/variants/librem13v2/board_info.txt
rename to src/mainboard/purism/librem_skl/variants/librem13/board_info.txt
diff --git a/src/mainboard/purism/librem_skl/variants/librem13v2/overridetree.cb b/src/mainboard/purism/librem_skl/variants/librem13/overridetree.cb
similarity index 100%
rename from src/mainboard/purism/librem_skl/variants/librem13v2/overridetree.cb
rename to src/mainboard/purism/librem_skl/variants/librem13/overridetree.cb
diff --git a/src/mainboard/purism/librem_skl/variants/librem15v3/board_info.txt b/src/mainboard/purism/librem_skl/variants/librem15/board_info.txt
similarity index 100%
rename from src/mainboard/purism/librem_skl/variants/librem15v3/board_info.txt
rename to src/mainboard/purism/librem_skl/variants/librem15/board_info.txt
diff --git a/src/mainboard/purism/librem_skl/variants/librem15v3/overridetree.cb b/src/mainboard/purism/librem_skl/variants/librem15/overridetree.cb
similarity index 100%
rename from src/mainboard/purism/librem_skl/variants/librem15v3/overridetree.cb
rename to src/mainboard/purism/librem_skl/variants/librem15/overridetree.cb
--
To view, visit https://review.coreboot.org/c/coreboot/+/40912
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id913e31ab52043e49769be9d3ebf6e71ecb0c856
Gerrit-Change-Number: 40912
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: newchange
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41036 )
Change subject: payloads/external/GRUB2: Makefile: fix check for changed files again
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/41036
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I295c67ab8d7596bf54cc69d088ef1df906f58d5f
Gerrit-Change-Number: 41036
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 04 May 2020 20:45:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41036 )
Change subject: payloads/external/GRUB2: Makefile: fix check for changed files again
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41036/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/41036/1//COMMIT_MSG@9
PS1, Line 9: cb
> Mind making this 'cb' uppercase please? You can edit the commit msg from the gerrit UI
Done
https://review.coreboot.org/c/coreboot/+/41036/1//COMMIT_MSG@9
PS1, Line 9: closig
> closing
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/41036
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I295c67ab8d7596bf54cc69d088ef1df906f58d5f
Gerrit-Change-Number: 41036
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Mon, 04 May 2020 20:36:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Hello build bot (Jenkins), Paul Menzel, Angel Pons, Werner Zeh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41036
to look at the new patch set (#2).
Change subject: payloads/external/GRUB2: Makefile: fix check for changed files again
......................................................................
payloads/external/GRUB2: Makefile: fix check for changed files again
This fixes the missing closing brace introduced in CB:40953.
Change-Id: I295c67ab8d7596bf54cc69d088ef1df906f58d5f
Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de>
---
M payloads/external/GRUB2/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/41036/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/41036
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I295c67ab8d7596bf54cc69d088ef1df906f58d5f
Gerrit-Change-Number: 41036
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: newpatchset