Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41028 )
Change subject: soc/intel/jasperlake: Correct the EMMC PCR Port ID
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/41028
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17d4e7b7e0fe5e0b18867b6481b5bc9227ae19e3
Gerrit-Change-Number: 41028
Gerrit-PatchSet: 4
Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Tue, 05 May 2020 03:53:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Shaunak Saha has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41056 )
Change subject: [WIP][DONOTMERGE]: Print GPIO DW's for every community
......................................................................
[WIP][DONOTMERGE]: Print GPIO DW's for every community
Function to print every gpio DW value. The values would
be printed in order of community as defined in soc's gpio.c
community array.
Signed-off-by: Shaunak Saha <shaunak.saha(a)intel.com>
Change-Id: I4c4282ac377c72b396217bc95a992b35821789a5
---
M src/soc/intel/common/block/gpio/gpio.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/41056/1
diff --git a/src/soc/intel/common/block/gpio/gpio.c b/src/soc/intel/common/block/gpio/gpio.c
index 8d345f9..8da6f68 100644
--- a/src/soc/intel/common/block/gpio/gpio.c
+++ b/src/soc/intel/common/block/gpio/gpio.c
@@ -311,9 +311,9 @@
comm = soc_gpio_get_community(&gpio_communities);
- for(i = 0; i < gpio_communities; i++) {
+ for (i = 0; i < gpio_communities; i++) {
group_curr = comm->groups;
- for(j = 0; j < comm->num_groups; j++) {
+ for (j = 0; j < comm->num_groups; j++) {
for (k = 0; k < group_curr->size; k++) {
config_offset = pad_config_offset(comm, (comm_size + k));
printk(BIOS_DEBUG, "gpio_padcfg GPP_%s_%d [0x%02x, %02zd] ", group_curr->grp_name, k, comm->port, relative_pad_in_comm(comm, (comm_size+k)));
--
To view, visit https://review.coreboot.org/c/coreboot/+/41056
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4c4282ac377c72b396217bc95a992b35821789a5
Gerrit-Change-Number: 41056
Gerrit-PatchSet: 1
Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newchange
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40414 )
Change subject: lib/spd_bin: add get_spd_sn function
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40414/4/src/soc/intel/common/block…
File src/soc/intel/common/block/smbus/smbuslib.c:
https://review.coreboot.org/c/coreboot/+/40414/4/src/soc/intel/common/block…
PS4, Line 92: /* smbus will return 0xff if addr is zero */
: if (addr == 0x00) {
: memset(sn, 0, SPD_SN_LEN);
: return;
: }
> If the do_smbus_read_byte() function already handles checking for an invalid address, I don't see a […]
do_smbus_read_byte not check the address 0x00 but will return 0xff.. if we want this, we need change it.
--
To view, visit https://review.coreboot.org/c/coreboot/+/40414
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I406bba7cc56debbd9851d430f069e4fb96ec937c
Gerrit-Change-Number: 40414
Gerrit-PatchSet: 4
Gerrit-Owner: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Tue, 05 May 2020 03:46:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41028 )
Change subject: soc/intel/jasperlake: Correct the EMMC PCR Port ID
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/41028
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17d4e7b7e0fe5e0b18867b6481b5bc9227ae19e3
Gerrit-Change-Number: 41028
Gerrit-PatchSet: 4
Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Tue, 05 May 2020 01:15:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment