Change in coreboot[master]: Signed-off-by: Shaunak Saha <shaunak.saha@intel.com> Change-Id: Ie359...
Shaunak Saha has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41055 )
Change subject: Signed-off-by: Shaunak Saha shaunak.saha@intel.com Change-Id: Ie3591f30dd0256bea537c675e60d3a86a3aa92e4 ......................................................................
Signed-off-by: Shaunak Saha shaunak.saha@intel.com Change-Id: Ie3591f30dd0256bea537c675e60d3a86a3aa92e4 --- M src/soc/intel/common/block/gpio/gpio.c 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/41055/1
diff --git a/src/soc/intel/common/block/gpio/gpio.c b/src/soc/intel/common/block/gpio/gpio.c index c1f1a6c..8d345f9 100644 --- a/src/soc/intel/common/block/gpio/gpio.c +++ b/src/soc/intel/common/block/gpio/gpio.c @@ -311,13 +311,13 @@
comm = soc_gpio_get_community(&gpio_communities);
- for( i = 0; i < gpio_communities; i++ ) { + for(i = 0; i < gpio_communities; i++) { group_curr = comm->groups; - for( j = 0; j < comm->num_groups; j++ ) { - for ( k = 0; k < group_curr->size; k++ ) { + for(j = 0; j < comm->num_groups; j++) { + for (k = 0; k < group_curr->size; k++) { config_offset = pad_config_offset(comm, (comm_size + k)); printk(BIOS_DEBUG, "gpio_padcfg GPP_%s_%d [0x%02x, %02zd] ", group_curr->grp_name, k, comm->port, relative_pad_in_comm(comm, (comm_size+k))); - for ( l = 0; l < GPIO_NUM_PAD_CFG_REGS; l++ ) { + for (l = 0; l < GPIO_NUM_PAD_CFG_REGS; l++) { pad_conf = pcr_read32(comm->port,PAD_CFG_OFFSET(config_offset, l)); printk(BIOS_DEBUG, " DW%d [0x%08x]", l,pad_conf); }
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41055 )
Change subject: Signed-off-by: Shaunak Saha shaunak.saha@intel.com Change-Id: Ie3591f30dd0256bea537c675e60d3a86a3aa92e4 ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41055/1/src/soc/intel/common/block/... File src/soc/intel/common/block/gpio/gpio.c:
https://review.coreboot.org/c/coreboot/+/41055/1/src/soc/intel/common/block/... PS1, Line 314: for(i = 0; i < gpio_communities; i++) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/41055/1/src/soc/intel/common/block/... PS1, Line 316: for(j = 0; j < comm->num_groups; j++) { space required before the open parenthesis '('
Shaunak Saha has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41055 )
Change subject: Signed-off-by: Shaunak Saha shaunak.saha@intel.com Change-Id: Ie3591f30dd0256bea537c675e60d3a86a3aa92e4 ......................................................................
Abandoned
-
build bot (Jenkins) (Code Review) -
Shaunak Saha (Code Review)