Change in coreboot[master]: mb/purism/librem_skl: Clean up Kconfig

[Matt DeVillier (Code Review)]

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40913 )


Change subject: mb/purism/librem_skl: Clean up Kconfig
......................................................................

mb/purism/librem_skl: Clean up Kconfig

Reorder Kconfig selects alphabetically, and select the correct SoC
based on board selection (even though no actual difference currently).

Signed-off-by: Matt DeVillier <[e-mail]>
Change-Id: I46f651a530ef0ed617dd1f3eee077e84279a40f2
---
M src/mainboard/purism/librem_skl/Kconfig
1 file changed, 5 insertions(+), 4 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40913/1

diff --git a/src/mainboard/purism/librem_skl/Kconfig b/src/mainboard/purism/librem_skl/Kconfig
index 08fa4c7..11bb08d 100644
--- a/src/mainboard/purism/librem_skl/Kconfig
+++ b/src/mainboard/purism/librem_skl/Kconfig
@@ -1,16 +1,17 @@
 config BOARD_PURISM_BASEBOARD_LIBREM_SKL
 	def_bool n
-	select SYSTEM_TYPE_LAPTOP
 	select BOARD_ROMSIZE_KB_16384
 	select HAVE_ACPI_RESUME
 	select HAVE_ACPI_TABLES
 	select INTEL_LPSS_UART_FOR_CONSOLE
 	select INTEL_GMA_HAVE_VBT
-	select SOC_INTEL_COMMON_BLOCK_HDA_VERB
-	select SOC_INTEL_SKYLAKE
-	select SPD_READ_BY_WORD
 	select MAINBOARD_HAS_LIBGFXINIT
 	select MAINBOARD_HAS_LPC_TPM
+	select SOC_INTEL_COMMON_BLOCK_HDA_VERB
+	select SOC_INTEL_KABYLAKE if BOARD_PURISM_LIBREM13_V4 || BOARD_PURISM_LIBREM15_V4
+	select SOC_INTEL_SKYLAKE if BOARD_PURISM_LIBREM13_V2 || BOARD_PURISM_LIBREM15_V3
+	select SPD_READ_BY_WORD
+	select SYSTEM_TYPE_LAPTOP
 
 if BOARD_PURISM_BASEBOARD_LIBREM_SKL
 

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40913
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I46f651a530ef0ed617dd1f3eee077e84279a40f2
Gerrit-Change-Number: 40913
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <[e-mail]>
Gerrit-MessageType: newchange

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40913 )

Change subject: mb/purism/librem_skl: Clean up Kconfig
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/40913/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40913/1//COMMIT_MSG@10 
PS1, Line 10: based on board selection (even though no actual difference currently).
Make the part inside parentheses a sentence?

 Reorder Kconfig selects alphabetically, and select the correct SoC
 for each variant (even though it currently makes no difference).



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40913
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I46f651a530ef0ed617dd1f3eee077e84279a40f2
Gerrit-Change-Number: 40913
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Thu, 30 Apr 2020 22:15:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Matt DeVillier (Code Review)]

Hello build bot (Jenkins), Angel Pons, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/40913

to look at the new patch set (#2).

Change subject: mb/purism/librem_skl: Clean up Kconfig
......................................................................

mb/purism/librem_skl: Clean up Kconfig

Reorder Kconfig selects alphabetically, and select the correct SoC
for each variant (even though it currently makes no difference).

Signed-off-by: Matt DeVillier <[e-mail]>
Change-Id: I46f651a530ef0ed617dd1f3eee077e84279a40f2
---
M src/mainboard/purism/librem_skl/Kconfig
1 file changed, 5 insertions(+), 4 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40913/2
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40913
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I46f651a530ef0ed617dd1f3eee077e84279a40f2
Gerrit-Change-Number: 40913
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-MessageType: newpatchset

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40913 )

Change subject: mb/purism/librem_skl: Clean up Kconfig
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40913/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40913/1//COMMIT_MSG@10 
PS1, Line 10: based on board selection (even though no actual difference currently).
> Make the part inside parentheses a sentence? […]
> Done

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40913 )

Change subject: mb/purism/librem_skl: Clean up Kconfig
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40913
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I46f651a530ef0ed617dd1f3eee077e84279a40f2
Gerrit-Change-Number: 40913
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Fri, 01 May 2020 11:41:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40913 )

Change subject: mb/purism/librem_skl: Clean up Kconfig
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40913
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I46f651a530ef0ed617dd1f3eee077e84279a40f2
Gerrit-Change-Number: 40913
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Fri, 01 May 2020 18:16:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40913 )

Change subject: mb/purism/librem_skl: Clean up Kconfig
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40913
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I46f651a530ef0ed617dd1f3eee077e84279a40f2
Gerrit-Change-Number: 40913
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Mon, 04 May 2020 13:47:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40913 )

Change subject: mb/purism/librem_skl: Clean up Kconfig
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40913
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I46f651a530ef0ed617dd1f3eee077e84279a40f2
Gerrit-Change-Number: 40913
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Mon, 04 May 2020 20:26:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40913 )

Change subject: mb/purism/librem_skl: Clean up Kconfig
......................................................................

mb/purism/librem_skl: Clean up Kconfig

Reorder Kconfig selects alphabetically, and select the correct SoC
for each variant (even though it currently makes no difference).

Signed-off-by: Matt DeVillier <[e-mail]>
Change-Id: I46f651a530ef0ed617dd1f3eee077e84279a40f2
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40913
Reviewed-by: Angel Pons <[e-mail]>
Reviewed-by: Nico Huber <[e-mail]>
Reviewed-by: Michael Niewöhner
Reviewed-by: Paul Menzel <[e-mail]>
Tested-by: build bot (Jenkins) <[e-mail]>
---
M src/mainboard/purism/librem_skl/Kconfig
1 file changed, 5 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve
  Angel Pons: Looks good to me, approved
  Michael Niewöhner: Looks good to me, approved



diff --git a/src/mainboard/purism/librem_skl/Kconfig b/src/mainboard/purism/librem_skl/Kconfig
index 08fa4c7..11bb08d 100644
--- a/src/mainboard/purism/librem_skl/Kconfig
+++ b/src/mainboard/purism/librem_skl/Kconfig
@@ -1,16 +1,17 @@
 config BOARD_PURISM_BASEBOARD_LIBREM_SKL
 	def_bool n
-	select SYSTEM_TYPE_LAPTOP
 	select BOARD_ROMSIZE_KB_16384
 	select HAVE_ACPI_RESUME
 	select HAVE_ACPI_TABLES
 	select INTEL_LPSS_UART_FOR_CONSOLE
 	select INTEL_GMA_HAVE_VBT
-	select SOC_INTEL_COMMON_BLOCK_HDA_VERB
-	select SOC_INTEL_SKYLAKE
-	select SPD_READ_BY_WORD
 	select MAINBOARD_HAS_LIBGFXINIT
 	select MAINBOARD_HAS_LPC_TPM
+	select SOC_INTEL_COMMON_BLOCK_HDA_VERB
+	select SOC_INTEL_KABYLAKE if BOARD_PURISM_LIBREM13_V4 || BOARD_PURISM_LIBREM15_V4
+	select SOC_INTEL_SKYLAKE if BOARD_PURISM_LIBREM13_V2 || BOARD_PURISM_LIBREM15_V3
+	select SPD_READ_BY_WORD
+	select SYSTEM_TYPE_LAPTOP
 
 if BOARD_PURISM_BASEBOARD_LIBREM_SKL
 

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40913
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I46f651a530ef0ed617dd1f3eee077e84279a40f2
Gerrit-Change-Number: 40913
Gerrit-PatchSet: 4
Gerrit-Owner: Matt DeVillier <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-MessageType: merged