coreboot-gerrit March 2020

coreboot-gerrit@coreboot.org

1 participants
3326 discussions

Change in coreboot[master]: mainboard/google/puff: Enable cros_ec_keyb device
by Furquan Shaikh (Code Review) 08 Mar '20

08 Mar '20

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39391 ) Change subject: mainboard/google/puff: Enable cros_ec_keyb device ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/39391 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10ba9d55e8997ce2412deb0613cfcaa8f24f271d Gerrit-Change-Number: 39391 Gerrit-PatchSet: 1 Gerrit-Owner: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 09 Mar 2020 03:46:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mainboard/hatch/mainboard.c: Accommodate larger SKU id space
by Kangheui Won (Code Review) 08 Mar '20

08 Mar '20

Kangheui Won has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38844 ) Change subject: mainboard/hatch/mainboard.c: Accommodate larger SKU id space ...................................................................... Abandoned not required anymore -- To view, visit https://review.coreboot.org/c/coreboot/+/38844 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic5a3f47989f596b838739becfb1da1bdaf16dd27 Gerrit-Change-Number: 38844 Gerrit-PatchSet: 2 Gerrit-Owner: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: mainboard/google/puff: Enable cros_ec_keyb device
by Kangheui Won (Code Review) 08 Mar '20

08 Mar '20

Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39391 ) Change subject: mainboard/google/puff: Enable cros_ec_keyb device ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/39391 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10ba9d55e8997ce2412deb0613cfcaa8f24f271d Gerrit-Change-Number: 39391 Gerrit-PatchSet: 1 Gerrit-Owner: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Comment-Date: Mon, 09 Mar 2020 03:26:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/asrock/h110m: add libgfxinit support
by Nico Huber (Code Review) 08 Mar '20

08 Mar '20

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39104 ) Change subject: mb/asrock/h110m: add libgfxinit support ...................................................................... Patch Set 11: (1 comment) https://review.coreboot.org/c/coreboot/+/39104/10//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/39104/10//COMMIT_MSG@7 PS10, Line 7: mb/asrock/h110m: add libgfxinit support > It probably doesn't work because it is wired through a DP-to-VGA converter. […] You can add `DP2, HDMI2, Internal` (the latter will be `eDP` in the future) and test if a VGA display shows up anywhere. -- To view, visit https://review.coreboot.org/c/coreboot/+/39104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4d87413f87d00986111ecb7b046423ff5eac1bf1 Gerrit-Change-Number: 39104 Gerrit-PatchSet: 11 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Sun, 08 Mar 2020 16:48:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Maxim Polyakov <max.senia.poliak(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload/drivers/nvram: Add function to write RTC
by Nico Huber (Code Review) 08 Mar '20

08 Mar '20

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23585 ) Change subject: libpayload/drivers/nvram: Add function to write RTC ...................................................................... Patch Set 3: Code-Review+1 (2 comments) https://review.coreboot.org/c/coreboot/+/23585/3/payloads/libpayload/driver… File payloads/libpayload/drivers/nvram.c: https://review.coreboot.org/c/coreboot/+/23585/3/payloads/libpayload/driver… PS3, Line 185: 0x04 Use the new constant? https://review.coreboot.org/c/coreboot/+/23585/3/payloads/libpayload/driver… PS3, Line 190: 0x02 Ditto -- To view, visit https://review.coreboot.org/c/coreboot/+/23585 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17b4c1ee0dcc649738ac6a7400b087d07213eaf0 Gerrit-Change-Number: 23585 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 08 Mar 2020 15:45:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload: Improve rtc functions
by Nico Huber (Code Review) 08 Mar '20

08 Mar '20

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/18498 ) Change subject: libpayload: Improve rtc functions ...................................................................... Patch Set 5: Code-Review+2 One nit, there was a comment "If one branch has braces all should have them." not sure why I marked it resolved. I also wonder now why checkpatch doesn't complain? -- To view, visit https://review.coreboot.org/c/coreboot/+/18498 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id773c33e228973e190a7e14c3d11979678b1a619 Gerrit-Change-Number: 18498 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Sun, 08 Mar 2020 15:39:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/kconfig: Silence warning about _GNU_SOURCE
by Angel Pons (Code Review) 08 Mar '20

08 Mar '20

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39183 ) Change subject: util/kconfig: Silence warning about _GNU_SOURCE ...................................................................... util/kconfig: Silence warning about _GNU_SOURCE For some reason, this symbol gets redefined, which causes a warning. Hide the warning by checking whether it is already defined. Change-Id: I70ffc9a799e0b536d6aba7d00f828bd6d915d94c Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M util/kconfig/nconf.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/39183/1 diff --git a/util/kconfig/nconf.c b/util/kconfig/nconf.c index 905dcd1..42ea494 100644 --- a/util/kconfig/nconf.c +++ b/util/kconfig/nconf.c @@ -5,7 +5,9 @@ * Derived from menuconfig. * */ +#ifndef _GNU_SOURCE #define _GNU_SOURCE +#endif #include <string.h> #include <stdlib.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/39183 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70ffc9a799e0b536d6aba7d00f828bd6d915d94c Gerrit-Change-Number: 39183 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

3 8

Change in coreboot[master]: soc/intel/common/block/cse: Add boot partition related APIs
by Angel Pons (Code Review) 08 Mar '20

08 Mar '20

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35402 ) Change subject: soc/intel/common/block/cse: Add boot partition related APIs ...................................................................... Patch Set 69: (6 comments) https://review.coreboot.org/c/coreboot/+/35402/69//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/35402/69//COMMIT_MSG@15 PS69, Line 15: |C nit: add a space? https://review.coreboot.org/c/coreboot/+/35402/69/src/soc/intel/common/bloc… File src/soc/intel/common/block/cse/cse_bp.c: https://review.coreboot.org/c/coreboot/+/35402/69/src/soc/intel/common/bloc… PS69, Line 39: __packed Does this need to be packed? https://review.coreboot.org/c/coreboot/+/35402/69/src/soc/intel/common/bloc… PS69, Line 56: __packed And this one? https://review.coreboot.org/c/coreboot/+/35402/69/src/soc/intel/common/bloc… PS69, Line 60: cse_check_prereq_bp_cmd_info I would rename this function so that it looks like a question. For example: cse_is_bp_cmd_info_possible https://review.coreboot.org/c/coreboot/+/35402/69/src/soc/intel/common/bloc… PS69, Line 62: if (cse_is_hfs1_cws_normal() && (cse_is_hfs1_com_normal() || : cse_is_hfs1_com_secover_mei_msg() || cse_is_hfs1_com_soft_temp_disable())) : return true; : return false; How about splitting this out for readability? if (cse_is_hfs1_cws_normal()) { if (cse_is_hfs1_com_normal()) return true; if (cse_is_hfs1_com_secover_mei_msg()) return true; if (cse_is_hfs1_com_soft_temp_disable()) return true; } return false; https://review.coreboot.org/c/coreboot/+/35402/69/src/soc/intel/common/bloc… File src/soc/intel/common/block/include/intelblocks/cse.h: https://review.coreboot.org/c/coreboot/+/35402/69/src/soc/intel/common/bloc… PS69, Line 231: | There's some misalignment around here -- To view, visit https://review.coreboot.org/c/coreboot/+/35402 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaa62409c0616d5913d21374a8a6804f82258eb4f Gerrit-Change-Number: 35402 Gerrit-PatchSet: 69 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Andrey Petrov <anpetrov(a)fb.com> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Sun, 08 Mar 2020 14:39:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/pc80/rtc: Expose get_option() in Ada
by Nico Huber (Code Review) 08 Mar '20

08 Mar '20

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38923 ) Change subject: drivers/pc80/rtc: Expose get_option() in Ada ...................................................................... drivers/pc80/rtc: Expose get_option() in Ada Change-Id: I723b4a2d5ef61c738146f86547d0da1d70840ccb Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M src/drivers/pc80/rtc/Makefile.inc A src/drivers/pc80/rtc/cb-nvram.adb A src/drivers/pc80/rtc/cb-nvram.ads 3 files changed, 56 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/38923/1 diff --git a/src/drivers/pc80/rtc/Makefile.inc b/src/drivers/pc80/rtc/Makefile.inc index 4938d78..bb33ccd 100644 --- a/src/drivers/pc80/rtc/Makefile.inc +++ b/src/drivers/pc80/rtc/Makefile.inc @@ -8,6 +8,9 @@ ramstage-$(CONFIG_DRIVERS_MC146818) += mc146818rtc.c smm-$(CONFIG_DRIVERS_MC146818) += mc146818rtc.c +ramstage-$(CONFIG_DRIVERS_MC146818) += cb-nvram.ads +ramstage-$(CONFIG_DRIVERS_MC146818) += cb-nvram.adb + all-$(CONFIG_USE_OPTION_TABLE) += option.c smm-$(CONFIG_USE_OPTION_TABLE) += option.c diff --git a/src/drivers/pc80/rtc/cb-nvram.adb b/src/drivers/pc80/rtc/cb-nvram.adb new file mode 100644 index 0000000..8549458 --- /dev/null +++ b/src/drivers/pc80/rtc/cb-nvram.adb @@ -0,0 +1,42 @@ +with System; +with Interfaces.C; + +package body CB.NVRAM is + + function c_get_option (dst: System.Address; name: System.Address) return Interfaces.C.int; + pragma import (C, c_get_option, "get_option"); + + procedure get_option (dst: System.Address; name: String) + is + use type Interfaces.C.size_t; + + c_name : Interfaces.C.char_array (0 .. 255); + ignored : Interfaces.C.int; + begin + if Interfaces.C.size_t (name'length) > c_name'last then + return; + end if; + for i in name'range loop + c_name (Interfaces.C.size_t (i - name'first)) := Interfaces.C.To_C (name (i)); + end loop; + c_name (Interfaces.C.size_t (name'length)) := Interfaces.C.nul; + + ignored := c_get_option (dst, c_name (0)'address); + end get_option; + + procedure get_option (val: in out Word8; name: String) is + begin + get_option (val'address, name); + end get_option; + + procedure get_option (val: in out Word16; name: String) is + begin + get_option (val'address, name); + end get_option; + + procedure get_option (val: in out Word32; name: String) is + begin + get_option (val'address, name); + end get_option; + +end CB.NVRAM; diff --git a/src/drivers/pc80/rtc/cb-nvram.ads b/src/drivers/pc80/rtc/cb-nvram.ads new file mode 100644 index 0000000..8d564f3 --- /dev/null +++ b/src/drivers/pc80/rtc/cb-nvram.ads @@ -0,0 +1,11 @@ +with HW; + +use HW; + +package CB.NVRAM is + + procedure get_option (val: in out Word8; name: String); + procedure get_option (val: in out Word16; name: String); + procedure get_option (val: in out Word32; name: String); + +end CB.NVRAM; -- To view, visit https://review.coreboot.org/c/coreboot/+/38923 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I723b4a2d5ef61c738146f86547d0da1d70840ccb Gerrit-Change-Number: 38923 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

2 2

Change in libgfxinit[master]: gma config: Add Comet Lake PCI IDs
by Nico Huber (Code Review) 08 Mar '20

08 Mar '20

Hello Angel Pons, Arthur Heymans, Matt DeVillier, I'd like you to do a code review. Please visit https://review.coreboot.org/c/libgfxinit/+/36443 to review the following change. Change subject: gma config: Add Comet Lake PCI IDs ...................................................................... gma config: Add Comet Lake PCI IDs Comet Lake is still treated like Kaby Lake :) Change-Id: I543f1a50c204d963de80111aa0afd724e4093c4a Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/hw-gfx-gma-config.ads.template 1 file changed, 15 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/43/36443/1 diff --git a/common/hw-gfx-gma-config.ads.template b/common/hw-gfx-gma-config.ads.template index 0e49943..7347341 100644 --- a/common/hw-gfx-gma-config.ads.template +++ b/common/hw-gfx-gma-config.ads.template @@ -428,6 +428,17 @@ function Is_Coffee_Lake (Device_Id : Word16) return Boolean is ((Device_Id and 16#fff0#) = 16#3e90#); + function Is_Comet_Lake_U (Device_Id : Word16) return Boolean is + ((Device_Id and 16#ff9f#) = 16#9b01# or + (Device_Id and 16#ff9f#) = 16#9b8a# or + (Device_Id and 16#ff9f#) = 16#9b8c#); + function Is_Comet_Lake (Device_Id : Word16) return Boolean is + ((Device_Id and 16#ff8f#) = 16#9b82# or + (Device_Id and 16#ff8f#) = 16#9b84# or + (Device_Id and 16#ff8f#) = 16#9b85# or + (Device_Id and 16#ff8f#) = 16#9b86# or + (Device_Id and 16#ff8f#) = 16#9b88#); + function Is_GPU (Device_Id : Word16; CPU : CPU_Type; CPU_Var : CPU_Variant) return Boolean is (case CPU is @@ -452,10 +463,12 @@ when Kabylake => (case CPU_Var is when Normal => Is_Kaby_Lake (Device_Id) or - Is_Coffee_Lake (Device_Id), + Is_Coffee_Lake (Device_Id) or + Is_Comet_Lake (Device_Id), when ULT => Is_Kaby_Lake_U (Device_Id) or - Is_Coffee_Lake_U (Device_Id), + Is_Coffee_Lake_U (Device_Id) or + Is_Comet_Lake_U (Device_Id), when ULX => Is_Kaby_Lake_Y (Device_Id) or Is_Kaby_Lake_Y_AML (Device_Id) or -- To view, visit https://review.coreboot.org/c/libgfxinit/+/36443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I543f1a50c204d963de80111aa0afd724e4093c4a Gerrit-Change-Number: 36443 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newchange

2 4

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2020