coreboot-gerrit March 2020

coreboot-gerrit@coreboot.org

1 participants
3326 discussions

Change in coreboot[master]: xcompile: check for prebuilt toolchain support
by Dhyey Patel (Code Review) 09 Mar '20

09 Mar '20

Dhyey Patel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39407 ) Change subject: xcompile: check for prebuilt toolchain support ...................................................................... xcompile: check for prebuilt toolchain support *) Currently xcompile only looks for the toolchain present in coreboot source folder. Add support to check if the prebuilt toolchain binary is installed in the OS. *) Note: Current patch will only respect prebuilt toolchain present in linux distros. Need to add more robust solution for Windows and Macintosh. Change-Id: I76000ebaf79e2c3c3329923aff132ac9a6bd5bd3 Signed-off-by: Griffin98 <griffin98(a)protonmail.com> --- M util/xcompile/xcompile 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/39407/1 diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index 59908c5..a2f3ee9 100755 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -39,6 +39,12 @@ XGCCPATH=${XGCCPATH:-"$(pwd)/../../util/crossgcc/xgcc/bin/"} fi +# Look for installed toolchain +if [ -d "/usr/share/crossgcc/bin/" ] +then + XGCCPATH=${XGCCPATH:-"/usr/share/crossgcc/bin/"} +fi + # coreboot crossgcc path if [ -d "$(pwd)/util/crossgcc/xgcc/bin/" ] then -- To view, visit https://review.coreboot.org/c/coreboot/+/39407 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I76000ebaf79e2c3c3329923aff132ac9a6bd5bd3 Gerrit-Change-Number: 39407 Gerrit-PatchSet: 1 Gerrit-Owner: Dhyey Patel Gerrit-MessageType: newchange

1 0

Change in SerialTest[master]: Add rough approximation of SerialTest scaffold
by Patrick Georgi (Code Review) 09 Mar '20

09 Mar '20

Hello Martin Roth, Angel Pons, Dossym Nurmukhanov, ron minnich, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/SerialTest/+/39083 to look at the new patch set (#7). Change subject: Add rough approximation of SerialTest scaffold ...................................................................... Add rough approximation of SerialTest scaffold Includes: - Accessing serial ports through servod - Sending lines of output through regular expressions - Creation of messages when regexps match - A set of demo events that track stage progression through bootblock, verstage, romstage, ramstage and depthcharge, and code to print some data when these events occur. Lacks: - Everything else Change-Id: Iab8d507dee6087bf32280ad6845fdd2d7715bf5c Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- A .gitignore A Makefile A drivers/drivers.go A drivers/servo/servo.go A eve.toml A events/events.go A serialtest.go 7 files changed, 398 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/SerialTest refs/changes/83/39083/7 -- To view, visit https://review.coreboot.org/c/SerialTest/+/39083 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: SerialTest Gerrit-Branch: master Gerrit-Change-Id: Iab8d507dee6087bf32280ad6845fdd2d7715bf5c Gerrit-Change-Number: 39083 Gerrit-PatchSet: 7 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Dossym Nurmukhanov <dossym(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Greg Edelston <gredelston(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in SerialTest[master]: Add rough approximation of SerialTest scaffold
by Patrick Georgi (Code Review) 09 Mar '20

09 Mar '20

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/SerialTest/+/39083 ) Change subject: Add rough approximation of SerialTest scaffold ...................................................................... Patch Set 5: (5 comments) https://review.coreboot.org/c/SerialTest/+/39083/5/drivers/servo/servo.go File drivers/servo/servo.go: https://review.coreboot.org/c/SerialTest/+/39083/5/drivers/servo/servo.go@16 PS5, Line 16: // This package is a singleton, so global variables are no problem. > could we ever want to have the ability to run more than one server from one program? it seems you ar […] It's supposed to be a program that runs a bunch of tests and returns a log. We have enough persistent processes in testlab scheduling, we don't need another one. https://review.coreboot.org/c/SerialTest/+/39083/5/drivers/servo/servo.go@29 PS5, Line 29: /* > I'd consider making a servo driver which embeds the other Drivers. […] In the end we still need some abstraction for individual device handlers because not everything using this framework will be using a servo. Servo is just the first implementation. https://review.coreboot.org/c/SerialTest/+/39083/5/drivers/servo/servo.go@64 PS5, Line 64: func ConsoleDriver() *drivers.ConsoleDriver { > I would consider separating out the creation from the IO. […] For a persistent process, sure. But what good is a non-started driver in a one-shot process? Ideally it wouldn't be instantiated in the first place. https://review.coreboot.org/c/SerialTest/+/39083/5/eve.toml File eve.toml: https://review.coreboot.org/c/SerialTest/+/39083/5/eve.toml@2 PS5, Line 2: ConsoleDriverName = "servo" > same thing here: you're in a package called driver(s), and the repetition is frowned upon. […] Done https://review.coreboot.org/c/SerialTest/+/39083/5/serialtest.go File serialtest.go: https://review.coreboot.org/c/SerialTest/+/39083/5/serialtest.go@34 PS5, Line 34: ConsoleDriverName string > I still feel like the Driver word should not be here: […] I changed the naming, but still puzzling over the "concrete types became Drivers" part. -- To view, visit https://review.coreboot.org/c/SerialTest/+/39083 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: SerialTest Gerrit-Branch: master Gerrit-Change-Id: Iab8d507dee6087bf32280ad6845fdd2d7715bf5c Gerrit-Change-Number: 39083 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Dossym Nurmukhanov <dossym(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Greg Edelston <gredelston(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 09 Mar 2020 16:38:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in SerialTest[master]: Add rough approximation of SerialTest scaffold
by Patrick Georgi (Code Review) 09 Mar '20

09 Mar '20

Hello Martin Roth, Angel Pons, Dossym Nurmukhanov, ron minnich, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/SerialTest/+/39083 to look at the new patch set (#6). Change subject: Add rough approximation of SerialTest scaffold ...................................................................... Add rough approximation of SerialTest scaffold Includes: - Accessing serial ports through servod - Sending lines of output through regular expressions - Creation of messages when regexps match - A set of demo events that track stage progression through bootblock, verstage, romstage, ramstage and depthcharge, and code to print some data when these events occur. Lacks: - Everything else Change-Id: Iab8d507dee6087bf32280ad6845fdd2d7715bf5c Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- A .gitignore A Makefile A drivers/drivers.go A drivers/servo/servo.go A eve.toml A events/events.go A serialtest.go 7 files changed, 398 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/SerialTest refs/changes/83/39083/6 -- To view, visit https://review.coreboot.org/c/SerialTest/+/39083 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: SerialTest Gerrit-Branch: master Gerrit-Change-Id: Iab8d507dee6087bf32280ad6845fdd2d7715bf5c Gerrit-Change-Number: 39083 Gerrit-PatchSet: 6 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Dossym Nurmukhanov <dossym(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Greg Edelston <gredelston(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/libretrend/lt1000: Add Libretrend LT1000 mainboard
by Michał Żygowski (Code Review) 09 Mar '20

09 Mar '20

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30360 ) Change subject: mb/libretrend/lt1000: Add Libretrend LT1000 mainboard ...................................................................... Patch Set 17: (1 comment) https://review.coreboot.org/c/coreboot/+/30360/15/src/mainboard/libretrend/… File src/mainboard/libretrend/lt1000/bootblock.c: https://review.coreboot.org/c/coreboot/+/30360/15/src/mainboard/libretrend/… PS15, Line 14: #define SERIAL1_DEV PNP_DEV(0x2e, IT8786E_SP1) > It’d be great if you added that as comment. Ohh my bad... "IT8786E has 6 COM ports, COM1/3/5 have default IO base 0x3f8 and COM2/4/6 have 0x2f8." So they do not share 0x3f8 only. There is an extensive comment below. See line 29 -- To view, visit https://review.coreboot.org/c/coreboot/+/30360 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I32fc8a7d3177ba379d04ad8b87adefcfca2b0fab Gerrit-Change-Number: 30360 Gerrit-PatchSet: 17 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 09 Mar 2020 14:33:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/libretrend/lt1000: Add Libretrend LT1000 mainboard
by Michał Żygowski (Code Review) 09 Mar '20

09 Mar '20

1 0

Change in coreboot[master]: mb/libretrend/lt1000: Add Libretrend LT1000 mainboard
by Michał Żygowski (Code Review) 09 Mar '20

09 Mar '20

Hello build bot (Jenkins), Martin Roth, Patrick Georgi, Angel Pons, Patrick Rudolph, Piotr Król, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/30360 to look at the new patch set (#17). Change subject: mb/libretrend/lt1000: Add Libretrend LT1000 mainboard ...................................................................... mb/libretrend/lt1000: Add Libretrend LT1000 mainboard Change-Id: I32fc8a7d3177ba379d04ad8b87adefcfca2b0fab Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> --- M Documentation/mainboard/index.md A Documentation/mainboard/libretrend/lt1000.jpg A Documentation/mainboard/libretrend/lt1000.md M MAINTAINERS A configs/config.libretrend_lt1000 A src/mainboard/libretrend/Kconfig A src/mainboard/libretrend/Kconfig.name A src/mainboard/libretrend/lt1000/Kconfig A src/mainboard/libretrend/lt1000/Kconfig.name A src/mainboard/libretrend/lt1000/Makefile.inc A src/mainboard/libretrend/lt1000/acpi/ec.asl A src/mainboard/libretrend/lt1000/acpi/superio.asl A src/mainboard/libretrend/lt1000/board_info.txt A src/mainboard/libretrend/lt1000/bootblock.c A src/mainboard/libretrend/lt1000/data.vbt A src/mainboard/libretrend/lt1000/devicetree.cb A src/mainboard/libretrend/lt1000/dsdt.asl A src/mainboard/libretrend/lt1000/gma-mainboard.ads A src/mainboard/libretrend/lt1000/gpio.h A src/mainboard/libretrend/lt1000/ramstage.c A src/mainboard/libretrend/lt1000/romstage.c 21 files changed, 861 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/30360/17 -- To view, visit https://review.coreboot.org/c/coreboot/+/30360 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I32fc8a7d3177ba379d04ad8b87adefcfca2b0fab Gerrit-Change-Number: 30360 Gerrit-PatchSet: 17 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/libretrend/lt1000: Add Libretrend LT1000 mainboard
by Michał Żygowski (Code Review) 09 Mar '20

09 Mar '20

1 0

Change in coreboot[master]: mb/libretrend/lt1000: Add Libretrend LT1000 mainboard
by Michał Żygowski (Code Review) 09 Mar '20

09 Mar '20

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30360 ) Change subject: mb/libretrend/lt1000: Add Libretrend LT1000 mainboard ...................................................................... Patch Set 15: (7 comments) https://review.coreboot.org/c/coreboot/+/30360/15//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/30360/15//COMMIT_MSG@7 PS15, Line 7: board support > I would just say `mainboard` Done https://review.coreboot.org/c/coreboot/+/30360/15/Documentation/mainboard/l… File Documentation/mainboard/libretrend/lt1000.md: https://review.coreboot.org/c/coreboot/+/30360/15/Documentation/mainboard/l… PS15, Line 34: Strongly advised to > *It is* strongly advised to ... Done https://review.coreboot.org/c/coreboot/+/30360/15/Documentation/mainboard/l… PS15, Line 35: possessing the > having an Done https://review.coreboot.org/c/coreboot/+/30360/15/src/mainboard/libretrend/… File src/mainboard/libretrend/lt1000/acpi/mainboard.asl: PS15: > I don't think we need this file Done https://review.coreboot.org/c/coreboot/+/30360/15/src/mainboard/libretrend/… File src/mainboard/libretrend/lt1000/devicetree.cb: https://review.coreboot.org/c/coreboot/+/30360/15/src/mainboard/libretrend/… PS15, Line 241: "THERMAL_MODE_DISABLED" > Should fit on the previous line Done https://review.coreboot.org/c/coreboot/+/30360/15/src/mainboard/libretrend/… PS15, Line 254: LVDS > backlight control? Done https://review.coreboot.org/c/coreboot/+/30360/15/src/mainboard/libretrend/… File src/mainboard/libretrend/lt1000/dsdt.asl: https://review.coreboot.org/c/coreboot/+/30360/15/src/mainboard/libretrend/… PS15, Line 31: #include "acpi/mainboard.asl" > We don't need this Done -- To view, visit https://review.coreboot.org/c/coreboot/+/30360 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I32fc8a7d3177ba379d04ad8b87adefcfca2b0fab Gerrit-Change-Number: 30360 Gerrit-PatchSet: 15 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 09 Mar 2020 13:26:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/libretrend/lt1000: Add Libretrend LT1000 mainboard
by Michał Żygowski (Code Review) 09 Mar '20

09 Mar '20

Hello build bot (Jenkins), Martin Roth, Patrick Georgi, Angel Pons, Patrick Rudolph, Piotr Król, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/30360 to look at the new patch set (#16). Change subject: mb/libretrend/lt1000: Add Libretrend LT1000 mainboard ...................................................................... mb/libretrend/lt1000: Add Libretrend LT1000 mainboard Change-Id: I32fc8a7d3177ba379d04ad8b87adefcfca2b0fab Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> --- M Documentation/mainboard/index.md A Documentation/mainboard/libretrend/lt1000.jpg A Documentation/mainboard/libretrend/lt1000.md M MAINTAINERS A configs/config.libretrend_lt1000 A src/mainboard/libretrend/Kconfig A src/mainboard/libretrend/Kconfig.name A src/mainboard/libretrend/lt1000/Kconfig A src/mainboard/libretrend/lt1000/Kconfig.name A src/mainboard/libretrend/lt1000/Makefile.inc A src/mainboard/libretrend/lt1000/acpi/ec.asl A src/mainboard/libretrend/lt1000/acpi/superio.asl A src/mainboard/libretrend/lt1000/board_info.txt A src/mainboard/libretrend/lt1000/bootblock.c A src/mainboard/libretrend/lt1000/data.vbt A src/mainboard/libretrend/lt1000/devicetree.cb A src/mainboard/libretrend/lt1000/dsdt.asl A src/mainboard/libretrend/lt1000/gma-mainboard.ads A src/mainboard/libretrend/lt1000/gpio.h A src/mainboard/libretrend/lt1000/ramstage.c A src/mainboard/libretrend/lt1000/romstage.c 21 files changed, 861 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/30360/16 -- To view, visit https://review.coreboot.org/c/coreboot/+/30360 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I32fc8a7d3177ba379d04ad8b87adefcfca2b0fab Gerrit-Change-Number: 30360 Gerrit-PatchSet: 16 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2020