Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39385 )
Change subject: mb/asus/p5qpl-am: Do not set BSEL GPIOs in devicetree
......................................................................
mb/asus/p5qpl-am: Do not set BSEL GPIOs in devicetree
This mainboard has the FSB BSEL straps wired to SuperIO GPIOs. They are
set up in romstage, so it makes no sense to rewrite their values in
ramstage.
Tested, my Asus P5QPL-AM still boots.
Change-Id: Ic47f96d12420ebcc70ab5cea940c4c09620c03ca
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
---
M src/mainboard/asus/p5qpl-am/variants/p5qpl-am/overridetree.cb
1 file changed, 6 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/39385/1
diff --git a/src/mainboard/asus/p5qpl-am/variants/p5qpl-am/overridetree.cb b/src/mainboard/asus/p5qpl-am/variants/p5qpl-am/overridetree.cb
index e84fd8a..3f56fdf 100644
--- a/src/mainboard/asus/p5qpl-am/variants/p5qpl-am/overridetree.cb
+++ b/src/mainboard/asus/p5qpl-am/variants/p5qpl-am/overridetree.cb
@@ -22,9 +22,6 @@
chip superio/winbond/w83627dhg
device pnp 2e.0 off end # Floppy
device pnp 2e.1 on # Parallel port
- # global
- irq 0x2c = 0x92
- # parallel port
io 0x60 = 0x378
irq 0x70 = 7
drq 0x74 = 3
@@ -40,16 +37,12 @@
irq 0x70 = 1
irq 0x72 = 12
end
- device pnp 2e.6 off end # SPI
- device pnp 2e.7 on end # GPIO6 (all input)
- device pnp 2e.8 off end # WDT0#, PLED
- device pnp 2e.9 off end # GPIO2
- device pnp 2e.109 on # GPIO3
- irq 0xf0 = 0xf3
- end
- device pnp 2e.209 on # GPIO4
- irq 0xf4 = 0x00
- end
+ device pnp 2e.6 off end # SPI
+ device pnp 2e.7 on end # GPIO6 (all input)
+ device pnp 2e.8 off end # WDT0#, PLED
+ device pnp 2e.9 off end # GPIO2
+ device pnp 2e.109 on end # GPIO3
+ device pnp 2e.209 on end # GPIO4
device pnp 2e.309 off end # GPIO5
device pnp 2e.a on # ACPI
irq 0x70 = 0
--
To view, visit https://review.coreboot.org/c/coreboot/+/39385
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic47f96d12420ebcc70ab5cea940c4c09620c03ca
Gerrit-Change-Number: 39385
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newchange
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39367 )
Change subject: src/soc/tigerlake: add S0ix support fsp_params
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39367/1/src/soc/intel/tigerlake/fs…
File src/soc/intel/tigerlake/fsp_params_tgl.c:
https://review.coreboot.org/c/coreboot/+/39367/1/src/soc/intel/tigerlake/fs…
PS1, Line 161: if(config->s0ix_enable) {
> space required before the open parenthesis '('
Done
https://review.coreboot.org/c/coreboot/+/39367/2/src/vendorcode/intel/fsp/f…
File src/vendorcode/intel/fsp/fsp2_0/tigerlake/FspsUpd.h:
PS2:
> Please update Fsp headers as a separate CL. Also, Intel is using a script to generate these. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/39367
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf29865e80311d6ef52ea0ff2a722f8d4e845dd7
Gerrit-Change-Number: 39367
Gerrit-PatchSet: 3
Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Mon, 09 Mar 2020 20:58:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins) <no-reply(a)coreboot.org>
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Gerrit-MessageType: comment
Hello build bot (Jenkins), Wonkyu Kim, John Zhao, Nick Vaccaro, Srinidhi N Kaushik, Patrick Rudolph, Divya S Sasidharan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39369
to look at the new patch set (#3).
Change subject: src/soc/tigerlake: Enabled D3ColdEnable in fsp_params
......................................................................
src/soc/tigerlake: Enabled D3ColdEnable in fsp_params
Tcss Thunderbolt is D3-cold capable and is recommended.
This enables the D3ColdEnable feature for TCSS Thunderbolt
when s0ix is enabled.
BUG=b:146624360,b:150912117
BRANCH=none
TEST="Build and Boot on Volteer"
Change-Id: If2b1b0b3b50cd8a7b2f974579dc281bcd65c243a
Signed-off-by: John Zhao <john.zhao(a)intel.com>
Reviewed-on: https://chrome-internal-review.googlesource.com/c/chromeos/third_party/core…
Reviewed-by: Caveh Jalali <caveh(a)google.com>
Reviewed-by: Nick Vaccaro <nvaccaro(a)google.com>
Reviewed-by: Wonkyu Kim <wonkyu.kim(a)intel.corp-partner.google.com>
Tested-by: Divya S Sasidharan <divya.s.sasidharan(a)intel.com>
Commit-Queue: Caveh Jalali <caveh(a)google.com>
---
M src/soc/intel/tigerlake/fsp_params_tgl.c
M src/vendorcode/intel/fsp/fsp2_0/tigerlake/FspsUpd.h
2 files changed, 7 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/39369/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/39369
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If2b1b0b3b50cd8a7b2f974579dc281bcd65c243a
Gerrit-Change-Number: 39369
Gerrit-PatchSet: 3
Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Divya S Sasidharan <divya.s.sasidharan(a)intel.com>
Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-MessageType: newpatchset
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39369 )
Change subject: src/soc/tigerlake: Enabled D3ColdEnable in fsp_params
......................................................................
Patch Set 2:
Could you add topic "TGL_UPSTREAM" for tracking later?
--
To view, visit https://review.coreboot.org/c/coreboot/+/39369
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If2b1b0b3b50cd8a7b2f974579dc281bcd65c243a
Gerrit-Change-Number: 39369
Gerrit-PatchSet: 2
Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Divya S Sasidharan <divya.s.sasidharan(a)intel.com>
Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Comment-Date: Mon, 09 Mar 2020 20:11:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39367 )
Change subject: src/soc/tigerlake: add S0ix support fsp_params
......................................................................
Patch Set 2:
Could you add topic "TGL_UPSTREAM" for tracking later?
--
To view, visit https://review.coreboot.org/c/coreboot/+/39367
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf29865e80311d6ef52ea0ff2a722f8d4e845dd7
Gerrit-Change-Number: 39367
Gerrit-PatchSet: 2
Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Mon, 09 Mar 2020 20:11:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39368 )
Change subject: src/soc/tigerlake: Enabled D3HotEnable in fsp_params
......................................................................
Patch Set 2:
Could you add topic "TGL_UPSTREAM" for tracking later?
--
To view, visit https://review.coreboot.org/c/coreboot/+/39368
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaba12339378b38ff850da812135f51a1d8d4130f
Gerrit-Change-Number: 39368
Gerrit-PatchSet: 2
Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Comment-Date: Mon, 09 Mar 2020 20:10:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Francois Toguo Fotso has uploaded a new patch set (#4) to the change originally created by Francois Toguo Fotso. ( https://review.coreboot.org/c/coreboot/+/30098 )
Change subject: Fix potential NULL pointer dereferences and memory leak
......................................................................
Fix potential NULL pointer dereferences and memory leak
Found-by: Klockwork
BUG=None
TEST=Boot to OS
Change-Id: I38a8910e68b7a8ce0e97ca4cdb9ef7f595c0e319
Signed-off-by: Francois Toguo <francois.toguo.fotso(a)intel.com>
---
M src/arch/x86/acpi_device.c
M src/arch/x86/acpigen.c
M src/include/nhlt.h
M src/lib/nhlt.c
M src/soc/intel/common/nhlt.c
5 files changed, 18 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/30098/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/30098
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I38a8910e68b7a8ce0e97ca4cdb9ef7f595c0e319
Gerrit-Change-Number: 30098
Gerrit-PatchSet: 4
Gerrit-Owner: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com>
Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-MessageType: newpatchset