Change in coreboot[master]: mb/asus/p5g41t-m_lx: Correct GPIO direction

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39386 )

Change subject: mb/asus/p5g41t-m_lx: Correct GPIO direction
......................................................................

mb/asus/p5g41t-m_lx: Correct GPIO direction

Not all GPIO4 pins on the SuperIO are configured as outputs.

Change-Id: Idf6350551a91c4c1a25a83e3fb9b1a6722a81c36
Signed-off-by: Angel Pons 
---
M src/mainboard/asus/p5qpl-am/early_init.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/39386/1

diff --git a/src/mainboard/asus/p5qpl-am/early_init.c b/src/mainboard/asus/p5qpl-am/early_init.c
index 5987033..97411fd 100644
--- a/src/mainboard/asus/p5qpl-am/early_init.c
+++ b/src/mainboard/asus/p5qpl-am/early_init.c
@@ -114,7 +114,7 @@
    	need_reset = (reg != old_reg);
    	pnp_write_config(GPIO_DEV, 0x30, 0x05);
    	pnp_write_config(GPIO_DEV, 0xf6, 0x08); /* invert GPIO43 */
-		pnp_write_config(GPIO_DEV, 0xf4, 0x00); /* GPIO4 direction */
+		pnp_write_config(GPIO_DEV, 0xf4, 0xa4); /* GPIO4 direction */

const int gpio43 = (bsel & 2) >> 1;
    	const int gpio44 = (bsel & 4) >> 2;

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39386 )

Change subject: mb/asus/p5g41t-m_lx: Correct GPIO direction
......................................................................

Patch Set 1: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39386 )

Change subject: mb/asus/p5g41t-m_lx: Correct GPIO direction
......................................................................

Patch Set 1: Code-Review+1

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39386 )

Change subject: mb/asus/p5g41t-m_lx: Correct GPIO direction
......................................................................

mb/asus/p5g41t-m_lx: Correct GPIO direction

Not all GPIO4 pins on the SuperIO are configured as outputs.

Change-Id: Idf6350551a91c4c1a25a83e3fb9b1a6722a81c36
Signed-off-by: Angel Pons 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39386
Tested-by: build bot (Jenkins) 
Reviewed-by: Nico Huber 
Reviewed-by: Paul Menzel 
---
M src/mainboard/asus/p5qpl-am/early_init.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve

diff --git a/src/mainboard/asus/p5qpl-am/early_init.c b/src/mainboard/asus/p5qpl-am/early_init.c
index 5987033..97411fd 100644
--- a/src/mainboard/asus/p5qpl-am/early_init.c
+++ b/src/mainboard/asus/p5qpl-am/early_init.c
@@ -114,7 +114,7 @@
    	need_reset = (reg != old_reg);
    	pnp_write_config(GPIO_DEV, 0x30, 0x05);
    	pnp_write_config(GPIO_DEV, 0xf6, 0x08); /* invert GPIO43 */
-		pnp_write_config(GPIO_DEV, 0xf4, 0x00); /* GPIO4 direction */
+		pnp_write_config(GPIO_DEV, 0xf4, 0xa4); /* GPIO4 direction */

const int gpio43 = (bsel & 2) >> 1;
    	const int gpio44 = (bsel & 4) >> 2;