coreboot-gerrit February 2020

coreboot-gerrit@coreboot.org

1 participants
1797 discussions

Change in coreboot[master]: autoport: Remove space in example code
by Paul Menzel (Code Review) 17 Feb '20

17 Feb '20

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38912 ) Change subject: autoport: Remove space in example code ...................................................................... autoport: Remove space in example code The coreboot coding style does not insert a space between the function and argument list. Change-Id: I740f6c7f513e4f2715c793f61c9d9835c55c9dce Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de> --- M util/autoport/readme.md 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/38912/1 diff --git a/util/autoport/readme.md b/util/autoport/readme.md index b73b441..a964e06 100644 --- a/util/autoport/readme.md +++ b/util/autoport/readme.md @@ -155,10 +155,10 @@ should look similar to this: void mainboard_get_spd(spd_raw_data *spd) { - read_spd (&spd[0], 0x50); - read_spd (&spd[1], 0x51); - read_spd (&spd[2], 0x52); - read_spd (&spd[3], 0x53); + read_spd(&spd[0], 0x50); + read_spd(&spd[1], 0x51); + read_spd(&spd[2], 0x52); + read_spd(&spd[3], 0x53); } Note that there should be one line per memory slot on the mainboard. -- To view, visit https://review.coreboot.org/c/coreboot/+/38912 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I740f6c7f513e4f2715c793f61c9d9835c55c9dce Gerrit-Change-Number: 38912 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newchange

4 3

Change in coreboot[master]: drivers/intel/gma: Print EDID with leading instead of trailing space
by Paul Menzel (Code Review) 17 Feb '20

17 Feb '20

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38915 ) Change subject: drivers/intel/gma: Print EDID with leading instead of trailing space ...................................................................... drivers/intel/gma: Print EDID with leading instead of trailing space This way, the block is a little indented below `EDID:` making it a little more structured for the eye. Change-Id: I12066efefb23c5ffa8ba6b8c486cd54e142d4dc1 Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de> --- M src/drivers/intel/gma/edid.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/38915/1 diff --git a/src/drivers/intel/gma/edid.c b/src/drivers/intel/gma/edid.c index cf6ea51..ca3ab32 100644 --- a/src/drivers/intel/gma/edid.c +++ b/src/drivers/intel/gma/edid.c @@ -103,7 +103,7 @@ printk (BIOS_SPEW, "EDID:\n"); for (i = 0; i < 128; i++) { - printk(BIOS_SPEW, "%02x ", edid[i]); + printk(BIOS_SPEW, " %02x", edid[i]); if ((i & 0xf) == 0xf) printk (BIOS_SPEW, "\n"); } -- To view, visit https://review.coreboot.org/c/coreboot/+/38915 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I12066efefb23c5ffa8ba6b8c486cd54e142d4dc1 Gerrit-Change-Number: 38915 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newchange

3 2

Change in coreboot[master]: drivers/intel/gma: Remove space between `printf ()`
by Paul Menzel (Code Review) 17 Feb '20

17 Feb '20

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38914 ) Change subject: drivers/intel/gma: Remove space between `printf ()` ...................................................................... drivers/intel/gma: Remove space between `printf ()` Fix the warning below. WARNING: space prohibited between function name and open parenthesis '(' Change-Id: I28d9ba64c790c659040cd34eda37125e191dab39 Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de> --- M src/drivers/intel/gma/edid.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/38914/1 diff --git a/src/drivers/intel/gma/edid.c b/src/drivers/intel/gma/edid.c index 4d4aec3..cf6ea51 100644 --- a/src/drivers/intel/gma/edid.c +++ b/src/drivers/intel/gma/edid.c @@ -103,7 +103,7 @@ printk (BIOS_SPEW, "EDID:\n"); for (i = 0; i < 128; i++) { - printk (BIOS_SPEW, "%02x ", edid[i]); + printk(BIOS_SPEW, "%02x ", edid[i]); if ((i & 0xf) == 0xf) printk (BIOS_SPEW, "\n"); } -- To view, visit https://review.coreboot.org/c/coreboot/+/38914 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I28d9ba64c790c659040cd34eda37125e191dab39 Gerrit-Change-Number: 38914 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newchange

3 2

Change in coreboot[master]: lib/edid: Zero struct only when used
by Paul Menzel (Code Review) 17 Feb '20

17 Feb '20

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38913 ) Change subject: lib/edid: Zero struct only when used ...................................................................... lib/edid: Zero struct only when used Change-Id: I1c14e7458153fb992b17f30d7015321fae533bb2 Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de> --- M src/lib/edid.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/38913/1 diff --git a/src/lib/edid.c b/src/lib/edid.c index 238fed5..048cc6a 100644 --- a/src/lib/edid.c +++ b/src/lib/edid.c @@ -1138,8 +1138,6 @@ .conformant = EDID_CONFORMANT, }; - memset(out, 0, sizeof(*out)); - if (!edid) { printk(BIOS_ERR, "No EDID found\n"); return EDID_ABSENT; @@ -1152,6 +1150,8 @@ return EDID_ABSENT; } + memset(out, 0, sizeof(*out)); + if (manufacturer_name(edid + 0x08, out->manufacturer_name)) c.manufacturer_name_well_formed = 1; -- To view, visit https://review.coreboot.org/c/coreboot/+/38913 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1c14e7458153fb992b17f30d7015321fae533bb2 Gerrit-Change-Number: 38913 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newchange

2 2

Change in coreboot[master]: cpu/x86/smm: Edit - improve clarity
by Name of user not set (Code Review) 17 Feb '20

17 Feb '20

cedarhouse1(a)comcast.net has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38821 ) Change subject: cpu/x86/smm: Edit - improve clarity ...................................................................... cpu/x86/smm: Edit - improve clarity Removed blank line to maintain the relation between the previous comment and the remainder of the block. Signed-off-by: Eugene D. Myers <edmyers(a)tycho.nsa.gov> Change-Id: Ib9754c6723ecd5e4895898490fc7228e1c3839d0 --- M src/cpu/x86/smm/smm_module_loader.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/38821/1 diff --git a/src/cpu/x86/smm/smm_module_loader.c b/src/cpu/x86/smm/smm_module_loader.c index 81020a4..66a40c4 100644 --- a/src/cpu/x86/smm/smm_module_loader.c +++ b/src/cpu/x86/smm/smm_module_loader.c @@ -396,7 +396,6 @@ /* Does the required amount of memory exceed the SMRAM region size? */ total_size = total_stack_size + handler_size; total_size += fxsave_size + SMM_DEFAULT_SIZE; - // account for the bios resource list if (CONFIG(STM)) total_size += CONFIG_BIOS_RESOURCE_LIST_SIZE; -- To view, visit https://review.coreboot.org/c/coreboot/+/38821 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib9754c6723ecd5e4895898490fc7228e1c3839d0 Gerrit-Change-Number: 38821 Gerrit-PatchSet: 1 Gerrit-Owner: cedarhouse1(a)comcast.net Gerrit-MessageType: newchange

6 11

Change in coreboot[master]: lib/edid.c: Remove trailing space from detailed mode output
by Patrick Georgi (Code Review) 17 Feb '20

17 Feb '20

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/17644 ) Change subject: lib/edid.c: Remove trailing space from detailed mode output ...................................................................... lib/edid.c: Remove trailing space from detailed mode output When the bit for interlaced mode is not set, a trailing space is added to the end. As the space is already accounted for in `" interlaced"`, remove that space. TEST=Boot on Lenovo X60t, and verify the trailing space in the detailed mode is gone. Change-Id: I4114c9e61a040fa005c806404ec51c12e2f02f4d Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/17644 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/lib/edid.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/lib/edid.c b/src/lib/edid.c index 4a2f07a..238fed5 100644 --- a/src/lib/edid.c +++ b/src/lib/edid.c @@ -573,7 +573,7 @@ "Detailed mode (IN HEX): Clock %d KHz, %x mm x %x mm\n" " %04x %04x %04x %04x hborder %x\n" " %04x %04x %04x %04x vborder %x\n" - " %chsync %cvsync%s%s %s\n", + " %chsync %cvsync%s%s%s\n", out->mode.pixel_clock, extra_info.x_mm, extra_info.y_mm, -- To view, visit https://review.coreboot.org/c/coreboot/+/17644 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4114c9e61a040fa005c806404ec51c12e2f02f4d Gerrit-Change-Number: 17644 Gerrit-PatchSet: 4 Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/octopus/variants/dood: add new SKU ID
by Kenneth Chan (Code Review) 17 Feb '20

17 Feb '20

Kenneth Chan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38730 ) Change subject: mb/google/octopus/variants/dood: add new SKU ID ...................................................................... mb/google/octopus/variants/dood: add new SKU ID add SKU ID 3 and 4 for dood DVT 1: Dood WiFi + LTE (evt) 2: Dood WiFi (evt) 3: Dood WiFi + LTE + dual camera (dvt) 4: Dood WiFi + dual camera (dvt) BUG=b:148988979 TEST=build firmware and verify on the DUT of sku 3 and 4 check LTE module with moden status Change-Id: If86efe2a2f7b2e165ad44220b6dd59e9080b5892 Signed-off-by: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> --- M src/mainboard/google/octopus/variants/dood/gpio.c M src/mainboard/google/octopus/variants/dood/variant.c 2 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/38730/1 diff --git a/src/mainboard/google/octopus/variants/dood/gpio.c b/src/mainboard/google/octopus/variants/dood/gpio.c index 5b567b3..ee4ca7f 100644 --- a/src/mainboard/google/octopus/variants/dood/gpio.c +++ b/src/mainboard/google/octopus/variants/dood/gpio.c @@ -22,6 +22,8 @@ enum { SKU_1_LTE = 1, /* Wifi + LTE */ SKU_2_WIFI = 2, /* Wifi */ + SKU_3_LTE_2CAM = 3, /* Wifi + LTE + dual camera*/ + SKU_4_WIFI_2CAM = 4, /* Wifi + dual Camera*/ }; static const struct pad_config default_override_table[] = { @@ -62,6 +64,7 @@ switch (sku_id) { case SKU_1_LTE: + case SKU_3_LTE_2CAM: *num = ARRAY_SIZE(lte_override_table); return lte_override_table; default: diff --git a/src/mainboard/google/octopus/variants/dood/variant.c b/src/mainboard/google/octopus/variants/dood/variant.c index 7116061..e4e4b18 100644 --- a/src/mainboard/google/octopus/variants/dood/variant.c +++ b/src/mainboard/google/octopus/variants/dood/variant.c @@ -23,6 +23,8 @@ enum { SKU_1_LTE = 1, /* Wifi + LTE */ SKU_2_WIFI = 2, /* Wifi */ + SKU_3_LTE_2CAM = 3, /* Wifi + LTE + dual camera*/ + SKU_4_WIFI_2CAM = 4, /* Wifi + dual Camera*/ }; struct gpio_with_delay { @@ -63,6 +65,7 @@ switch (get_board_sku()) { case SKU_1_LTE: + case SKU_3_LTE_2CAM: power_off_lte_module(slp_typ); return; default: -- To view, visit https://review.coreboot.org/c/coreboot/+/38730 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If86efe2a2f7b2e165ad44220b6dd59e9080b5892 Gerrit-Change-Number: 38730 Gerrit-PatchSet: 1 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

5 18

Change in coreboot[master]: util/docker: Use more stable URL
by Patrick Georgi (Code Review) 17 Feb '20

17 Feb '20

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38899 ) Change subject: util/docker: Use more stable URL ...................................................................... util/docker: Use more stable URL The pgeorgi namespace is my own and things could change without notice there. encapsulate is now maintained on review.coreboot.org/encapsulate.git and mirrored over to github, so let's use that. Change-Id: I12e43f61f693a6b0392b84dd56ede665a1a2129a Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/docker/coreboot-jenkins-node/Dockerfile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/38899/1 diff --git a/util/docker/coreboot-jenkins-node/Dockerfile b/util/docker/coreboot-jenkins-node/Dockerfile index cfe5abb..73f7f18 100644 --- a/util/docker/coreboot-jenkins-node/Dockerfile +++ b/util/docker/coreboot-jenkins-node/Dockerfile @@ -45,7 +45,7 @@ echo "tmpfs /home/coreboot/.ccache tmpfs rw,mode=1777 0 0" >> /etc/fstab # Build encapsulate tool -ADD https://raw.githubusercontent.com/pgeorgi/encapsulate/master/encapsulate.c /tmp/encapsulate.c +ADD https://raw.githubusercontent.com/coreboot/encapsulate/master/encapsulate.c /tmp/encapsulate.c RUN gcc -o /usr/sbin/encapsulate /tmp/encapsulate.c && \ chown root /usr/sbin/encapsulate && \ chmod +s /usr/sbin/encapsulate -- To view, visit https://review.coreboot.org/c/coreboot/+/38899 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I12e43f61f693a6b0392b84dd56ede665a1a2129a Gerrit-Change-Number: 38899 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

4 6

Change in coreboot[master]: mb/google/drallion: correct USB3 OC pin error
by EricR Lai (Code Review) 17 Feb '20

17 Feb '20

EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38885 ) Change subject: mb/google/drallion: correct USB3 OC pin error ...................................................................... mb/google/drallion: correct USB3 OC pin error USB3 OC pin was configured wrong pin. Follow HW circuit to set it. BUG=b:147869924 TEST=USB function works well Signed-off-by: Eric Lai <ericr_lai(a)compal.corp-partner.google.com> Change-Id: I61234a2054ab52fa508482d3dd0f94b13f96a5c9 --- M src/mainboard/google/drallion/variants/drallion/devicetree.cb 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/38885/1 diff --git a/src/mainboard/google/drallion/variants/drallion/devicetree.cb b/src/mainboard/google/drallion/variants/drallion/devicetree.cb index 06d3e5d..92f3fb9 100644 --- a/src/mainboard/google/drallion/variants/drallion/devicetree.cb +++ b/src/mainboard/google/drallion/variants/drallion/devicetree.cb @@ -154,9 +154,9 @@ register "usb2_ports[9]" = "USB2_PORT_MID(OC_SKIP)" # Bluetooth register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Left Type-C Port - register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Left Type-C Port 2 - register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC0)" # Right Type-A Port 1 - register "usb3_ports[3]" = "USB3_PORT_DEFAULT(OC1)" # Right Type-A Port 2 + register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC0)" # Right Type-A Port 1 + register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC1)" # Right Type-A Port 2 + register "usb3_ports[3]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Left Type-C Port 2 register "usb3_ports[4]" = "USB3_PORT_DEFAULT(OC_SKIP)" # WWAN register "usb3_ports[5]" = "USB3_PORT_EMPTY" -- To view, visit https://review.coreboot.org/c/coreboot/+/38885 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61234a2054ab52fa508482d3dd0f94b13f96a5c9 Gerrit-Change-Number: 38885 Gerrit-PatchSet: 1 Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: newchange

4 7

Change in coreboot[master]: mb/google/puff: Enable SPD_READ_BY_WORD to short the boottime
by Jamie Chen (Code Review) 17 Feb '20

17 Feb '20

Jamie Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38848 ) Change subject: mb/google/puff: Enable SPD_READ_BY_WORD to short the boottime ...................................................................... mb/google/puff: Enable SPD_READ_BY_WORD to short the boottime Puff uses the smbus to access SPD of memory DIMM. Add select SPD_READ_BY_WORD under BOARD_GOOGLE_PUFF in Kconfig.name It's for shorting the SPD reading time. BUG=b:149360051 BRANCH=None TEST=build puff and boot up OS ran cbmem -t | grep FspMemoryInit Without this patch: 950:calling FspMemoryInit 643,199 (257,588) With this patch: 950:calling FspMemoryInit 477,714 (154,612) Signed-off-by: Jamie Chen <jamie.chen(a)intel.com> Change-Id: I161e8eb386ab604b16746f0deeecc3d6c9063c3a --- M src/mainboard/google/hatch/Kconfig.name 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/38848/1 diff --git a/src/mainboard/google/hatch/Kconfig.name b/src/mainboard/google/hatch/Kconfig.name index e216135..2427b12 100644 --- a/src/mainboard/google/hatch/Kconfig.name +++ b/src/mainboard/google/hatch/Kconfig.name @@ -48,6 +48,7 @@ select BOARD_GOOGLE_BASEBOARD_HATCH select BOARD_ROMSIZE_KB_32768 select ROMSTAGE_SPD_SMBUS + select SPD_READ_BY_WORD config BOARD_GOOGLE_HELIOS_DISKSWAP bool "-> Helios_Diskswap" -- To view, visit https://review.coreboot.org/c/coreboot/+/38848 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I161e8eb386ab604b16746f0deeecc3d6c9063c3a Gerrit-Change-Number: 38848 Gerrit-PatchSet: 1 Gerrit-Owner: Jamie Chen <jamie.chen(a)intel.com> Gerrit-MessageType: newchange

4 4

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2020