Change in coreboot[master]: mb/google/octopus/variants/dood: add new SKU ID

[Kenneth Chan (Code Review)]

Kenneth Chan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38730 )

Change subject: mb/google/octopus/variants/dood: add new SKU ID
......................................................................

mb/google/octopus/variants/dood: add new SKU ID

add SKU ID 3 and 4 for dood DVT
1: Dood WiFi + LTE (evt)
2: Dood WiFi  (evt)
3: Dood WiFi + LTE + dual camera (dvt)
4: Dood WiFi + dual camera (dvt)

BUG=b:148988979
TEST=build firmware and verify on the DUT of sku 3 and 4
     check LTE module with moden status

Change-Id: If86efe2a2f7b2e165ad44220b6dd59e9080b5892
Signed-off-by: Kenneth Chan 
---
M src/mainboard/google/octopus/variants/dood/gpio.c
M src/mainboard/google/octopus/variants/dood/variant.c
2 files changed, 6 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/38730/1

diff --git a/src/mainboard/google/octopus/variants/dood/gpio.c b/src/mainboard/google/octopus/variants/dood/gpio.c
index 5b567b3..ee4ca7f 100644
--- a/src/mainboard/google/octopus/variants/dood/gpio.c
+++ b/src/mainboard/google/octopus/variants/dood/gpio.c
@@ -22,6 +22,8 @@
 enum {
    SKU_1_LTE  = 1, /* Wifi + LTE */
    SKU_2_WIFI = 2, /* Wifi */
+	SKU_3_LTE_2CAM = 3, /* Wifi + LTE + dual camera*/
+	SKU_4_WIFI_2CAM = 4, /* Wifi + dual Camera*/
 };

static const struct pad_config default_override_table[] = {
@@ -62,6 +64,7 @@

switch (sku_id) {
    case SKU_1_LTE:
+	case SKU_3_LTE_2CAM:
    	*num = ARRAY_SIZE(lte_override_table);
    	return lte_override_table;
    default:
diff --git a/src/mainboard/google/octopus/variants/dood/variant.c b/src/mainboard/google/octopus/variants/dood/variant.c
index 7116061..e4e4b18 100644
--- a/src/mainboard/google/octopus/variants/dood/variant.c
+++ b/src/mainboard/google/octopus/variants/dood/variant.c
@@ -23,6 +23,8 @@
 enum {
    SKU_1_LTE  = 1, /* Wifi + LTE */
    SKU_2_WIFI = 2, /* Wifi */
+	SKU_3_LTE_2CAM = 3, /* Wifi + LTE + dual camera*/
+	SKU_4_WIFI_2CAM = 4, /* Wifi + dual Camera*/
 };

struct gpio_with_delay {
@@ -63,6 +65,7 @@

switch (get_board_sku()) {
    case SKU_1_LTE:
+	case SKU_3_LTE_2CAM:
    	power_off_lte_module(slp_typ);
    	return;
    default:

[Kenneth Chan (Code Review)]

Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38730 )

Change subject: mb/google/octopus/variants/dood: add new SKU ID
......................................................................

Patch Set 1: Code-Review+1

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38730 )

Change subject: mb/google/octopus/variants/dood: add new SKU ID
......................................................................

Patch Set 1:

(4 comments)

https://review.coreboot.org/c/coreboot/+/38730/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38730/1//COMMIT_MSG@7 
PS1, Line 7: mb/google/octopus/variants/dood: add new SKU ID
Add two new SKU IDs

https://review.coreboot.org/c/coreboot/+/38730/1//COMMIT_MSG@11 
PS1, Line 11:   
One space.

https://review.coreboot.org/c/coreboot/+/38730/1//COMMIT_MSG@17 
PS1, Line 17: moden status
What is that?

https://review.coreboot.org/c/coreboot/+/38730/1/src/mainboard/google/octopu... 
File src/mainboard/google/octopus/variants/dood/gpio.c:

https://review.coreboot.org/c/coreboot/+/38730/1/src/mainboard/google/octopu... 
PS1, Line 25: */
Space before */.

Change in coreboot[master]: mb/google/octopus/variants/dood: add two new SKU IDs

[Kenneth Chan (Code Review)]

Hello Marco Chen, Henry Sun, build bot (Jenkins), Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38730

to look at the new patch set (#2).

Change subject: mb/google/octopus/variants/dood: add two new SKU IDs
......................................................................

mb/google/octopus/variants/dood: add two new SKU IDs

add SKU ID 3 and 4 for dood DVT
1: Dood WiFi + LTE (evt)
2: Dood WiFi (evt)
3: Dood WiFi + LTE + dual camera (dvt)
4: Dood WiFi + dual camera (dvt)

BUG=b:148988979
TEST=build firmware and verify on the DUT of sku 3 and 4
     check LTE module is enabled or not

Change-Id: If86efe2a2f7b2e165ad44220b6dd59e9080b5892
Signed-off-by: Kenneth Chan 
---
M src/mainboard/google/octopus/variants/dood/gpio.c
M src/mainboard/google/octopus/variants/dood/variant.c
2 files changed, 6 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/38730/2

Change in coreboot[master]: mb/google/octopus/variants/dood: add two new SKU IDs

[Kenneth Chan (Code Review)]

Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38730 )

Change subject: mb/google/octopus/variants/dood: add two new SKU IDs
......................................................................

Patch Set 2: Code-Review+1

Change in coreboot[master]: mb/google/octopus/variants/dood: add two new SKU IDs

[Kenneth Chan (Code Review)]

Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38730 )

Change subject: mb/google/octopus/variants/dood: add two new SKU IDs
......................................................................

Patch Set 2:
> Patch Set 1:
>
> (4 comments)

Uploaded patch set 2.
Thanks.

Change in coreboot[master]: mb/google/octopus/variants/dood: add two new SKU IDs

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38730 )

Change subject: mb/google/octopus/variants/dood: add two new SKU IDs
......................................................................

Patch Set 2: Code-Review+1

Change in coreboot[master]: mb/google/octopus/variants/dood: add two new SKU IDs

[Marco Chen (Code Review)]

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38730 )

Change subject: mb/google/octopus/variants/dood: add two new SKU IDs
......................................................................

Patch Set 2: Code-Review+2

Change in coreboot[master]: mb/google/octopus/variants/dood: add two new SKU IDs

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38730 )

Change subject: mb/google/octopus/variants/dood: add two new SKU IDs
......................................................................

Patch Set 2: Code-Review+2

Change in coreboot[master]: mb/google/octopus/variants/dood: add two new SKU IDs

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38730 )

Change subject: mb/google/octopus/variants/dood: add two new SKU IDs
......................................................................

Patch Set 2: Code-Review+1

Change in coreboot[master]: mb/google/octopus/variants/dood: add two new SKU IDs

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38730 )

Change subject: mb/google/octopus/variants/dood: add two new SKU IDs
......................................................................

Patch Set 2:

Hi Patrick,

Could you help to approve the cl ?

Change in coreboot[master]: mb/google/octopus/variants/dood: add two new SKU IDs

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38730 )

Change subject: mb/google/octopus/variants/dood: add two new SKU IDs
......................................................................

Patch Set 2:

Hi Furquan,

Could you help to merge the cl ？

Change in coreboot[master]: mb/google/octopus/variants/dood: add two new SKU IDs

[Marco Chen (Code Review)]

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38730 )

Change subject: mb/google/octopus/variants/dood: add two new SKU IDs
......................................................................

Patch Set 2:

Hi Kenneth and Ren, as I remember all comments should be replied; otherwise the CL can't be merged.

Change in coreboot[master]: mb/google/octopus/variants/dood: add two new SKU IDs

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38730 )

Change subject: mb/google/octopus/variants/dood: add two new SKU IDs
......................................................................

Patch Set 2:
> Patch Set 1:
>
> (4 comments)

the comments had been solved on pathset #2

Change in coreboot[master]: mb/google/octopus/variants/dood: add two new SKU IDs

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38730 )

Change subject: mb/google/octopus/variants/dood: add two new SKU IDs
......................................................................

Patch Set 2:
> Patch Set 1:
>
> (4 comments)

fixed !!

Change in coreboot[master]: mb/google/octopus/variants/dood: add two new SKU IDs

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38730 )

Change subject: mb/google/octopus/variants/dood: add two new SKU IDs
......................................................................

Patch Set 2:
> Patch Set 1:
>
> (4 comments)

fixed

Change in coreboot[master]: mb/google/octopus/variants/dood: add two new SKU IDs

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38730 )

Change subject: mb/google/octopus/variants/dood: add two new SKU IDs
......................................................................

Patch Set 2:

(4 comments)

https://review.coreboot.org/c/coreboot/+/38730/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38730/1//COMMIT_MSG@7 
PS1, Line 7: mb/google/octopus/variants/dood: add new SKU ID
> Add two new SKU IDs

fixed

https://review.coreboot.org/c/coreboot/+/38730/1//COMMIT_MSG@11 
PS1, Line 11:
> One space.

fixed

https://review.coreboot.org/c/coreboot/+/38730/1//COMMIT_MSG@17 
PS1, Line 17: moden status
> What is that?

fixed

https://review.coreboot.org/c/coreboot/+/38730/1/src/mainboard/google/octopu... 
File src/mainboard/google/octopus/variants/dood/gpio.c:

https://review.coreboot.org/c/coreboot/+/38730/1/src/mainboard/google/octopu... 
PS1, Line 25: */
> Space before */.

fixed

Change in coreboot[master]: mb/google/octopus/variants/dood: add two new SKU IDs

[Kenneth Chan (Code Review)]

Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38730 )

Change subject: mb/google/octopus/variants/dood: add two new SKU IDs
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38730/1/src/mainboard/google/octopu... 
File src/mainboard/google/octopus/variants/dood/gpio.c:

https://review.coreboot.org/c/coreboot/+/38730/1/src/mainboard/google/octopu... 
PS1, Line 25: */
> fixed

Done

Change in coreboot[master]: mb/google/octopus/variants/dood: add two new SKU IDs

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38730 )

Change subject: mb/google/octopus/variants/dood: add two new SKU IDs
......................................................................

mb/google/octopus/variants/dood: add two new SKU IDs

add SKU ID 3 and 4 for dood DVT
1: Dood WiFi + LTE (evt)
2: Dood WiFi (evt)
3: Dood WiFi + LTE + dual camera (dvt)
4: Dood WiFi + dual camera (dvt)

BUG=b:148988979
TEST=build firmware and verify on the DUT of sku 3 and 4
     check LTE module is enabled or not

Change-Id: If86efe2a2f7b2e165ad44220b6dd59e9080b5892
Signed-off-by: Kenneth Chan 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38730
Reviewed-by: Marco Chen 
Reviewed-by: Ren Kuo 
Reviewed-by: Paul Menzel 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/octopus/variants/dood/gpio.c
M src/mainboard/google/octopus/variants/dood/variant.c
2 files changed, 6 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Ren Kuo: Looks good to me, approved
  Marco Chen: Looks good to me, approved
  Kenneth Chan: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/octopus/variants/dood/gpio.c b/src/mainboard/google/octopus/variants/dood/gpio.c
index 5b567b3..96b8ac0 100644
--- a/src/mainboard/google/octopus/variants/dood/gpio.c
+++ b/src/mainboard/google/octopus/variants/dood/gpio.c
@@ -22,6 +22,8 @@
 enum {
    SKU_1_LTE  = 1, /* Wifi + LTE */
    SKU_2_WIFI = 2, /* Wifi */
+	SKU_3_LTE_2CAM = 3, /* Wifi + LTE + dual camera */
+	SKU_4_WIFI_2CAM = 4, /* Wifi + dual camera */
 };

static const struct pad_config default_override_table[] = {
@@ -62,6 +64,7 @@

switch (sku_id) {
    case SKU_1_LTE:
+	case SKU_3_LTE_2CAM:
    	*num = ARRAY_SIZE(lte_override_table);
    	return lte_override_table;
    default:
diff --git a/src/mainboard/google/octopus/variants/dood/variant.c b/src/mainboard/google/octopus/variants/dood/variant.c
index 7116061..694e190 100644
--- a/src/mainboard/google/octopus/variants/dood/variant.c
+++ b/src/mainboard/google/octopus/variants/dood/variant.c
@@ -23,6 +23,8 @@
 enum {
    SKU_1_LTE  = 1, /* Wifi + LTE */
    SKU_2_WIFI = 2, /* Wifi */
+	SKU_3_LTE_2CAM = 3, /* Wifi + LTE + dual camera */
+	SKU_4_WIFI_2CAM = 4, /* Wifi + dual camera */
 };

struct gpio_with_delay {
@@ -63,6 +65,7 @@

switch (get_board_sku()) {
    case SKU_1_LTE:
+	case SKU_3_LTE_2CAM:
    	power_off_lte_module(slp_typ);
    	return;
    default: