Patrick Georgi submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Ren Kuo: Looks good to me, approved Marco Chen: Looks good to me, approved Kenneth Chan: Looks good to me, but someone else must approve
mb/google/octopus/variants/dood: add two new SKU IDs

add SKU ID 3 and 4 for dood DVT
1: Dood WiFi + LTE (evt)
2: Dood WiFi (evt)
3: Dood WiFi + LTE + dual camera (dvt)
4: Dood WiFi + dual camera (dvt)

BUG=b:148988979
TEST=build firmware and verify on the DUT of sku 3 and 4
check LTE module is enabled or not

Change-Id: If86efe2a2f7b2e165ad44220b6dd59e9080b5892
Signed-off-by: Kenneth Chan <kenneth.chan@quanta.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38730
Reviewed-by: Marco Chen <marcochen@google.com>
Reviewed-by: Ren Kuo <ren.kuo@quanta.corp-partner.google.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/mainboard/google/octopus/variants/dood/gpio.c
M src/mainboard/google/octopus/variants/dood/variant.c
2 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/src/mainboard/google/octopus/variants/dood/gpio.c b/src/mainboard/google/octopus/variants/dood/gpio.c
index 5b567b3..96b8ac0 100644
--- a/src/mainboard/google/octopus/variants/dood/gpio.c
+++ b/src/mainboard/google/octopus/variants/dood/gpio.c
@@ -22,6 +22,8 @@
enum {
SKU_1_LTE = 1, /* Wifi + LTE */
SKU_2_WIFI = 2, /* Wifi */
+ SKU_3_LTE_2CAM = 3, /* Wifi + LTE + dual camera */
+ SKU_4_WIFI_2CAM = 4, /* Wifi + dual camera */
};

static const struct pad_config default_override_table[] = {
@@ -62,6 +64,7 @@

switch (sku_id) {
case SKU_1_LTE:
+ case SKU_3_LTE_2CAM:
*num = ARRAY_SIZE(lte_override_table);
return lte_override_table;
default:
diff --git a/src/mainboard/google/octopus/variants/dood/variant.c b/src/mainboard/google/octopus/variants/dood/variant.c
index 7116061..694e190 100644
--- a/src/mainboard/google/octopus/variants/dood/variant.c
+++ b/src/mainboard/google/octopus/variants/dood/variant.c
@@ -23,6 +23,8 @@
enum {
SKU_1_LTE = 1, /* Wifi + LTE */
SKU_2_WIFI = 2, /* Wifi */
+ SKU_3_LTE_2CAM = 3, /* Wifi + LTE + dual camera */
+ SKU_4_WIFI_2CAM = 4, /* Wifi + dual camera */
};

struct gpio_with_delay {
@@ -63,6 +65,7 @@

switch (get_board_sku()) {
case SKU_1_LTE:
+ case SKU_3_LTE_2CAM:
power_off_lte_module(slp_typ);
return;
default:

To view, visit change 38730. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If86efe2a2f7b2e165ad44220b6dd59e9080b5892
Gerrit-Change-Number: 38730
Gerrit-PatchSet: 3
Gerrit-Owner: Kenneth Chan <kenneth.chan@quanta.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Henry Sun <henrysun@google.com>
Gerrit-Reviewer: Kenneth Chan <kenneth.chan@quanta.corp-partner.google.com>
Gerrit-Reviewer: Marco Chen <marcochen@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Ren Kuo <ren.kuo@quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged