coreboot-gerrit February 2020

coreboot-gerrit@coreboot.org

1 participants
1797 discussions

Change in coreboot[master]: cpu/x86/name: Making name.c file available in romstage
by Usha P (Code Review) 18 Feb '20

18 Feb '20

Usha P has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38940 ) Change subject: cpu/x86/name: Making name.c file available in romstage ...................................................................... cpu/x86/name: Making name.c file available in romstage In this patch name.c file that includes the definition for fill_processor_name which is used by the report_cpu_info function is been made available in romstage. This is done to facilitate the report_platform_info to be called from romstage, as the intension is to move the report_platform_info to romstage for all S0C's due to the bootblock size constraint. BUG=None TEST=Build and boot APL, GLK and CNL platforms. Change-Id: Ifd6d4b80c2e07d02adaed676a56efeb6fb704552 Signed-off-by: Usha P <usha.p(a)intel.com> --- M src/cpu/x86/name/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/38940/1 diff --git a/src/cpu/x86/name/Makefile.inc b/src/cpu/x86/name/Makefile.inc index 944c18f..02b5863 100644 --- a/src/cpu/x86/name/Makefile.inc +++ b/src/cpu/x86/name/Makefile.inc @@ -12,4 +12,5 @@ ## bootblock-y += name.c +romstage-y += name.c ramstage-y += name.c -- To view, visit https://review.coreboot.org/c/coreboot/+/38940 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd6d4b80c2e07d02adaed676a56efeb6fb704552 Gerrit-Change-Number: 38940 Gerrit-PatchSet: 1 Gerrit-Owner: Usha P <usha.p(a)intel.com> Gerrit-MessageType: newchange

4 5

Change in coreboot[master]: security/vboot: Correct help text of VBOOT_STARTS_IN_ROMSTAGE
by Yu-Ping Wu (Code Review) 18 Feb '20

18 Feb '20

Yu-Ping Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38900 ) Change subject: security/vboot: Correct help text of VBOOT_STARTS_IN_ROMSTAGE ...................................................................... security/vboot: Correct help text of VBOOT_STARTS_IN_ROMSTAGE Since CB:37231, the vboot working data has been replaced with vboot workbuf, so corrrect the help text of option VBOOT_STARTS_IN_ROMSTAGE accordingly. BRANCH=none BUG=chromium:1021452 TEST=none Change-Id: I80783274179ae7582bbb4c8f9d392895623badce Signed-off-by: Yu-Ping Wu <yupingso(a)google.com> --- M src/security/vboot/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/38900/1 diff --git a/src/security/vboot/Kconfig b/src/security/vboot/Kconfig index ea70e65..1f0fee7 100644 --- a/src/security/vboot/Kconfig +++ b/src/security/vboot/Kconfig @@ -114,8 +114,8 @@ depends on !VBOOT_STARTS_IN_BOOTBLOCK help Firmware verification happens during the end of romstage (after - memory initialization). This implies that vboot working data is - allocated in CBMEM. + memory initialization). This implies that vboot workbuf is allocated + in CBMEM. config VBOOT_MOCK_SECDATA bool "Mock secdata for firmware verification" -- To view, visit https://review.coreboot.org/c/coreboot/+/38900 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I80783274179ae7582bbb4c8f9d392895623badce Gerrit-Change-Number: 38900 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newchange

5 9

Change in coreboot[master]: nb/intel/sandybridge: Add Xeon E3-1200 (v1) hostbridge PCI ID
by Jonathan Kollasch (Code Review) 18 Feb '20

18 Feb '20

Jonathan Kollasch has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38865 ) Change subject: nb/intel/sandybridge: Add Xeon E3-1200 (v1) hostbridge PCI ID ...................................................................... nb/intel/sandybridge: Add Xeon E3-1200 (v1) hostbridge PCI ID Change-Id: I70187d09ecdaa8149299cdd8f6f8fc9517b05e15 Signed-off-by: Jonathan A. Kollasch <jakllsch(a)kollasch.net> --- M src/northbridge/intel/sandybridge/northbridge.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/38865/1 diff --git a/src/northbridge/intel/sandybridge/northbridge.c b/src/northbridge/intel/sandybridge/northbridge.c index a9b1c25..d679eaa 100644 --- a/src/northbridge/intel/sandybridge/northbridge.c +++ b/src/northbridge/intel/sandybridge/northbridge.c @@ -472,6 +472,12 @@ .device = 0x0104, /* Sandy bridge */ }; +static const struct pci_driver mc_driver_108 __pci_driver = { + .ops = &mc_ops, + .vendor = PCI_VENDOR_ID_INTEL, + .device = 0x0108, /* Sandy bridge */ +}; + static const struct pci_driver mc_driver_150 __pci_driver = { .ops = &mc_ops, .vendor = PCI_VENDOR_ID_INTEL, -- To view, visit https://review.coreboot.org/c/coreboot/+/38865 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70187d09ecdaa8149299cdd8f6f8fc9517b05e15 Gerrit-Change-Number: 38865 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Kollasch <jakllsch(a)kollasch.net> Gerrit-MessageType: newchange

5 8

Change in coreboot[master]: volteer: allow empty SPD_SOURCES
by Paul Fagerburg (Code Review) 18 Feb '20

18 Feb '20

Paul Fagerburg has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38902 ) Change subject: volteer: allow empty SPD_SOURCES ...................................................................... volteer: allow empty SPD_SOURCES Some Volteer variants might not use SPD files. Allow SPD_SOURCES in spd/Makefile.inc to be empty. BUG=None BRANCH=None TEST=Build coreboot and see that it builds without error Signed-off-by: Paul Fagerburg <pfagerburg(a)google.com> Change-Id: I5a8231b999e16503867d3c8df571b11fa0c1f6a6 --- M src/mainboard/google/volteer/spd/Makefile.inc 1 file changed, 3 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/38902/1 diff --git a/src/mainboard/google/volteer/spd/Makefile.inc b/src/mainboard/google/volteer/spd/Makefile.inc index c4b9e99..9f0106b 100644 --- a/src/mainboard/google/volteer/spd/Makefile.inc +++ b/src/mainboard/google/volteer/spd/Makefile.inc @@ -6,13 +6,10 @@ ## SPDX-License-Identifier: GPL-2.0-or-later ## +ifneq ($(SPD_SOURCES),) SPD_BIN = $(obj)/spd.bin -ifeq ($(SPD_SOURCES),) - SPD_DEPS := $(error SPD_SOURCES is not set. Variant must provide this) -else - SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/spd/$(f).spd.hex) -endif +SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/spd/$(f).spd.hex) # Include spd ROM data $(SPD_BIN): $(SPD_DEPS) @@ -25,3 +22,4 @@ cbfs-files-y += spd.bin spd.bin-file := $(SPD_BIN) spd.bin-type := spd +endif -- To view, visit https://review.coreboot.org/c/coreboot/+/38902 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5a8231b999e16503867d3c8df571b11fa0c1f6a6 Gerrit-Change-Number: 38902 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-MessageType: newchange

3 3

Change in coreboot[4.11_branch]: Makefile.inc: Ignore _HID & _ADR conflicts in Broadwell & Lynxpoint
by Angel Pons (Code Review) 18 Feb '20

18 Feb '20

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38959 ) Change subject: Makefile.inc: Ignore _HID & _ADR conflicts in Broadwell & Lynxpoint ...................................................................... Patch Set 2: > Patch Set 2: > > Builder for 4.10 & 4.11 branches is set up. It builds with the toolchain from that branch. Thanks! -- To view, visit https://review.coreboot.org/c/coreboot/+/38959 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: 4.11_branch Gerrit-Change-Id: Iced2e55e9f2aa7a262a5c1ffeff32af78acfa35e Gerrit-Change-Number: 38959 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 18 Feb 2020 09:40:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/block/lpc: create LPC_GET_DEV macro
by Subrata Banik (Code Review) 18 Feb '20

18 Feb '20

Subrata Banik has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/30209 ) Change subject: soc/intel/common/block/lpc: create LPC_GET_DEV macro ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/30209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I84a6102bf3849e9d4fe28e4c6a11bc7badcf5114 Gerrit-Change-Number: 30209 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: soc/intel/common/block/lpc: create LPC_GET_DEV macro
by Subrata Banik (Code Review) 18 Feb '20

18 Feb '20

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30209 ) Change subject: soc/intel/common/block/lpc: create LPC_GET_DEV macro ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/c/coreboot/+/30209/2/src/soc/intel/common/block… File src/soc/intel/common/block/lpc/lpc_lib.c: https://review.coreboot.org/c/coreboot/+/30209/2/src/soc/intel/common/block… PS2, Line 29: #if !defined(__SIMPLE_DEVICE__) : #include <device/device.h> : #define LPC_GET_DEV pcidev_on_root(PCH_DEV_SLOT_LPC, 0x0) : #else : #define LPC_GET_DEV PCH_DEV_LPC : #endif > > > > > Hence, avoids the need for any #if in platform code. > > > > > > > > FYI, this is soc code not the platform code. hatch, poppy are the platform code in my understanding. this is soc library. i was adhering old review comments from Arthur who has suggested to have a macro rather function names. > > > > > > Sorry, I don't know how you call things. To me, a platform in this > > > context is chipset + CPU. What I actually meant is #if outside of > > > src/include/device/. > > > > > > About Arthur's comments, they were for patch set 1 which looks much > > > differently. Also, the original problem patch set 1 tried to solve > > > was fixed in the meantime. There was > > > > > > #ifdef __SIMPLE_DEVICE__ > > > pci_devfn_t dev; > > > #else > > > struct device *dev; > > > #endif > > > > > > earlier, but isn't anymore. Which explains the commit message, maybe. > > > > i'm not very sure about that, Arthur's concern is still active herehttps://github.com/coreboot/coreboot/blob/master/src/soc/intel/common/b… > > Ok, that looks ugly, so? My shot at it: https://review.coreboot.org/c/coreboot/+/38946 yes, thanks, i was about to reach there after parking this CL but its good that you picked the problem. > > > > > and i was coping the same into this file, hence he has suggested to use macros rather function > > Are you sure he meant adding macros or maybe using the existing ones? > > > > Maybe let's back up and start with the problem you are trying to > > > solve? Is there anything you want to add to / change in this file > > > that isn't possible because of the `#define __SIMPLE_DEVICE__`? > > > > problem is having different macros for "dev". > > Inside pci_read_config16() function we are using PCH_DEV_LPC and https://review.coreboot.org/c/coreboot/+/30209/2/src/soc/intel/common/block… here we are using struct device * > > hence user has to have lots of knowledge about different use case inside croeboot, which i was trying to avoid and provide more abstraction > > I agree, but this has to be handled at a much lower level, in src/device/. > The coreboot infrastructure wasn't ready for the amount of code sharing > between stages as we have it today in soc/intel/. People added it never- > theless, so now we sit on a pile of technical debt. Agree, lets plan to fix this. in my opinion the more abstraction/wrapper over core codes (like src/device or cpu etc) are easy for developers to work without going into last level of details and see so many duplicate options to use. I hope we had good discussion and will abandon this CL -- To view, visit https://review.coreboot.org/c/coreboot/+/30209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I84a6102bf3849e9d4fe28e4c6a11bc7badcf5114 Gerrit-Change-Number: 30209 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 18 Feb 2020 04:06:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com> Comment-In-Reply-To: Aamir Bohra <aamir.bohra(a)intel.com> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in coreboot[4.11_branch]: Makefile.inc: Ignore _HID & _ADR conflicts in Broadwell & Lynxpoint
by Martin Roth (Code Review) 18 Feb '20

18 Feb '20

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38959 ) Change subject: Makefile.inc: Ignore _HID & _ADR conflicts in Broadwell & Lynxpoint ...................................................................... Patch Set 2: Builder for 4.10 & 4.11 branches is set up. It builds with the toolchain from that branch. -- To view, visit https://review.coreboot.org/c/coreboot/+/38959 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: 4.11_branch Gerrit-Change-Id: Iced2e55e9f2aa7a262a5c1ffeff32af78acfa35e Gerrit-Change-Number: 38959 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 18 Feb 2020 03:55:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[4.11_branch]: Makefile.inc: Adapt $(spc) definition
by Martin Roth (Code Review) 18 Feb '20

18 Feb '20

Martin Roth has uploaded a new patch set (#3) to the change originally created by Angel Pons. ( https://review.coreboot.org/c/coreboot/+/38958 ) Change subject: Makefile.inc: Adapt $(spc) definition ...................................................................... Makefile.inc: Adapt $(spc) definition GNU Make 4.3 is more picky about the $(spc) definition. It seems, the variable ends up empty. The old definition worked for nearly 8 years, RIP. Tested with GNU Make 4.2.1 and 4.3. Change-Id: I7981e0066b550251ae4a98d7b50e83049fc5586a Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/38790 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> (cherry picked from commit 0f6f70c3942c152c512b1aa51b6f6079a05e003b) --- M Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/38958/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/38958 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: 4.11_branch Gerrit-Change-Id: I7981e0066b550251ae4a98d7b50e83049fc5586a Gerrit-Change-Number: 38958 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Test commit
by Martin Roth (Code Review) 18 Feb '20

18 Feb '20

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38949 ) Change subject: Test commit ...................................................................... Test commit Signed-off-by: Martin Roth <martin(a)coreboot.org> Change-Id: Ide730f10b3468418157428ee62e7d4cd629586a9 --- M README.md 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/38949/1 diff --git a/README.md b/README.md index 14879c1..018ba72 100644 --- a/README.md +++ b/README.md @@ -102,3 +102,6 @@ Please check the individual source files for details. This makes the resulting coreboot images licensed under the GPL, version 2. + + +TESTING. -- To view, visit https://review.coreboot.org/c/coreboot/+/38949 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide730f10b3468418157428ee62e7d4cd629586a9 Gerrit-Change-Number: 38949 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: newchange

1 5

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2020