coreboot-gerrit December 2020

coreboot-gerrit@coreboot.org

1 participants
3168 discussions

Change in coreboot[master]: mb/clevo/l140cu: Remove unnecessary device declarations
by Michael Niewöhner (Code Review) 06 Dec '20

06 Dec '20

1 0

Change in coreboot[master]: mb/siemens/chili: Remove unnecessary device declarations
by Felix Singer (Code Review) 06 Dec '20

06 Dec '20

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48374 ) Change subject: mb/siemens/chili: Remove unnecessary device declarations ...................................................................... Patch Set 3: (2 comments) https://review.coreboot.org/c/coreboot/+/48374/2/src/mainboard/siemens/chil… File src/mainboard/siemens/chili/variants/base/devicetree.cb: https://review.coreboot.org/c/coreboot/+/48374/2/src/mainboard/siemens/chil… PS2, Line 75: device pci 00.0 on end # x1 i219 > on-board -> keep re-added these. https://review.coreboot.org/c/coreboot/+/48374/2/src/mainboard/siemens/chil… PS2, Line 82: device pci 00.0 on end # x1 i210 > on-board -> keep Done -- To view, visit https://review.coreboot.org/c/coreboot/+/48374 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I193aea7c92f340bd80a41a3777bcddc3f1339620 Gerrit-Change-Number: 48374 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Sun, 06 Dec 2020 13:09:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/clevo/l140cu: Remove unnecessary device declarations
by Felix Singer (Code Review) 06 Dec '20

06 Dec '20

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48373 ) Change subject: mb/clevo/l140cu: Remove unnecessary device declarations ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/c/coreboot/+/48373/2/src/mainboard/clevo/cml-u/… File src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb: https://review.coreboot.org/c/coreboot/+/48373/2/src/mainboard/clevo/cml-u/… PS2, Line 135: device pci 00.0 on end # x1 Card reader > setting subsystem ids and smbios depend on the flag `. […] re-added these devices. -- To view, visit https://review.coreboot.org/c/coreboot/+/48373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3aa3f72de764889becdb0afeb2dac522385d70ef Gerrit-Change-Number: 48373 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Sun, 06 Dec 2020 13:05:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/siemens/chili: Remove unnecessary device declarations
by Felix Singer (Code Review) 06 Dec '20

06 Dec '20

Hello build bot (Jenkins), Nico Huber, Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/48374 to look at the new patch set (#3). Change subject: mb/siemens/chili: Remove unnecessary device declarations ...................................................................... mb/siemens/chili: Remove unnecessary device declarations Change-Id: I193aea7c92f340bd80a41a3777bcddc3f1339620 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/siemens/chili/variants/base/devicetree.cb M src/mainboard/siemens/chili/variants/chili/devicetree.cb 2 files changed, 5 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/48374/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/48374 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I193aea7c92f340bd80a41a3777bcddc3f1339620 Gerrit-Change-Number: 48374 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/clevo/l140cu: Remove unnecessary device declarations
by Felix Singer (Code Review) 06 Dec '20

06 Dec '20

Hello build bot (Jenkins), Nico Huber, Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/48373 to look at the new patch set (#3). Change subject: mb/clevo/l140cu: Remove unnecessary device declarations ...................................................................... mb/clevo/l140cu: Remove unnecessary device declarations Remove unnecessary device declarations and remove comments where SMBIOS slot descriptions are used. Change-Id: I3aa3f72de764889becdb0afeb2dac522385d70ef Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/48373/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/48373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3aa3f72de764889becdb0afeb2dac522385d70ef Gerrit-Change-Number: 48373 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/supermicro/x11-lga1151-series: drop HAVE_ACPI_RESUME
by Michael Niewöhner (Code Review) 06 Dec '20

06 Dec '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48366 ) Change subject: mb/supermicro/x11-lga1151-series: drop HAVE_ACPI_RESUME ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/48366 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie75c9217078d38c42eba2b30c078b8bb1c2ca694 Gerrit-Change-Number: 48366 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 06 Dec 2020 12:54:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/clevo/l140cu: Remove unnecessary device declarations
by Michael Niewöhner (Code Review) 06 Dec '20

06 Dec '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48373 ) Change subject: mb/clevo/l140cu: Remove unnecessary device declarations ...................................................................... Patch Set 2: -Code-Review (2 comments) https://review.coreboot.org/c/coreboot/+/48373/2/src/mainboard/clevo/cml-u/… File src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb: https://review.coreboot.org/c/coreboot/+/48373/2/src/mainboard/clevo/cml-u/… PS2, Line 135: device pci 00.0 on end # x1 Card reader > this one is on-board, thus keep it setting subsystem ids and smbios depend on the flag `.on_mainboard`, which sconfig sets depending on presence of a device -> keep this one https://review.coreboot.org/c/coreboot/+/48373/2/src/mainboard/clevo/cml-u/… PS2, Line 135: # x1 Card reader PcieRpEnable will vanish; maybe add the comment above or as # PCI Express Port 6 (x1 Card reader)? -- To view, visit https://review.coreboot.org/c/coreboot/+/48373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3aa3f72de764889becdb0afeb2dac522385d70ef Gerrit-Change-Number: 48373 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 06 Dec 2020 12:12:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/siemens/chili: Remove unnecessary device declarations
by Michael Niewöhner (Code Review) 06 Dec '20

06 Dec '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48374 ) Change subject: mb/siemens/chili: Remove unnecessary device declarations ...................................................................... Patch Set 2: (2 comments) https://review.coreboot.org/c/coreboot/+/48374/2/src/mainboard/siemens/chil… File src/mainboard/siemens/chili/variants/base/devicetree.cb: https://review.coreboot.org/c/coreboot/+/48374/2/src/mainboard/siemens/chil… PS2, Line 75: device pci 00.0 on end # x1 i219 on-board -> keep https://review.coreboot.org/c/coreboot/+/48374/2/src/mainboard/siemens/chil… PS2, Line 82: device pci 00.0 on end # x1 i210 on-board -> keep -- To view, visit https://review.coreboot.org/c/coreboot/+/48374 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I193aea7c92f340bd80a41a3777bcddc3f1339620 Gerrit-Change-Number: 48374 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 06 Dec 2020 11:50:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/clevo/l140cu: Remove unnecessary device declarations
by Michael Niewöhner (Code Review) 06 Dec '20

06 Dec '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48373 ) Change subject: mb/clevo/l140cu: Remove unnecessary device declarations ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/c/coreboot/+/48373/2/src/mainboard/clevo/cml-u/… File src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb: https://review.coreboot.org/c/coreboot/+/48373/2/src/mainboard/clevo/cml-u/… PS2, Line 135: device pci 00.0 on end # x1 Card reader this one is on-board, thus keep it -- To view, visit https://review.coreboot.org/c/coreboot/+/48373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3aa3f72de764889becdb0afeb2dac522385d70ef Gerrit-Change-Number: 48373 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 06 Dec 2020 11:50:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/siemens/chili: Remove unnecessary device declarations
by Michael Niewöhner (Code Review) 06 Dec '20

06 Dec '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48374 ) Change subject: mb/siemens/chili: Remove unnecessary device declarations ...................................................................... Patch Set 2: Code-Review-1 not sure if that's a good idea -- To view, visit https://review.coreboot.org/c/coreboot/+/48374 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I193aea7c92f340bd80a41a3777bcddc3f1339620 Gerrit-Change-Number: 48374 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 06 Dec 2020 11:26:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2020