coreboot-gerrit November 2020

coreboot-gerrit@coreboot.org

1 participants
3243 discussions

Change in coreboot[master]: soc/intel/denverton_ns: Enable MC Exception
by Angel Pons (Code Review) 17 Nov '20

17 Nov '20

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25434 ) Change subject: soc/intel/denverton_ns: Enable MC Exception ...................................................................... Patch Set 19: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/25434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9773c61d06bb6c68612e498a35b5ad22cd5a8a6e Gerrit-Change-Number: 25434 Gerrit-PatchSet: 19 Gerrit-Owner: Julien Viard de Galbert <coreboot-review-ju(a)vdg.name> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Guckian <d.guckian20(a)gmail.com> Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Julien Viard de Galbert <coreboot-review-ju(a)vdg.name> Gerrit-Reviewer: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jay Talbott <JayTalbott(a)sysproconsulting.com> Gerrit-Comment-Date: Tue, 17 Nov 2020 22:36:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in em100[master]: Update to use upstream version 4.3.12
by Stefan Reinauer (Code Review) 17 Nov '20

17 Nov '20

Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/47646 ) Change subject: Update to use upstream version 4.3.12 ...................................................................... Update to use upstream version 4.3.12 The EM100Pro/EM100Pro-G2 Software package was updated by Dediprog to 4.3.12 on 2020-11-13 13:41:05. Upstream 4.3.12 is using the original download slot again, adjust the makechips.sh script. Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Change-Id: I310f34d493569d7b887873a277e22cda325d8049 --- M makechips.sh 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/em100 refs/changes/46/47646/1 diff --git a/makechips.sh b/makechips.sh index 8a2d901..b4c43d0 100755 --- a/makechips.sh +++ b/makechips.sh @@ -12,8 +12,7 @@ # GNU General Public License for more details. # -URL="https://www.dediprog.com/download/save/1145.msi" -VURL="https://www.dediprog.com/download?productCategory=SPI+Flash+Solution&produc…" +URL="https://www.dediprog.com/download/save/78.msi" if ! which curl > /dev/null; then echo "Install curl to run this script." -- To view, visit https://review.coreboot.org/c/em100/+/47646 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: I310f34d493569d7b887873a277e22cda325d8049 Gerrit-Change-Number: 47646 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newchange

2 2

Change in em100[master]: makedpfw: Clean up include files
by Stefan Reinauer (Code Review) 17 Nov '20

17 Nov '20

Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/47645 ) Change subject: makedpfw: Clean up include files ...................................................................... makedpfw: Clean up include files Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Change-Id: I21afd69e42d12c6545c09adbf7a1b8ee60fee80d --- M makedpfw.c 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/em100 refs/changes/45/47645/1 diff --git a/makedpfw.c b/makedpfw.c index eaa85a0..a09d132 100644 --- a/makedpfw.c +++ b/makedpfw.c @@ -13,11 +13,8 @@ #include <stdio.h> #include <stdint.h> -#include <sys/types.h> #include <sys/stat.h> -#include <unistd.h> #include <getopt.h> -#include <errno.h> #include <string.h> #include <stdlib.h> -- To view, visit https://review.coreboot.org/c/em100/+/47645 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: I21afd69e42d12c6545c09adbf7a1b8ee60fee80d Gerrit-Change-Number: 47645 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newchange

2 2

Change in coreboot[master]: Documentation: Update release notes for Denverton NS deprecation
by Julien Viard de Galbert (Code Review) 17 Nov '20

17 Nov '20

Julien Viard de Galbert has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47539 ) Change subject: Documentation: Update release notes for Denverton NS deprecation ...................................................................... Patch Set 1: I can only help maintaining it as a hobbyist, my day job is no longer to work on that port. Also it seams that denverton EDS is no longer public, the link on Intel returns only the spec update, so I no longer have access to the full specifications. I can update code and patches from time to time, test it on one 'scaleway/tagada' board, but without help from Intel, it will be hard to maintain the port. -- To view, visit https://review.coreboot.org/c/coreboot/+/47539 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0a6df3f3e640d1316e9cc2dbe244ea63c3a24dfa Gerrit-Change-Number: 47539 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julien Viard de Galbert <coreboot-review-ju(a)vdg.name> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: Дмитрий Понаморев <dponamorev(a)gmail.com> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Tue, 17 Nov 2020 22:25:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Makefile: Write .xcompile to $(obj)
by Stefan Reinauer (Code Review) 17 Nov '20

17 Nov '20

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28101 ) Change subject: Makefile: Write .xcompile to $(obj) ...................................................................... Patch Set 10: Code-Review+1 This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/28101 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia83f234447b977efa824751c9674154b77d606b0 Gerrit-Change-Number: 28101 Gerrit-PatchSet: 10 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Raul Rangel <rrangel(a)google.com> Gerrit-Comment-Date: Tue, 17 Nov 2020 22:17:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [DONOTSUBMIT] for testing only: use both gpio conf function and compa...
by Julien Viard de Galbert (Code Review) 17 Nov '20

17 Nov '20

Julien Viard de Galbert has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/24929 ) Change subject: [DONOTSUBMIT] for testing only: use both gpio conf function and compare logs ;) ...................................................................... Abandoned This was for testing only and the related patches are merged. -- To view, visit https://review.coreboot.org/c/coreboot/+/24929 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I882c851bf8e07ed1a602d631bd387c204994b1c6 Gerrit-Change-Number: 24929 Gerrit-PatchSet: 3 Gerrit-Owner: Julien Viard de Galbert <coreboot-review-ju(a)vdg.name> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: soc/intel/tigerlake: Define TCSS AUX pin bias control
by Tim Wawrzynczak (Code Review) 17 Nov '20

17 Nov '20

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47653 ) Change subject: soc/intel/tigerlake: Define TCSS AUX pin bias control ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/coreboot/+/47653/1/src/soc/intel/tigerlake/in… File src/soc/intel/tigerlake/include/soc/early_tcss.h: https://review.coreboot.org/c/coreboot/+/47653/1/src/soc/intel/tigerlake/in… PS1, Line 103: 0x09000000 > for the GPIO pins this is how FSP has them defined and what it is expecting. see FspsUpd. […] I see, it's a chipset-specific constant, thanks Brandon! Caveh, how about a `#define TGL_LP_GPIO_ID 0x09000000` instead? -- To view, visit https://review.coreboot.org/c/coreboot/+/47653 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I001aede139c2503ce9cae3af8d625624ff6e1af7 Gerrit-Change-Number: 47653 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 17 Nov 2020 21:17:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Caveh Jalali <caveh(a)chromium.org> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer/v/volteer2: Config for passive USB-C DB on C1
by Paul Menzel (Code Review) 17 Nov '20

17 Nov '20

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47501 ) Change subject: mb/google/volteer/v/volteer2: Config for passive USB-C DB on C1 ...................................................................... Patch Set 7: (1 comment) https://review.coreboot.org/c/coreboot/+/47501/7//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/47501/7//COMMIT_MSG@7 PS7, Line 7: Config for passive USB-C DB on C1 Plesae make it a statement by adding a verb (in imperative mood): > Add config for passive USB-C DB on C1 > Integrate passive USB-C DB on C1 -- To view, visit https://review.coreboot.org/c/coreboot/+/47501 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id9939450213bac4c0d661759bef2f38f3fd3af76 Gerrit-Change-Number: 47501 Gerrit-PatchSet: 7 Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 17 Nov 2020 21:10:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/tigerlake: Define TCSS AUX pin bias control
by Brandon Breitenstein (Code Review) 17 Nov '20

17 Nov '20

Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47653 ) Change subject: soc/intel/tigerlake: Define TCSS AUX pin bias control ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/coreboot/+/47653/1/src/soc/intel/tigerlake/in… File src/soc/intel/tigerlake/include/soc/early_tcss.h: https://review.coreboot.org/c/coreboot/+/47653/1/src/soc/intel/tigerlake/in… PS1, Line 103: 0x09000000 > @brandon.breitenstein@intel.com […] for the GPIO pins this is how FSP has them defined and what it is expecting. see FspsUpd.h and reference the GpioPinsTGLH.h file in FSP -- To view, visit https://review.coreboot.org/c/coreboot/+/47653 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I001aede139c2503ce9cae3af8d625624ff6e1af7 Gerrit-Change-Number: 47653 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 17 Nov 2020 21:08:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Caveh Jalali <caveh(a)chromium.org> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/skylake: Use correct NHLT_PDM_DEV definition
by Benjamin Doron (Code Review) 17 Nov '20

17 Nov '20

Hello build bot (Jenkins), Matt DeVillier, Angel Pons, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/45010 to look at the new patch set (#8). Change subject: soc/intel/skylake: Use correct NHLT_PDM_DEV definition ...................................................................... soc/intel/skylake: Use correct NHLT_PDM_DEV definition According to the NHLT specification[1], PDM_DEV is defined as "1" on Kabylake based platforms. coreboot currently sets it to "0" on all platforms. Add an entry to the enum and use it to define NHLT_PDM_DEV for Kabylake. "Device Type" will resume from "2" on all platforms, but entries are currently reserved. Tested on an Acer Aspire VN7-572G (Skylake-U), which has a 1ch array DMIC, on Windows 10. 1. https://01.org/sites/default/files/595976_intel_sst_nhlt.pdf Change-Id: Ifbc67228c9e7af7db5154d597ca8d67860cfd2ed Signed-off-by: Benjamin Doron <benjamin.doron00(a)gmail.com> --- M src/include/nhlt.h M src/soc/intel/skylake/nhlt/dmic.c 2 files changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/45010/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/45010 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifbc67228c9e7af7db5154d597ca8d67860cfd2ed Gerrit-Change-Number: 45010 Gerrit-PatchSet: 8 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2020