coreboot-gerrit November 2020

coreboot-gerrit@coreboot.org

1 participants
3243 discussions

Change in coreboot[master]: soc/intel/skl: correct OC pin skip value for disabled usb ports
by Felix Singer (Code Review) 25 Nov '20

25 Nov '20

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48003 ) Change subject: soc/intel/skl: correct OC pin skip value for disabled usb ports ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/c/coreboot/+/48003/1//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/48003/1//COMMIT_MSG@10 PS1, Line 10: a nit: an https://review.coreboot.org/c/coreboot/+/48003/1//COMMIT_MSG@12 PS1, Line 12: macro nit: actually, it's an enum -- To view, visit https://review.coreboot.org/c/coreboot/+/48003 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41a8df3dce3712b4ab27c4e6e10160b2207406d1 Gerrit-Change-Number: 48003 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 25 Nov 2020 17:22:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: 3rdparty/vboot: Update to latest master
by Patrick Georgi (Code Review) 25 Nov '20

25 Nov '20

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47906 ) Change subject: 3rdparty/vboot: Update to latest master ...................................................................... 3rdparty/vboot: Update to latest master This brings in changes to make vboot compile with gcc 4.9 Change-Id: I64f27f346df264cb6eeeb4e3203fcca7d35f7e83 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M 3rdparty/vboot 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/47906/1 diff --git a/3rdparty/vboot b/3rdparty/vboot index 9d4053d..edd2224 160000 --- a/3rdparty/vboot +++ b/3rdparty/vboot @@ -1 +1 @@ -Subproject commit 9d4053df76c127f625a8571d3ef16e6a063c8de5 +Subproject commit edd222428715125b9ef2a9a8a064fc32a0d0bd24 -- To view, visit https://review.coreboot.org/c/coreboot/+/47906 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I64f27f346df264cb6eeeb4e3203fcca7d35f7e83 Gerrit-Change-Number: 47906 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

2 5

Change in coreboot[master]: drivers/intel/fsp2_0: move the FSP FD PATH option down in menuconfig
by Michael Niewöhner (Code Review) 25 Nov '20

25 Nov '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47999 ) Change subject: drivers/intel/fsp2_0: move the FSP FD PATH option down in menuconfig ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/c/coreboot/+/47999/2/src/drivers/intel/fsp2_0/K… File src/drivers/intel/fsp2_0/Kconfig: https://review.coreboot.org/c/coreboot/+/47999/2/src/drivers/intel/fsp2_0/K… PS2, Line 85: config FSP_FD_PATH : string "Location of FSP FD file" if FSP_FULL_FD && !FSP_USE_REPO : help : Path to the FSP FD file that contains the individual FSP-T, FSP-M : and FSP-S binaries. The file gets split at build-time. : : config FSP_FD_PATH : string "Location of FSP FD file" if FSP_FULL_FD && !FSP_USE_REPO : help : Path to the FSP FD file that contains the individual FSP-T, FSP-M : and FSP-S binaries. > Something went wrong during rebase, it seems? lol yeah, fixed -- To view, visit https://review.coreboot.org/c/coreboot/+/47999 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie03a418fab30a908d020abf94becbaedf54fbb99 Gerrit-Change-Number: 47999 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 25 Nov 2020 16:05:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: move the FSP FD PATH option down in menuconfig
by Michael Niewöhner (Code Review) 25 Nov '20

25 Nov '20

Hello build bot (Jenkins), Nico Huber, Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Subrata Banik, Andrey Petrov, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/47999 to look at the new patch set (#3). Change subject: drivers/intel/fsp2_0: move the FSP FD PATH option down in menuconfig ...................................................................... drivers/intel/fsp2_0: move the FSP FD PATH option down in menuconfig Move the FSP FD PATH option down, so it gets shown in-place instead of the split FD files, when the users chooses to use a full FD binary. Change-Id: Ie03a418fab30a908d020abf94becbaedf54fbb99 Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/drivers/intel/fsp2_0/Kconfig 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/47999/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/47999 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie03a418fab30a908d020abf94becbaedf54fbb99 Gerrit-Change-Number: 47999 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: introduce possibility of using a full FD binary
by Michael Niewöhner (Code Review) 25 Nov '20

25 Nov '20

Hello build bot (Jenkins), Nico Huber, Furquan Shaikh, Patrick Georgi, Martin Roth, Paul Menzel, Tim Wawrzynczak, Subrata Banik, Andrey Petrov, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/47993 to look at the new patch set (#6). Change subject: drivers/intel/fsp2_0: introduce possibility of using a full FD binary ...................................................................... drivers/intel/fsp2_0: introduce possibility of using a full FD binary Currently, setting a custom FSP binary is only possible by using split FSP-T/M/S FD files. This change introduces the possibility to pass a combined FD file (the "standard" FSP format). This is done by adding a new boolean Kconfig FSP_FULL_FD, specifying that the FSP is a single FD file instead of split FSP-T/M/S FD files, and making FSP_FD_PATH user-visible when the option is chosen. In this case, the other options for split files get hidden. When the user chooses to use a full FD file instead of the split ones, the FD file gets split during build, just like it is done when selecting the Github FSP repo (FSP_USE_REPO). Test: Supermicro X11SSM-F builds and boots fine with custom FSP FD set. Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> Change-Id: I1cb98c1ff319823a2a8a95444c9b4f3d96162a02 --- M src/drivers/intel/fsp2_0/Kconfig M src/drivers/intel/fsp2_0/Makefile.inc 2 files changed, 17 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/47993/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/47993 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1cb98c1ff319823a2a8a95444c9b4f3d96162a02 Gerrit-Change-Number: 47993 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/crossgcc: curl must write downloaded bytes to a file
by Idwer Vollering (Code Review) 25 Nov '20

25 Nov '20

Idwer Vollering has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47911 ) Change subject: util/crossgcc: curl must write downloaded bytes to a file ...................................................................... util/crossgcc: curl must write downloaded bytes to a file How curl would behave has been changed, and broken, in commit 82a30a134c. Signed-off-by: Idwer Vollering <vidwer(a)gmail.com> Change-Id: I0d946b86baad3f6409a5042701808da307e5bcb7 --- M util/crossgcc/buildgcc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/47911/1 diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index bba8ac7..01c4f86 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -1066,7 +1066,7 @@ download_showing_percentage() { url=$1 echo - curl --progress-bar --location --retry 3 "$url" + curl -O --progress-bar --location --retry 3 "$url" } fi -- To view, visit https://review.coreboot.org/c/coreboot/+/47911 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d946b86baad3f6409a5042701808da307e5bcb7 Gerrit-Change-Number: 47911 Gerrit-PatchSet: 1 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-MessageType: newchange

3 6

Change in coreboot[master]: soc/intel/skl: correct OC pin skip value for disabled usb ports
by Michael Niewöhner (Code Review) 25 Nov '20

25 Nov '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48003 ) Change subject: soc/intel/skl: correct OC pin skip value for disabled usb ports ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/48003 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41a8df3dce3712b4ab27c4e6e10160b2207406d1 Gerrit-Change-Number: 48003 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Wed, 25 Nov 2020 15:47:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: move the FSP FD PATH option down in menuconfig
by Nico Huber (Code Review) 25 Nov '20

25 Nov '20

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47999 ) Change subject: drivers/intel/fsp2_0: move the FSP FD PATH option down in menuconfig ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/c/coreboot/+/47999/2/src/drivers/intel/fsp2_0/K… File src/drivers/intel/fsp2_0/Kconfig: https://review.coreboot.org/c/coreboot/+/47999/2/src/drivers/intel/fsp2_0/K… PS2, Line 85: config FSP_FD_PATH : string "Location of FSP FD file" if FSP_FULL_FD && !FSP_USE_REPO : help : Path to the FSP FD file that contains the individual FSP-T, FSP-M : and FSP-S binaries. The file gets split at build-time. : : config FSP_FD_PATH : string "Location of FSP FD file" if FSP_FULL_FD && !FSP_USE_REPO : help : Path to the FSP FD file that contains the individual FSP-T, FSP-M : and FSP-S binaries. Something went wrong during rebase, it seems? -- To view, visit https://review.coreboot.org/c/coreboot/+/47999 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie03a418fab30a908d020abf94becbaedf54fbb99 Gerrit-Change-Number: 47999 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 25 Nov 2020 15:37:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: introduce possibility of using a full FD binary
by Michael Niewöhner (Code Review) 25 Nov '20

25 Nov '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47993 ) Change subject: drivers/intel/fsp2_0: introduce possibility of using a full FD binary ...................................................................... Patch Set 5: (2 comments) https://review.coreboot.org/c/coreboot/+/47993/4/src/drivers/intel/fsp2_0/K… File src/drivers/intel/fsp2_0/Kconfig: https://review.coreboot.org/c/coreboot/+/47993/4/src/drivers/intel/fsp2_0/K… PS4, Line 60: !FSP_USE_REPO > Why did this change to !FSP_USE_REPO? Only the string changed, that means, FSP_FD_PATH gets hidden in menuconfig, when FSP_USE_REPO is selected. Before it was not shown at all, so for !FSP_USE_REPO the behaviour does not change. https://review.coreboot.org/c/coreboot/+/47993/4/src/drivers/intel/fsp2_0/K… PS4, Line 88: Use a combined FSP FD file instead of individual, split binaries. > Probably say that this takes as input a combined FSP FD file instead of individual, split binaries a […] Not completely correct. FSP_FULL_FD is a boolean. The file then needs to be set in FSP_FD_PATH. Since selecting FSP_FULL_FD then shows FSP_FD_PATH with its help text "Path to the FSP FD file that contains the individual FSP-T, FSP-M and FSP-S binaries.", I don't think we should add this redundant information here again. I have added that part about splitting at runtime to both, though. -- To view, visit https://review.coreboot.org/c/coreboot/+/47993 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1cb98c1ff319823a2a8a95444c9b4f3d96162a02 Gerrit-Change-Number: 47993 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 25 Nov 2020 15:34:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: introduce possibility of using a full FD binary
by Michael Niewöhner (Code Review) 25 Nov '20

25 Nov '20

Hello build bot (Jenkins), Nico Huber, Furquan Shaikh, Patrick Georgi, Martin Roth, Paul Menzel, Tim Wawrzynczak, Subrata Banik, Andrey Petrov, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/47993 to look at the new patch set (#5). Change subject: drivers/intel/fsp2_0: introduce possibility of using a full FD binary ...................................................................... drivers/intel/fsp2_0: introduce possibility of using a full FD binary Currently, setting a custom FSP binary is only possible by using split FSP-T/M/S FD files. This change introduces the possibility to pass a combined FD file (the "standard" FSP format). This is done by adding a new boolean Kconfig FSP_FULL_FD, specifying that the FSP is a single FD file instead of split FSP-T/M/S FD files, and making FSP_FD_PATH user-visible when the option is chosen. In this case, the other options for split files get hidden. When the user chooses to use a full FD file instead of the split ones, the FD file gets split during build, just like it is done when selecting the Github FSP repo (FSP_USE_REPO). Test: Supermicro X11SSM-F builds and boots fine with custom FSP FD set. Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> Change-Id: I1cb98c1ff319823a2a8a95444c9b4f3d96162a02 --- M src/drivers/intel/fsp2_0/Kconfig M src/drivers/intel/fsp2_0/Makefile.inc 2 files changed, 21 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/47993/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/47993 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1cb98c1ff319823a2a8a95444c9b4f3d96162a02 Gerrit-Change-Number: 47993 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2020