coreboot-gerrit November 2020

coreboot-gerrit@coreboot.org

1 participants
3243 discussions

Change in coreboot[master]: soc/intel/skl: correct OC pin skip value for disabled usb ports
by Tim Wawrzynczak (Code Review) 25 Nov '20

25 Nov '20

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48003 ) Change subject: soc/intel/skl: correct OC pin skip value for disabled usb ports ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/c/coreboot/+/48003/2/src/soc/intel/skylake/chip… File src/soc/intel/skylake/chip.c: https://review.coreboot.org/c/coreboot/+/48003/2/src/soc/intel/skylake/chip… PS2, Line 160: if (config->usb3_ports[i].enable) { : params->Usb3OverCurrentPin[i] = config->usb3_ports[i].ocpin; : } else { : params->Usb3OverCurrentPin[i] = OC_SKIP; : } while you're here, get rid of the extra curly braces here? not req'd for single-statement if/else -- To view, visit https://review.coreboot.org/c/coreboot/+/48003 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41a8df3dce3712b4ab27c4e6e10160b2207406d1 Gerrit-Change-Number: 48003 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 25 Nov 2020 20:48:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: move the FSP FD PATH option down in menuconfig
by Michael Niewöhner (Code Review) 25 Nov '20

25 Nov '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47999 ) Change subject: drivers/intel/fsp2_0: move the FSP FD PATH option down in menuconfig ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/c/coreboot/+/47999/3//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/47999/3//COMMIT_MSG@9 PS3, Line 9: in-place instead of > Well, that's already the case even without that change. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/47999 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie03a418fab30a908d020abf94becbaedf54fbb99 Gerrit-Change-Number: 47999 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 25 Nov 2020 20:05:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: move the FSP FD PATH option down in menuconfig
by Michael Niewöhner (Code Review) 25 Nov '20

25 Nov '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47999 ) Change subject: drivers/intel/fsp2_0: move the FSP FD PATH option down in menuconfig ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/c/coreboot/+/47999/3//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/47999/3//COMMIT_MSG@9 PS3, Line 9: in-place instead of > no worries, "in place of" is like "instead of" or "as a substitute for". […] Well, that's already the case even without that change. But it definitely sounds better than "in-place instead of" -- To view, visit https://review.coreboot.org/c/coreboot/+/47999 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie03a418fab30a908d020abf94becbaedf54fbb99 Gerrit-Change-Number: 47999 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 25 Nov 2020 20:05:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: move the FSP FD PATH option down in menuconfig
by Michael Niewöhner (Code Review) 25 Nov '20

25 Nov '20

Hello build bot (Jenkins), Nico Huber, Furquan Shaikh, Tim Wawrzynczak, Paul Menzel, Subrata Banik, Andrey Petrov, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/47999 to look at the new patch set (#4). Change subject: drivers/intel/fsp2_0: move the FSP FD PATH option down in menuconfig ...................................................................... drivers/intel/fsp2_0: move the FSP FD PATH option down in menuconfig Move the FSP FD PATH option down, so it gets shown in place of the split FD files, when the users chooses to use a full FD binary. Change-Id: Ie03a418fab30a908d020abf94becbaedf54fbb99 Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/drivers/intel/fsp2_0/Kconfig 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/47999/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/47999 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie03a418fab30a908d020abf94becbaedf54fbb99 Gerrit-Change-Number: 47999 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: move the FSP FD PATH option down in menuconfig
by Tim Wawrzynczak (Code Review) 25 Nov '20

25 Nov '20

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47999 ) Change subject: drivers/intel/fsp2_0: move the FSP FD PATH option down in menuconfig ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/c/coreboot/+/47999/3//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/47999/3//COMMIT_MSG@9 PS3, Line 9: in-place instead of > well, what I wanted to say is that it's on the very same position. […] no worries, "in place of" is like "instead of" or "as a substitute for". IOW, if you select this, you will see this option instead of the options for the split FD files -- To view, visit https://review.coreboot.org/c/coreboot/+/47999 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie03a418fab30a908d020abf94becbaedf54fbb99 Gerrit-Change-Number: 47999 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 25 Nov 2020 20:01:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: move the FSP FD PATH option down in menuconfig
by Michael Niewöhner (Code Review) 25 Nov '20

25 Nov '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47999 ) Change subject: drivers/intel/fsp2_0: move the FSP FD PATH option down in menuconfig ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/c/coreboot/+/47999/3//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/47999/3//COMMIT_MSG@9 PS3, Line 9: in-place instead of > "in place of" ? well, what I wanted to say is that it's on the very same position. Non-native here and I'm unsure if "in place of" is really the same as "in-place" 😄 -- To view, visit https://review.coreboot.org/c/coreboot/+/47999 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie03a418fab30a908d020abf94becbaedf54fbb99 Gerrit-Change-Number: 47999 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 25 Nov 2020 19:56:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: move the FSP FD PATH option down in menuconfig
by Tim Wawrzynczak (Code Review) 25 Nov '20

25 Nov '20

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: move the FSP FD PATH option down in menuconfig
by Tim Wawrzynczak (Code Review) 25 Nov '20

25 Nov '20

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47999 ) Change subject: drivers/intel/fsp2_0: move the FSP FD PATH option down in menuconfig ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/c/coreboot/+/47999/3//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/47999/3//COMMIT_MSG@9 PS3, Line 9: in-place instead of "in place of" ? -- To view, visit https://review.coreboot.org/c/coreboot/+/47999 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie03a418fab30a908d020abf94becbaedf54fbb99 Gerrit-Change-Number: 47999 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 25 Nov 2020 19:46:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: introduce possibility of using a full FD binary
by Tim Wawrzynczak (Code Review) 25 Nov '20

25 Nov '20

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47993 ) Change subject: drivers/intel/fsp2_0: introduce possibility of using a full FD binary ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/47993 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1cb98c1ff319823a2a8a95444c9b4f3d96162a02 Gerrit-Change-Number: 47993 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 25 Nov 2020 19:45:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: volteer/variants/eldrid: usb2_ports register tuning
by Nick Chen (Code Review) 25 Nov '20

25 Nov '20

Nick Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47863 ) Change subject: volteer/variants/eldrid: usb2_ports register tuning ...................................................................... volteer/variants/eldrid: usb2_ports register tuning 1. Disable M.2 WWAN and Type-A Port A1 2. Change register 4 to 3 and tuning USB2 Port1 eye diagram 3. Lower camera driving BUG=b:169105751 Signed-off-by: Nick Chen <nick_xr_chen(a)wistron.corp-partner.google.com> Change-Id: I6b8a5c0d5e814de232d79a43354f5ec0220fc5ea --- M src/mainboard/google/volteer/variants/eldrid/overridetree.cb 1 file changed, 14 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/47863/1 diff --git a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb index 72571c0..b84848c 100644 --- a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb +++ b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb @@ -58,12 +58,22 @@ }, }, }" - #These settings improve the USB2 Port1 eye diagram + + #Disable Type-A Port A1 + register "usb2_ports[1]" = "USB2_PORT_EMPTY" + + #Disable M.2 WWAN + register "usb2_ports[2]" = "USB2_PORT_EMPTY" + + #improve the USB2 Port1 eye diagram + register "usb2_ports[3]" = "USB2_PORT_SHORT(OC_SKIP)" + + #lower camera driving register "usb2_ports[4]" = "{ .enable = 1, - .tx_bias = 7, - .tx_emp_enable = 7, - .pre_emp_bias = 3, + .tx_bias = 0, + .tx_emp_enable = 0, + .pre_emp_bias = 0, .pre_emp_bit = 0, }" -- To view, visit https://review.coreboot.org/c/coreboot/+/47863 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b8a5c0d5e814de232d79a43354f5ec0220fc5ea Gerrit-Change-Number: 47863 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Chen <nick_xr_chen(a)wistron.corp-partner.google.com> Gerrit-MessageType: newchange

5 12

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2020