coreboot-gerrit November 2020

coreboot-gerrit@coreboot.org

1 participants
3243 discussions

Change in coreboot[master]: soc/intel/alderlake: Add lp5_ccc_config to the board memory configura...
by Angel Pons (Code Review) 26 Nov '20

26 Nov '20

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47436 ) Change subject: soc/intel/alderlake: Add lp5_ccc_config to the board memory configuration ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/c/coreboot/+/47436/4/src/soc/intel/alderlake/in… File src/soc/intel/alderlake/include/soc/meminit.h: https://review.coreboot.org/c/coreboot/+/47436/4/src/soc/intel/alderlake/in… PS4, Line 96: CCC What does CCC stand for? CA, CTL, CLK? -- To view, visit https://review.coreboot.org/c/coreboot/+/47436 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I24b1cf50c1b0b945fce75239bac38e40aeb8a83a Gerrit-Change-Number: 47436 Gerrit-PatchSet: 4 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 26 Nov 2020 09:00:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlp: Add support for LPDDR5
by Angel Pons (Code Review) 26 Nov '20

26 Nov '20

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46899 ) Change subject: mb/intel/adlp: Add support for LPDDR5 ...................................................................... Patch Set 12: (1 comment) https://review.coreboot.org/c/coreboot/+/46899/12//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/46899/12//COMMIT_MSG@7 PS12, Line 7: adlp adlrvp ? -- To view, visit https://review.coreboot.org/c/coreboot/+/46899 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I787bf97dd6c244bd3b0662e5bd061a2da80baa90 Gerrit-Change-Number: 46899 Gerrit-PatchSet: 12 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Balaji Manigandan <balaji.bmg(a)gmail.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 26 Nov 2020 08:51:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/ocp/deltalake: Configure GPIO
by build bot (Jenkins) (Code Review) 26 Nov '20

26 Nov '20

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47229 ) Change subject: mb/ocp/deltalake: Configure GPIO ...................................................................... Patch Set 7: (98 comments) https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… File src/mainboard/ocp/deltalake/include/cpxsp_dl_gpio.h: https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 12: _PAD_CFG_STRUCT(GPP_A0, PAD_FUNC(NF3) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 14: _PAD_CFG_STRUCT(GPP_A1, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 16: _PAD_CFG_STRUCT(GPP_A2, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF), 0), /* LAD1 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 17: _PAD_CFG_STRUCT(GPP_A3, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 19: _PAD_CFG_STRUCT(GPP_A4, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 21: _PAD_CFG_STRUCT(GPP_A5, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 23: _PAD_CFG_STRUCT(GPP_A6, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 25: _PAD_CFG_STRUCT(GPP_A7, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 27: _PAD_CFG_STRUCT(GPP_A8, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF), 0), /* CLKRUN# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 28: _PAD_CFG_STRUCT(GPP_A9, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 31: _PAD_CFG_STRUCT(GPP_A11, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 33: _PAD_CFG_STRUCT(GPP_A12, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 35: _PAD_CFG_STRUCT(GPP_A13, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 38: _PAD_CFG_STRUCT(GPP_A15, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 52: _PAD_CFG_STRUCT(GPP_B2, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 54: _PAD_CFG_STRUCT(GPP_B3, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 56: _PAD_CFG_STRUCT(GPP_B4, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 58: _PAD_CFG_STRUCT(GPP_B5, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 60: _PAD_CFG_STRUCT(GPP_B6, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 64: _PAD_CFG_STRUCT(GPP_B9, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 68: _PAD_CFG_STRUCT(GPP_B12, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 70: _PAD_CFG_STRUCT(GPP_B13, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 72: _PAD_CFG_STRUCT(GPP_B14, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 74: _PAD_CFG_STRUCT(GPP_B15, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 76: _PAD_CFG_STRUCT(GPP_B16, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 78: _PAD_CFG_STRUCT(GPP_B17, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 80: _PAD_CFG_STRUCT(GPP_B18, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 85: _PAD_CFG_STRUCT(GPP_B22, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 87: _PAD_CFG_STRUCT(GPP_B23, PAD_FUNC(NF2) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 91: _PAD_CFG_STRUCT(GPP_F0, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 93: _PAD_CFG_STRUCT(GPP_F1, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 95: _PAD_CFG_STRUCT(GPP_F2, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 97: _PAD_CFG_STRUCT(GPP_F3, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 99: _PAD_CFG_STRUCT(GPP_F4, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 101: _PAD_CFG_STRUCT(GPP_F5, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 106: _PAD_CFG_STRUCT(GPP_F9, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 127: _PAD_CFG_STRUCT(GPP_C2, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 131: _PAD_CFG_STRUCT(GPP_C5, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 135: _PAD_CFG_STRUCT(GPP_C8, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 140: _PAD_CFG_STRUCT(GPP_C12, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 142: _PAD_CFG_STRUCT(GPP_C13, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 144: _PAD_CFG_STRUCT(GPP_C14, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 150: _PAD_CFG_STRUCT(GPP_C19, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 153: _PAD_CFG_STRUCT(GPP_C21, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 155: _PAD_CFG_STRUCT(GPP_C22, PAD_RESET(RSMRST) | PAD_IRQ_ROUTE(SMI) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 157: _PAD_CFG_STRUCT(GPP_C23, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 187: _PAD_CFG_STRUCT(GPP_E0, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 189: _PAD_CFG_STRUCT(GPP_E1, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 191: _PAD_CFG_STRUCT(GPP_E2, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 193: _PAD_CFG_STRUCT(GPP_E3, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 198: _PAD_CFG_STRUCT(GPP_E7, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 201: _PAD_CFG_STRUCT(GPP_E9, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 213: _PAD_CFG_STRUCT(GPD3, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 215: _PAD_CFG_STRUCT(GPD4, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 217: _PAD_CFG_STRUCT(GPD5, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 219: _PAD_CFG_STRUCT(GPD6, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 224: _PAD_CFG_STRUCT(GPD10, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 226: _PAD_CFG_STRUCT(GPD11, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 239: _PAD_CFG_STRUCT(GPP_I8, PAD_FUNC(NF2) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 241: _PAD_CFG_STRUCT(GPP_I9, PAD_FUNC(NF2) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 280: _PAD_CFG_STRUCT(GPP_K7, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 282: _PAD_CFG_STRUCT(GPP_K8, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 284: _PAD_CFG_STRUCT(GPP_K9, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 286: _PAD_CFG_STRUCT(GPP_K10, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 303: _PAD_CFG_STRUCT(GPP_G12, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 305: _PAD_CFG_STRUCT(GPP_G13, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 307: _PAD_CFG_STRUCT(GPP_G14, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 310: _PAD_CFG_STRUCT(GPP_G16, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 312: _PAD_CFG_STRUCT(GPP_G17, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 314: _PAD_CFG_STRUCT(GPP_G18, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 316: _PAD_CFG_STRUCT(GPP_G19, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 319: _PAD_CFG_STRUCT(GPP_G21, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 326: _PAD_CFG_STRUCT(GPP_H1, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 341: _PAD_CFG_STRUCT(GPP_H15, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 345: _PAD_CFG_STRUCT(GPP_H18, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 347: _PAD_CFG_STRUCT(GPP_H19, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 349: _PAD_CFG_STRUCT(GPP_H20, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 351: _PAD_CFG_STRUCT(GPP_H21, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 358: _PAD_CFG_STRUCT(GPP_L1, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 360: _PAD_CFG_STRUCT(GPP_L2, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 362: _PAD_CFG_STRUCT(GPP_L3, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 366: _PAD_CFG_STRUCT(GPP_L5, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 368: _PAD_CFG_STRUCT(GPP_L6, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 370: _PAD_CFG_STRUCT(GPP_L7, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 372: _PAD_CFG_STRUCT(GPP_L8, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 374: _PAD_CFG_STRUCT(GPP_L9, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 376: _PAD_CFG_STRUCT(GPP_L10, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 393: _PAD_CFG_STRUCT(GPP_A0, PAD_FUNC(NF3) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 395: _PAD_CFG_STRUCT(GPP_A1, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 397: _PAD_CFG_STRUCT(GPP_A2, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF), 0), /* LAD1 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 398: _PAD_CFG_STRUCT(GPP_A3, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 400: _PAD_CFG_STRUCT(GPP_A4, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 402: _PAD_CFG_STRUCT(GPP_A5, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 404: _PAD_CFG_STRUCT(GPP_A6, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 406: _PAD_CFG_STRUCT(GPP_A8, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF), 0), /* CLKRUN# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 407: _PAD_CFG_STRUCT(GPP_A9, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 410: _PAD_CFG_STRUCT(GPP_A13, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace https://review.coreboot.org/c/coreboot/+/47229/7/src/mainboard/ocp/deltalak… PS7, Line 413: _PAD_CFG_STRUCT(GPP_A15, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/47229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9837a22bc231a4cb919de316ff6f6ee88411ab8 Gerrit-Change-Number: 47229 Gerrit-PatchSet: 7 Gerrit-Owner: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Bryant Ou <bryant.ou.q(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 26 Nov 2020 08:27:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/ocp/deltalake: Configure GPIO
by Paul Menzel (Code Review) 26 Nov '20

26 Nov '20

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47229 ) Change subject: mb/ocp/deltalake: Configure GPIO ...................................................................... Patch Set 7: (2 comments) https://review.coreboot.org/c/coreboot/+/47229/6//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/47229/6//COMMIT_MSG@7 PS6, Line 7: mb/ocp/deltalake: Configure GPIO GPIOs https://review.coreboot.org/c/coreboot/+/47229/6//COMMIT_MSG@13 PS6, Line 13: by Intel ITP and verify the results match with the header file. This change is hard to review. Could you split it out in two patches. First convert the existing configuration to the new syntax, with `BUILD_TIMELESS=1` verifying nothing changed, and then add the changes from the new inteltool dump? -- To view, visit https://review.coreboot.org/c/coreboot/+/47229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9837a22bc231a4cb919de316ff6f6ee88411ab8 Gerrit-Change-Number: 47229 Gerrit-PatchSet: 7 Gerrit-Owner: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Bryant Ou <bryant.ou.q(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 26 Nov 2020 07:54:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/ocp/deltalake: Configure GPIO
by Jingle Hsu (Code Review) 26 Nov '20

26 Nov '20

Hello build bot (Jenkins), Marc Jones, Maxim Polyakov, Jonathan Zhang, Johnny Lin, Angel Pons, Morgan Jang, Bryant Ou, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/47229 to look at the new patch set (#7). Change subject: mb/ocp/deltalake: Configure GPIO ...................................................................... mb/ocp/deltalake: Configure GPIO On Delta Lake DVT with original UEFI firmware, dump GPIO settings by util/inteltool and generate header file by util/intelp2m. Tested=On OCP Delta Lake DVT, dump GPIO configurations by Intel ITP and verify the results match with the header file. Change-Id: Ic9837a22bc231a4cb919de316ff6f6ee88411ab8 Signed-off-by: Jingle Hsu <jingle_hsu(a)wiwynn.com> --- M src/mainboard/ocp/deltalake/include/cpxsp_dl_gpio.h 1 file changed, 340 insertions(+), 244 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/47229/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/47229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9837a22bc231a4cb919de316ff6f6ee88411ab8 Gerrit-Change-Number: 47229 Gerrit-PatchSet: 7 Gerrit-Owner: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Bryant Ou <bryant.ou.q(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/alderlake: Add lp5_ccc_config to the board memory configura...
by Paul Menzel (Code Review) 26 Nov '20

26 Nov '20

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47436 ) Change subject: soc/intel/alderlake: Add lp5_ccc_config to the board memory configuration ...................................................................... Patch Set 4: (2 comments) https://review.coreboot.org/c/coreboot/+/47436/4/src/soc/intel/alderlake/in… File src/soc/intel/alderlake/include/soc/meminit.h: https://review.coreboot.org/c/coreboot/+/47436/4/src/soc/intel/alderlake/in… PS4, Line 95: Bit Mark:Bits [7:0] What is a *bit mark*? https://review.coreboot.org/c/coreboot/+/47436/4/src/soc/intel/alderlake/in… PS4, Line 96: Ascending lowercase? -- To view, visit https://review.coreboot.org/c/coreboot/+/47436 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I24b1cf50c1b0b945fce75239bac38e40aeb8a83a Gerrit-Change-Number: 47436 Gerrit-PatchSet: 4 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 26 Nov 2020 07:48:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlp: Add support for LPDDR5
by Paul Menzel (Code Review) 26 Nov '20

26 Nov '20

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46899 ) Change subject: mb/intel/adlp: Add support for LPDDR5 ...................................................................... Patch Set 12: (3 comments) https://review.coreboot.org/c/coreboot/+/46899/12/src/mainboard/intel/adlrv… File src/mainboard/intel/adlrvp/memory.c: https://review.coreboot.org/c/coreboot/+/46899/12/src/mainboard/intel/adlrv… PS12, Line 62: 15, 14, 12, 13, 8, 9, 10, 11 }, /* Byte 1 */ Should bytes 0 and 1 be put on one line? https://review.coreboot.org/c/coreboot/+/46899/12/src/mainboard/intel/adlrv… PS12, Line 81: { 0, 1 }, { 0, 1 }, { 0, 1 }, { 0, 1 }, : { 0, 1 }, { 0, 1 }, { 0, 1 }, { 0, 1 } These should be indented, and even put on onel ine. https://review.coreboot.org/c/coreboot/+/46899/12/src/mainboard/intel/adlrv… PS12, Line 89: 0xFF Lowercase? -- To view, visit https://review.coreboot.org/c/coreboot/+/46899 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I787bf97dd6c244bd3b0662e5bd061a2da80baa90 Gerrit-Change-Number: 46899 Gerrit-PatchSet: 12 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Balaji Manigandan <balaji.bmg(a)gmail.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 26 Nov 2020 07:46:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/ocp/deltalake: Configure GPIO
by build bot (Jenkins) (Code Review) 26 Nov '20

26 Nov '20

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47229 ) Change subject: mb/ocp/deltalake: Configure GPIO ...................................................................... Patch Set 6: (100 comments) https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… File src/mainboard/ocp/deltalake/include/cpxsp_dl_gpio.h: https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 12: _PAD_CFG_STRUCT(GPP_A0, PAD_FUNC(NF3) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* ESPI_ALERT1# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 13: _PAD_CFG_STRUCT(GPP_A1, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | (1 << 1), 0), /* LAD0 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 14: _PAD_CFG_STRUCT(GPP_A2, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF), 0), /* LAD1 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 15: _PAD_CFG_STRUCT(GPP_A3, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | (1 << 1), 0), /* LAD2 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 16: _PAD_CFG_STRUCT(GPP_A4, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | (1 << 1), 0), /* LAD3 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 17: _PAD_CFG_STRUCT(GPP_A5, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | 1, 0), /* LFRAME# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 18: _PAD_CFG_STRUCT(GPP_A6, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | (1 << 1) | 1, 0), /* SERIRQ */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 19: _PAD_CFG_STRUCT(GPP_A7, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* PIRQA# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 20: _PAD_CFG_STRUCT(GPP_A8, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF), 0), /* CLKRUN# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 21: _PAD_CFG_STRUCT(GPP_A9, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* CLKOUT_LPC0 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 23: _PAD_CFG_STRUCT(GPP_A11, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* PME# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 24: _PAD_CFG_STRUCT(GPP_A12, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 25: _PAD_CFG_STRUCT(GPP_A13, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* SUSWARN#/SUSPWRDNACK */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 27: _PAD_CFG_STRUCT(GPP_A15, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* SUS_ACK# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 40: _PAD_CFG_STRUCT(GPP_B2, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 41: _PAD_CFG_STRUCT(GPP_B3, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 42: _PAD_CFG_STRUCT(GPP_B4, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 43: _PAD_CFG_STRUCT(GPP_B5, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1) | 1, 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 44: _PAD_CFG_STRUCT(GPP_B6, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1) | 1, 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 47: _PAD_CFG_STRUCT(GPP_B9, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | 1, 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 50: _PAD_CFG_STRUCT(GPP_B12, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | 1, 0), /* GLB_RST_WARN_N# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 51: _PAD_CFG_STRUCT(GPP_B13, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | 1, 0), /* PLTRST# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 52: _PAD_CFG_STRUCT(GPP_B14, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), 0), /* SPKR */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 53: _PAD_CFG_STRUCT(GPP_B15, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 54: _PAD_CFG_STRUCT(GPP_B16, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 55: _PAD_CFG_STRUCT(GPP_B17, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 56: _PAD_CFG_STRUCT(GPP_B18, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1) | 1, 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 60: _PAD_CFG_STRUCT(GPP_B22, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | 1, 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 61: _PAD_CFG_STRUCT(GPP_B23, PAD_FUNC(NF2) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | 1, 0), /* PCHHOT# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 64: _PAD_CFG_STRUCT(GPP_F0, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | (1 << 1), 0), /* SATAXPCIE3 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 65: _PAD_CFG_STRUCT(GPP_F1, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | (1 << 1), 0), /* SATAXPCIE4 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 66: _PAD_CFG_STRUCT(GPP_F2, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* SATAXPCIE5 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 67: _PAD_CFG_STRUCT(GPP_F3, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | (1 << 1), 0), /* SATAXPCIE6 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 68: _PAD_CFG_STRUCT(GPP_F4, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | 1, 0), /* SATAXPCIE7 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 69: _PAD_CFG_STRUCT(GPP_F5, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 73: _PAD_CFG_STRUCT(GPP_F9, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 93: _PAD_CFG_STRUCT(GPP_C2, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* SMBALERT# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 96: _PAD_CFG_STRUCT(GPP_C5, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | (1 << 1) | 1, 0), /* SML0ALERT# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 99: _PAD_CFG_STRUCT(GPP_C8, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 103: _PAD_CFG_STRUCT(GPP_C12, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1) | 1, 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 104: _PAD_CFG_STRUCT(GPP_C13, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1) | 1, 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 105: _PAD_CFG_STRUCT(GPP_C14, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 110: _PAD_CFG_STRUCT(GPP_C19, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | 1, 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 112: _PAD_CFG_STRUCT(GPP_C21, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1) | 1, 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 113: _PAD_CFG_STRUCT(GPP_C22, PAD_RESET(RSMRST) | PAD_IRQ_ROUTE(SMI) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 114: _PAD_CFG_STRUCT(GPP_C23, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 143: _PAD_CFG_STRUCT(GPP_E0, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | (1 << 1), 0), /* SATAXPCIE0 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 144: _PAD_CFG_STRUCT(GPP_E1, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | (1 << 1), 0), /* SATAXPCIE1 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 145: _PAD_CFG_STRUCT(GPP_E2, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | (1 << 1), 0), /* SATAXPCIE2 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 146: _PAD_CFG_STRUCT(GPP_E3, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* CPU_GP0 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 150: _PAD_CFG_STRUCT(GPP_E7, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 152: _PAD_CFG_STRUCT(GPP_E9, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* USB_OC0# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 160: _PAD_CFG_STRUCT(GPD1, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* ACPRESENT */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 162: _PAD_CFG_STRUCT(GPD3, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* PWRBTN# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 163: _PAD_CFG_STRUCT(GPD4, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | 1, 0), /* SLP_S3# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 164: _PAD_CFG_STRUCT(GPD5, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | 1, 0), /* SLP_S4# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 165: _PAD_CFG_STRUCT(GPD6, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* SLP_A# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 169: _PAD_CFG_STRUCT(GPD10, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* SLP_S5# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 170: _PAD_CFG_STRUCT(GPD11, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* GBEPHY */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 182: _PAD_CFG_STRUCT(GPP_I8, PAD_FUNC(NF2) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* PCI_DIS */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 183: _PAD_CFG_STRUCT(GPP_I9, PAD_FUNC(NF2) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* LAN_DIS */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 221: _PAD_CFG_STRUCT(GPP_K7, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1) | 1, 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 222: _PAD_CFG_STRUCT(GPP_K8, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), 0), /* LAN_NCSI_ARB_IN */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 223: _PAD_CFG_STRUCT(GPP_K9, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), 0), /* LAN_NCSI_ARB_OUT */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 224: _PAD_CFG_STRUCT(GPP_K10, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* PE_RST# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 240: _PAD_CFG_STRUCT(GPP_G12, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 241: _PAD_CFG_STRUCT(GPP_G13, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 242: _PAD_CFG_STRUCT(GPP_G14, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 244: _PAD_CFG_STRUCT(GPP_G16, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 245: _PAD_CFG_STRUCT(GPP_G17, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | 1, 0), /* ADR_COMPLETE */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 246: _PAD_CFG_STRUCT(GPP_G18, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | 1, 0), /* NMI# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 247: _PAD_CFG_STRUCT(GPP_G19, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | 1, 0), /* SMI# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 249: _PAD_CFG_STRUCT(GPP_G21, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 255: _PAD_CFG_STRUCT(GPP_H1, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 269: _PAD_CFG_STRUCT(GPP_H15, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 272: _PAD_CFG_STRUCT(GPP_H18, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 273: _PAD_CFG_STRUCT(GPP_H19, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 274: _PAD_CFG_STRUCT(GPP_H20, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 275: _PAD_CFG_STRUCT(GPP_H21, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 281: _PAD_CFG_STRUCT(GPP_L1, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), 0), /* CSME_INTR_OUT */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 282: _PAD_CFG_STRUCT(GPP_L2, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* TESTCH0_D0 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 283: _PAD_CFG_STRUCT(GPP_L3, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* TESTCH0_D1 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 284: _PAD_CFG_STRUCT(GPP_L4, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* TESTCH0_D2 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 285: _PAD_CFG_STRUCT(GPP_L5, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* TESTCH0_D3 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 286: _PAD_CFG_STRUCT(GPP_L6, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* TESTCH0_D4 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 287: _PAD_CFG_STRUCT(GPP_L7, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* TESTCH0_D5 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 288: _PAD_CFG_STRUCT(GPP_L8, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* TESTCH0_D6 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 289: _PAD_CFG_STRUCT(GPP_L9, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* TESTCH0_D7 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 290: _PAD_CFG_STRUCT(GPP_L10, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* TESTCH0_CLK */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 306: _PAD_CFG_STRUCT(GPP_A0, PAD_FUNC(NF3) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* ESPI_ALERT1# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 307: _PAD_CFG_STRUCT(GPP_A1, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | (1 << 1), 0), /* LAD0 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 308: _PAD_CFG_STRUCT(GPP_A2, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF), 0), /* LAD1 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 309: _PAD_CFG_STRUCT(GPP_A3, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | (1 << 1), 0), /* LAD2 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 310: _PAD_CFG_STRUCT(GPP_A4, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | (1 << 1), 0), /* LAD3 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 311: _PAD_CFG_STRUCT(GPP_A5, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | 1, 0), /* LFRAME# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 312: _PAD_CFG_STRUCT(GPP_A6, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | (1 << 1) | 1, 0), /* SERIRQ */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 313: _PAD_CFG_STRUCT(GPP_A8, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF), 0), /* CLKRUN# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 314: _PAD_CFG_STRUCT(GPP_A9, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* CLKOUT_LPC0 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 316: _PAD_CFG_STRUCT(GPP_A13, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* SUSWARN#/SUSPWRDNACK */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/6/src/mainboard/ocp/deltalak… PS6, Line 318: _PAD_CFG_STRUCT(GPP_A15, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* SUS_ACK# */ line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/47229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9837a22bc231a4cb919de316ff6f6ee88411ab8 Gerrit-Change-Number: 47229 Gerrit-PatchSet: 6 Gerrit-Owner: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Bryant Ou <bryant.ou.q(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 26 Nov 2020 07:30:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/ocp/deltalake: Configure GPIO
by Jingle Hsu (Code Review) 26 Nov '20

26 Nov '20

Hello build bot (Jenkins), Marc Jones, Maxim Polyakov, Jonathan Zhang, Johnny Lin, Angel Pons, Morgan Jang, Bryant Ou, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/47229 to look at the new patch set (#6). Change subject: mb/ocp/deltalake: Configure GPIO ...................................................................... mb/ocp/deltalake: Configure GPIO On Delta Lake DVT with original UEFI firmware, dump GPIO settings by util/inteltool and generate header file by util/intelp2m. Tested=On OCP Delta Lake DVT, dump GPIO configurations by Intel ITP and verify the results match with the header file. Change-Id: Ic9837a22bc231a4cb919de316ff6f6ee88411ab8 Signed-off-by: Jingle Hsu <jingle_hsu(a)wiwynn.com> --- M src/mainboard/ocp/deltalake/include/cpxsp_dl_gpio.h 1 file changed, 244 insertions(+), 244 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/47229/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/47229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9837a22bc231a4cb919de316ff6f6ee88411ab8 Gerrit-Change-Number: 47229 Gerrit-PatchSet: 6 Gerrit-Owner: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Bryant Ou <bryant.ou.q(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/ocp/deltalake: Configure GPIO
by build bot (Jenkins) (Code Review) 26 Nov '20

26 Nov '20

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47229 ) Change subject: mb/ocp/deltalake: Configure GPIO ...................................................................... Patch Set 5: (100 comments) https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… File src/mainboard/ocp/deltalake/include/cpxsp_dl_gpio.h: https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 12: _PAD_CFG_STRUCT(GPP_A0, PAD_FUNC(NF3) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* ESPI_ALERT1# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 13: _PAD_CFG_STRUCT(GPP_A1, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | (1 << 1), 0), /* LAD0 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 14: _PAD_CFG_STRUCT(GPP_A2, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF), 0), /* LAD1 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 15: _PAD_CFG_STRUCT(GPP_A3, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | (1 << 1), 0), /* LAD2 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 16: _PAD_CFG_STRUCT(GPP_A4, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | (1 << 1), 0), /* LAD3 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 17: _PAD_CFG_STRUCT(GPP_A5, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | 1, 0), /* LFRAME# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 18: _PAD_CFG_STRUCT(GPP_A6, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | (1 << 1) | 1, 0), /* SERIRQ */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 19: _PAD_CFG_STRUCT(GPP_A7, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* PIRQA# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 20: _PAD_CFG_STRUCT(GPP_A8, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF), 0), /* CLKRUN# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 21: _PAD_CFG_STRUCT(GPP_A9, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* CLKOUT_LPC0 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 23: _PAD_CFG_STRUCT(GPP_A11, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* PME# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 24: _PAD_CFG_STRUCT(GPP_A12, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 25: _PAD_CFG_STRUCT(GPP_A13, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* SUSWARN#/SUSPWRDNACK */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 27: _PAD_CFG_STRUCT(GPP_A15, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* SUS_ACK# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 40: _PAD_CFG_STRUCT(GPP_B2, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 41: _PAD_CFG_STRUCT(GPP_B3, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 42: _PAD_CFG_STRUCT(GPP_B4, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 43: _PAD_CFG_STRUCT(GPP_B5, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1) | 1, 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 44: _PAD_CFG_STRUCT(GPP_B6, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1) | 1, 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 47: _PAD_CFG_STRUCT(GPP_B9, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | 1, 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 50: _PAD_CFG_STRUCT(GPP_B12, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | 1, 0), /* GLB_RST_WARN_N# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 51: _PAD_CFG_STRUCT(GPP_B13, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | 1, 0), /* PLTRST# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 52: _PAD_CFG_STRUCT(GPP_B14, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), 0), /* SPKR */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 53: _PAD_CFG_STRUCT(GPP_B15, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 54: _PAD_CFG_STRUCT(GPP_B16, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 55: _PAD_CFG_STRUCT(GPP_B17, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 56: _PAD_CFG_STRUCT(GPP_B18, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1) | 1, 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 60: _PAD_CFG_STRUCT(GPP_B22, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | 1, 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 61: _PAD_CFG_STRUCT(GPP_B23, PAD_FUNC(NF2) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | 1, 0), /* PCHHOT# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 64: _PAD_CFG_STRUCT(GPP_F0, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | (1 << 1), 0), /* SATAXPCIE3 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 65: _PAD_CFG_STRUCT(GPP_F1, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | (1 << 1), 0), /* SATAXPCIE4 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 66: _PAD_CFG_STRUCT(GPP_F2, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* SATAXPCIE5 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 67: _PAD_CFG_STRUCT(GPP_F3, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | (1 << 1), 0), /* SATAXPCIE6 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 68: _PAD_CFG_STRUCT(GPP_F4, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | 1, 0), /* SATAXPCIE7 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 69: _PAD_CFG_STRUCT(GPP_F5, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 73: _PAD_CFG_STRUCT(GPP_F9, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 93: _PAD_CFG_STRUCT(GPP_C2, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* SMBALERT# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 96: _PAD_CFG_STRUCT(GPP_C5, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | (1 << 1) | 1, 0), /* SML0ALERT# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 99: _PAD_CFG_STRUCT(GPP_C8, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 103: _PAD_CFG_STRUCT(GPP_C12, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1) | 1, 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 104: _PAD_CFG_STRUCT(GPP_C13, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1) | 1, 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 105: _PAD_CFG_STRUCT(GPP_C14, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 110: _PAD_CFG_STRUCT(GPP_C19, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | 1, 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 112: _PAD_CFG_STRUCT(GPP_C21, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1) | 1, 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 113: _PAD_CFG_STRUCT(GPP_C22, PAD_RESET(RSMRST) | PAD_IRQ_ROUTE(SMI) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 114: _PAD_CFG_STRUCT(GPP_C23, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 143: _PAD_CFG_STRUCT(GPP_E0, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | (1 << 1), 0), /* SATAXPCIE0 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 144: _PAD_CFG_STRUCT(GPP_E1, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | (1 << 1), 0), /* SATAXPCIE1 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 145: _PAD_CFG_STRUCT(GPP_E2, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | (1 << 1), 0), /* SATAXPCIE2 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 146: _PAD_CFG_STRUCT(GPP_E3, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* CPU_GP0 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 150: _PAD_CFG_STRUCT(GPP_E7, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 152: _PAD_CFG_STRUCT(GPP_E9, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* USB_OC0# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 160: _PAD_CFG_STRUCT(GPD1, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* ACPRESENT */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 162: _PAD_CFG_STRUCT(GPD3, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* PWRBTN# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 163: _PAD_CFG_STRUCT(GPD4, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | 1, 0), /* SLP_S3# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 164: _PAD_CFG_STRUCT(GPD5, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | 1, 0), /* SLP_S4# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 165: _PAD_CFG_STRUCT(GPD6, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* SLP_A# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 169: _PAD_CFG_STRUCT(GPD10, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* SLP_S5# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 170: _PAD_CFG_STRUCT(GPD11, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* GBEPHY */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 182: _PAD_CFG_STRUCT(GPP_I8, PAD_FUNC(NF2) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* PCI_DIS */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 183: _PAD_CFG_STRUCT(GPP_I9, PAD_FUNC(NF2) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* LAN_DIS */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 221: _PAD_CFG_STRUCT(GPP_K7, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1) | 1, 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 222: _PAD_CFG_STRUCT(GPP_K8, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), 0), /* LAN_NCSI_ARB_IN */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 223: _PAD_CFG_STRUCT(GPP_K9, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), 0), /* LAN_NCSI_ARB_OUT */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 224: _PAD_CFG_STRUCT(GPP_K10, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* PE_RST# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 240: _PAD_CFG_STRUCT(GPP_G12, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 241: _PAD_CFG_STRUCT(GPP_G13, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 242: _PAD_CFG_STRUCT(GPP_G14, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 244: _PAD_CFG_STRUCT(GPP_G16, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 245: _PAD_CFG_STRUCT(GPP_G17, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | 1, 0), /* ADR_COMPLETE */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 246: _PAD_CFG_STRUCT(GPP_G18, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | 1, 0), /* NMI# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 247: _PAD_CFG_STRUCT(GPP_G19, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | 1, 0), /* SMI# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 249: _PAD_CFG_STRUCT(GPP_G21, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 255: _PAD_CFG_STRUCT(GPP_H1, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 269: _PAD_CFG_STRUCT(GPP_H15, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 272: _PAD_CFG_STRUCT(GPP_H18, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 273: _PAD_CFG_STRUCT(GPP_H19, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 274: _PAD_CFG_STRUCT(GPP_H20, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 275: _PAD_CFG_STRUCT(GPP_H21, PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 281: _PAD_CFG_STRUCT(GPP_L1, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), 0), /* CSME_INTR_OUT */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 282: _PAD_CFG_STRUCT(GPP_L2, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* TESTCH0_D0 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 283: _PAD_CFG_STRUCT(GPP_L3, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* TESTCH0_D1 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 284: _PAD_CFG_STRUCT(GPP_L4, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* TESTCH0_D2 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 285: _PAD_CFG_STRUCT(GPP_L5, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* TESTCH0_D3 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 286: _PAD_CFG_STRUCT(GPP_L6, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* TESTCH0_D4 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 287: _PAD_CFG_STRUCT(GPP_L7, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* TESTCH0_D5 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 288: _PAD_CFG_STRUCT(GPP_L8, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* TESTCH0_D6 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 289: _PAD_CFG_STRUCT(GPP_L9, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* TESTCH0_D7 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 290: _PAD_CFG_STRUCT(GPP_L10, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* TESTCH0_CLK */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 306: _PAD_CFG_STRUCT(GPP_A0, PAD_FUNC(NF3) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* ESPI_ALERT1# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 307: _PAD_CFG_STRUCT(GPP_A1, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | (1 << 1), 0), /* LAD0 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 308: _PAD_CFG_STRUCT(GPP_A2, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF), 0), /* LAD1 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 309: _PAD_CFG_STRUCT(GPP_A3, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | (1 << 1), 0), /* LAD2 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 310: _PAD_CFG_STRUCT(GPP_A4, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | (1 << 1), 0), /* LAD3 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 311: _PAD_CFG_STRUCT(GPP_A5, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | 1, 0), /* LFRAME# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 312: _PAD_CFG_STRUCT(GPP_A6, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | (1 << 1) | 1, 0), /* SERIRQ */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 313: _PAD_CFG_STRUCT(GPP_A8, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF), 0), /* CLKRUN# */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 314: _PAD_CFG_STRUCT(GPP_A9, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* CLKOUT_LPC0 */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 316: _PAD_CFG_STRUCT(GPP_A13, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), /* SUSWARN#/SUSPWRDNACK */ line over 96 characters https://review.coreboot.org/c/coreboot/+/47229/5/src/mainboard/ocp/deltalak… PS5, Line 318: _PAD_CFG_STRUCT(GPP_A15, PAD_FUNC(NF1) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* SUS_ACK# */ line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/47229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9837a22bc231a4cb919de316ff6f6ee88411ab8 Gerrit-Change-Number: 47229 Gerrit-PatchSet: 5 Gerrit-Owner: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Bryant Ou <bryant.ou.q(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 26 Nov 2020 07:26:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2020