coreboot-gerrit October 2020

coreboot-gerrit@coreboot.org

1 participants
3474 discussions

Change in coreboot[master]: soc/intel/xeon_sp/cpx: Add save_dimm_info for SMBIOS type 17
by Johnny Lin (Code Review) 05 Oct '20

05 Oct '20

Hello Marc Jones, John Looney, Patrick Rudolph, Jonathan Zhang, Jingle Hsu, Angel Pons, Morgan Jang, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/45798 to look at the new patch set (#5). Change subject: soc/intel/xeon_sp/cpx: Add save_dimm_info for SMBIOS type 17 ...................................................................... soc/intel/xeon_sp/cpx: Add save_dimm_info for SMBIOS type 17 For now only implement for one socket and some of the fields are hard-coded for DDR4 including memory device type, data width, voltage and ECC support. Change-Id: I3cb72d18027d972140828970206834ff55b72022 Signed-off-by: Johnny Lin <johnny_lin(a)wiwynn.com> --- M src/soc/intel/xeon_sp/cpx/Makefile.inc A src/soc/intel/xeon_sp/cpx/ddr.c A src/soc/intel/xeon_sp/cpx/include/soc/ddr.h M src/soc/intel/xeon_sp/cpx/romstage.c M src/soc/intel/xeon_sp/include/soc/romstage.h M src/soc/intel/xeon_sp/romstage.c 6 files changed, 218 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/45798/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/45798 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3cb72d18027d972140828970206834ff55b72022 Gerrit-Change-Number: 45798 Gerrit-PatchSet: 5 Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Reviewer: John Looney <john.looney(a)gmail.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: vc/intel/fsp/fsp2_0/cpx_sp: Add DIMM present field
by Johnny Lin (Code Review) 05 Oct '20

05 Oct '20

Hello Anjaneya "Reddy" Chagam, Patrick Rudolph, Jonathan Zhang, Jingle Hsu, Angel Pons, Morgan Jang, Patrick Rudolph, Nathaniel L Desimone, Isaac W Oram, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/45797 to look at the new patch set (#5). Change subject: vc/intel/fsp/fsp2_0/cpx_sp: Add DIMM present field ...................................................................... vc/intel/fsp/fsp2_0/cpx_sp: Add DIMM present field This field from SystemMemoryMapHob is used to detect if the DIMM is present. Tested=On OCP Delta Lake, verify the DIMM present status is expected. Change-Id: I988e7341ddd3b701c698b41451a87890f21cc928 Signed-off-by: Johnny Lin <johnny_lin(a)wiwynn.com> --- M src/vendorcode/intel/fsp/fsp2_0/cooperlake_sp/hob_memmap.h 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/45797/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/45797 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I988e7341ddd3b701c698b41451a87890f21cc928 Gerrit-Change-Number: 45797 Gerrit-PatchSet: 5 Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Isaac W Oram <isaac.w.oram(a)intel.com> Gerrit-Reviewer: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/siemens/mc_apl6: Enable eMMC and program eMMC DLL settings
by Mario Scheithauer (Code Review) 05 Oct '20

05 Oct '20

Mario Scheithauer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45898 ) Change subject: mb/siemens/mc_apl6: Enable eMMC and program eMMC DLL settings ...................................................................... mb/siemens/mc_apl6: Enable eMMC and program eMMC DLL settings Enable eMMC and program eMMC DLL settings for mc_apl6 mainboard. Change-Id: Ib760a1a26a92047e8916979ffb5001bcff0a6e45 Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com> --- M src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb 1 file changed, 48 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/45898/1 diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb index 4aa8bc9..e9fd143 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb @@ -14,6 +14,53 @@ register "pcie_rp_clkreq_pin[4]" = "CLKREQ_DISABLED" register "pcie_rp_clkreq_pin[5]" = "CLKREQ_DISABLED" + # EMMC TX CMD Delay + # Refer to EDS-Vol2-21.3.7 + # [14:8] steps of delay for HS400, each 125ps. + # [6:0] steps of delay for SDR104/HS200, each 125ps. + # SDR Mode 3h - 375ps + register "emmc_tx_cmd_cntl" = "0x00000503" + + # EMMC TX DATA Delay 1 + # Refer to EDS-Vol2-21.3.8 + # [14:8] steps of delay for HS400, each 125ps. + # [6:0] steps of delay for SDR104/HS200, each 125ps. + # HS200 Mode Bh - 1.375ns + register "emmc_tx_data_cntl1" = "0x0C0B" + + # EMMC TX DATA Delay 2 + # Refer to EDS-Vol2-21.3.9 + # [30:24] steps of delay for SDR50, each 125ps. + # [22:16] steps of delay for DDR50, each 125ps. + # [14:8] steps of delay for SDR25/HS50, each 125ps. + # [6:0] steps of delay for SDR12, each 125ps. + register "emmc_tx_data_cntl2" = "0x28162828" + + # EMMC RX CMD/DATA Delay 1 + # Refer to EDS-Vol2-21.3.10 + # [30:24] steps of delay for SDR50, each 125ps. + # [22:16] steps of delay for DDR50, each 125ps. + # [14:8] steps of delay for SDR25/HS50, each 125ps. + # [6:0] steps of delay for SDR12, each 125ps. + register "emmc_rx_cmd_data_cntl1" = "0x00181717" + + # EMMC RX Strobe Ctrl + # Refer to EDS-Vol2-21.3.11 + # [14:8] hs400_mode1: Rx Strobe Delay DLL 1 (HS400 Mode) + # [6:0] hs400_mode2: Rx Strobe Delay DLL 2 (HS400 Mode) + register "emmc_rx_strobe_cntl" = "0xa0a" + + # EMMC RX CMD/DATA Delay 2 + # Refer to EDS-Vol2-21.3.12 + # [17:16] stands for Rx Clock before Output Buffer + # [14:8] steps of delay for Auto Tuning Mode, each 125ps. + # [6:0] steps of delay for HS200, each 125ps. + # HS200 Mode 4h - 500ps + register "emmc_rx_cmd_data_cntl2" = "0x10004" + + # 0:HS400(Default), 1:HS200, 2:DDR50 + register "emmc_host_max_speed" = "1" + # Enable Vtd feature register "enable_vtd" = "1" @@ -70,7 +117,7 @@ device pci 19.2 off end # - SPI 2 device pci 1a.0 off end # - PWM device pci 1b.0 on end # - SDCARD - device pci 1c.0 off end # - eMMC + device pci 1c.0 on end # - eMMC device pci 1d.0 off end # - UFS device pci 1e.0 off end # - SDIO device pci 1f.0 on # - LPC -- To view, visit https://review.coreboot.org/c/coreboot/+/45898 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib760a1a26a92047e8916979ffb5001bcff0a6e45 Gerrit-Change-Number: 45898 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-MessageType: newchange

3 9

Change in coreboot[master]: soc/intel/common/block/acpi: Factor out common platform.asl
by Subrata Banik (Code Review) 05 Oct '20

05 Oct '20

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45982 ) Change subject: soc/intel/common/block/acpi: Factor out common platform.asl ...................................................................... soc/intel/common/block/acpi: Factor out common platform.asl This patch moves platform.asl into common block acpi directory to avoid duplicating the same ASL code block across SoC directory. TEST=Able to build and boot TGL, CNL and CML platform. 1) Dump and disassemble DSDT, verify _PIC method present inside common platform.asl is still there. 2) Verify no ACPI error seen while running 'dmesg` from console. Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> Change-Id: I5189b03d6abfaec39882d28b40a9bfa002128be3 --- M src/mainboard/asrock/h110m/dsdt.asl M src/mainboard/clevo/cml-u/dsdt.asl M src/mainboard/facebook/monolith/dsdt.asl M src/mainboard/google/dedede/dsdt.asl M src/mainboard/google/deltaur/dsdt.asl M src/mainboard/google/drallion/dsdt.asl M src/mainboard/google/eve/dsdt.asl M src/mainboard/google/fizz/dsdt.asl M src/mainboard/google/glados/dsdt.asl M src/mainboard/google/hatch/dsdt.asl M src/mainboard/google/poppy/dsdt.asl M src/mainboard/google/sarien/dsdt.asl M src/mainboard/google/volteer/dsdt.asl M src/mainboard/intel/cannonlake_rvp/dsdt.asl M src/mainboard/intel/coffeelake_rvp/dsdt.asl M src/mainboard/intel/icelake_rvp/dsdt.asl M src/mainboard/intel/jasperlake_rvp/dsdt.asl M src/mainboard/intel/kblrvp/dsdt.asl M src/mainboard/intel/kunimitsu/dsdt.asl M src/mainboard/intel/saddlebrook/dsdt.asl M src/mainboard/intel/tglrvp/dsdt.asl M src/mainboard/kontron/bsl6/dsdt.asl M src/mainboard/libretrend/lt1000/dsdt.asl M src/mainboard/prodrive/hermes/dsdt.asl M src/mainboard/protectli/vault_kbl/dsdt.asl M src/mainboard/purism/librem_skl/dsdt.asl M src/mainboard/purism/librem_whl/dsdt.asl M src/mainboard/razer/blade_stealth_kbl/dsdt.asl M src/mainboard/supermicro/x11-lga1151-series/dsdt.asl M src/mainboard/system76/lemp9/dsdt.asl R src/soc/intel/common/block/acpi/acpi/platform.asl D src/soc/intel/elkhartlake/acpi/platform.asl D src/soc/intel/icelake/acpi/platform.asl D src/soc/intel/jasperlake/acpi/platform.asl D src/soc/intel/skylake/acpi/platform.asl D src/soc/intel/tigerlake/acpi/platform.asl 36 files changed, 30 insertions(+), 130 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/45982/1 diff --git a/src/mainboard/asrock/h110m/dsdt.asl b/src/mainboard/asrock/h110m/dsdt.asl index 4059596..457c927 100644 --- a/src/mainboard/asrock/h110m/dsdt.asl +++ b/src/mainboard/asrock/h110m/dsdt.asl @@ -10,7 +10,7 @@ 0x20110725 // OEM revision ) { - #include <soc/intel/skylake/acpi/platform.asl> + #include <soc/intel/common/block/acpi/acpi/platform.asl> // global NVS and variables #include <soc/intel/skylake/acpi/globalnvs.asl> diff --git a/src/mainboard/clevo/cml-u/dsdt.asl b/src/mainboard/clevo/cml-u/dsdt.asl index eac27b5..bffb668 100644 --- a/src/mainboard/clevo/cml-u/dsdt.asl +++ b/src/mainboard/clevo/cml-u/dsdt.asl @@ -10,7 +10,7 @@ 0x20110725 // OEM revision ) { - #include <soc/intel/cannonlake/acpi/platform.asl> + #include <soc/intel/common/block/acpi/acpi/platform.asl> #include <soc/intel/common/block/acpi/acpi/globalnvs.asl> #include <cpu/intel/common/acpi/cpu.asl> diff --git a/src/mainboard/facebook/monolith/dsdt.asl b/src/mainboard/facebook/monolith/dsdt.asl index 238e87b..2fd7851 100644 --- a/src/mainboard/facebook/monolith/dsdt.asl +++ b/src/mainboard/facebook/monolith/dsdt.asl @@ -10,7 +10,7 @@ 0x20110725 // OEM revision ) { - #include <soc/intel/skylake/acpi/platform.asl> + #include <soc/intel/common/block/acpi/acpi/platform.asl> // global NVS and variables #include <soc/intel/skylake/acpi/globalnvs.asl> diff --git a/src/mainboard/google/dedede/dsdt.asl b/src/mainboard/google/dedede/dsdt.asl index 6365e5e..bbdbd3b 100644 --- a/src/mainboard/google/dedede/dsdt.asl +++ b/src/mainboard/google/dedede/dsdt.asl @@ -13,7 +13,7 @@ 0x20110725 /* OEM revision */ ) { - #include <soc/intel/jasperlake/acpi/platform.asl> + #include <soc/intel/common/block/acpi/acpi/platform.asl> /* global NVS and variables */ #include <soc/intel/common/block/acpi/acpi/globalnvs.asl> diff --git a/src/mainboard/google/deltaur/dsdt.asl b/src/mainboard/google/deltaur/dsdt.asl index fac58bd..8666ec7 100644 --- a/src/mainboard/google/deltaur/dsdt.asl +++ b/src/mainboard/google/deltaur/dsdt.asl @@ -13,7 +13,7 @@ 0x20110725 /* OEM revision */ ) { - #include <soc/intel/tigerlake/acpi/platform.asl> + #include <soc/intel/common/block/acpi/acpi/platform.asl> /* global NVS and variables */ #include <soc/intel/common/block/acpi/acpi/globalnvs.asl> diff --git a/src/mainboard/google/drallion/dsdt.asl b/src/mainboard/google/drallion/dsdt.asl index c9f7391..2fbff26 100644 --- a/src/mainboard/google/drallion/dsdt.asl +++ b/src/mainboard/google/drallion/dsdt.asl @@ -12,7 +12,7 @@ 0x20110725 /* OEM revision */ ) { - #include <soc/intel/cannonlake/acpi/platform.asl> + #include <soc/intel/common/block/acpi/acpi/platform.asl> /* global NVS and variables */ #include <soc/intel/common/block/acpi/acpi/globalnvs.asl> diff --git a/src/mainboard/google/eve/dsdt.asl b/src/mainboard/google/eve/dsdt.asl index b73dcb5..0009d95 100644 --- a/src/mainboard/google/eve/dsdt.asl +++ b/src/mainboard/google/eve/dsdt.asl @@ -13,7 +13,7 @@ 0x20110725 // OEM revision ) { - #include <soc/intel/skylake/acpi/platform.asl> + #include <soc/intel/common/block/acpi/acpi/platform.asl> /* global NVS and variables */ #include <soc/intel/skylake/acpi/globalnvs.asl> diff --git a/src/mainboard/google/fizz/dsdt.asl b/src/mainboard/google/fizz/dsdt.asl index 83c7718..965770c 100644 --- a/src/mainboard/google/fizz/dsdt.asl +++ b/src/mainboard/google/fizz/dsdt.asl @@ -13,7 +13,7 @@ 0x20110725 // OEM revision ) { - #include <soc/intel/skylake/acpi/platform.asl> + #include <soc/intel/common/block/acpi/acpi/platform.asl> /* global NVS and variables */ #include <soc/intel/skylake/acpi/globalnvs.asl> diff --git a/src/mainboard/google/glados/dsdt.asl b/src/mainboard/google/glados/dsdt.asl index 040c960..707c84c 100644 --- a/src/mainboard/google/glados/dsdt.asl +++ b/src/mainboard/google/glados/dsdt.asl @@ -10,7 +10,7 @@ 0x20110725 // OEM revision ) { - #include <soc/intel/skylake/acpi/platform.asl> + #include <soc/intel/common/block/acpi/acpi/platform.asl> // global NVS and variables #include <soc/intel/skylake/acpi/globalnvs.asl> diff --git a/src/mainboard/google/hatch/dsdt.asl b/src/mainboard/google/hatch/dsdt.asl index d60da37..3ca98ab 100644 --- a/src/mainboard/google/hatch/dsdt.asl +++ b/src/mainboard/google/hatch/dsdt.asl @@ -13,7 +13,7 @@ 0x20110725 /* OEM revision */ ) { - #include <soc/intel/cannonlake/acpi/platform.asl> + #include <soc/intel/common/block/acpi/acpi/platform.asl> /* global NVS and variables */ #include <soc/intel/common/block/acpi/acpi/globalnvs.asl> diff --git a/src/mainboard/google/poppy/dsdt.asl b/src/mainboard/google/poppy/dsdt.asl index 29dbb58..ed25beb 100644 --- a/src/mainboard/google/poppy/dsdt.asl +++ b/src/mainboard/google/poppy/dsdt.asl @@ -13,7 +13,7 @@ 0x20110725 // OEM revision ) { - #include <soc/intel/skylake/acpi/platform.asl> + #include <soc/intel/common/block/acpi/acpi/platform.asl> /* global NVS and variables */ #include <soc/intel/skylake/acpi/globalnvs.asl> diff --git a/src/mainboard/google/sarien/dsdt.asl b/src/mainboard/google/sarien/dsdt.asl index 0382fcb..aafade4 100644 --- a/src/mainboard/google/sarien/dsdt.asl +++ b/src/mainboard/google/sarien/dsdt.asl @@ -12,7 +12,7 @@ 0x20110725 /* OEM revision */ ) { - #include <soc/intel/cannonlake/acpi/platform.asl> + #include <soc/intel/common/block/acpi/acpi/platform.asl> /* global NVS and variables */ #include <soc/intel/common/block/acpi/acpi/globalnvs.asl> diff --git a/src/mainboard/google/volteer/dsdt.asl b/src/mainboard/google/volteer/dsdt.asl index dc8f7ad..18c975e 100644 --- a/src/mainboard/google/volteer/dsdt.asl +++ b/src/mainboard/google/volteer/dsdt.asl @@ -13,7 +13,7 @@ 0x20110725 // OEM revision ) { - #include <soc/intel/tigerlake/acpi/platform.asl> + #include <soc/intel/common/block/acpi/acpi/platform.asl> // global NVS and variables #include <soc/intel/common/block/acpi/acpi/globalnvs.asl> diff --git a/src/mainboard/intel/cannonlake_rvp/dsdt.asl b/src/mainboard/intel/cannonlake_rvp/dsdt.asl index 5a06a45..280844d 100644 --- a/src/mainboard/intel/cannonlake_rvp/dsdt.asl +++ b/src/mainboard/intel/cannonlake_rvp/dsdt.asl @@ -10,7 +10,7 @@ 0x20110725 // OEM revision ) { - #include <soc/intel/cannonlake/acpi/platform.asl> + #include <soc/intel/common/block/acpi/acpi/platform.asl> // global NVS and variables #include <soc/intel/common/block/acpi/acpi/globalnvs.asl> diff --git a/src/mainboard/intel/coffeelake_rvp/dsdt.asl b/src/mainboard/intel/coffeelake_rvp/dsdt.asl index 121012e..5dd84cf 100644 --- a/src/mainboard/intel/coffeelake_rvp/dsdt.asl +++ b/src/mainboard/intel/coffeelake_rvp/dsdt.asl @@ -10,7 +10,7 @@ 0x20110725 // OEM revision ) { - #include <soc/intel/cannonlake/acpi/platform.asl> + #include <soc/intel/common/block/acpi/acpi/platform.asl> // global NVS and variables #include <soc/intel/common/block/acpi/acpi/globalnvs.asl> diff --git a/src/mainboard/intel/icelake_rvp/dsdt.asl b/src/mainboard/intel/icelake_rvp/dsdt.asl index a3c93e2..41a9c0a 100644 --- a/src/mainboard/intel/icelake_rvp/dsdt.asl +++ b/src/mainboard/intel/icelake_rvp/dsdt.asl @@ -13,7 +13,7 @@ 0x20110725 // OEM revision ) { - #include <soc/intel/icelake/acpi/platform.asl> + #include <soc/intel/common/block/acpi/acpi/platform.asl> // global NVS and variables #include <soc/intel/common/block/acpi/acpi/globalnvs.asl> diff --git a/src/mainboard/intel/jasperlake_rvp/dsdt.asl b/src/mainboard/intel/jasperlake_rvp/dsdt.asl index be883b4c..ce781e2 100644 --- a/src/mainboard/intel/jasperlake_rvp/dsdt.asl +++ b/src/mainboard/intel/jasperlake_rvp/dsdt.asl @@ -13,7 +13,7 @@ 0x20110725 /* OEM revision */ ) { - #include <soc/intel/jasperlake/acpi/platform.asl> + #include <soc/intel/common/block/acpi/acpi/platform.asl> /* global NVS and variables */ #include <soc/intel/common/block/acpi/acpi/globalnvs.asl> diff --git a/src/mainboard/intel/kblrvp/dsdt.asl b/src/mainboard/intel/kblrvp/dsdt.asl index 354f488..6eee06a 100644 --- a/src/mainboard/intel/kblrvp/dsdt.asl +++ b/src/mainboard/intel/kblrvp/dsdt.asl @@ -10,7 +10,7 @@ 0x20110725 // OEM revision ) { - #include <soc/intel/skylake/acpi/platform.asl> + #include <soc/intel/common/block/acpi/acpi/platform.asl> // global NVS and variables #include <soc/intel/skylake/acpi/globalnvs.asl> diff --git a/src/mainboard/intel/kunimitsu/dsdt.asl b/src/mainboard/intel/kunimitsu/dsdt.asl index 90a5594..7159577 100644 --- a/src/mainboard/intel/kunimitsu/dsdt.asl +++ b/src/mainboard/intel/kunimitsu/dsdt.asl @@ -10,7 +10,7 @@ 0x20110725 // OEM revision ) { - #include <soc/intel/skylake/acpi/platform.asl> + #include <soc/intel/common/block/acpi/acpi/platform.asl> // global NVS and variables #include <soc/intel/skylake/acpi/globalnvs.asl> diff --git a/src/mainboard/intel/saddlebrook/dsdt.asl b/src/mainboard/intel/saddlebrook/dsdt.asl index f705b54..d869076 100644 --- a/src/mainboard/intel/saddlebrook/dsdt.asl +++ b/src/mainboard/intel/saddlebrook/dsdt.asl @@ -10,7 +10,7 @@ 0x20110725 // OEM revision ) { - #include <soc/intel/skylake/acpi/platform.asl> + #include <soc/intel/common/block/acpi/acpi/platform.asl> // global NVS and variables #include <soc/intel/skylake/acpi/globalnvs.asl> diff --git a/src/mainboard/intel/tglrvp/dsdt.asl b/src/mainboard/intel/tglrvp/dsdt.asl index e5323ef..5cde1de 100644 --- a/src/mainboard/intel/tglrvp/dsdt.asl +++ b/src/mainboard/intel/tglrvp/dsdt.asl @@ -13,7 +13,7 @@ 0x20110725 /* OEM revision */ ) { - #include <soc/intel/tigerlake/acpi/platform.asl> + #include <soc/intel/common/block/acpi/acpi/platform.asl> /* global NVS and variables */ #include <soc/intel/common/block/acpi/acpi/globalnvs.asl> diff --git a/src/mainboard/kontron/bsl6/dsdt.asl b/src/mainboard/kontron/bsl6/dsdt.asl index a133a9d..225c8a5 100644 --- a/src/mainboard/kontron/bsl6/dsdt.asl +++ b/src/mainboard/kontron/bsl6/dsdt.asl @@ -11,7 +11,7 @@ ) { #include <cpu/intel/common/acpi/cpu.asl> - #include <soc/intel/skylake/acpi/platform.asl> + #include <soc/intel/common/block/acpi/acpi/platform.asl> #include <soc/intel/skylake/acpi/globalnvs.asl> Device (\_SB.PCI0) { diff --git a/src/mainboard/libretrend/lt1000/dsdt.asl b/src/mainboard/libretrend/lt1000/dsdt.asl index 5b3a5df..2a3876b 100644 --- a/src/mainboard/libretrend/lt1000/dsdt.asl +++ b/src/mainboard/libretrend/lt1000/dsdt.asl @@ -10,7 +10,7 @@ 0x20110725 /* OEM revision */ ) { - #include <soc/intel/skylake/acpi/platform.asl> + #include <soc/intel/common/block/acpi/acpi/platform.asl> #include <soc/intel/skylake/acpi/globalnvs.asl> #include <cpu/intel/common/acpi/cpu.asl> diff --git a/src/mainboard/prodrive/hermes/dsdt.asl b/src/mainboard/prodrive/hermes/dsdt.asl index 4d8d170..ef84928 100644 --- a/src/mainboard/prodrive/hermes/dsdt.asl +++ b/src/mainboard/prodrive/hermes/dsdt.asl @@ -10,7 +10,7 @@ 0x20110725 // OEM revision ) { - #include <soc/intel/cannonlake/acpi/platform.asl> + #include <soc/intel/common/block/acpi/acpi/platform.asl> // global NVS and variables #include <soc/intel/common/block/acpi/acpi/globalnvs.asl> diff --git a/src/mainboard/protectli/vault_kbl/dsdt.asl b/src/mainboard/protectli/vault_kbl/dsdt.asl index 5b3a5df..2a3876b 100644 --- a/src/mainboard/protectli/vault_kbl/dsdt.asl +++ b/src/mainboard/protectli/vault_kbl/dsdt.asl @@ -10,7 +10,7 @@ 0x20110725 /* OEM revision */ ) { - #include <soc/intel/skylake/acpi/platform.asl> + #include <soc/intel/common/block/acpi/acpi/platform.asl> #include <soc/intel/skylake/acpi/globalnvs.asl> #include <cpu/intel/common/acpi/cpu.asl> diff --git a/src/mainboard/purism/librem_skl/dsdt.asl b/src/mainboard/purism/librem_skl/dsdt.asl index dacfeff..0039e6b 100644 --- a/src/mainboard/purism/librem_skl/dsdt.asl +++ b/src/mainboard/purism/librem_skl/dsdt.asl @@ -10,7 +10,7 @@ 0x20110725 // OEM revision ) { - #include <soc/intel/skylake/acpi/platform.asl> + #include <soc/intel/common/block/acpi/acpi/platform.asl> // global NVS and variables #include <soc/intel/skylake/acpi/globalnvs.asl> diff --git a/src/mainboard/purism/librem_whl/dsdt.asl b/src/mainboard/purism/librem_whl/dsdt.asl index 296be17..d365cf5 100644 --- a/src/mainboard/purism/librem_whl/dsdt.asl +++ b/src/mainboard/purism/librem_whl/dsdt.asl @@ -10,7 +10,7 @@ 0x20110725 /* OEM revision */ ) { - #include <soc/intel/cannonlake/acpi/platform.asl> + ##include <soc/intel/common/block/acpi/acpi/platform.asl> #include <soc/intel/common/block/acpi/acpi/globalnvs.asl> #include <cpu/intel/common/acpi/cpu.asl> diff --git a/src/mainboard/razer/blade_stealth_kbl/dsdt.asl b/src/mainboard/razer/blade_stealth_kbl/dsdt.asl index ec3ca79..7d4a92c 100644 --- a/src/mainboard/razer/blade_stealth_kbl/dsdt.asl +++ b/src/mainboard/razer/blade_stealth_kbl/dsdt.asl @@ -11,7 +11,7 @@ 0x20110725 // OEM revision ){ //Platform - #include <soc/intel/skylake/acpi/platform.asl> + #include <soc/intel/common/block/acpi/acpi/platform.asl> // global NVS and variables #include <soc/intel/skylake/acpi/globalnvs.asl> diff --git a/src/mainboard/supermicro/x11-lga1151-series/dsdt.asl b/src/mainboard/supermicro/x11-lga1151-series/dsdt.asl index f705b54..d869076 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/dsdt.asl +++ b/src/mainboard/supermicro/x11-lga1151-series/dsdt.asl @@ -10,7 +10,7 @@ 0x20110725 // OEM revision ) { - #include <soc/intel/skylake/acpi/platform.asl> + #include <soc/intel/common/block/acpi/acpi/platform.asl> // global NVS and variables #include <soc/intel/skylake/acpi/globalnvs.asl> diff --git a/src/mainboard/system76/lemp9/dsdt.asl b/src/mainboard/system76/lemp9/dsdt.asl index eac27b5..bffb668 100644 --- a/src/mainboard/system76/lemp9/dsdt.asl +++ b/src/mainboard/system76/lemp9/dsdt.asl @@ -10,7 +10,7 @@ 0x20110725 // OEM revision ) { - #include <soc/intel/cannonlake/acpi/platform.asl> + #include <soc/intel/common/block/acpi/acpi/platform.asl> #include <soc/intel/common/block/acpi/acpi/globalnvs.asl> #include <cpu/intel/common/acpi/cpu.asl> diff --git a/src/soc/intel/cannonlake/acpi/platform.asl b/src/soc/intel/common/block/acpi/acpi/platform.asl similarity index 100% rename from src/soc/intel/cannonlake/acpi/platform.asl rename to src/soc/intel/common/block/acpi/acpi/platform.asl diff --git a/src/soc/intel/elkhartlake/acpi/platform.asl b/src/soc/intel/elkhartlake/acpi/platform.asl deleted file mode 100644 index 4b01aeb..0000000 --- a/src/soc/intel/elkhartlake/acpi/platform.asl +++ /dev/null @@ -1,20 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -/* Enable ACPI _SWS methods */ -#include <soc/intel/common/acpi/acpi_wake_source.asl> -/* Generic indicator for sleep state */ -#include <soc/intel/common/acpi/platform.asl> - -/* - * The _PIC method is called by the OS to choose between interrupt - * routing via the i8259 interrupt controller or the APIC. - * - * _PIC is called with a parameter of 0 for i8259 configuration and - * with a parameter of 1 for Local Apic/IOAPIC configuration. - */ - -Method (_PIC, 1) -{ - /* Remember the OS' IRQ routing choice. */ - PICM = Arg0 -} diff --git a/src/soc/intel/icelake/acpi/platform.asl b/src/soc/intel/icelake/acpi/platform.asl deleted file mode 100644 index 4b01aeb..0000000 --- a/src/soc/intel/icelake/acpi/platform.asl +++ /dev/null @@ -1,20 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -/* Enable ACPI _SWS methods */ -#include <soc/intel/common/acpi/acpi_wake_source.asl> -/* Generic indicator for sleep state */ -#include <soc/intel/common/acpi/platform.asl> - -/* - * The _PIC method is called by the OS to choose between interrupt - * routing via the i8259 interrupt controller or the APIC. - * - * _PIC is called with a parameter of 0 for i8259 configuration and - * with a parameter of 1 for Local Apic/IOAPIC configuration. - */ - -Method (_PIC, 1) -{ - /* Remember the OS' IRQ routing choice. */ - PICM = Arg0 -} diff --git a/src/soc/intel/jasperlake/acpi/platform.asl b/src/soc/intel/jasperlake/acpi/platform.asl deleted file mode 100644 index 4b01aeb..0000000 --- a/src/soc/intel/jasperlake/acpi/platform.asl +++ /dev/null @@ -1,20 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -/* Enable ACPI _SWS methods */ -#include <soc/intel/common/acpi/acpi_wake_source.asl> -/* Generic indicator for sleep state */ -#include <soc/intel/common/acpi/platform.asl> - -/* - * The _PIC method is called by the OS to choose between interrupt - * routing via the i8259 interrupt controller or the APIC. - * - * _PIC is called with a parameter of 0 for i8259 configuration and - * with a parameter of 1 for Local Apic/IOAPIC configuration. - */ - -Method (_PIC, 1) -{ - /* Remember the OS' IRQ routing choice. */ - PICM = Arg0 -} diff --git a/src/soc/intel/skylake/acpi/platform.asl b/src/soc/intel/skylake/acpi/platform.asl deleted file mode 100644 index 4b01aeb..0000000 --- a/src/soc/intel/skylake/acpi/platform.asl +++ /dev/null @@ -1,20 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -/* Enable ACPI _SWS methods */ -#include <soc/intel/common/acpi/acpi_wake_source.asl> -/* Generic indicator for sleep state */ -#include <soc/intel/common/acpi/platform.asl> - -/* - * The _PIC method is called by the OS to choose between interrupt - * routing via the i8259 interrupt controller or the APIC. - * - * _PIC is called with a parameter of 0 for i8259 configuration and - * with a parameter of 1 for Local Apic/IOAPIC configuration. - */ - -Method (_PIC, 1) -{ - /* Remember the OS' IRQ routing choice. */ - PICM = Arg0 -} diff --git a/src/soc/intel/tigerlake/acpi/platform.asl b/src/soc/intel/tigerlake/acpi/platform.asl deleted file mode 100644 index 4b01aeb..0000000 --- a/src/soc/intel/tigerlake/acpi/platform.asl +++ /dev/null @@ -1,20 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -/* Enable ACPI _SWS methods */ -#include <soc/intel/common/acpi/acpi_wake_source.asl> -/* Generic indicator for sleep state */ -#include <soc/intel/common/acpi/platform.asl> - -/* - * The _PIC method is called by the OS to choose between interrupt - * routing via the i8259 interrupt controller or the APIC. - * - * _PIC is called with a parameter of 0 for i8259 configuration and - * with a parameter of 1 for Local Apic/IOAPIC configuration. - */ - -Method (_PIC, 1) -{ - /* Remember the OS' IRQ routing choice. */ - PICM = Arg0 -} -- To view, visit https://review.coreboot.org/c/coreboot/+/45982 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5189b03d6abfaec39882d28b40a9bfa002128be3 Gerrit-Change-Number: 45982 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: newchange

3 4

Change in coreboot[master]: soc/intel/{cnl,icl,skl}: Convert 'platform.asl' to ASL 2.0 syntax
by Subrata Banik (Code Review) 05 Oct '20

05 Oct '20

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45981 ) Change subject: soc/intel/{cnl,icl,skl}: Convert 'platform.asl' to ASL 2.0 syntax ...................................................................... soc/intel/{cnl,icl,skl}: Convert 'platform.asl' to ASL 2.0 syntax Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> Change-Id: I3fcd971402e540d91a7392ca58175eb3ecc24cec --- M src/soc/intel/cannonlake/acpi/platform.asl M src/soc/intel/icelake/acpi/platform.asl M src/soc/intel/skylake/acpi/platform.asl 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/45981/1 diff --git a/src/soc/intel/cannonlake/acpi/platform.asl b/src/soc/intel/cannonlake/acpi/platform.asl index 7345864..4b01aeb 100644 --- a/src/soc/intel/cannonlake/acpi/platform.asl +++ b/src/soc/intel/cannonlake/acpi/platform.asl @@ -16,5 +16,5 @@ Method (_PIC, 1) { /* Remember the OS' IRQ routing choice. */ - Store (Arg0, PICM) + PICM = Arg0 } diff --git a/src/soc/intel/icelake/acpi/platform.asl b/src/soc/intel/icelake/acpi/platform.asl index 7345864..4b01aeb 100644 --- a/src/soc/intel/icelake/acpi/platform.asl +++ b/src/soc/intel/icelake/acpi/platform.asl @@ -16,5 +16,5 @@ Method (_PIC, 1) { /* Remember the OS' IRQ routing choice. */ - Store (Arg0, PICM) + PICM = Arg0 } diff --git a/src/soc/intel/skylake/acpi/platform.asl b/src/soc/intel/skylake/acpi/platform.asl index 7345864..4b01aeb 100644 --- a/src/soc/intel/skylake/acpi/platform.asl +++ b/src/soc/intel/skylake/acpi/platform.asl @@ -16,5 +16,5 @@ Method (_PIC, 1) { /* Remember the OS' IRQ routing choice. */ - Store (Arg0, PICM) + PICM = Arg0 } -- To view, visit https://review.coreboot.org/c/coreboot/+/45981 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3fcd971402e540d91a7392ca58175eb3ecc24cec Gerrit-Change-Number: 45981 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: newchange

3 3

Change in coreboot[master]: soc/intel/skylake: Align platform.asl with CNL
by Subrata Banik (Code Review) 05 Oct '20

05 Oct '20

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45980 ) Change subject: soc/intel/skylake: Align platform.asl with CNL ...................................................................... soc/intel/skylake: Align platform.asl with CNL Refer _WAK and _PTS ASL functions from common platform.asl TEST=Dump and disassemble DSDT, verify all methods present inside common platform.asl like _WAK, _PTS etc. are still there. Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> Change-Id: I625e42b3c49abbb3595a4307da5fc24850a98fbb --- M src/soc/intel/skylake/acpi/platform.asl 1 file changed, 2 insertions(+), 28 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/45980/1 diff --git a/src/soc/intel/skylake/acpi/platform.asl b/src/soc/intel/skylake/acpi/platform.asl index 6b9dc40..7345864 100644 --- a/src/soc/intel/skylake/acpi/platform.asl +++ b/src/soc/intel/skylake/acpi/platform.asl @@ -2,9 +2,8 @@ /* Enable ACPI _SWS methods */ #include <soc/intel/common/acpi/acpi_wake_source.asl> - -External (\_SB.MPTS, MethodObj) -External (\_SB.MWAK, MethodObj) +/* Generic indicator for sleep state */ +#include <soc/intel/common/acpi/platform.asl> /* * The _PIC method is called by the OS to choose between interrupt @@ -19,28 +18,3 @@ /* Remember the OS' IRQ routing choice. */ Store (Arg0, PICM) } - -/* - * The _PTS method (Prepare To Sleep) is called before the OS is - * entering a sleep state. The sleep state number is passed in Arg0 - */ - -Method (_PTS, 1) -{ - If (CondRefOf (\_SB.MPTS)) - { - \_SB.MPTS (Arg0) - } -} - -/* The _WAK method is called on system wakeup */ - -Method (_WAK, 1) -{ - If (CondRefOf (\_SB.MWAK)) - { - \_SB.MWAK (Arg0) - } - - Return (Package (){ 0, 0 }) -} -- To view, visit https://review.coreboot.org/c/coreboot/+/45980 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I625e42b3c49abbb3595a4307da5fc24850a98fbb Gerrit-Change-Number: 45980 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: newchange

3 7

Change in coreboot[master]: soc/intel/common/block/acpi: Factor out common smbus.asl
by Subrata Banik (Code Review) 05 Oct '20

05 Oct '20

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45979 ) Change subject: soc/intel/common/block/acpi: Factor out common smbus.asl ...................................................................... soc/intel/common/block/acpi: Factor out common smbus.asl This patch moves smbus.asl into common block acpi directory to avoid duplicating the same ASL code block across SoC directory. TEST=Able to build and boot TGL, CNL and CML platform. 1) Dump and disassemble DSDT, verify SBUS device present inside common smbus.asl is still there. 2) Verify no ACPI error seen while running 'dmesg` from console. Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> Change-Id: Ib1ae48f7ece3e521501d92c40cd551287ea2f1ec --- D src/soc/intel/cannonlake/acpi/smbus.asl M src/soc/intel/cannonlake/acpi/southbridge.asl R src/soc/intel/common/block/acpi/acpi/smbus.asl D src/soc/intel/denverton_ns/acpi/smbus.asl M src/soc/intel/denverton_ns/acpi/southcluster.asl M src/soc/intel/elkhartlake/acpi/southbridge.asl D src/soc/intel/icelake/acpi/smbus.asl M src/soc/intel/icelake/acpi/southbridge.asl D src/soc/intel/jasperlake/acpi/smbus.asl M src/soc/intel/jasperlake/acpi/southbridge.asl M src/soc/intel/skylake/acpi/pch.asl D src/soc/intel/skylake/acpi/smbus.asl D src/soc/intel/tigerlake/acpi/smbus.asl M src/soc/intel/tigerlake/acpi/southbridge.asl 14 files changed, 7 insertions(+), 55 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/45979/1 diff --git a/src/soc/intel/cannonlake/acpi/smbus.asl b/src/soc/intel/cannonlake/acpi/smbus.asl deleted file mode 100644 index 7860f60..0000000 --- a/src/soc/intel/cannonlake/acpi/smbus.asl +++ /dev/null @@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -// Intel SMBus Controller 0:1f.4 - -Device (SBUS) -{ - Name (_ADR, 0x001f0004) -} diff --git a/src/soc/intel/cannonlake/acpi/southbridge.asl b/src/soc/intel/cannonlake/acpi/southbridge.asl index 76a5445..7b6708c 100644 --- a/src/soc/intel/cannonlake/acpi/southbridge.asl +++ b/src/soc/intel/cannonlake/acpi/southbridge.asl @@ -32,7 +32,7 @@ #include "serialio.asl" /* SMBus 0:1f.4 */ -#include "smbus.asl" +#include <soc/intel/common/block/acpi/acpi/smbus.asl> /* ISH 0:13.0 */ #include "ish.asl" diff --git a/src/soc/intel/elkhartlake/acpi/smbus.asl b/src/soc/intel/common/block/acpi/acpi/smbus.asl similarity index 100% rename from src/soc/intel/elkhartlake/acpi/smbus.asl rename to src/soc/intel/common/block/acpi/acpi/smbus.asl diff --git a/src/soc/intel/denverton_ns/acpi/smbus.asl b/src/soc/intel/denverton_ns/acpi/smbus.asl deleted file mode 100644 index 7860f60..0000000 --- a/src/soc/intel/denverton_ns/acpi/smbus.asl +++ /dev/null @@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -// Intel SMBus Controller 0:1f.4 - -Device (SBUS) -{ - Name (_ADR, 0x001f0004) -} diff --git a/src/soc/intel/denverton_ns/acpi/southcluster.asl b/src/soc/intel/denverton_ns/acpi/southcluster.asl index ad9c088..68f55f2 100644 --- a/src/soc/intel/denverton_ns/acpi/southcluster.asl +++ b/src/soc/intel/denverton_ns/acpi/southcluster.asl @@ -117,7 +117,7 @@ #include "pmc.asl" // SMBus 0:1f.4 -#include "smbus.asl" +#include <soc/intel/common/block/acpi/acpi/smbus.asl> // Northpeak 0:1f.7 #include "npk.asl" diff --git a/src/soc/intel/elkhartlake/acpi/southbridge.asl b/src/soc/intel/elkhartlake/acpi/southbridge.asl index 003c4c2..d85ddac 100644 --- a/src/soc/intel/elkhartlake/acpi/southbridge.asl +++ b/src/soc/intel/elkhartlake/acpi/southbridge.asl @@ -30,7 +30,7 @@ #include "serialio.asl" /* SMBus 0:1f.4 */ -#include "smbus.asl" +#include <soc/intel/common/block/acpi/acpi/smbus.asl> /* USB XHCI 0:14.0 */ #include "xhci.asl" diff --git a/src/soc/intel/icelake/acpi/smbus.asl b/src/soc/intel/icelake/acpi/smbus.asl deleted file mode 100644 index 7860f60..0000000 --- a/src/soc/intel/icelake/acpi/smbus.asl +++ /dev/null @@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -// Intel SMBus Controller 0:1f.4 - -Device (SBUS) -{ - Name (_ADR, 0x001f0004) -} diff --git a/src/soc/intel/icelake/acpi/southbridge.asl b/src/soc/intel/icelake/acpi/southbridge.asl index 019a5f0..4abea7c 100644 --- a/src/soc/intel/icelake/acpi/southbridge.asl +++ b/src/soc/intel/icelake/acpi/southbridge.asl @@ -30,7 +30,7 @@ #include "serialio.asl" /* SMBus 0:1f.4 */ -#include "smbus.asl" +#include <soc/intel/common/block/acpi/acpi/smbus.asl> /* USB XHCI 0:14.0 */ #include "xhci.asl" diff --git a/src/soc/intel/jasperlake/acpi/smbus.asl b/src/soc/intel/jasperlake/acpi/smbus.asl deleted file mode 100644 index 6705f22..0000000 --- a/src/soc/intel/jasperlake/acpi/smbus.asl +++ /dev/null @@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -/* Intel SMBus Controller 0:1f.4 */ - -Device (SBUS) -{ - Name (_ADR, 0x001f0004) -} diff --git a/src/soc/intel/jasperlake/acpi/southbridge.asl b/src/soc/intel/jasperlake/acpi/southbridge.asl index 76a9714..c1ea273 100644 --- a/src/soc/intel/jasperlake/acpi/southbridge.asl +++ b/src/soc/intel/jasperlake/acpi/southbridge.asl @@ -33,7 +33,7 @@ #include "serialio.asl" /* SMBus 0:1f.4 */ -#include "smbus.asl" +#include <soc/intel/common/block/acpi/acpi/smbus.asl> /* ISH 0:12.0 */ #include "ish.asl" diff --git a/src/soc/intel/skylake/acpi/pch.asl b/src/soc/intel/skylake/acpi/pch.asl index 9d5f8be..6eea5bb 100644 --- a/src/soc/intel/skylake/acpi/pch.asl +++ b/src/soc/intel/skylake/acpi/pch.asl @@ -36,7 +36,7 @@ #include "serialio.asl" /* SMBus 0:1f.3 */ -#include "smbus.asl" +#include <soc/intel/common/block/acpi/acpi/smbus.asl> /* Storage Controllers */ #include "scs.asl" diff --git a/src/soc/intel/skylake/acpi/smbus.asl b/src/soc/intel/skylake/acpi/smbus.asl deleted file mode 100644 index 7860f60..0000000 --- a/src/soc/intel/skylake/acpi/smbus.asl +++ /dev/null @@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -// Intel SMBus Controller 0:1f.4 - -Device (SBUS) -{ - Name (_ADR, 0x001f0004) -} diff --git a/src/soc/intel/tigerlake/acpi/smbus.asl b/src/soc/intel/tigerlake/acpi/smbus.asl deleted file mode 100644 index 6705f22..0000000 --- a/src/soc/intel/tigerlake/acpi/smbus.asl +++ /dev/null @@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -/* Intel SMBus Controller 0:1f.4 */ - -Device (SBUS) -{ - Name (_ADR, 0x001f0004) -} diff --git a/src/soc/intel/tigerlake/acpi/southbridge.asl b/src/soc/intel/tigerlake/acpi/southbridge.asl index b193de4..7d6a0fb 100644 --- a/src/soc/intel/tigerlake/acpi/southbridge.asl +++ b/src/soc/intel/tigerlake/acpi/southbridge.asl @@ -30,7 +30,7 @@ #include "serialio.asl" /* SMBus 0:1f.4 */ -#include "smbus.asl" +#include <soc/intel/common/block/acpi/acpi/smbus.asl> /* ISH 0:12.0 */ #include "ish.asl" -- To view, visit https://review.coreboot.org/c/coreboot/+/45979 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib1ae48f7ece3e521501d92c40cd551287ea2f1ec Gerrit-Change-Number: 45979 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: newchange

3 3

Change in coreboot[master]: mainboard/intel/tglrvp: Refer to common IPU ASL
by Subrata Banik (Code Review) 05 Oct '20

05 Oct '20

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45978 ) Change subject: mainboard/intel/tglrvp: Refer to common IPU ASL ...................................................................... mainboard/intel/tglrvp: Refer to common IPU ASL This patch delete SoC local copy of ipu.asl and refer from common block ipu.asl TEST=Dump and disassemble DSDT on tglrvp, verify IPU0 device present there. Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> Change-Id: I6a0f8a919092f7bbcd64d4791746d30fdee33894 --- M src/mainboard/intel/tglrvp/dsdt.asl D src/soc/intel/tigerlake/acpi/ipu.asl 2 files changed, 1 insertion(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/45978/1 diff --git a/src/mainboard/intel/tglrvp/dsdt.asl b/src/mainboard/intel/tglrvp/dsdt.asl index e34fd58..45ad849 100644 --- a/src/mainboard/intel/tglrvp/dsdt.asl +++ b/src/mainboard/intel/tglrvp/dsdt.asl @@ -52,6 +52,6 @@ #include "acpi/mainboard.asl" /* Camera */ - #include <soc/intel/tigerlake/acpi/ipu.asl> + #include <soc/intel/common/block/acpi/acpi/ipu.asl> #include "acpi/mipi_camera.asl" } diff --git a/src/soc/intel/tigerlake/acpi/ipu.asl b/src/soc/intel/tigerlake/acpi/ipu.asl deleted file mode 100644 index b6d8e8f..0000000 --- a/src/soc/intel/tigerlake/acpi/ipu.asl +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -Scope (\_SB.PCI0) -{ - Device (IPU0) - { - Name (_ADR, 0x00050000) - Name (_DDN, "Camera and Imaging Subsystem") - } -} -- To view, visit https://review.coreboot.org/c/coreboot/+/45978 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6a0f8a919092f7bbcd64d4791746d30fdee33894 Gerrit-Change-Number: 45978 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: newchange

2 6

Change in coreboot[master]: soc/intel/jasperlake: Delete unused ipu.asl
by Subrata Banik (Code Review) 05 Oct '20

05 Oct '20

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45977 ) Change subject: soc/intel/jasperlake: Delete unused ipu.asl ...................................................................... soc/intel/jasperlake: Delete unused ipu.asl Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> Change-Id: I8c7363d442ed40c36fc01dc3608bab864865f29d --- D src/soc/intel/jasperlake/acpi/ipu.asl 1 file changed, 0 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/45977/1 diff --git a/src/soc/intel/jasperlake/acpi/ipu.asl b/src/soc/intel/jasperlake/acpi/ipu.asl deleted file mode 100644 index b6d8e8f..0000000 --- a/src/soc/intel/jasperlake/acpi/ipu.asl +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -Scope (\_SB.PCI0) -{ - Device (IPU0) - { - Name (_ADR, 0x00050000) - Name (_DDN, "Camera and Imaging Subsystem") - } -} -- To view, visit https://review.coreboot.org/c/coreboot/+/45977 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8c7363d442ed40c36fc01dc3608bab864865f29d Gerrit-Change-Number: 45977 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

2 2

Change in coreboot[master]: soc/intel/common/block: Rename IPU ACPI device
by Subrata Banik (Code Review) 05 Oct '20

05 Oct '20

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45976 ) Change subject: soc/intel/common/block: Rename IPU ACPI device ...................................................................... soc/intel/common/block: Rename IPU ACPI device IMGU->IPU0 to align with other SoC IPU entires. TEST=Dump and disassemble DSDT on poppy, verify IPU0 device present there. Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> Change-Id: I803c01f9156a56dbd903b6ba7897cc0f96b0a26a --- M src/soc/intel/common/block/acpi/acpi/ipu.asl 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/45976/1 diff --git a/src/soc/intel/common/block/acpi/acpi/ipu.asl b/src/soc/intel/common/block/acpi/acpi/ipu.asl index 2380964..ba1d9af 100644 --- a/src/soc/intel/common/block/acpi/acpi/ipu.asl +++ b/src/soc/intel/common/block/acpi/acpi/ipu.asl @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -/* IPU3 input system - Device 05, Function 0 */ -Device (IMGU) +/* Imaging Unit - Device 05, Function 0 */ +Device (IPU0) { Name (_ADR, 0x00050000) Name (_DDN, "Imaging Unit") -- To view, visit https://review.coreboot.org/c/coreboot/+/45976 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I803c01f9156a56dbd903b6ba7897cc0f96b0a26a Gerrit-Change-Number: 45976 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: newchange

2 2

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2020