coreboot-gerrit September 2019

coreboot-gerrit@coreboot.org

1 participants
1442 discussions

Change in ...coreboot[master]: 3rdparty/chromeec: Update to latest master
by Nico Huber (Code Review) 16 Sep '19

16 Sep '19

Hello HAOUAS Elyes, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/30679 to review the following change. Change subject: 3rdparty/chromeec: Update to latest master ...................................................................... 3rdparty/chromeec: Update to latest master It's been some time and there are 1420 new commits. Including one that allows reproducible builds \o/ and one that breaks building with empty $(CC) :-/ Change-Id: I5e81d5a2f1018481b9103fc5a1f4b8c72fb9deec Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M 3rdparty/chromeec M src/ec/google/chromeec/Makefile.inc 2 files changed, 5 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/30679/1 diff --git a/3rdparty/chromeec b/3rdparty/chromeec index 11bd4c0..860fe29 160000 --- a/3rdparty/chromeec +++ b/3rdparty/chromeec @@ -1 +1 @@ -Subproject commit 11bd4c0f4d11357ab830982d7dec164813c886dd +Subproject commit 860fe2962d40ee901369d1dc67f4aa7a7a42ba4d diff --git a/src/ec/google/chromeec/Makefile.inc b/src/ec/google/chromeec/Makefile.inc index 85e2599..f005cbc 100644 --- a/src/ec/google/chromeec/Makefile.inc +++ b/src/ec/google/chromeec/Makefile.inc @@ -62,6 +62,8 @@ $(obj)/mainboard/$(MAINBOARDDIR)/ecrw: $(MAKE) -C $(CHROMEEC_SOURCE) $(if $(CONFIG_CCACHE),,CCACHE=) \ out=$(abspath $(obj)/external/chromeec/$(CONFIG_EC_GOOGLE_CHROMEEC_BOARDNAME)) \ + REPRODUCIBLE_BUILD=1 \ + CC=$(GCC_CC_arm) \ CROSS_COMPILE=$(subst -cpp,-,$(CPP_arm)) \ HOST_CROSS_COMPILE= \ BOARD=$(CONFIG_EC_GOOGLE_CHROMEEC_BOARDNAME) \ @@ -99,6 +101,8 @@ $(obj)/mainboard/$(MAINBOARDDIR)/pdrw: $(MAKE) -C $(CHROMEEC_SOURCE) $(if $(CONFIG_CCACHE),,CCACHE=) \ out=$(abspath $(obj)/external/chromeec/$(CONFIG_EC_GOOGLE_CHROMEEC_PD_BOARDNAME)) \ + REPRODUCIBLE_BUILD=1 \ + CC=$(GCC_CC_arm) \ CROSS_COMPILE=$(subst -cpp,-,$(CPP_arm)) \ HOST_CROSS_COMPILE= \ BOARD=$(CONFIG_EC_GOOGLE_CHROMEEC_PD_BOARDNAME) \ -- To view, visit https://review.coreboot.org/c/coreboot/+/30679 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e81d5a2f1018481b9103fc5a1f4b8c72fb9deec Gerrit-Change-Number: 30679 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

2 2

Change in coreboot[master]: [WIP]: Filter cpp comments
by Nico Huber (Code Review) 16 Sep '19

16 Sep '19

Nico Huber has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/29640 ) Change subject: [WIP]: Filter cpp comments ...................................................................... Abandoned Turned out to be very wrong (ccache relies on the comments to track dependencies or so). -- To view, visit https://review.coreboot.org/c/coreboot/+/29640 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5fdaf8cacc26d990a7571bfe6c99a63a427d0944 Gerrit-Change-Number: 29640 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: sb/intel/*/gnvs: Drop orphaned looking, broken boilerplate
by Nico Huber (Code Review) 16 Sep '19

16 Sep '19

Nico Huber has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/20333 ) Change subject: sb/intel/*/gnvs: Drop orphaned looking, broken boilerplate ...................................................................... Abandoned Not orphaned, just an undocumented API. Given that IASL has been updated in the meantime, it shouldn't be needed anymore. -- To view, visit https://review.coreboot.org/c/coreboot/+/20333 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ee08e84dedefd6febf219476e7e166dd2abc965 Gerrit-Change-Number: 20333 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: HACK: soc/intel/broadwell: Force libgfxinit
by Nico Huber (Code Review) 16 Sep '19

16 Sep '19

Nico Huber has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/20100 ) Change subject: HACK: soc/intel/broadwell: Force libgfxinit ...................................................................... Abandoned rotten -- To view, visit https://review.coreboot.org/c/coreboot/+/20100 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id5d0c2c12b1ff8f95ba4e0223a3e9aff27547acd Gerrit-Change-Number: 20100 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: NOTFORMERGE soc/intel/skylake/pei_data: Comment about obsoleted struct
by Nico Huber (Code Review) 16 Sep '19

16 Sep '19

Nico Huber has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/19638 ) Change subject: NOTFORMERGE soc/intel/skylake/pei_data: Comment about obsoleted struct ...................................................................... Abandoned killed pei_data -- To view, visit https://review.coreboot.org/c/coreboot/+/19638 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6bfd1708b532ab8a59442a46a471fbc5e4f88697 Gerrit-Change-Number: 19638 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: drivers/i2c: add driver for PLL52C63-01 clock generator
by Felix Held (Code Review) 16 Sep '19

16 Sep '19

Felix Held has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31078 ) Change subject: drivers/i2c: add driver for PLL52C63-01 clock generator ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/31078 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If8bb25feabadcb3c9dc5190919035da340538c12 Gerrit-Change-Number: 31078 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: mainboard/lenovo/t410: Add new port
by Angel Pons (Code Review) 16 Sep '19

16 Sep '19

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/11791 ) Change subject: mainboard/lenovo/t410: Add new port ...................................................................... Patch Set 20: (1 comment) https://review.coreboot.org/c/coreboot/+/11791/17/src/mainboard/lenovo/t410… File src/mainboard/lenovo/t410/romstage.c: https://review.coreboot.org/c/coreboot/+/11791/17/src/mainboard/lenovo/t410… PS17, Line 74: static const u32 rcba_dump3[] = { : /* 3310 */ 0x02060100, 0x0000000f, 0x01020000, 0x80000000, : /* 3320 */ 0x00000000, 0x04000000, 0x00000000, 0x00000000, : /* 3330 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3340 */ 0x000fffff, 0x00000000, 0x00000000, 0x00000000, : /* 3350 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3360 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3370 */ 0x00000000, 0x00000000, 0x7f8fdfff, 0x00000000, : /* 3380 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3390 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 33a0 */ 0x00003900, 0x00000000, 0x00000000, 0x00000000, : /* 33b0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 33c0 */ 0x00010000, 0x00000000, 0x00000000, 0x0001004b, : /* 33d0 */ 0x06000008, 0x00010000, 0x00000000, 0x00000000, : /* 33e0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 33f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3400 */ 0x0000001c, 0x00000080, 0x00000000, 0x00000000, : /* 3410 */ 0x00000c61, 0x00000000, 0x16e41fe1, 0xbf4f001f, : /* 3420 */ 0x00000000, 0x00060010, 0x0000000d, 0x00000000, : /* 3430 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3440 */ 0xdeaddeed, 0x00000000, 0x00000000, 0x00000000, : /* 3450 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3460 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3470 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3480 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3490 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 34a0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 34b0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 34c0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 34d0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 34e0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 34f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3500 */ 0x2000055f, 0x2000055f, 0x2000074b, 0x2000014b, : /* 3510 */ 0x2000014b, 0x2000074b, 0x2000074b, 0x2000074b, : /* 3520 */ 0x2000055f, 0x2000055f, 0x2000074b, 0x2000074b, : /* 3530 */ 0x20000557, 0x2000055f, 0x00000000, 0x00000000, : /* 3540 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3550 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3560 */ 0x00000001, 0x000026a3, 0x00040002, 0x01000052, : /* 3570 */ 0x02000772, 0x16000f8f, 0x1800ff4f, 0x0001d630, : /* 3580 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3590 */ 0x00000003, 0x00000000, 0x00000000, 0x00000000, : /* 35a0 */ 0xfc000201, 0x3c000201, 0x00000000, 0x00000000, : /* 35b0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 35c0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 35d0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 35e0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 35f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3600 */ 0x0a001f00, 0x00000000, 0x00000000, 0x00000001, : /* 3610 */ 0x00010000, 0x00000000, 0x00000000, 0x00000000, : /* 3620 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3630 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3640 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3650 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3660 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3670 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3680 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3690 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 36a0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 36b0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 36c0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 36d0 */ 0x00000000, 0x089c0018, 0x00000000, 0x00000000, : /* 36e0 */ 0x11111111, 0x00000000, 0x00000000, 0x00000000, : /* 36f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3700 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : }; > IDK, but as it's present on x201 it seems common to have this on nehalem. This should come from inteltool RCBA dump on vendor firmware. If you're going to do a replay, at least do it with the values of the right board. -- To view, visit https://review.coreboot.org/c/coreboot/+/11791 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id9d872e643dd242e925bfb46d18076e6ad100995 Gerrit-Change-Number: 11791 Gerrit-PatchSet: 20 Gerrit-Owner: Nicolas Reinecke <nr(a)das-labor.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nicolas Reinecke <nr(a)das-labor.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Eloy Degen Gerrit-CC: Matt Parnell <mparnell(a)gmail.com> Gerrit-CC: Okashi Odayakana <okashi(a)okashi.me> Gerrit-CC: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Comment-Date: Mon, 16 Sep 2019 12:06:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mainboard/lenovo/t410: Add new port
by Patrick Rudolph (Code Review) 16 Sep '19

16 Sep '19

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/11791 ) Change subject: mainboard/lenovo/t410: Add new port ...................................................................... Patch Set 19: (1 comment) https://review.coreboot.org/c/coreboot/+/11791/17/src/mainboard/lenovo/t410… File src/mainboard/lenovo/t410/romstage.c: https://review.coreboot.org/c/coreboot/+/11791/17/src/mainboard/lenovo/t410… PS17, Line 74: static const u32 rcba_dump3[] = { : /* 3310 */ 0x02060100, 0x0000000f, 0x01020000, 0x80000000, : /* 3320 */ 0x00000000, 0x04000000, 0x00000000, 0x00000000, : /* 3330 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3340 */ 0x000fffff, 0x00000000, 0x00000000, 0x00000000, : /* 3350 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3360 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3370 */ 0x00000000, 0x00000000, 0x7f8fdfff, 0x00000000, : /* 3380 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3390 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 33a0 */ 0x00003900, 0x00000000, 0x00000000, 0x00000000, : /* 33b0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 33c0 */ 0x00010000, 0x00000000, 0x00000000, 0x0001004b, : /* 33d0 */ 0x06000008, 0x00010000, 0x00000000, 0x00000000, : /* 33e0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 33f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3400 */ 0x0000001c, 0x00000080, 0x00000000, 0x00000000, : /* 3410 */ 0x00000c61, 0x00000000, 0x16e41fe1, 0xbf4f001f, : /* 3420 */ 0x00000000, 0x00060010, 0x0000000d, 0x00000000, : /* 3430 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3440 */ 0xdeaddeed, 0x00000000, 0x00000000, 0x00000000, : /* 3450 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3460 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3470 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3480 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3490 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 34a0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 34b0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 34c0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 34d0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 34e0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 34f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3500 */ 0x2000055f, 0x2000055f, 0x2000074b, 0x2000014b, : /* 3510 */ 0x2000014b, 0x2000074b, 0x2000074b, 0x2000074b, : /* 3520 */ 0x2000055f, 0x2000055f, 0x2000074b, 0x2000074b, : /* 3530 */ 0x20000557, 0x2000055f, 0x00000000, 0x00000000, : /* 3540 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3550 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3560 */ 0x00000001, 0x000026a3, 0x00040002, 0x01000052, : /* 3570 */ 0x02000772, 0x16000f8f, 0x1800ff4f, 0x0001d630, : /* 3580 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3590 */ 0x00000003, 0x00000000, 0x00000000, 0x00000000, : /* 35a0 */ 0xfc000201, 0x3c000201, 0x00000000, 0x00000000, : /* 35b0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 35c0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 35d0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 35e0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 35f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3600 */ 0x0a001f00, 0x00000000, 0x00000000, 0x00000001, : /* 3610 */ 0x00010000, 0x00000000, 0x00000000, 0x00000000, : /* 3620 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3630 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3640 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3650 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3660 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3670 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3680 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3690 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 36a0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 36b0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 36c0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 36d0 */ 0x00000000, 0x089c0018, 0x00000000, 0x00000000, : /* 36e0 */ 0x11111111, 0x00000000, 0x00000000, 0x00000000, : /* 36f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3700 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : }; > Where does it come from? copy-paste? fresh for this board? […] IDK, but as it's present on x201 it seems common to have this on nehalem. -- To view, visit https://review.coreboot.org/c/coreboot/+/11791 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id9d872e643dd242e925bfb46d18076e6ad100995 Gerrit-Change-Number: 11791 Gerrit-PatchSet: 19 Gerrit-Owner: Nicolas Reinecke <nr(a)das-labor.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nicolas Reinecke <nr(a)das-labor.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eloy Degen Gerrit-CC: Matt Parnell <mparnell(a)gmail.com> Gerrit-CC: Okashi Odayakana <okashi(a)okashi.me> Gerrit-CC: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Comment-Date: Mon, 16 Sep 2019 10:52:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mainboard/lenovo/t410: Add new port
by Patrick Rudolph (Code Review) 16 Sep '19

16 Sep '19

Patrick Rudolph has uploaded a new patch set (#20) to the change originally created by Nicolas Reinecke. ( https://review.coreboot.org/c/coreboot/+/11791 ) Change subject: mainboard/lenovo/t410: Add new port ...................................................................... mainboard/lenovo/t410: Add new port The port is based on the x201 / t410s. 2537-vg5 / i5, no discrete gpu Tested and working: * Native raminit * Native gfxinit * Booting Seabios 1.12.1 * Booting from EHCI * Running GNU/Linux 5.0.0 * No errors in dmesg * EHCI debug on the devices left side, bottom-right * Keyboard * Fn keys (Mute, Volume, Mic) * Touchpad * TPM * Wifi * Sound * USB * Ethernet * S3 resume Testing in progress. Untested: * VGA * Displayport Bugs: * AC adapter can't be read from ACPI TODOs: * Hide internal PCI devices Details for flashing externally: 1. Disconnect all power 2. Connect the external flasher 3. Connect the power cord (This fixes internal power control) 4. Remove the power cord Change-Id: Id9d872e643dd242e925bfb46d18076e6ad100995 Signed-off-by: Nicolas Reinecke <nr(a)das-labor.org> Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M Documentation/mainboard/index.md A Documentation/mainboard/lenovo/t410.md A Documentation/mainboard/lenovo/t410_chip_location.jpg A src/mainboard/lenovo/t410/Kconfig A src/mainboard/lenovo/t410/Kconfig.name A src/mainboard/lenovo/t410/Makefile.inc A src/mainboard/lenovo/t410/acpi/dock.asl A src/mainboard/lenovo/t410/acpi/ec.asl A src/mainboard/lenovo/t410/acpi/gpe.asl A src/mainboard/lenovo/t410/acpi/platform.asl A src/mainboard/lenovo/t410/acpi/superio.asl A src/mainboard/lenovo/t410/acpi_tables.c A src/mainboard/lenovo/t410/board_info.txt A src/mainboard/lenovo/t410/cmos.default A src/mainboard/lenovo/t410/cmos.layout A src/mainboard/lenovo/t410/data.vbt A src/mainboard/lenovo/t410/devicetree.cb A src/mainboard/lenovo/t410/dock.c A src/mainboard/lenovo/t410/dock.h A src/mainboard/lenovo/t410/dsdt.asl A src/mainboard/lenovo/t410/gma-mainboard.ads A src/mainboard/lenovo/t410/gpio.c A src/mainboard/lenovo/t410/hda_verb.c A src/mainboard/lenovo/t410/mainboard.c A src/mainboard/lenovo/t410/romstage.c A src/mainboard/lenovo/t410/smi.h A src/mainboard/lenovo/t410/smihandler.c A src/mainboard/lenovo/t410/thermal.h 28 files changed, 1,705 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/11791/20 -- To view, visit https://review.coreboot.org/c/coreboot/+/11791 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id9d872e643dd242e925bfb46d18076e6ad100995 Gerrit-Change-Number: 11791 Gerrit-PatchSet: 20 Gerrit-Owner: Nicolas Reinecke <nr(a)das-labor.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nicolas Reinecke <nr(a)das-labor.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eloy Degen Gerrit-CC: Matt Parnell <mparnell(a)gmail.com> Gerrit-CC: Okashi Odayakana <okashi(a)okashi.me> Gerrit-CC: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mainboard/lenovo/t410: Add new port
by Nico Huber (Code Review) 16 Sep '19

16 Sep '19

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/11791 ) Change subject: mainboard/lenovo/t410: Add new port ...................................................................... Patch Set 19: Code-Review-1 (1 comment) The RCBA dump is a blocker, IMO. Such things make further maintenance of the code base unnecessarily hard. https://review.coreboot.org/c/coreboot/+/11791/17/src/mainboard/lenovo/t410… File src/mainboard/lenovo/t410/romstage.c: https://review.coreboot.org/c/coreboot/+/11791/17/src/mainboard/lenovo/t410… PS17, Line 74: static const u32 rcba_dump3[] = { : /* 3310 */ 0x02060100, 0x0000000f, 0x01020000, 0x80000000, : /* 3320 */ 0x00000000, 0x04000000, 0x00000000, 0x00000000, : /* 3330 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3340 */ 0x000fffff, 0x00000000, 0x00000000, 0x00000000, : /* 3350 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3360 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3370 */ 0x00000000, 0x00000000, 0x7f8fdfff, 0x00000000, : /* 3380 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3390 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 33a0 */ 0x00003900, 0x00000000, 0x00000000, 0x00000000, : /* 33b0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 33c0 */ 0x00010000, 0x00000000, 0x00000000, 0x0001004b, : /* 33d0 */ 0x06000008, 0x00010000, 0x00000000, 0x00000000, : /* 33e0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 33f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3400 */ 0x0000001c, 0x00000080, 0x00000000, 0x00000000, : /* 3410 */ 0x00000c61, 0x00000000, 0x16e41fe1, 0xbf4f001f, : /* 3420 */ 0x00000000, 0x00060010, 0x0000000d, 0x00000000, : /* 3430 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3440 */ 0xdeaddeed, 0x00000000, 0x00000000, 0x00000000, : /* 3450 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3460 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3470 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3480 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3490 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 34a0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 34b0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 34c0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 34d0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 34e0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 34f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3500 */ 0x2000055f, 0x2000055f, 0x2000074b, 0x2000014b, : /* 3510 */ 0x2000014b, 0x2000074b, 0x2000074b, 0x2000074b, : /* 3520 */ 0x2000055f, 0x2000055f, 0x2000074b, 0x2000074b, : /* 3530 */ 0x20000557, 0x2000055f, 0x00000000, 0x00000000, : /* 3540 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3550 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3560 */ 0x00000001, 0x000026a3, 0x00040002, 0x01000052, : /* 3570 */ 0x02000772, 0x16000f8f, 0x1800ff4f, 0x0001d630, : /* 3580 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3590 */ 0x00000003, 0x00000000, 0x00000000, 0x00000000, : /* 35a0 */ 0xfc000201, 0x3c000201, 0x00000000, 0x00000000, : /* 35b0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 35c0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 35d0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 35e0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 35f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3600 */ 0x0a001f00, 0x00000000, 0x00000000, 0x00000001, : /* 3610 */ 0x00010000, 0x00000000, 0x00000000, 0x00000000, : /* 3620 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3630 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3640 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3650 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3660 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3670 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3680 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3690 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 36a0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 36b0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 36c0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 36d0 */ 0x00000000, 0x089c0018, 0x00000000, 0x00000000, : /* 36e0 */ 0x11111111, 0x00000000, 0x00000000, 0x00000000, : /* 36f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : /* 3700 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, : }; > seems to boot without the replay. Where does it come from? copy-paste? fresh for this board? I don't consider ports with such replays mergable... -- To view, visit https://review.coreboot.org/c/coreboot/+/11791 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id9d872e643dd242e925bfb46d18076e6ad100995 Gerrit-Change-Number: 11791 Gerrit-PatchSet: 19 Gerrit-Owner: Nicolas Reinecke <nr(a)das-labor.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nicolas Reinecke <nr(a)das-labor.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eloy Degen Gerrit-CC: Matt Parnell <mparnell(a)gmail.com> Gerrit-CC: Okashi Odayakana <okashi(a)okashi.me> Gerrit-CC: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Comment-Date: Mon, 16 Sep 2019 10:32:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2019