coreboot-gerrit September 2019

coreboot-gerrit@coreboot.org

1 participants
1442 discussions

Change in ...coreboot[master]: [WIP] binaryPI: Refactor Makefile for PSP directory
by Kyösti Mälkki (Code Review) 17 Sep '19

17 Sep '19

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31073 Change subject: [WIP] binaryPI: Refactor Makefile for PSP directory ...................................................................... [WIP] binaryPI: Refactor Makefile for PSP directory Change-Id: I3c2d528519ac26b24159a46400f232d6acd629e9 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/southbridge/amd/pi/hudson/Makefile.inc 1 file changed, 15 insertions(+), 53 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/31073/1 diff --git a/src/southbridge/amd/pi/hudson/Makefile.inc b/src/southbridge/amd/pi/hudson/Makefile.inc index c7cd757..22e38c7 100644 --- a/src/southbridge/amd/pi/hudson/Makefile.inc +++ b/src/southbridge/amd/pi/hudson/Makefile.inc @@ -74,77 +74,39 @@ HUDSON_FWM_POSITION=$(call int-add, $(call int-subtract, 0xffffffff $(CONFIG_ROM_SIZE)) 0x20000 1) -## ifeq ($(CONFIG_HUDSON_PSP), y) -## -### 0 -## ifeq ($(CONFIG_CPU_AMD_PI_00730F01), y) FIRMWARE_LOCATE=$(dir $(call strip_quotes, $(CONFIG_AMD_PUBKEY_FILE))) FIRMWARE_TYPE= + +PSPBTLDR_FILE=$(top)/$(FIRMWARE_LOCATE)/PspBootLoader.Bypass.sbin +PSPRCVR_FILE=$(top)/$(FIRMWARE_LOCATE)/PspRecovery.sbin +PSPSCUREOS_FILE=$(top)/$(FIRMWARE_LOCATE)/PspSecureOs.sbin +PSPTRUSTLETS_FILE=$(top)/$(FIRMWARE_LOCATE)/trustlets.bin +TRUSTLETKEY_FILE=$(top)/$(FIRMWARE_LOCATE)/Trustlet.tkn.cert endif -## + + ifeq ($(CONFIG_CPU_AMD_PI_00660F01), y) FIRMWARE_LOCATE=$(dir $(call strip_quotes, $(CONFIG_AMD_PUBKEY_FILE))) FIRMWARE_TYPE=CZ + +PSPBTLDR_FILE=$(top)/$(FIRMWARE_LOCATE)/PspBootLoader_prod_CZ.sbin +PSPRCVR_FILE=$(top)/$(FIRMWARE_LOCATE)/PspRecoveryBootLoader_prod_CZ.sbin +PSPSCUREOS_FILE=$(top)/$(FIRMWARE_LOCATE)/PspSecureOs_prod_CZ.csbin +PSPTRUSTLETS_FILE=$(top)/$(FIRMWARE_LOCATE)/PspTrustlets_prod_CZ.cbin +TRUSTLETKEY_FILE=$(top)/$(FIRMWARE_LOCATE)/TrustletKey_prod_CZ.sbin +SMUFIRMWARE2_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuFirmware2_prod_CZ.sbin endif -###5 PUBSIGNEDKEY_FILE=$(top)/$(FIRMWARE_LOCATE)/RtmPubSigned$(FIRMWARE_TYPE).key -###1 -ifeq ($(CONFIG_CPU_AMD_PI_00730F01), y) -PSPBTLDR_FILE=$(top)/$(FIRMWARE_LOCATE)/PspBootLoader$(FIRMWARE_TYPE).Bypass.sbin -else ifeq ($(CONFIG_CPU_AMD_PI_00660F01), y) -PSPBTLDR_FILE=$(top)/$(FIRMWARE_LOCATE)/PspBootLoader_prod_$(FIRMWARE_TYPE).sbin -endif - -###3 -ifeq ($(CONFIG_CPU_AMD_PI_00730F01), y) -PSPRCVR_FILE=$(top)/$(FIRMWARE_LOCATE)/PspRecovery$(FIRMWARE_TYPE).sbin -else ifeq ($(CONFIG_CPU_AMD_PI_00660F01), y) -PSPRCVR_FILE=$(top)/$(FIRMWARE_LOCATE)/PspRecoveryBootLoader_prod_$(FIRMWARE_TYPE).sbin -endif - -###2 -ifeq ($(CONFIG_CPU_AMD_PI_00730F01), y) -PSPSCUREOS_FILE=$(top)/$(FIRMWARE_LOCATE)/PspSecureOs$(FIRMWARE_TYPE).sbin -else ifeq ($(CONFIG_CPU_AMD_PI_00660F01), y) -PSPSCUREOS_FILE=$(top)/$(FIRMWARE_LOCATE)/PspSecureOs_prod_$(FIRMWARE_TYPE).csbin -endif - -###4 PSPNVRAM_FILE=$(top)/$(FIRMWARE_LOCATE)/PspNvram$(FIRMWARE_TYPE).bin - -###8 SMUFWM_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuFirmware$(FIRMWARE_TYPE).sbin SMUFWM_FN_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuFirmware$(FIRMWARE_TYPE)_FN.sbin - -###95 SMUSCS_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuScs$(FIRMWARE_TYPE).bin - -###9 PSPSECUREDEBUG_FILE=$(top)/$(FIRMWARE_LOCATE)/PspSecureDebug$(FIRMWARE_TYPE).Key -###12 -ifeq ($(CONFIG_CPU_AMD_PI_00730F01), y) -PSPTRUSTLETS_FILE=$(top)/$(FIRMWARE_LOCATE)/trustlets.bin -else ifeq ($(CONFIG_CPU_AMD_PI_00660F01), y) -PSPTRUSTLETS_FILE=$(top)/$(FIRMWARE_LOCATE)/PspTrustlets_prod_$(FIRMWARE_TYPE).cbin -endif - -###13 -ifeq ($(CONFIG_CPU_AMD_PI_00730F01), y) -TRUSTLETKEY_FILE=$(top)/$(FIRMWARE_LOCATE)/Trustlet.tkn.cert -else ifeq ($(CONFIG_CPU_AMD_PI_00660F01), y) -TRUSTLETKEY_FILE=$(top)/$(FIRMWARE_LOCATE)/TrustletKey_prod_$(FIRMWARE_TYPE).sbin -endif - -###18 -ifeq ($(CONFIG_CPU_AMD_PI_00660F01), y) -SMUFIRMWARE2_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuFirmware2_prod_$(FIRMWARE_TYPE).sbin -endif - endif add_opt_prefix=$(if $(call strip_quotes, $(1)), $(2) $(call strip_quotes, $(1)), ) -- To view, visit https://review.coreboot.org/c/coreboot/+/31073 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c2d528519ac26b24159a46400f232d6acd629e9 Gerrit-Change-Number: 31073 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newchange

3 4

Change in ...coreboot[master]: google/kukui: Pass reset gpio parameter to BL31
by Tristan Hsieh (Code Review) 17 Sep '19

17 Sep '19

Tristan Hsieh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31605 Change subject: google/kukui: Pass reset gpio parameter to BL31 ...................................................................... google/kukui: Pass reset gpio parameter to BL31 To support gpio reset SoC, we need to pass the reset gpio parameter to BL31. BUG=b:80501386 BRANCH=none TEST=Boots correctly on Kukui and ATF(BL31) can get this parameter. Change-Id: Iefa70dc0714a9283a79f97d475b07ac047f5f3b0 Signed-off-by: Tristan Shieh <tristan.shieh(a)mediatek.com> --- M src/mainboard/google/kukui/mainboard.c 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/31605/1 diff --git a/src/mainboard/google/kukui/mainboard.c b/src/mainboard/google/kukui/mainboard.c index e1d8f5f..489762d 100644 --- a/src/mainboard/google/kukui/mainboard.c +++ b/src/mainboard/google/kukui/mainboard.c @@ -14,10 +14,13 @@ */ #include <device/device.h> +#include <soc/bl31_plat_params.h> #include <soc/gpio.h> #include <soc/mmu_operations.h> #include <soc/usb.h> +#include "gpio.h" + static void configure_emmc(void) { const gpio_t emmc_pin[] = { @@ -37,10 +40,28 @@ setup_usb_host(); } +static void register_reset_to_bl31(void) +{ + static struct bl31_gpio_param param_reset = { + .h = { + .type = PARAM_RESET, + }, + .gpio = { + .polarity = BL31_GPIO_LEVEL_HIGH, + .direction = BL31_GPIO_DIR_OUT, + }, + }; + + param_reset.gpio.index = GPIO_RESET.id; + register_bl31_param(&param_reset.h); +} + static void mainboard_init(struct device *dev) { configure_emmc(); configure_usb(); + + register_reset_to_bl31(); } static void mainboard_enable(struct device *dev) -- To view, visit https://review.coreboot.org/c/coreboot/+/31605 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iefa70dc0714a9283a79f97d475b07ac047f5f3b0 Gerrit-Change-Number: 31605 Gerrit-PatchSet: 1 Gerrit-Owner: Tristan Hsieh <tristan.shieh(a)mediatek.com> Gerrit-MessageType: newchange

7 12

Change in coreboot[master]: AUTHORS: Move src/device copyrights into AUTHORS file
by Martin Roth (Code Review) 17 Sep '19

17 Sep '19

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35430 ) Change subject: AUTHORS: Move src/device copyrights into AUTHORS file ...................................................................... AUTHORS: Move src/device copyrights into AUTHORS file As discussed on the mailing list and voted upon, the coreboot project is going to move the majority of copyrights out of the headers and into an AUTHORS file. This will happen a bit at a time, as we'll be unifying license headers at the same time. Additional cleanup - Unify "Inc" to "Inc." and "LLC." to "LLC" Signed-off-by: Martin Roth <martin(a)coreboot.org> Change-Id: Ie03a3ce1f6085494bd5f38da76e2467970cf301a --- M AUTHORS M src/device/Kconfig M src/device/azalia_device.c M src/device/cardbus_device.c M src/device/cpu_device.c M src/device/device.c M src/device/device_const.c M src/device/device_util.c M src/device/dram/ddr2.c M src/device/dram/ddr3.c M src/device/dram/ddr4.c M src/device/dram/ddr_common.c M src/device/hypertransport.c M src/device/i2c.c M src/device/mmio.c M src/device/oprom/Makefile.inc M src/device/oprom/realmode/Makefile.inc M src/device/oprom/realmode/x86.c M src/device/oprom/realmode/x86.h M src/device/oprom/realmode/x86_asm.S M src/device/oprom/realmode/x86_interrupts.c M src/device/pci_class.c M src/device/pci_device.c M src/device/pci_early.c M src/device/pci_rom.c M src/device/pciexp_device.c M src/device/pcix_device.c M src/device/pnp_device.c M src/device/root_device.c M src/device/smbus_ops.c M src/device/software_i2c.c 31 files changed, 22 insertions(+), 146 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/35430/1 diff --git a/AUTHORS b/AUTHORS index 63c5fd2..72521a1 100644 --- a/AUTHORS +++ b/AUTHORS @@ -9,7 +9,7 @@ # For patches adding or removing a name: git log -i -S "NAME" --source --all 9elements Agency GmbH -Advanced Micro Devices, Inc +Advanced Micro Devices, Inc. Alex Züpke Alexander Couzens Alexandru Gagniuc @@ -19,16 +19,24 @@ Carl-Daniel Hailfinger coresystems GmbH Damien Zammit +David Hendricks +David Mosberger-Tang Denis Dowling DENX Software Engineering +DMP Electronics Inc. +Drew Eckhardt +Egbert Eich Eric Biederman Eswar Nallusamy Facebook, Inc. +Felix Held +Frederic Potter Free Software Foundation, Inc. -Freescale Semiconductor, Inc +Freescale Semiconductor, Inc. Gary Jennejohn Gerd Hoffmann Google LLC +Greg Watson Imagination Technologies Intel Corporation Jason Zhao @@ -38,26 +46,33 @@ Kshitij Kyösti Mälkki Lei Wen +Li-Ta Lo Libra Li Linus Torvalds +Linux Networx, Inc. Marc Jones Marek Vasut Marius Gröger -Marvell Semiconductor Inc +Martin Mares +Marvell Semiconductor Inc. +MediaTek Inc. MontaVista Software, Inc. +Myles Watson Nicholas Sielicki Nick Barker +Nico Huber Patrick Georgi Patrick Rudolph PC Engines GmbH Per Odlund Peter Stuge -Raptor Engineering, LLC. +Raptor Engineering, LLC Richard Woodruff Ronald G. Minnich Rudolf Marek Russell King Sage Electronic Engineering, LLC +SciTech Software, Inc. secunet Security Networks AG Siemens AG Silicon Integrated System Corporation @@ -83,3 +98,4 @@ src/commonlib src/console src/cpu +src/device diff --git a/src/device/Kconfig b/src/device/Kconfig index 0b90833..97ed997 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -1,9 +1,6 @@ ## ## This file is part of the coreboot project. ## -## Copyright (C) 2007-2010 coresystems GmbH -## (Written by Stefan Reinauer <stepan(a)coresystems.de> for coresystems GmbH) -## ## This program is free software; you can redistribute it and/or modify ## it under the terms of the GNU General Public License as published by ## the Free Software Foundation; version 2 of the License. diff --git a/src/device/azalia_device.c b/src/device/azalia_device.c index a2849b7..5c8a67e 100644 --- a/src/device/azalia_device.c +++ b/src/device/azalia_device.c @@ -1,8 +1,6 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2013 DMP Electronics Inc. - * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; version 2 of the License. diff --git a/src/device/cardbus_device.c b/src/device/cardbus_device.c index adfc503..a440746 100644 --- a/src/device/cardbus_device.c +++ b/src/device/cardbus_device.c @@ -1,10 +1,6 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2005 Linux Networx - * (Written by Eric Biederman <ebiederman(a)lnxi.com> for Linux Networx) - * Copyright (C) 2005 Ronald G. Minnich <rminnich(a)gmail.com> - * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; version 2 of the License. diff --git a/src/device/cpu_device.c b/src/device/cpu_device.c index f59cce3..a786dc0 100644 --- a/src/device/cpu_device.c +++ b/src/device/cpu_device.c @@ -1,9 +1,6 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2011 Advanced Micro Devices, Inc. - * Copyright (C) 2012 Kyösti Mälkki <kyosti.malkki(a)gmail.com> - * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; version 2 of the License. diff --git a/src/device/device.c b/src/device/device.c index 17cd8f4..44d1f95 100644 --- a/src/device/device.c +++ b/src/device/device.c @@ -1,20 +1,6 @@ /* * This file is part of the coreboot project. * - * It was originally based on the Linux kernel (arch/i386/kernel/pci-pc.c). - * - * Modifications are: - * Copyright (C) 2003 Eric Biederman <ebiederm(a)xmission.com> - * Copyright (C) 2003-2004 Linux Networx - * (Written by Eric Biederman <ebiederman(a)lnxi.com> for Linux Networx) - * Copyright (C) 2003 Ronald G. Minnich <rminnich(a)gmail.com> - * Copyright (C) 2004-2005 Li-Ta Lo <ollie(a)lanl.gov> - * Copyright (C) 2005-2006 Tyan - * (Written by Yinghai Lu <yhlu(a)tyan.com> for Tyan) - * Copyright (C) 2005-2006 Stefan Reinauer <stepan(a)openbios.org> - * Copyright (C) 2009 Myles Watson <mylesgw(a)gmail.com> - * Copyright (c) 1999--2000 Martin Mares <mj(a)suse.cz> - * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; version 2 of the License. @@ -26,16 +12,7 @@ */ /* - * Lots of mods by Ron Minnich <rminnich(a)lanl.gov>, with - * the final architecture guidance from Tom Merritt <tjm(a)codegen.com>. - * - * In particular, we changed from the one-pass original version to - * Tom's recommended multiple-pass version. I wasn't sure about doing - * it with multiple passes, until I actually started doing it and saw - * the wisdom of Tom's recommendations... - * - * Lots of cleanups by Eric Biederman to handle bridges, and to - * handle resource allocation for non-PCI devices. + * Originally based on the Linux kernel (arch/i386/kernel/pci-pc.c). */ #include <console/console.h> diff --git a/src/device/device_const.c b/src/device/device_const.c index 0712d0c..5143563 100644 --- a/src/device/device_const.c +++ b/src/device/device_const.c @@ -1,13 +1,6 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2003-2004 Linux Networx - * (Written by Eric Biederman <ebiederman(a)lnxi.com> for Linux Networx) - * Copyright (C) 2003 Greg Watson <jarrah(a)users.sourceforge.net> - * Copyright (C) 2004 Li-Ta Lo <ollie(a)lanl.gov> - * Copyright (C) 2005-2006 Tyan - * (Written by Yinghai Lu <yhlu(a)tyan.com> for Tyan) - * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; version 2 of the License. diff --git a/src/device/device_util.c b/src/device/device_util.c index 38303126b..df66f5c 100644 --- a/src/device/device_util.c +++ b/src/device/device_util.c @@ -1,13 +1,6 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2003-2004 Linux Networx - * (Written by Eric Biederman <ebiederman(a)lnxi.com> for Linux Networx) - * Copyright (C) 2003 Greg Watson <jarrah(a)users.sourceforge.net> - * Copyright (C) 2004 Li-Ta Lo <ollie(a)lanl.gov> - * Copyright (C) 2005-2006 Tyan - * (Written by Yinghai Lu <yhlu(a)tyan.com> for Tyan) - * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; version 2 of the License. diff --git a/src/device/dram/ddr2.c b/src/device/dram/ddr2.c index d66b576..5319806 100644 --- a/src/device/dram/ddr2.c +++ b/src/device/dram/ddr2.c @@ -1,9 +1,6 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2017 Patrick Rudolph <siro(a)das-labor.org> - * Copyright (C) 2017 Arthur Heymans <arthur(a)aheymans.xyz> - * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation, either version 2 of the License, or diff --git a/src/device/dram/ddr3.c b/src/device/dram/ddr3.c index 4a900fa..3f0c0a7 100644 --- a/src/device/dram/ddr3.c +++ b/src/device/dram/ddr3.c @@ -1,8 +1,6 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2011-2013 Alexandru Gagniuc <mr.nuke.me(a)gmail.com> - * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation, either version 2 of the License, or diff --git a/src/device/dram/ddr4.c b/src/device/dram/ddr4.c index 5927b41..4f99ecc 100644 --- a/src/device/dram/ddr4.c +++ b/src/device/dram/ddr4.c @@ -1,8 +1,6 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2019 Facebook, Inc. - * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; version 2 of the License. diff --git a/src/device/dram/ddr_common.c b/src/device/dram/ddr_common.c index eb36bf5..bc87712 100644 --- a/src/device/dram/ddr_common.c +++ b/src/device/dram/ddr_common.c @@ -1,8 +1,6 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2019 Facebook, Inc. - * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; version 2 of the License. diff --git a/src/device/hypertransport.c b/src/device/hypertransport.c index 027c3ef..1a8f7e6 100644 --- a/src/device/hypertransport.c +++ b/src/device/hypertransport.c @@ -1,15 +1,6 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2003-2004 Linux Networx - * (Written by Eric Biederman <ebiederman(a)lnxi.com> for Linux Networx) - * Copyright (C) 2004 David Hendricks <sc(a)flagen.com> - * Copyright (C) 2004 Li-Ta Lo <ollie(a)lanl.gov> - * Copyright (C) 2005-2006 Tyan - * (Written by Yinghai Lu <yhlu(a)tyan.com> for Tyan) - * Copyright (C) 2005-2006 Stefan Reinauer <stepan(a)openbios.org> - * Copyright (C) 2015 Timothy Pearson <tpearson(a)raptorengineeringinc.com>, Raptor Engineering - * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; version 2 of the License. diff --git a/src/device/i2c.c b/src/device/i2c.c index aa695ca..fb29b72 100644 --- a/src/device/i2c.c +++ b/src/device/i2c.c @@ -1,8 +1,6 @@ /* * This file is part of the coreboot project. * - * Copyright 2016 MediaTek Inc. - * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; version 2 of the License. diff --git a/src/device/mmio.c b/src/device/mmio.c index 61a1130..643ff04 100644 --- a/src/device/mmio.c +++ b/src/device/mmio.c @@ -1,8 +1,6 @@ /* * This file is part of the coreboot project. * - * Copyright 2019 Google LLC - * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; version 2 of the License. diff --git a/src/device/oprom/Makefile.inc b/src/device/oprom/Makefile.inc index 61970ae..64b4b87 100644 --- a/src/device/oprom/Makefile.inc +++ b/src/device/oprom/Makefile.inc @@ -1,8 +1,6 @@ ## ## This file is part of the coreboot project. ## -## Copyright (C) 2007-2010 coresystems GmbH -## ## This program is free software; you can redistribute it and/or modify ## it under the terms of the GNU General Public License as published by ## the Free Software Foundation; version 2 of the License. diff --git a/src/device/oprom/realmode/Makefile.inc b/src/device/oprom/realmode/Makefile.inc index 5417240..6f8cde3 100644 --- a/src/device/oprom/realmode/Makefile.inc +++ b/src/device/oprom/realmode/Makefile.inc @@ -1,8 +1,6 @@ ## ## This file is part of the coreboot project. ## -## Copyright (C) 2012 secunet Security Networks AG -## ## This program is free software; you can redistribute it and/or modify ## it under the terms of the GNU General Public License as published by ## the Free Software Foundation; version 2 of the License. diff --git a/src/device/oprom/realmode/x86.c b/src/device/oprom/realmode/x86.c index 10a3c49..8ba0241 100644 --- a/src/device/oprom/realmode/x86.c +++ b/src/device/oprom/realmode/x86.c @@ -1,9 +1,6 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2007 Advanced Micro Devices, Inc. - * Copyright (C) 2009-2010 coresystems GmbH - * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; version 2 of the License. diff --git a/src/device/oprom/realmode/x86.h b/src/device/oprom/realmode/x86.h index 052c9c0..a68b50e 100644 --- a/src/device/oprom/realmode/x86.h +++ b/src/device/oprom/realmode/x86.h @@ -1,9 +1,6 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2007 Advanced Micro Devices, Inc. - * Copyright (C) 2009-2010 coresystems GmbH - * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; version 2 of the License. diff --git a/src/device/oprom/realmode/x86_asm.S b/src/device/oprom/realmode/x86_asm.S index ec82e53..8c9e12b 100644 --- a/src/device/oprom/realmode/x86_asm.S +++ b/src/device/oprom/realmode/x86_asm.S @@ -1,8 +1,6 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2009-2010 coresystems GmbH - * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; version 2 of the License. diff --git a/src/device/oprom/realmode/x86_interrupts.c b/src/device/oprom/realmode/x86_interrupts.c index 8e3a51e..4e1c5ed 100644 --- a/src/device/oprom/realmode/x86_interrupts.c +++ b/src/device/oprom/realmode/x86_interrupts.c @@ -1,10 +1,6 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2001 Ronald G. Minnich - * Copyright (C) 2005 Nick.Barker9(a)btinternet.com - * Copyright (C) 2007-2009 coresystems GmbH - * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; version 2 of the License. diff --git a/src/device/pci_class.c b/src/device/pci_class.c index d9c3a4f..ca36154 100644 --- a/src/device/pci_class.c +++ b/src/device/pci_class.c @@ -1,9 +1,6 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2013 Google Inc. - * Copyright (C) 2015 Intel Corp. - * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; version 2 of the License. diff --git a/src/device/pci_device.c b/src/device/pci_device.c index 84fc82c..7ecb652 100644 --- a/src/device/pci_device.c +++ b/src/device/pci_device.c @@ -1,22 +1,6 @@ /* * This file is part of the coreboot project. * - * It was originally based on the Linux kernel (drivers/pci/pci.c). - * Copyright 1993 -- 1997 Drew Eckhardt, Frederic Potter, - * David Mosberger-Tang - * - * Copyright 1997 -- 1999 Martin Mares <mj(a)atrey.karlin.mff.cuni.cz> - * - * Copyright (C) 2003-2004 Linux Networx - * (Written by Eric Biederman <ebiederman(a)lnxi.com> for Linux Networx) - * Copyright (C) 2003-2006 Ronald G. Minnich <rminnich(a)gmail.com> - * Copyright (C) 2004-2005 Li-Ta Lo <ollie(a)lanl.gov> - * Copyright (C) 2005-2006 Tyan - * (Written by Yinghai Lu <yhlu(a)tyan.com> for Tyan) - * Copyright (C) 2005-2009 coresystems GmbH - * (Written by Stefan Reinauer <stepan(a)coresystems.de> for coresystems GmbH) - * Copyright (C) 2014 Sage Electronic Engineering, LLC. - * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; version 2 of the License. @@ -28,6 +12,7 @@ */ /* + * Originally based on the Linux kernel (drivers/pci/pci.c). * PCI Bus Services, see include/linux/pci.h for further explanation. */ diff --git a/src/device/pci_early.c b/src/device/pci_early.c index 7c9ea00..880480d 100644 --- a/src/device/pci_early.c +++ b/src/device/pci_early.c @@ -1,8 +1,6 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2011 Google Inc - * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; version 2 of the License. diff --git a/src/device/pci_rom.c b/src/device/pci_rom.c index 2b2d46d..01c02e5 100644 --- a/src/device/pci_rom.c +++ b/src/device/pci_rom.c @@ -1,12 +1,6 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2005 Li-Ta Lo <ollie(a)lanl.gov> - * Copyright (C) 2005 Tyan - * (Written by Yinghai Lu <yhlu(a)tyan.com> for Tyan) - * Copyright (C) 2005 Ronald G. Minnich <rminnich(a)gmail.com> - * Copyright (C) 2005-2007 Stefan Reinauer <stepan(a)openbios.org> - * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; version 2 of the License. diff --git a/src/device/pciexp_device.c b/src/device/pciexp_device.c index c209816..9a45be8 100644 --- a/src/device/pciexp_device.c +++ b/src/device/pciexp_device.c @@ -1,9 +1,6 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2005 Linux Networx - * (Written by Eric Biederman <ebiederman(a)lnxi.com> for Linux Networx) - * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; version 2 of the License. diff --git a/src/device/pcix_device.c b/src/device/pcix_device.c index e327b88..1db4d4a 100644 --- a/src/device/pcix_device.c +++ b/src/device/pcix_device.c @@ -1,9 +1,6 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2005 Linux Networx - * (Written by Eric Biederman <ebiederman(a)lnxi.com> for Linux Networx) - * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; version 2 of the License. diff --git a/src/device/pnp_device.c b/src/device/pnp_device.c index 402e5d1..164fc19 100644 --- a/src/device/pnp_device.c +++ b/src/device/pnp_device.c @@ -1,14 +1,6 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2004 Linux Networx - * (Written by Eric Biederman <ebiederman(a)lnxi.com> for Linux Networx) - * Copyright (C) 2004 Li-Ta Lo <ollie(a)lanl.gov> - * Copyright (C) 2005 Tyan - * (Written by Yinghai Lu <yhlu(a)tyan.com> for Tyan) - * Copyright (C) 2013 Nico Huber <nico.h(a)gmx.de> - * Copyright (C) 2018 Felix Held <felix-coreboot(a)felixheld.de> - * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; version 2 of the License. diff --git a/src/device/root_device.c b/src/device/root_device.c index f8e2907..beeead2 100644 --- a/src/device/root_device.c +++ b/src/device/root_device.c @@ -1,13 +1,6 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2003-2004 Linux Networx - * (Written by Eric Biederman <ebiederman(a)lnxi.com> for Linux Networx) - * Copyright (C) 2003 Ronald G. Minnich <rminnich(a)gmail.com> - * Copyright (C) 2004-2005 Li-Ta Lo <ollie(a)lanl.gov> - * Copyright (C) 2005 Tyan - * (Written by Yinghai Lu <yhlu(a)tyan.com> for Tyan) - * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; version 2 of the License. diff --git a/src/device/smbus_ops.c b/src/device/smbus_ops.c index c91f415..13e6cad 100644 --- a/src/device/smbus_ops.c +++ b/src/device/smbus_ops.c @@ -1,10 +1,6 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2004 Tyan - * (Written by Yinghai Lu <yhlu(a)tyan.com> for Tyan) - * Copyright (C) 2004 Li-Ta Lo <ollie(a)lanl.gov> - * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; version 2 of the License. diff --git a/src/device/software_i2c.c b/src/device/software_i2c.c index 402f1d4..5dc9990 100644 --- a/src/device/software_i2c.c +++ b/src/device/software_i2c.c @@ -1,8 +1,6 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2014 Google, Inc. - * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; version 2 of the License. -- To view, visit https://review.coreboot.org/c/coreboot/+/35430 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie03a3ce1f6085494bd5f38da76e2467970cf301a Gerrit-Change-Number: 35430 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

2 2

Change in coreboot[master]: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF
by Nico Huber (Code Review) 17 Sep '19

17 Sep '19

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32734 ) Change subject: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF ...................................................................... Patch Set 82: (1 comment) https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/… File src/mainboard/supermicro/x11ssh/Kconfig.name: https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/… PS74, Line 1: BOARD_SUPERMICRO_X11SSH_PLUS_TF : bool "X11SSH+-TF" > Not done Can somebody elaborate how the + got there? As it's also part of the Kconfig symbol, I'd guess it was intentional. Was it? -- To view, visit https://review.coreboot.org/c/coreboot/+/32734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2edaa4a928de3a065e517c0f20e3302b4b702323 Gerrit-Change-Number: 32734 Gerrit-PatchSet: 82 Gerrit-Owner: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Keno Fischer <keno(a)alumni.harvard.edu> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Name of user not set #1002358 Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: T. Hudson <trammell.hudson(a)gmail.com> Gerrit-Reviewer: Trammell Hudson <hudson(a)trmm.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Christoph Pomaska <github(a)aufmachen.jetzt> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-CC: Michael Niewöhner Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 17 Sep 2019 08:10:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: editorconfig: add max. line length
by Michael Niewöhner (Code Review) 17 Sep '19

17 Sep '19

Michael Niewöhner has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35412 ) Change subject: editorconfig: add max. line length ...................................................................... editorconfig: add max. line length Change-Id: Ic9515cd9623369fbebf720e339f4fef122e4b525 --- M .editorconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/35412/1 diff --git a/.editorconfig b/.editorconfig index eb44fcd..b9d4fc4 100644 --- a/.editorconfig +++ b/.editorconfig @@ -9,3 +9,4 @@ insert_final_newline = true end_of_line = lf trim_trailing_whitespace = true +max_line_length = 73 -- To view, visit https://review.coreboot.org/c/coreboot/+/35412 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9515cd9623369fbebf720e339f4fef122e4b525 Gerrit-Change-Number: 35412 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner Gerrit-MessageType: newchange

3 8

Change in coreboot[master]: [TEST] pushing with new machine
by Bora Guvendik (Code Review) 16 Sep '19

16 Sep '19

Bora Guvendik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35441 ) Change subject: [TEST] pushing with new machine ...................................................................... [TEST] pushing with new machine Change-Id: Ieb7f6553a24af6bd4603ccb653e74b8ac19c05ae Signed-off-by: Bora Guvendik <bora.guvendik(a)intel.com> --- M src/mainboard/google/drallion/romstage.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/35441/1 diff --git a/src/mainboard/google/drallion/romstage.c b/src/mainboard/google/drallion/romstage.c index 20eee7f..f449fd6 100644 --- a/src/mainboard/google/drallion/romstage.c +++ b/src/mainboard/google/drallion/romstage.c @@ -12,7 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. */ - #include <ec/google/wilco/romstage.h> #include <soc/cnl_memcfg_init.h> #include <soc/romstage.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/35441 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb7f6553a24af6bd4603ccb653e74b8ac19c05ae Gerrit-Change-Number: 35441 Gerrit-PatchSet: 1 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-MessageType: newchange

1 1

Change in ...coreboot[master]: src/Kconfig: increase size if using flattened image tree
by Marty E. Plummer (Code Review) 16 Sep '19

16 Sep '19

Marty E. Plummer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32392 Change subject: src/Kconfig: increase size if using flattened image tree ...................................................................... src/Kconfig: increase size if using flattened image tree FIT support takes more heap memory than most coreboot payloads. Change-Id: Id17f25e94d97e937b0e9a9cee3dd1a8aef1d525d Signed-off-by: Marty E. Plummer <hanetzer(a)startmail.com> --- M src/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/32392/1 diff --git a/src/Kconfig b/src/Kconfig index 62b3818..90c724e 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -428,6 +428,7 @@ config HEAP_SIZE hex + default 0x100000 if FLATTENED_DEVICE_TREE default 0x4000 config STACK_SIZE -- To view, visit https://review.coreboot.org/c/coreboot/+/32392 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id17f25e94d97e937b0e9a9cee3dd1a8aef1d525d Gerrit-Change-Number: 32392 Gerrit-PatchSet: 1 Gerrit-Owner: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-MessageType: newchange

5 13

Change in coreboot[master]: Documentation: rename "Rookie guide" to "code labs"
by Patrick Georgi (Code Review) 16 Sep '19

16 Sep '19

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35425 ) Change subject: Documentation: rename "Rookie guide" to "code labs" ...................................................................... Documentation: rename "Rookie guide" to "code labs" We generally try to stay away from ascribing attributes to (future) devs. "Rookie guide" refers to the reader, while "code labs" refers to the material. In the same spirit, move from "lessons" to "parts". It's not school :-) Change-Id: I11a69a2a05ba9a0bc48f8bf62463d9585da043ec Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- A Documentation/codelabs/index.md R Documentation/codelabs/part1.md R Documentation/codelabs/part2.md M Documentation/index.md D Documentation/lessons/index.md M Documentation/mainboard/supermicro/x10slm-f.md 6 files changed, 9 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/35425/1 diff --git a/Documentation/codelabs/index.md b/Documentation/codelabs/index.md new file mode 100644 index 0000000..66b9be7 --- /dev/null +++ b/Documentation/codelabs/index.md @@ -0,0 +1,4 @@ +# Code labs + +* [Part 1: Starting from scratch](part1.md) +* [Part 2: Submitting a patch to coreboot.org](part2.md) diff --git a/Documentation/lessons/lesson1.md b/Documentation/codelabs/part1.md similarity index 98% rename from Documentation/lessons/lesson1.md rename to Documentation/codelabs/part1.md index bbb3eb5..2ebb955 100644 --- a/Documentation/lessons/lesson1.md +++ b/Documentation/codelabs/part1.md @@ -1,5 +1,5 @@ -coreboot Lesson 1: Starting from scratch -======================================== +coreboot code lab #1: Starting from scratch +=========================================== From a fresh Ubuntu 16.04 or 18.04 install, here are all the steps required for a very basic build: diff --git a/Documentation/lessons/lesson2.md b/Documentation/codelabs/part2.md similarity index 98% rename from Documentation/lessons/lesson2.md rename to Documentation/codelabs/part2.md index ae70c70..55222a9 100644 --- a/Documentation/lessons/lesson2.md +++ b/Documentation/codelabs/part2.md @@ -1,4 +1,4 @@ -# coreboot Lesson 2: Submitting a patch to coreboot.org +# coreboot code lab #2: Submitting a patch to coreboot.org ## Part 1: Setting up an account at coreboot.org diff --git a/Documentation/index.md b/Documentation/index.md index 50141b5..43194ce 100644 --- a/Documentation/index.md +++ b/Documentation/index.md @@ -161,7 +161,7 @@ Contents: * [Getting Started](getting_started/index.md) -* [Rookie Guide](lessons/index.md) +* [Code labs](codelabs/index.md) * [Coding Style](coding_style.md) * [Project Ideas](contributing/project_ideas.md) * [Code of Conduct](community/code_of_conduct.md) diff --git a/Documentation/lessons/index.md b/Documentation/lessons/index.md deleted file mode 100644 index 6540e8c..0000000 --- a/Documentation/lessons/index.md +++ /dev/null @@ -1,4 +0,0 @@ -# Rookie Guide - -* [Lesson 1: Starting from scratch](lesson1.md) -* [Lesson 2: Submitting a patch to coreboot.org](lesson2.md) diff --git a/Documentation/mainboard/supermicro/x10slm-f.md b/Documentation/mainboard/supermicro/x10slm-f.md index 2c2e6a8..8832e45 100644 --- a/Documentation/mainboard/supermicro/x10slm-f.md +++ b/Documentation/mainboard/supermicro/x10slm-f.md @@ -12,7 +12,7 @@ ```eval_rst If you haven't already, build the coreboot toolchain as described in -:doc:`../../lessons/lesson1`. +:doc:`../../codelabs/part1`. ``` A fully working image should be possible so long as you have the -- To view, visit https://review.coreboot.org/c/coreboot/+/35425 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I11a69a2a05ba9a0bc48f8bf62463d9585da043ec Gerrit-Change-Number: 35425 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

6 11

Change in coreboot[master]: Documentation: minor grammar fixes
by Patrick Georgi (Code Review) 16 Sep '19

16 Sep '19

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35424 ) Change subject: Documentation: minor grammar fixes ...................................................................... Documentation: minor grammar fixes Change-Id: Iff6df888a293b525d436a5be215e8972ae2dd46a Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M Documentation/getting_started/gerrit_guidelines.md 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/35424/1 diff --git a/Documentation/getting_started/gerrit_guidelines.md b/Documentation/getting_started/gerrit_guidelines.md index 34104d8..7e549a9 100644 --- a/Documentation/getting_started/gerrit_guidelines.md +++ b/Documentation/getting_started/gerrit_guidelines.md @@ -47,10 +47,10 @@ before submission. Remember that there are coreboot developers in timezones all over the world, and everyone should have a chance to contribute. Trivial patches would be things like whitespace changes or spelling fixes. -In general, small changes that don’t impact the final binary output. The +In general, small changes don’t impact the final binary output. The 24-hour period would start at submission, and would be restarted at any update which significantly changes any part of the patch. Patches can be -'Fast-tracked' and submitted in under this 24 hour with the agreement of at +'Fast-tracked' and submitted in under 24 hours with the agreement of at least 3 +2 votes. * Do not +2 patches that you authored or own, even for something as trivial -- To view, visit https://review.coreboot.org/c/coreboot/+/35424 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iff6df888a293b525d436a5be215e8972ae2dd46a Gerrit-Change-Number: 35424 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

5 9

Change in ...coreboot[master]: sb/intel/i82801ix: Allow to compile with flashconsole
by Nico Huber (Code Review) 16 Sep '19

16 Sep '19

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31269 Change subject: sb/intel/i82801ix: Allow to compile with flashconsole ...................................................................... sb/intel/i82801ix: Allow to compile with flashconsole Change-Id: Ib8c5a1853b21fc0b70b688f6176ee2edaf4dbdaa Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M src/southbridge/intel/i82801ix/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/31269/1 diff --git a/src/southbridge/intel/i82801ix/Kconfig b/src/southbridge/intel/i82801ix/Kconfig index 571778a..0787c94 100644 --- a/src/southbridge/intel/i82801ix/Kconfig +++ b/src/southbridge/intel/i82801ix/Kconfig @@ -26,6 +26,7 @@ select HAVE_USBDEBUG_OPTIONS select SOUTHBRIDGE_INTEL_COMMON_GPIO select SOUTHBRIDGE_INTEL_COMMON_SMM + select SOUTHBRIDGE_INTEL_COMMON_SPI if CONSOLE_SPI_FLASH select INTEL_DESCRIPTOR_MODE_CAPABLE select ACPI_INTEL_HARDWARE_SLEEP_VALUES -- To view, visit https://review.coreboot.org/c/coreboot/+/31269 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib8c5a1853b21fc0b70b688f6176ee2edaf4dbdaa Gerrit-Change-Number: 31269 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newchange

2 2

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2019