Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35424 )
Change subject: Documentation: minor grammar fixes ......................................................................
Documentation: minor grammar fixes
Change-Id: Iff6df888a293b525d436a5be215e8972ae2dd46a Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Documentation/getting_started/gerrit_guidelines.md 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/35424/1
diff --git a/Documentation/getting_started/gerrit_guidelines.md b/Documentation/getting_started/gerrit_guidelines.md index 34104d8..7e549a9 100644 --- a/Documentation/getting_started/gerrit_guidelines.md +++ b/Documentation/getting_started/gerrit_guidelines.md @@ -47,10 +47,10 @@ before submission. Remember that there are coreboot developers in timezones all over the world, and everyone should have a chance to contribute. Trivial patches would be things like whitespace changes or spelling fixes. -In general, small changes that don’t impact the final binary output. The +In general, small changes don’t impact the final binary output. The 24-hour period would start at submission, and would be restarted at any update which significantly changes any part of the patch. Patches can be -'Fast-tracked' and submitted in under this 24 hour with the agreement of at +'Fast-tracked' and submitted in under 24 hours with the agreement of at least 3 +2 votes.
* Do not +2 patches that you authored or own, even for something as trivial
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35424 )
Change subject: Documentation: minor grammar fixes ......................................................................
Patch Set 1: Code-Review+2
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35424 )
Change subject: Documentation: minor grammar fixes ......................................................................
Patch Set 1: Code-Review+2
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35424 )
Change subject: Documentation: minor grammar fixes ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/35424/1/Documentation/getting_start... File Documentation/getting_started/gerrit_guidelines.md:
https://review.coreboot.org/c/coreboot/+/35424/1/Documentation/getting_start... PS1, Line 50: In general, small changes don’t impact the final binary output. this changes the the meaning of this sentence to something that's untrue; there can be small changes that change the output binary
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35424 )
Change subject: Documentation: minor grammar fixes ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35424/1/Documentation/getting_start... File Documentation/getting_started/gerrit_guidelines.md:
https://review.coreboot.org/c/coreboot/+/35424/1/Documentation/getting_start... PS1, Line 50: In general, small changes don’t impact the final binary output.
this changes the the meaning of this sentence to something that's untrue; there can be small changes […]
It doesn't really change the meaning, it gives meaning ;-) But I clarified it.
Hello Felix Held, Angel Pons, Arthur Heymans, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35424
to look at the new patch set (#2).
Change subject: Documentation: minor grammar fixes ......................................................................
Documentation: minor grammar fixes
Change-Id: Iff6df888a293b525d436a5be215e8972ae2dd46a Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Documentation/getting_started/gerrit_guidelines.md 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/35424/2
Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35424 )
Change subject: Documentation: minor grammar fixes ......................................................................
Patch Set 2: Code-Review+2
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35424 )
Change subject: Documentation: minor grammar fixes ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35424 )
Change subject: Documentation: minor grammar fixes ......................................................................
Patch Set 2: Code-Review+2
I wonder what happens when a change has 3 +2... Oh.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35424 )
Change subject: Documentation: minor grammar fixes ......................................................................
Documentation: minor grammar fixes
Change-Id: Iff6df888a293b525d436a5be215e8972ae2dd46a Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35424 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Lance Zhao lance.zhao@gmail.com Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Angel Pons th3fanbus@gmail.com --- M Documentation/getting_started/gerrit_guidelines.md 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Lance Zhao: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/Documentation/getting_started/gerrit_guidelines.md b/Documentation/getting_started/gerrit_guidelines.md index 34104d8..735ba3b 100644 --- a/Documentation/getting_started/gerrit_guidelines.md +++ b/Documentation/getting_started/gerrit_guidelines.md @@ -46,11 +46,11 @@ * Let non-trivial patches sit in a review state for at least 24 hours before submission. Remember that there are coreboot developers in timezones all over the world, and everyone should have a chance to contribute. -Trivial patches would be things like whitespace changes or spelling fixes. -In general, small changes that don’t impact the final binary output. The +Trivial patches would be things like whitespace changes or spelling fixes, +in general those that don’t impact the final binary output. The 24-hour period would start at submission, and would be restarted at any update which significantly changes any part of the patch. Patches can be -'Fast-tracked' and submitted in under this 24 hour with the agreement of at +'Fast-tracked' and submitted in under 24 hours with the agreement of at least 3 +2 votes.
* Do not +2 patches that you authored or own, even for something as trivial
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Felix Held (Code Review)
-
Lance Zhao (Code Review)
-
Patrick Georgi (Code Review)