coreboot-gerrit May 2019

coreboot-gerrit@coreboot.org

1 participants
1485 discussions

Change in ...coreboot[master]: cpu/amd/fam10: Link fidvid.c
by Arthur Heymans (Code Review) 26 May '19

26 May '19

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/20973 ) Change subject: cpu/amd/fam10: Link fidvid.c ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/20973 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I724fa6c3ba0cc4fdfb11cc28fd54611c5959f2fb Gerrit-Change-Number: 20973 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: nb/amd/mct: Don't include all needed headers in mct_d.h
by Arthur Heymans (Code Review) 26 May '19

26 May '19

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/20972 ) Change subject: nb/amd/mct: Don't include all needed headers in mct_d.h ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/20972 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I454eb9f00c8ffebd7a48bf9cb65d012b3fc335f2 Gerrit-Change-Number: 20972 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: nb/amd/mct: Fix building with DQS_TRAIN_DEBUG > 0
by Arthur Heymans (Code Review) 26 May '19

26 May '19

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/20975 ) Change subject: nb/amd/mct: Fix building with DQS_TRAIN_DEBUG > 0 ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/20975 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7d56f4cb5660466b7cf193a08adbfc17834c7a50 Gerrit-Change-Number: 20975 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: nb/amd/amdfam10/amdfam10.h: Clean up header
by Arthur Heymans (Code Review) 26 May '19

26 May '19

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/20974 ) Change subject: nb/amd/amdfam10/amdfam10.h: Clean up header ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/20974 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3df97a038cf265423cb7019d1639a3d47d4871f7 Gerrit-Change-Number: 20974 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: cpu/amd/fam10: Reduce headers included in init_cpus.h
by Arthur Heymans (Code Review) 26 May '19

26 May '19

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/20976 ) Change subject: cpu/amd/fam10: Reduce headers included in init_cpus.h ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/20976 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id91caa7c55367e794802788d9007920817f2d484 Gerrit-Change-Number: 20976 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: [WIP]ec/lenovo/h8: Add nvram option to set mute button behavior
by Arthur Heymans (Code Review) 26 May '19

26 May '19

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/20944 ) Change subject: [WIP]ec/lenovo/h8: Add nvram option to set mute button behavior ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/20944 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7979d5868e0df0c02d96e238ee879c1f1fec359 Gerrit-Change-Number: 20944 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: [WIP]console/Kconfig: fix SPI flash console dependencies
by Arthur Heymans (Code Review) 26 May '19

26 May '19

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/20892 ) Change subject: [WIP]console/Kconfig: fix SPI flash console dependencies ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/20892 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I713389ef9ed5e965fc34b590a86f4b5e2e84d304 Gerrit-Change-Number: 20892 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: [UNTESTED]mb/lenovo/t400: Make dock LEDs behave like vendor bios
by Arthur Heymans (Code Review) 26 May '19

26 May '19

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/19542 ) Change subject: [UNTESTED]mb/lenovo/t400: Make dock LEDs behave like vendor bios ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/19542 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia3ff479dba687216c537bc810ec561dfc98d25b1 Gerrit-Change-Number: 19542 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: util/board_status.sh: Clone board_status repo with --depth 1
by Arthur Heymans (Code Review) 26 May '19

26 May '19

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/19124 ) Change subject: util/board_status.sh: Clone board_status repo with --depth 1 ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/19124 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d32ce35cfddad9cc156cf00e9d5b61a3d2135eb Gerrit-Change-Number: 19124 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: intel/sandybridge: Make timC training more robust.
by Patrick Rudolph (Code Review) 26 May '19

26 May '19

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/22776 ) Change subject: intel/sandybridge: Make timC training more robust. ...................................................................... Patch Set 3: (2 comments) https://review.coreboot.org/#/c/22776/3/src/northbridge/intel/sandybridge/r… File src/northbridge/intel/sandybridge/raminit_common.c: https://review.coreboot.org/#/c/22776/3/src/northbridge/intel/sandybridge/r… PS3, Line 1577: rn.length < 8 > Why? 0 errors is 0 errors... if the lane is erroneous there might be a single good sample. In that case rn.all is not true, and the following raminit will fail as we didn't pick the optimal value, instead we pick a random "good" one. This check ensures that the area is big enough. It happens in 1 out of 10 boots that I don't hit rn.all and thus the PC won't boot. https://review.coreboot.org/#/c/22776/3/src/northbridge/intel/sandybridge/r… PS3, Line 1581: avarage > The average is a very high since most of the entries will have the max (4000) errors. […] usually you will only see 4000 and 0, but as tests showed in an error case it can be anything. taking the average between min and max seems the best solution. As this is a recovery attempt that is seldom taken I'd not try to improve it any more, as it gives good results already. -- To view, visit https://review.coreboot.org/c/coreboot/+/22776 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9986616e86560c4980ccd8e3e549af53caa15c71 Gerrit-Change-Number: 22776 Gerrit-PatchSet: 3 Gerrit-Owner: Tobias Diedrich <ranma+coreboot(a)tdiedrich.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tobias Diedrich <ranma+coreboot(a)tdiedrich.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 26 May 2019 08:45:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2019