coreboot-gerrit May 2019

coreboot-gerrit@coreboot.org

1 participants
1485 discussions

Change in ...coreboot[master]: {drivers,soc/intel/braswell}: Implement C_ENVIRONMENT_BOOTBLOCK support
by Frans Hendriks (Code Review) 27 May '19

27 May '19

1 0

Change in ...coreboot[master]: {drivers,soc/intel/braswell}: Implement C_ENVIRONMENT_BOOTBLOCK support
by Frans Hendriks (Code Review) 27 May '19

27 May '19

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29662 ) Change subject: {drivers,soc/intel/braswell}: Implement C_ENVIRONMENT_BOOTBLOCK support ...................................................................... Patch Set 30: (2 comments) > Patch Set 30: > > (3 comments) > > > Patch Set 30: > > > > > Patch Set 30: > > > > > > (3 comments) > > > > > > You might want to rebase on top of https://review.coreboot.org/q/topic:%22fsp1.1+cleanup . It cleans up a few things and should make the transition and the bootflow in general cleaner. It gets rid of the many functions that do nothing but calling the next one, like the one in car_stage_entry.S > > > > I was wondering how to combine your cleanup and this patch. > > I tested a few of your patches, not all of them yet. > > > > Will rebase on top of your patch next week. > > I was curious if your patch properly applied on top of the branch. Simply cherry-picking your patch on top of my branch applies rather ok. Not too many changes needed (mostly keep stuff from my branch that was cleaned up). If you want I could push it. I can also comment on a few things that I noticed went wrong. No problem if you push the update. https://review.coreboot.org/#/c/29662/30/src/soc/intel/braswell/bootblock/c… File src/soc/intel/braswell/bootblock/cache_as_ram.S: https://review.coreboot.org/#/c/29662/30/src/soc/intel/braswell/bootblock/c… PS30, Line 1: /* > I wouldn't move this file, since it is FSP-T specific, not braswell (I hope no-one does, but one cou […] Agree with move to drivers/intel/fsp1_1. Is there any need to add with Kconfig option? AFAIK currently only Braswell is using FSP1.1. https://review.coreboot.org/#/c/29662/30/src/soc/intel/braswell/bootblock/c… PS30, Line 49: .global cache_as_ram > unneeded? Ack can be removed. -- To view, visit https://review.coreboot.org/c/coreboot/+/29662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab48ad72f1514c93f20d70db5ef4fd8fa2383e8c Gerrit-Change-Number: 29662 Gerrit-PatchSet: 30 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com> Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: York Yang <yyang024(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 27 May 2019 07:36:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/common/p2sb.c: Improve fetching the device variable
by Arthur Heymans (Code Review) 26 May '19

26 May '19

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/30395 ) Change subject: soc/intel/common/p2sb.c: Improve fetching the device variable ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/30395 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f10887170c07cd36cb1a94602142ce585cf537e Gerrit-Change-Number: 30395 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: arch/x86/car.ld: Add symbol to share the BIST across CAR stages
by Arthur Heymans (Code Review) 26 May '19

26 May '19

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/30482 ) Change subject: arch/x86/car.ld: Add symbol to share the BIST across CAR stages ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/30482 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I78761b024b97bc644aef076b122902c43989b09f Gerrit-Change-Number: 30482 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: mb/lenovo/t400: Enable PCIe port on dock
by Arthur Heymans (Code Review) 26 May '19

26 May '19

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/27121 ) Change subject: mb/lenovo/t400: Enable PCIe port on dock ...................................................................... Abandoned Not working -- To view, visit https://review.coreboot.org/c/coreboot/+/27121 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2ad8a37988f2b6b5974ce0bdb565a7729e6dd15d Gerrit-Change-Number: 27121 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Homero De Carvalho <homero_programador(a)yahoo.com.br> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: mb/lenovo/x200: Add ACPI methods to set battery thresholds
by Arthur Heymans (Code Review) 26 May '19

26 May '19

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/20913 ) Change subject: mb/lenovo/x200: Add ACPI methods to set battery thresholds ...................................................................... Abandoned something similar was merged -- To view, visit https://review.coreboot.org/c/coreboot/+/20913 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia049407cea7a60887ecba7b7c96e5000473865dd Gerrit-Change-Number: 20913 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: intel/gma/Makefile.inc: Add a helper function to add VBT binaries
by Arthur Heymans (Code Review) 26 May '19

26 May '19

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/30428 ) Change subject: intel/gma/Makefile.inc: Add a helper function to add VBT binaries ...................................................................... Abandoned something similar was already merged -- To view, visit https://review.coreboot.org/c/coreboot/+/30428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I80d9b3421f6e539879ad4802119fe81d7ea1e234 Gerrit-Change-Number: 30428 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: nb/intel/x4x: Improve D0F0_DEVEN programming
by Arthur Heymans (Code Review) 26 May '19

26 May '19

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/26798 ) Change subject: nb/intel/x4x: Improve D0F0_DEVEN programming ...................................................................... Abandoned Those bits are hardcoded iirc, so it does not matter much... -- To view, visit https://review.coreboot.org/c/coreboot/+/26798 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I007927e19a8ea716ba6c188a92144325a077c21d Gerrit-Change-Number: 26798 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: nb/amd/mct_ddr3/mct_d.c: Break out of allow_config_restore loop
by Arthur Heymans (Code Review) 26 May '19

26 May '19

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/20971 ) Change subject: nb/amd/mct_ddr3/mct_d.c: Break out of allow_config_restore loop ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/20971 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie669d1bc38411e40ab95c28b17ee8818874dc741 Gerrit-Change-Number: 20971 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raptor Engineering Automated Test Stand <noreply(a)raptorengineeringinc.com> Gerrit-Reviewer: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: nb/amd/amdfam10/debug.c: Fix building with DEBUG_SMBUS
by Arthur Heymans (Code Review) 26 May '19

26 May '19

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/20970 ) Change subject: nb/amd/amdfam10/debug.c: Fix building with DEBUG_SMBUS ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/20970 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iebe8aa1c4c3019414c6a23404cc5dc7f668cd8eb Gerrit-Change-Number: 20970 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raptor Engineering Automated Test Stand <noreply(a)raptorengineeringinc.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2019