Hello Piotr Król, Thomas Heijligen, build bot (Jenkins), Michał Żygowski,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/29477
to look at the new patch set (#8).
Change subject: x86/smbios: Untangle system and board tables
......................................................................
x86/smbios: Untangle system and board tables
We were used to set the same values in the system and board tables.
We'll keep the mainboard values as defaults for the system tables,
so nothing changes unless somebody overrides the system table hooks.
Change-Id: I3c9c95a1307529c3137647a161a698a4c3daa0ae
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
M src/Kconfig
M src/arch/x86/smbios.c
M src/drivers/i2c/at24rf08c/Kconfig
M src/drivers/i2c/at24rf08c/lenovo_serials.c
M src/include/smbios.h
M src/mainboard/emulation/qemu-i440fx/fw_cfg.c
M src/mainboard/google/fizz/mainboard.c
M src/mainboard/google/hatch/mainboard.c
M src/mainboard/google/kahlee/mainboard.c
M src/mainboard/google/octopus/mainboard.c
M src/mainboard/google/poppy/variants/nami/mainboard.c
M src/mainboard/google/poppy/variants/nautilus/mainboard.c
M src/mainboard/google/poppy/variants/rammus/mainboard.c
M src/mainboard/google/reef/mainboard.c
M src/mainboard/google/sarien/sku.c
M src/mainboard/pcengines/apu1/mainboard.c
M src/mainboard/pcengines/apu2/mainboard.c
M src/mainboard/scaleway/tagada/ramstage.c
18 files changed, 68 insertions(+), 60 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/29477/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/29477
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3c9c95a1307529c3137647a161a698a4c3daa0ae
Gerrit-Change-Number: 29477
Gerrit-PatchSet: 8
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-MessageType: newpatchset
Hello Angel Pons, Thomas Heijligen, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/29480
to look at the new patch set (#8).
Change subject: [WIP] mb/kontron/bsl6: Add new Skylake COMe module
......................................................................
[WIP] mb/kontron/bsl6: Add new Skylake COMe module
Add Kontron/bSL6 together with Siemens/Boxer26, a baseboard for the
bSL6.
Change-Id: If2b6a3f1e9dd095463f1f1521068b9f66a9189c5
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
A src/mainboard/kontron/bsl6/Kconfig
A src/mainboard/kontron/bsl6/Kconfig.name
A src/mainboard/kontron/bsl6/Makefile.inc
A src/mainboard/kontron/bsl6/acpi/ec.asl
A src/mainboard/kontron/bsl6/acpi/mainboard.asl
A src/mainboard/kontron/bsl6/acpi/superio.asl
A src/mainboard/kontron/bsl6/acpi_tables.c
A src/mainboard/kontron/bsl6/board_info.txt
A src/mainboard/kontron/bsl6/bootblock.c
A src/mainboard/kontron/bsl6/cmos.default
A src/mainboard/kontron/bsl6/cmos.layout
A src/mainboard/kontron/bsl6/dsdt.asl
A src/mainboard/kontron/bsl6/gpio.h
A src/mainboard/kontron/bsl6/ramstage.c
A src/mainboard/kontron/bsl6/romstage.c
A src/mainboard/kontron/bsl6/variant.h
A src/mainboard/kontron/bsl6/variants/boxer26/boxer26_eeprom.h
A src/mainboard/kontron/bsl6/variants/boxer26/devicetree.cb
A src/mainboard/kontron/bsl6/variants/boxer26/gma-mainboard.ads
A src/mainboard/kontron/bsl6/variants/boxer26/romstage.c
A src/mainboard/kontron/bsl6/variants/boxer26/smbios.c
A src/mainboard/kontron/bsl6/variants/bsl6/devicetree.cb
A src/mainboard/kontron/bsl6/variants/bsl6/gma-mainboard.ads
A src/mainboard/kontron/bsl6/variants/bsl6/romstage.c
24 files changed, 1,451 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/29480/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/29480
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If2b6a3f1e9dd095463f1f1521068b9f66a9189c5
Gerrit-Change-Number: 29480
Gerrit-PatchSet: 8
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
Hello Kyösti Mälkki, Arthur Heymans, Paul Menzel, Thomas Heijligen, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/29478
to look at the new patch set (#7).
Change subject: device/i2c_bus: Add i2c_dev_readb_at_word()
......................................................................
device/i2c_bus: Add i2c_dev_readb_at_word()
Does the same as i2c_dev_readb_at() but sends a 2-byte offset to the I2C
chip (for larger EEPROM parts).
Change-Id: I7516f3e5d9aca362c2b340aa5627d91510c09412
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
M src/device/i2c_bus.c
M src/include/device/i2c_bus.h
2 files changed, 47 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/29478/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/29478
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7516f3e5d9aca362c2b340aa5627d91510c09412
Gerrit-Change-Number: 29478
Gerrit-PatchSet: 7
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Hello Piotr Król, Thomas Heijligen, build bot (Jenkins), Michał Żygowski,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/29477
to look at the new patch set (#7).
Change subject: x86/smbios: Untangle system and board tables
......................................................................
x86/smbios: Untangle system and board tables
We were used to set the same values in the system and board tables.
We'll keep the mainboard values as defaults for the system tables,
so nothing changes unless somebody overrides the system table hooks.
Change-Id: I3c9c95a1307529c3137647a161a698a4c3daa0ae
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
M src/Kconfig
M src/arch/x86/smbios.c
M src/drivers/i2c/at24rf08c/Kconfig
M src/drivers/i2c/at24rf08c/lenovo_serials.c
M src/include/smbios.h
M src/mainboard/emulation/qemu-i440fx/fw_cfg.c
M src/mainboard/google/fizz/mainboard.c
M src/mainboard/google/hatch/mainboard.c
M src/mainboard/google/kahlee/mainboard.c
M src/mainboard/google/octopus/mainboard.c
M src/mainboard/google/poppy/variants/nami/mainboard.c
M src/mainboard/google/poppy/variants/nautilus/mainboard.c
M src/mainboard/google/poppy/variants/rammus/mainboard.c
M src/mainboard/google/reef/mainboard.c
M src/mainboard/google/sarien/sku.c
M src/mainboard/pcengines/apu1/mainboard.c
M src/mainboard/pcengines/apu2/mainboard.c
M src/mainboard/scaleway/tagada/ramstage.c
18 files changed, 68 insertions(+), 60 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/29477/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/29477
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3c9c95a1307529c3137647a161a698a4c3daa0ae
Gerrit-Change-Number: 29477
Gerrit-PatchSet: 7
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-MessageType: newpatchset
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/21194 )
Change subject: drivers/i2c/lm96000: Add new hardware-monitoring IC
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/21194
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie7df3107bffb7f8e45e71c4c1fbe4eb0a9e3cd03
Gerrit-Change-Number: 21194
Gerrit-PatchSet: 9
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Thu, 14 Mar 2019 16:22:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29475 )
Change subject: drivers/i2c/nct7802y: Add new hardware-monitoring IC
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/29475
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I35ea79e12941804e398c6304a08170a776f4ca76
Gerrit-Change-Number: 29475
Gerrit-PatchSet: 6
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 14 Mar 2019 16:18:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29474 )
Change subject: device: Use scan_static_bus() over scan_lpc_bus()
......................................................................
Patch Set 6:
I have no strong feelings about this, I kind of liked it if logs did not change due the renaming.
--
To view, visit https://review.coreboot.org/c/coreboot/+/29474
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0eb005e41b9168fffc344ee8e666d43b605a30ba
Gerrit-Change-Number: 29474
Gerrit-PatchSet: 6
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com>
Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Reviewer: York Yang <york.yang(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Thu, 14 Mar 2019 15:50:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hello Aaron Durbin, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31752
to look at the new patch set (#4).
Change subject: device/pci: Rewrite PCI MMCONF with symbol reference
......................................................................
device/pci: Rewrite PCI MMCONF with symbol reference
The effect of pointer aliasing on writes is that any data on CPU
registers that has been resolved from (non-const and non-volatile)
memory objects has to be discarded and resolved. In other words, the
compiler assumes that a pointer that does not have an absolute value
at build-time, and is of type 'void *' or 'char *', may write over
any memory object.
Using a unique datatype for MMIO writes makes the pointer to _not_
qualify for pointer aliasing with any other objects in memory. This
avoid constantly resolving the PCI MMCONF address, which is a derived
value from a 'struct device *'.
Change-Id: Id112aa5e729ffd8015bb806786bdee38783b7ea9
Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
---
A src/arch/x86/include/arch/pci_mmio_cfg_romcc.h
M src/arch/x86/include/arch/pci_ops.h
M src/device/Makefile.inc
M src/device/pci_ops.c
M src/include/device/pci_mmio_cfg.h
5 files changed, 112 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/31752/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/31752
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id112aa5e729ffd8015bb806786bdee38783b7ea9
Gerrit-Change-Number: 31752
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
Hello Kyösti Mälkki, Aaron Durbin, Thomas Heijligen, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/29474
to look at the new patch set (#6).
Change subject: device: Use scan_static_bus() over scan_lpc_bus()
......................................................................
device: Use scan_static_bus() over scan_lpc_bus()
Devices behind LPC can expose more buses (e.g. I2C on a super-i/o).
So we should scan buses on LPC devices, too.
Change-Id: I0eb005e41b9168fffc344ee8e666d43b605a30ba
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
M src/device/root_device.c
M src/include/device/device.h
M src/northbridge/via/vx900/lpc.c
M src/northbridge/via/vx900/traf_ctrl.c
M src/soc/amd/stoneyridge/lpc.c
M src/soc/intel/baytrail/southcluster.c
M src/soc/intel/braswell/southcluster.c
M src/soc/intel/broadwell/lpc.c
M src/soc/intel/common/block/lpc/lpc.c
M src/soc/intel/common/block/pmc/pmc.c
M src/soc/intel/denverton_ns/lpc.c
M src/soc/intel/fsp_baytrail/southcluster.c
M src/soc/intel/fsp_broadwell_de/southcluster.c
M src/soc/intel/quark/lpc.c
M src/southbridge/amd/agesa/hudson/lpc.c
M src/southbridge/amd/amd8111/lpc.c
M src/southbridge/amd/cimx/sb800/late.c
M src/southbridge/amd/cimx/sb900/late.c
M src/southbridge/amd/pi/hudson/lpc.c
M src/southbridge/amd/sb700/lpc.c
M src/southbridge/amd/sb800/lpc.c
M src/southbridge/broadcom/bcm5785/lpc.c
M src/southbridge/intel/bd82x6x/lpc.c
M src/southbridge/intel/fsp_rangeley/lpc.c
M src/southbridge/intel/i82371eb/isa.c
M src/southbridge/intel/i82801dx/lpc.c
M src/southbridge/intel/i82801gx/lpc.c
M src/southbridge/intel/i82801ix/lpc.c
M src/southbridge/intel/i82801jx/lpc.c
M src/southbridge/intel/ibexpeak/lpc.c
M src/southbridge/intel/lynxpoint/lpc.c
M src/southbridge/nvidia/ck804/lpc.c
M src/southbridge/nvidia/mcp55/lpc.c
33 files changed, 31 insertions(+), 41 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/29474/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/29474
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0eb005e41b9168fffc344ee8e666d43b605a30ba
Gerrit-Change-Number: 29474
Gerrit-PatchSet: 6
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset