coreboot-gerrit March 2019

coreboot-gerrit@coreboot.org

1 participants
1542 discussions

Change in ...coreboot[master]: cpu/intel/model_1067x: Don't try to apply MCU a second time
by Nico Huber (Code Review) 01 Mar '19

01 Mar '19

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31665 Change subject: cpu/intel/model_1067x: Don't try to apply MCU a second time ...................................................................... cpu/intel/model_1067x: Don't try to apply MCU a second time Applying microcode updates a second time seems to be only necessary on newer platforms (Nehalem+) for "uncore" updates. Change-Id: Ia2ee9c70677190ffd1a08df1101d39a14fc2c384 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M src/cpu/intel/model_1067x/mp_init.c 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/31665/1 diff --git a/src/cpu/intel/model_1067x/mp_init.c b/src/cpu/intel/model_1067x/mp_init.c index b8b3159..4b67893 100644 --- a/src/cpu/intel/model_1067x/mp_init.c +++ b/src/cpu/intel/model_1067x/mp_init.c @@ -85,9 +85,6 @@ /* Relocate the SMM handler. */ smm_relocate(); - - /* After SMM relocation a 2nd microcode load is required. */ - intel_microcode_load_unlocked(microcode_patch); } static void post_mp_init(void) -- To view, visit https://review.coreboot.org/c/coreboot/+/31665 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia2ee9c70677190ffd1a08df1101d39a14fc2c384 Gerrit-Change-Number: 31665 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newchange

4 3

Change in ...coreboot[master]: mb/google/sarien: ALC3204 HDA verb table pin config change
by Joyce Toh (Code Review) 01 Mar '19

01 Mar '19

Joyce Toh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31624 Change subject: mb/google/sarien: ALC3204 HDA verb table pin config change ...................................................................... mb/google/sarien: ALC3204 HDA verb table pin config change On Sarien, change pin config of 0x19 (headset mic) and 0x21(headset headphone) to change jack location so that naming does not use "Front" in the name."Front Headphone" --> "Headphone" so it matches naming on Arcada. BUG=b:126334749 TEST= build coreboot with change and verify with 'evtest' command that jack name is "HDA Intel PCH Headphone" not "HDA Intel PCH Front Headphone". Change-Id: I36ccf0c0a3952ab363fe6ee313fac8f0cce4dd61 Signed-off-by: Joyce Toh <joyce.toh(a)intel.com> --- M src/mainboard/google/sarien/variants/sarien/include/variant/hda_verb.h 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/31624/1 diff --git a/src/mainboard/google/sarien/variants/sarien/include/variant/hda_verb.h b/src/mainboard/google/sarien/variants/sarien/include/variant/hda_verb.h index 52ebb48..6eb6d14 100644 --- a/src/mainboard/google/sarien/variants/sarien/include/variant/hda_verb.h +++ b/src/mainboard/google/sarien/variants/sarien/include/variant/hda_verb.h @@ -34,12 +34,12 @@ AZALIA_PIN_CFG(0x0, 0x13, 0x40000000), AZALIA_PIN_CFG(0x0, 0x14, 0x90170110), AZALIA_PIN_CFG(0x0, 0x18, 0x411111f0), - AZALIA_PIN_CFG(0x0, 0x19, 0x02a11030), + AZALIA_PIN_CFG(0x0, 0x19, 0x04a11030), AZALIA_PIN_CFG(0x0, 0x1a, 0x411111f0), AZALIA_PIN_CFG(0x0, 0x1b, 0x411111f0), AZALIA_PIN_CFG(0x0, 0x1d, 0x40700001), AZALIA_PIN_CFG(0x0, 0x1e, 0x421212f2), - AZALIA_PIN_CFG(0x0, 0x21, 0x02211020), + AZALIA_PIN_CFG(0x0, 0x21, 0x04211020), /* ALC3204 default-1 */ 0x02050040, -- To view, visit https://review.coreboot.org/c/coreboot/+/31624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36ccf0c0a3952ab363fe6ee313fac8f0cce4dd61 Gerrit-Change-Number: 31624 Gerrit-PatchSet: 1 Gerrit-Owner: Joyce Toh <joyce.toh(a)intel.com> Gerrit-MessageType: newchange

4 8

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2019