Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31584 )
Change subject: Revert "src/soc/intel/cannonlake: Add _DSM methods for LPIT table"
......................................................................
Patch Set 3: Code-Review-1
--
To view, visit https://review.coreboot.org/c/coreboot/+/31584
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I090e69e0a20a1cc209c82bae914e1640f7fce90e
Gerrit-Change-Number: 31584
Gerrit-PatchSet: 3
Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Thu, 14 Mar 2019 18:29:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/14921 )
Change subject: libpayload: Fix CONFIG_LP_DEBUG_MALLOC for 64-bit archs
......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/#/c/14921/6/payloads/libpayload/include/stdlib.h
File payloads/libpayload/include/stdlib.h:
https://review.coreboot.org/#/c/14921/6/payloads/libpayload/include/stdlib.…
PS6, Line 97: printf("realloc(%p, %zu) called from %s:%s:%d...\n", __p, __s, \
Prefer using '"%s...", __func__' to using 'realloc', this function's name, in a string
https://review.coreboot.org/#/c/14921/6/payloads/libpayload/include/stdlib.…
PS6, Line 99: printf("PRE realloc\n"); \
Prefer using '"%s...", __func__' to using 'realloc', this function's name, in a string
https://review.coreboot.org/#/c/14921/6/payloads/libpayload/include/stdlib.…
PS6, Line 102: printf("POST realloc (ptr = %p)\n", ptr); \
Prefer using '"%s...", __func__' to using 'realloc', this function's name, in a string
https://review.coreboot.org/#/c/14921/6/payloads/libpayload/libc/malloc.c
File payloads/libpayload/libc/malloc.c:
https://review.coreboot.org/#/c/14921/6/payloads/libpayload/libc/malloc.c@4…
PS6, Line 483: printf(" found memalign region. %u free, %zu required\n", reg->free, (size + align - 1)/align);
line over 96 characters
--
To view, visit https://review.coreboot.org/c/coreboot/+/14921
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib54ebc3cfba99f372690365b78c7ceb372c0bd45
Gerrit-Change-Number: 14921
Gerrit-PatchSet: 6
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org>
Gerrit-Reviewer: Uwe Hermann <uwe(a)hermann-uwe.de>
Gerrit-Reviewer: You-Cheng Syu <youcheng(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 14 Mar 2019 18:29:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hello Patrick Rudolph, AndreX Andraos,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31584
to look at the new patch set (#3).
Change subject: Revert "src/soc/intel/cannonlake: Add _DSM methods for LPIT table"
......................................................................
Revert "src/soc/intel/cannonlake: Add _DSM methods for LPIT table"
This reverts commit 5620b105461cc18cf1439f02013153237f372b4b.
This patch is only to make suspend_stress_test work until the proper
fix for keyboard wake is found and should never be merged.
Change-Id: I090e69e0a20a1cc209c82bae914e1640f7fce90e
---
M src/mainboard/google/sarien/dsdt.asl
D src/soc/intel/cannonlake/acpi/lpit.asl
2 files changed, 0 insertions(+), 79 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/31584/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/31584
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I090e69e0a20a1cc209c82bae914e1640f7fce90e
Gerrit-Change-Number: 31584
Gerrit-PatchSet: 3
Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/14921 )
Change subject: libpayload: Fix CONFIG_LP_DEBUG_MALLOC for 64-bit archs
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/14921/5/payloads/libpayload/include/stdlib.h
File payloads/libpayload/include/stdlib.h:
https://review.coreboot.org/#/c/14921/5/payloads/libpayload/include/stdlib.…
PS5, Line 142: #endif
> one more blank line after #endif?
Done
https://review.coreboot.org/#/c/14921/5/payloads/libpayload/libc/malloc.c
File payloads/libpayload/libc/malloc.c:
https://review.coreboot.org/#/c/14921/5/payloads/libpayload/libc/malloc.c@4…
PS5, Line 483: printf(" found memalign region. %u free, %zu required\n", reg->free, (size + align - 1)/align);
> fix col 80?
That's a pre-existing condition, not related to my patch (also, there's a long string exception).
--
To view, visit https://review.coreboot.org/c/coreboot/+/14921
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib54ebc3cfba99f372690365b78c7ceb372c0bd45
Gerrit-Change-Number: 14921
Gerrit-PatchSet: 5
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org>
Gerrit-Reviewer: Uwe Hermann <uwe(a)hermann-uwe.de>
Gerrit-Reviewer: You-Cheng Syu <youcheng(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 14 Mar 2019 18:29:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org>
Comment-In-Reply-To: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: comment
Hello Aaron Durbin, Philippe Mathieu-Daudé, Uwe Hermann, You-Cheng Syu, Paul Menzel, Hung-Te Lin, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/14921
to look at the new patch set (#6).
Change subject: libpayload: Fix CONFIG_LP_DEBUG_MALLOC for 64-bit archs
......................................................................
libpayload: Fix CONFIG_LP_DEBUG_MALLOC for 64-bit archs
New compilers are a little more stringent about defining the same
prototype more than once, so some of our CONFIG_LP_DEBUG_MALLOC wrappers
don't quite work the way they are written anymore. Also, several of the
printf()s weren't written 64-bit safe. And let's add some
double-evaluation safety while I'm here anyway... and I have no idea why
this ever depended on CONFIG_LP_USB, that just seems like a typo.
Change-Id: Ib54ebc3cfba99f372690365b78c7ceb372c0bd45
Signed-off-by: Julius Werner <jwerner(a)chromium.org>
---
M payloads/libpayload/Kconfig
M payloads/libpayload/include/stdlib.h
M payloads/libpayload/libc/malloc.c
3 files changed, 91 insertions(+), 102 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/14921/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/14921
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib54ebc3cfba99f372690365b78c7ceb372c0bd45
Gerrit-Change-Number: 14921
Gerrit-PatchSet: 6
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org>
Gerrit-Reviewer: Uwe Hermann <uwe(a)hermann-uwe.de>
Gerrit-Reviewer: You-Cheng Syu <youcheng(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29475 )
Change subject: drivers/i2c/nct7802y: Add new hardware-monitoring IC
......................................................................
Patch Set 6:
Thanks for review... and the patience ;)
--
To view, visit https://review.coreboot.org/c/coreboot/+/29475
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I35ea79e12941804e398c6304a08170a776f4ca76
Gerrit-Change-Number: 29475
Gerrit-PatchSet: 6
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 14 Mar 2019 18:26:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hello Angel Pons, Thomas Heijligen, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/29480
to look at the new patch set (#10).
Change subject: [WIP] mb/kontron/bsl6: Add new Skylake COMe module
......................................................................
[WIP] mb/kontron/bsl6: Add new Skylake COMe module
Add Kontron/bSL6 together with Siemens/Boxer26, a baseboard for the
bSL6.
Change-Id: If2b6a3f1e9dd095463f1f1521068b9f66a9189c5
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
A src/mainboard/kontron/bsl6/Kconfig
A src/mainboard/kontron/bsl6/Kconfig.name
A src/mainboard/kontron/bsl6/Makefile.inc
A src/mainboard/kontron/bsl6/acpi/ec.asl
A src/mainboard/kontron/bsl6/acpi/mainboard.asl
A src/mainboard/kontron/bsl6/acpi/superio.asl
A src/mainboard/kontron/bsl6/acpi_tables.c
A src/mainboard/kontron/bsl6/board_info.txt
A src/mainboard/kontron/bsl6/bootblock.c
A src/mainboard/kontron/bsl6/cmos.default
A src/mainboard/kontron/bsl6/cmos.layout
A src/mainboard/kontron/bsl6/dsdt.asl
A src/mainboard/kontron/bsl6/gpio.h
A src/mainboard/kontron/bsl6/ramstage.c
A src/mainboard/kontron/bsl6/romstage.c
A src/mainboard/kontron/bsl6/variant.h
A src/mainboard/kontron/bsl6/variants/boxer26/boxer26_eeprom.h
A src/mainboard/kontron/bsl6/variants/boxer26/devicetree.cb
A src/mainboard/kontron/bsl6/variants/boxer26/gma-mainboard.ads
A src/mainboard/kontron/bsl6/variants/boxer26/romstage.c
A src/mainboard/kontron/bsl6/variants/boxer26/smbios.c
A src/mainboard/kontron/bsl6/variants/bsl6/devicetree.cb
A src/mainboard/kontron/bsl6/variants/bsl6/gma-mainboard.ads
A src/mainboard/kontron/bsl6/variants/bsl6/romstage.c
24 files changed, 1,449 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/29480/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/29480
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If2b6a3f1e9dd095463f1f1521068b9f66a9189c5
Gerrit-Change-Number: 29480
Gerrit-PatchSet: 10
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset