coreboot-gerrit March 2019

coreboot-gerrit@coreboot.org

1 participants
1542 discussions

Change in ...coreboot[master]: sb/{amd,broadcom,nvidia}: Make use of generic set_subsystem()
by Kyösti Mälkki (Code Review) 21 Mar '19

21 Mar '19

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31990 ) Change subject: sb/{amd,broadcom,nvidia}: Make use of generic set_subsystem() ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/31990 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I99b87004ea74a1ad0ec1d6e0c500df11dae4997c Gerrit-Change-Number: 31990 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Mar 2019 16:30:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: sb/intel/{i82801g/i/j,bd82x6x}: Make use of generic set_subsystem()
by Kyösti Mälkki (Code Review) 21 Mar '19

21 Mar '19

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31987 ) Change subject: sb/intel/{i82801g/i/j,bd82x6x}: Make use of generic set_subsystem() ...................................................................... Patch Set 1: (1 comment) Arthur, Patrick; can you verify this on hardware? Subrata; Yes, submitting inside branch out-of-order is never good idea... https://review.coreboot.org/#/c/31987/1/src/southbridge/intel/bd82x6x/pci.c File src/southbridge/intel/bd82x6x/pci.c: https://review.coreboot.org/#/c/31987/1/src/southbridge/intel/bd82x6x/pci.c… PS1, Line 70: This all seems copy-paste error or code that was forgotten on some refactoring. It's pointless to test dev->on_mainboard in code that runs for the integrated PCI-to-PCI device 0:1e.0, and this seems redundant with PCI subsystem calling the same ops->set_subsystem. -- To view, visit https://review.coreboot.org/c/coreboot/+/31987 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7a3eb2e29eb245c0e70abc23c2139aebc07cbfe Gerrit-Change-Number: 31987 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Mar 2019 16:29:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: sb/intel/lynxpoint: Remove PCI bridge function
by Subrata Banik (Code Review) 21 Mar '19

21 Mar '19

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31986 ) Change subject: sb/intel/lynxpoint: Remove PCI bridge function ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/31986 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I954ee9cf8228c6352743cae968a0dd665865496c Gerrit-Change-Number: 31986 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Mar 2019 16:25:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: sb/intel/{i82801g/i/j,bd82x6x}: Make use of generic set_subsystem()
by Subrata Banik (Code Review) 21 Mar '19

21 Mar '19

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31987 ) Change subject: sb/intel/{i82801g/i/j,bd82x6x}: Make use of generic set_subsystem() ...................................................................... Patch Set 1: Tree should get merge to land this CL -- To view, visit https://review.coreboot.org/c/coreboot/+/31987 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7a3eb2e29eb245c0e70abc23c2139aebc07cbfe Gerrit-Change-Number: 31987 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Mar 2019 16:24:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: sb/intel/{i82801g/i/j,bd82x6x}: Make use of generic set_subsystem()
by Subrata Banik (Code Review) 21 Mar '19

21 Mar '19

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31987 ) Change subject: sb/intel/{i82801g/i/j,bd82x6x}: Make use of generic set_subsystem() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/31987 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7a3eb2e29eb245c0e70abc23c2139aebc07cbfe Gerrit-Change-Number: 31987 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Mar 2019 16:24:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: sb/intel/{i82801g/i/j,bd82x6x}: Make use of generic set_subsystem()
by Kyösti Mälkki (Code Review) 21 Mar '19

21 Mar '19

1 0

Change in ...coreboot[master]: sb/intel/lynxpoint: Remove PCI bridge function
by Kyösti Mälkki (Code Review) 21 Mar '19

21 Mar '19

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31986 ) Change subject: sb/intel/lynxpoint: Remove PCI bridge function ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/31986 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I954ee9cf8228c6352743cae968a0dd665865496c Gerrit-Change-Number: 31986 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Comment-Date: Wed, 20 Mar 2019 16:21:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: sdm845: Add GPIO IRQ APIs
by T.Michael Turney (Code Review) 20 Mar '19

20 Mar '19

Hello mturney mturney, Taniya Das, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/30003 to look at the new patch set (#13). Change subject: sdm845: Add GPIO IRQ APIs ...................................................................... sdm845: Add GPIO IRQ APIs Introduces new and required GPIO IRQ APIs in coreboot GPIO driver. Change-Id: I68f34e7bba17d9baad1db2bf025ba2db4afdfb58 Signed-off-by: Taniya Das <tdas(a)codeaurora.org> Signed-off-by: Shefali Jain <shefjain(a)codeaurora.org> --- M src/soc/qualcomm/sdm845/gpio.c M src/soc/qualcomm/sdm845/include/soc/gpio.h 2 files changed, 84 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/30003/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/30003 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I68f34e7bba17d9baad1db2bf025ba2db4afdfb58 Gerrit-Change-Number: 30003 Gerrit-PatchSet: 13 Gerrit-Owner: T.Michael Turney <tturne(a)codeaurora.org> Gerrit-Reviewer: Taniya Das <tdas(a)qualcomm.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: sdm845: Add QCLib to RomStage to perform DDR init
by T.Michael Turney (Code Review) 20 Mar '19

20 Mar '19

Hello mturney mturney, Julius Werner, Paul Menzel, build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/25208 to look at the new patch set (#71). Change subject: sdm845: Add QCLib to RomStage to perform DDR init ...................................................................... sdm845: Add QCLib to RomStage to perform DDR init CB acts as I/O handler for QCLib (e.g. DDR training data) This interface allows bi-directional data flow between CB and QCLib Tested and working interfaces: DDR Training data QCLib serial console output DDR Information (base & size) limits cfg data TEST=build & run Change-Id: I073186674a1a593547d1ee1d15c7cd4fd8ad5bc1 Signed-off-by: T Michael Turney <mturney(a)codeaurora.org> --- M src/mainboard/google/cheza/chromeos.fmd M src/mainboard/google/cheza/romstage.c M src/soc/qualcomm/sdm845/Kconfig M src/soc/qualcomm/sdm845/Makefile.inc M src/soc/qualcomm/sdm845/include/soc/memlayout.ld M src/soc/qualcomm/sdm845/include/soc/mmu.h A src/soc/qualcomm/sdm845/include/soc/qclib.h M src/soc/qualcomm/sdm845/include/soc/symbols.h M src/soc/qualcomm/sdm845/mmu.c A src/soc/qualcomm/sdm845/qclib_execute.c M src/soc/qualcomm/sdm845/soc.c 11 files changed, 460 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/25208/71 -- To view, visit https://review.coreboot.org/c/coreboot/+/25208 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I073186674a1a593547d1ee1d15c7cd4fd8ad5bc1 Gerrit-Change-Number: 25208 Gerrit-PatchSet: 71 Gerrit-Owner: T.Michael Turney <tturne(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: T.Michael Turney <tturne(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: sdm845: Add GPIO IRQ APIs
by build bot (Jenkins) (Code Review) 20 Mar '19

20 Mar '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30003 ) Change subject: sdm845: Add GPIO IRQ APIs ...................................................................... Patch Set 12: (1 comment) https://review.coreboot.org/#/c/30003/12/src/soc/qualcomm/sdm845/gpio.c File src/soc/qualcomm/sdm845/gpio.c: https://review.coreboot.org/#/c/30003/12/src/soc/qualcomm/sdm845/gpio.c@91 PS12, Line 91: << GPIO_INTR_RAW_STATUS_EN_SHIFT); line over 80 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/30003 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I68f34e7bba17d9baad1db2bf025ba2db4afdfb58 Gerrit-Change-Number: 30003 Gerrit-PatchSet: 12 Gerrit-Owner: T.Michael Turney <tturne(a)codeaurora.org> Gerrit-Reviewer: Taniya Das <tdas(a)qualcomm.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 20 Mar 2019 14:07:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2019