Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31992 )
Change subject: soc/intel/broadwell: Fix use of CONFIG_USBDEBUG
......................................................................
Patch Set 1:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31992
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52c852fb449de5a6512aa2556592e6dfe7b0c573
Gerrit-Change-Number: 31992
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)google.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 20 Mar 2019 17:07:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31991 )
Change subject: soc/intel/{baytrail,braswell}: Make use of generic set_subsystem()
......................................................................
Patch Set 1:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31991
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8bf8f8b2ca1836316f84fb7f01820a00d7194d51
Gerrit-Change-Number: 31991
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 20 Mar 2019 17:06:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31841 )
Change subject: Documentation/soc/intel: Add MP Initialization document
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31841/2/Documentation/soc/intel/mp_init/mp_…
File Documentation/soc/intel/mp_init/mp_init.md:
https://review.coreboot.org/#/c/31841/2/Documentation/soc/intel/mp_init/mp_…
PS2, Line 26: Considering about facts we are having
"Considering these facts there are"
--
To view, visit https://review.coreboot.org/c/coreboot/+/31841
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I055808e2ddf03663e1ec5d3d423054d1caa911cb
Gerrit-Change-Number: 31841
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 16:44:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30287 )
Change subject: soc/intel/common: Add Kconfig option to choose desired MP Init for platform
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/#/c/30287/10/src/soc/intel/common/block/cpu/Kco…
File src/soc/intel/common/block/cpu/Kconfig:
https://review.coreboot.org/#/c/30287/10/src/soc/intel/common/block/cpu/Kco…
PS10, Line 58: help
> if we do that then we are limiting users not to select USE_INTEL_FSP_MP_INIT with !FSP2. […]
If this is to be user selectable, you need to add a title to this so it shows up in menuconfig etc. (and user overrides are honored when reading config files).
With that, you can add another line stating "default y if !PLATFORM_USES_FSP2_1" which gives a default that can still be overridden.
https://review.coreboot.org/#/c/30287/10/src/soc/intel/common/block/cpu/Kco…
PS10, Line 68: USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI
that's quite a mouthful and I still don't know what it's supposed to do: install the PPI if this flag is enabled?
--
To view, visit https://review.coreboot.org/c/coreboot/+/30287
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifbea463fdaf97d68c21a759c37f49492d58a056b
Gerrit-Change-Number: 30287
Gerrit-PatchSet: 10
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-CC: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 16:43:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com>
Comment-In-Reply-To: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-MessageType: comment
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30289 )
Change subject: soc/intel/common: Remove common chip config use_fsp_mp_init
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/#/c/30289/11/src/soc/intel/common/block/cpu/mp_…
File src/soc/intel/common/block/cpu/mp_init.c:
https://review.coreboot.org/#/c/30289/11/src/soc/intel/common/block/cpu/mp_…
PS11, Line 141: if (CONFIG(USE_INTEL_FSP_MP_INIT))
I don't think this needs to be a separate function, "USE_INTEL_FSP_MP_INIT" is rather self-explanatory and it's used directly in other places, too.
--
To view, visit https://review.coreboot.org/c/coreboot/+/30289
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ee51276026748e8daf154f89e57095e8fe50280
Gerrit-Change-Number: 30289
Gerrit-PatchSet: 11
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 16:39:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31988 )
Change subject: sb/amd8111: Drop unused code
......................................................................
Patch Set 1:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31988
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b1f46865aa380c2a31e05e55418b27296c72136
Gerrit-Change-Number: 31988
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 20 Mar 2019 16:31:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment