Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31995 )
Change subject: arch/mips: Fix <arch/mmio.h> prototypes
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31995/4/src/arch/mips/include/arch/mmio.h
File src/arch/mips/include/arch/mmio.h:
https://review.coreboot.org/#/c/31995/4/src/arch/mips/include/arch/mmio.h@68
PS4, Line 68: #define write32_x(addr, val) write32((void *)(addr), (val))
> Why not just […]
Wait that needs to be... uhh...
Okay, I give up, you're right about the painful part. ;)
--
To view, visit https://review.coreboot.org/c/coreboot/+/31995
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ide8502ee8cda8995828c77fe1674d8ba6f3aa15f
Gerrit-Change-Number: 31995
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 20 Mar 2019 22:06:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31995 )
Change subject: arch/mips: Fix <arch/mmio.h> prototypes
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/31995/4/src/arch/mips/include/arch/mmio.h
File src/arch/mips/include/arch/mmio.h:
https://review.coreboot.org/#/c/31995/4/src/arch/mips/include/arch/mmio.h@68
PS4, Line 68: #define write32_x(addr, val) write32((void *)(addr), (val))
Why not just
for f in $(find src/soc/imgtec -type f); do sed -i -e 's/\(write\|read\)\(8\|16\|32\)(\([^,]*[,)]\)/\1\2((void *)(\3)/g' $f; done
?
--
To view, visit https://review.coreboot.org/c/coreboot/+/31995
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ide8502ee8cda8995828c77fe1674d8ba6f3aa15f
Gerrit-Change-Number: 31995
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 20 Mar 2019 22:01:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31994 )
Change subject: lib/ramtest.c: Make it a bit more arch-agnostic
......................................................................
Patch Set 3:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31994
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I05734515c0bbd043d489c76cf9cf8b2dbe0ff515
Gerrit-Change-Number: 31994
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 20 Mar 2019 21:52:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31996 )
Change subject: arch/ppc64: Add <arch/mmio.h> stubs
......................................................................
Patch Set 2:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31996
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icdaa0995c8610dcc636923cc79b8455dfaeaa057
Gerrit-Change-Number: 31996
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 20 Mar 2019 21:50:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31995 )
Change subject: arch/mips: Fix <arch/mmio.h> prototypes
......................................................................
Patch Set 4:
Trying to get this in with minimal effort from my side.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31995
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ide8502ee8cda8995828c77fe1674d8ba6f3aa15f
Gerrit-Change-Number: 31995
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 20 Mar 2019 21:49:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29301 )
Change subject: src: Use include <reset.h> when appropriate
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/29301/7/src/southbridge/amd/pi/hudson/early…
File src/southbridge/amd/pi/hudson/early_setup.c:
https://review.coreboot.org/#/c/29301/7/src/southbridge/amd/pi/hudson/early…
PS7, Line 25: #include <Fch/Fch.h>
> Changing order of AMD vendorcode inludes sometimes takes ill effects, please move this back to its o […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/29301
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b852cae4ef84d257bf1e5486447583bdd16b441
Gerrit-Change-Number: 29301
Gerrit-PatchSet: 7
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: York Yang <york.yang(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 21:47:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-MessageType: comment
Hello Patrick Rudolph, Aaron Durbin, Huang Jin, York Yang, Paul Menzel, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, David Guckian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/29301
to look at the new patch set (#8).
Change subject: src: Use include <reset.h> when appropriate
......................................................................
src: Use include <reset.h> when appropriate
Change-Id: I3b852cae4ef84d257bf1e5486447583bdd16b441
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/arch/x86/cf9_reset.c
M src/cpu/amd/family_10h-family_15h/init_cpus.c
M src/cpu/amd/family_10h-family_15h/init_cpus.h
M src/cpu/intel/fsp_model_406dx/bootblock.c
M src/drivers/intel/fsp2_0/stage_cache.c
M src/ec/google/chromeec/ec.c
M src/lib/hardwaremain.c
M src/mainboard/amd/bimini_fam10/romstage.c
M src/mainboard/amd/mahogany_fam10/romstage.c
M src/mainboard/amd/tilapia_fam10/romstage.c
M src/mainboard/asus/m4a78-em/romstage.c
M src/mainboard/asus/m4a785-m/romstage.c
M src/mainboard/gigabyte/ma785gm/romstage.c
M src/mainboard/gigabyte/ma785gmt/romstage.c
M src/mainboard/gigabyte/ma78gm/romstage.c
M src/mainboard/google/foster/pmic.c
M src/mainboard/google/smaug/pmic.c
M src/mainboard/google/veyron/bootblock.c
M src/mainboard/google/veyron_mickey/bootblock.c
M src/mainboard/google/veyron_rialto/bootblock.c
M src/mainboard/hp/dl165_g6_fam10/romstage.c
M src/mainboard/iei/kino-780am2-fam10/romstage.c
M src/mainboard/jetway/pa78vm5/romstage.c
M src/mainboard/msi/ms9652_fam10/romstage.c
M src/mainboard/supermicro/h8dmr_fam10/romstage.c
M src/mainboard/supermicro/h8qme_fam10/romstage.c
M src/mainboard/supermicro/h8scm_fam10/romstage.c
M src/mainboard/tyan/s2912_fam10/romstage.c
M src/security/tpm/tspi/tspi.c
M src/security/vboot/common.c
M src/soc/cavium/common/bdk-coreboot.c
M src/soc/intel/braswell/romstage/romstage.c
M src/soc/intel/common/block/cpu/cpulib.c
M src/soc/intel/fsp_baytrail/bootblock/bootblock.c
M src/soc/intel/skylake/romstage/romstage.c
M src/southbridge/amd/agesa/hudson/early_setup.c
M src/southbridge/amd/pi/hudson/early_setup.c
M src/southbridge/amd/sb700/early_setup.c
M src/southbridge/nvidia/ck804/early_setup_car.c
39 files changed, 24 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/29301/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/29301
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b852cae4ef84d257bf1e5486447583bdd16b441
Gerrit-Change-Number: 29301
Gerrit-PatchSet: 8
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: York Yang <york.yang(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-MessageType: newpatchset
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29301 )
Change subject: src: Use include <reset.h> when appropriate
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/29301/7/src/southbridge/amd/pi/hudson/early…
File src/southbridge/amd/pi/hudson/early_setup.c:
https://review.coreboot.org/#/c/29301/7/src/southbridge/amd/pi/hudson/early…
PS7, Line 25: #include <Fch/Fch.h>
Changing order of AMD vendorcode inludes sometimes takes ill effects, please move this back to its old position.
--
To view, visit https://review.coreboot.org/c/coreboot/+/29301
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b852cae4ef84d257bf1e5486447583bdd16b441
Gerrit-Change-Number: 29301
Gerrit-PatchSet: 7
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: York Yang <york.yang(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 21:32:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29195 )
Change subject: Use standard pci_dev_set_subsystem function where possible
......................................................................
Patch Set 2:
> Patch Set 2:
>
> Follow up in these commits:
>
> * I5fbed39ed448baf11f0e0786ce0ee94741d57237
> * I91982597fdf586ab514bec3d8e4d09f2565fe56d
> * I954ee9cf8228c6352743cae968a0dd665865496c
> * Ia7a3eb2e29eb245c0e70abc23c2139aebc07cbfe
> * I2b1f46865aa380c2a31e05e55418b27296c72136
> * Ie36a87314054d00daed6a63b495bd5f5eabef66e
> * I99b87004ea74a1ad0ec1d6e0c500df11dae4997c
Sorry, I had not come across your work :(
--
To view, visit https://review.coreboot.org/c/coreboot/+/29195
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I90c1ee9ddf8341291ccb82c1f699410c6e9fc104
Gerrit-Change-Number: 29195
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 21:18:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29195 )
Change subject: Use standard pci_dev_set_subsystem function where possible
......................................................................
Patch Set 2:
Follow up in these commits:
* I5fbed39ed448baf11f0e0786ce0ee94741d57237
* I91982597fdf586ab514bec3d8e4d09f2565fe56d
* I954ee9cf8228c6352743cae968a0dd665865496c
* Ia7a3eb2e29eb245c0e70abc23c2139aebc07cbfe
* I2b1f46865aa380c2a31e05e55418b27296c72136
* Ie36a87314054d00daed6a63b495bd5f5eabef66e
* I99b87004ea74a1ad0ec1d6e0c500df11dae4997c
--
To view, visit https://review.coreboot.org/c/coreboot/+/29195
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I90c1ee9ddf8341291ccb82c1f699410c6e9fc104
Gerrit-Change-Number: 29195
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 20 Mar 2019 21:12:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment