Hello Kyösti Mälkki, HAOUAS Elyes, Julius Werner, build bot (Jenkins), Nico Huber,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/32015
to review the following change.
Change subject: Revert "soc/nvidia/tegra{124,210}: Remove unneeded 'include <halt.h>'"
......................................................................
Revert "soc/nvidia/tegra{124,210}: Remove unneeded 'include <halt.h>'"
This reverts commit a9273b5015f1cbcf3fc5db048663147c25c76f83.
Reason for revert: halt.h may be the wrong solution to the problem, but we need a better fix: https://qa.coreboot.org/job/coreboot-gerrit/91169/testReport/junit/(root)/t…
Change-Id: Ibfe77eca75b8f2c2d722d8ca69644ecb00122540
---
M src/soc/nvidia/tegra124/lp0/tegra_lp0_resume.c
M src/soc/nvidia/tegra210/lp0/tegra_lp0_resume.c
2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/32015/1
diff --git a/src/soc/nvidia/tegra124/lp0/tegra_lp0_resume.c b/src/soc/nvidia/tegra124/lp0/tegra_lp0_resume.c
index 7cc3204..4f219e4 100644
--- a/src/soc/nvidia/tegra124/lp0/tegra_lp0_resume.c
+++ b/src/soc/nvidia/tegra124/lp0/tegra_lp0_resume.c
@@ -14,6 +14,7 @@
* GNU General Public License for more details.
*/
+#include <halt.h>
#include <stdint.h>
/* Function unit addresses. */
diff --git a/src/soc/nvidia/tegra210/lp0/tegra_lp0_resume.c b/src/soc/nvidia/tegra210/lp0/tegra_lp0_resume.c
index 51e75f5..ddd1f4f 100644
--- a/src/soc/nvidia/tegra210/lp0/tegra_lp0_resume.c
+++ b/src/soc/nvidia/tegra210/lp0/tegra_lp0_resume.c
@@ -14,6 +14,7 @@
* GNU General Public License for more details.
*/
+#include <halt.h>
#include <stdint.h>
/* Function unit addresses. */
--
To view, visit https://review.coreboot.org/c/coreboot/+/32015
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibfe77eca75b8f2c2d722d8ca69644ecb00122540
Gerrit-Change-Number: 32015
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newchange
Timothy Pearson has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31996 )
Change subject: arch/ppc64: Add <arch/mmio.h> stubs
......................................................................
arch/ppc64: Add <arch/mmio.h> stubs
The work may be incomplete, we only have an emulation
power8 at the moment in the tree.
Change-Id: Icdaa0995c8610dcc636923cc79b8455dfaeaa057
Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/31996
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Timothy Pearson <tpearson(a)raptorengineering.com>
---
A src/arch/ppc64/include/arch/mmio.h
1 file changed, 53 insertions(+), 0 deletions(-)
Approvals:
build bot (Jenkins): Verified
Timothy Pearson: Looks good to me, approved
diff --git a/src/arch/ppc64/include/arch/mmio.h b/src/arch/ppc64/include/arch/mmio.h
new file mode 100644
index 0000000..8ffb816
--- /dev/null
+++ b/src/arch/ppc64/include/arch/mmio.h
@@ -0,0 +1,53 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef __ARCH_MMIO_H__
+#define __ARCH_MMIO_H__
+
+#include <stdint.h>
+
+/* NOTE: These are just stubs; if the architecture requires special
+ * care to avoid posted writes or cachelines, it is not yet done here.
+ */
+
+static inline uint8_t read8(const volatile void *addr)
+{
+ return *(volatile uint8_t *)addr;
+}
+
+static inline uint16_t read16(const volatile void *addr)
+{
+ return *(volatile uint16_t *)addr;
+}
+
+static inline uint32_t read32(const volatile void *addr)
+{
+ return *(volatile uint32_t *)addr;
+}
+
+static inline void write8(volatile void *addr, uint8_t val)
+{
+ *(volatile uint8_t *)addr = val;
+}
+
+static inline void write16(volatile void *addr, uint16_t val)
+{
+ *(volatile uint16_t *)addr = val;
+}
+
+static inline void write32(volatile void *addr, uint32_t val)
+{
+ *(volatile uint32_t *)addr = val;
+}
+
+#endif /* __ARCH_MMIO_H__ */
--
To view, visit https://review.coreboot.org/c/coreboot/+/31996
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icdaa0995c8610dcc636923cc79b8455dfaeaa057
Gerrit-Change-Number: 31996
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Timothy Pearson <tpearson(a)raptorengineering.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-MessageType: merged