HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29301 )
Change subject: src: Use include <reset.h> when appropriate
......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/#/c/29301/13/src/southbridge/nvidia/ck804/early…
File src/southbridge/nvidia/ck804/early_setup_car.c:
https://review.coreboot.org/#/c/29301/13/src/southbridge/nvidia/ck804/early…
PS13, Line 367: do_board_reset
I think that I'm wrong here !
--
To view, visit https://review.coreboot.org/c/coreboot/+/29301
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b852cae4ef84d257bf1e5486447583bdd16b441
Gerrit-Change-Number: 29301
Gerrit-PatchSet: 13
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: York Yang <yyang024(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Comment-Date: Fri, 29 Mar 2019 14:25:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hello Patrick Rudolph, Aaron Durbin, Huang Jin, York Yang, Paul Menzel, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, David Guckian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/29301
to look at the new patch set (#13).
Change subject: src: Use include <reset.h> when appropriate
......................................................................
src: Use include <reset.h> when appropriate
Change-Id: I3b852cae4ef84d257bf1e5486447583bdd16b441
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/arch/x86/cf9_reset.c
M src/cpu/amd/family_10h-family_15h/init_cpus.h
M src/cpu/intel/fsp_model_406dx/bootblock.c
M src/drivers/intel/fsp2_0/stage_cache.c
M src/ec/google/chromeec/ec.c
M src/lib/hardwaremain.c
M src/mainboard/google/foster/pmic.c
M src/mainboard/google/smaug/pmic.c
M src/mainboard/google/veyron/bootblock.c
M src/mainboard/google/veyron_mickey/bootblock.c
M src/mainboard/google/veyron_rialto/bootblock.c
M src/security/tpm/tspi/tspi.c
M src/security/vboot/common.c
M src/soc/cavium/common/bdk-coreboot.c
M src/soc/intel/braswell/romstage/romstage.c
M src/soc/intel/common/block/cpu/cpulib.c
M src/soc/intel/fsp_baytrail/bootblock/bootblock.c
M src/soc/intel/skylake/romstage/romstage.c
M src/southbridge/amd/agesa/hudson/early_setup.c
M src/southbridge/amd/pi/hudson/early_setup.c
M src/southbridge/amd/sb700/early_setup.c
M src/southbridge/nvidia/ck804/early_setup_car.c
22 files changed, 6 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/29301/13
--
To view, visit https://review.coreboot.org/c/coreboot/+/29301
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b852cae4ef84d257bf1e5486447583bdd16b441
Gerrit-Change-Number: 29301
Gerrit-PatchSet: 13
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: York Yang <yyang024(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-MessageType: newpatchset
Hello Patrick Rudolph, Aaron Durbin, Huang Jin, York Yang, Paul Menzel, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, David Guckian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/29301
to look at the new patch set (#12).
Change subject: src: Use include <reset.h> when appropriate
......................................................................
src: Use include <reset.h> when appropriate
Change-Id: I3b852cae4ef84d257bf1e5486447583bdd16b441
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/arch/x86/cf9_reset.c
M src/cpu/amd/family_10h-family_15h/init_cpus.h
M src/cpu/intel/fsp_model_406dx/bootblock.c
M src/drivers/intel/fsp2_0/stage_cache.c
M src/ec/google/chromeec/ec.c
M src/lib/hardwaremain.c
M src/mainboard/google/foster/pmic.c
M src/mainboard/google/smaug/pmic.c
M src/mainboard/google/veyron/bootblock.c
M src/mainboard/google/veyron_mickey/bootblock.c
M src/mainboard/google/veyron_rialto/bootblock.c
M src/security/tpm/tspi/tspi.c
M src/security/vboot/common.c
M src/soc/cavium/common/bdk-coreboot.c
M src/soc/intel/braswell/romstage/romstage.c
M src/soc/intel/common/block/cpu/cpulib.c
M src/soc/intel/fsp_baytrail/bootblock/bootblock.c
M src/soc/intel/skylake/romstage/romstage.c
M src/southbridge/amd/agesa/hudson/early_setup.c
M src/southbridge/amd/pi/hudson/early_setup.c
M src/southbridge/amd/sb700/early_setup.c
21 files changed, 4 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/29301/12
--
To view, visit https://review.coreboot.org/c/coreboot/+/29301
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b852cae4ef84d257bf1e5486447583bdd16b441
Gerrit-Change-Number: 29301
Gerrit-PatchSet: 12
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: York Yang <yyang024(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-MessageType: newpatchset
Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31928 )
Change subject: soc/intel/cannonlake: enable VMX support
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/31928/4/src/soc/intel/cannonlake/cpu.c
File src/soc/intel/cannonlake/cpu.c:
https://review.coreboot.org/#/c/31928/4/src/soc/intel/cannonlake/cpu.c@428
PS4, Line 428: set_vmx_and_lock
> Internally this function is checking for CONFIG(ENABLE_VMX) also so we can skip check of VmxEnable f […]
done
--
To view, visit https://review.coreboot.org/c/coreboot/+/31928
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I33dbffa6301afabd688080751ba3b85a43e00156
Gerrit-Change-Number: 31928
Gerrit-PatchSet: 5
Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: RONAK KANABAR <ronak199323(a)gmail.com>
Gerrit-CC: Thomas Heijligen <src(a)posteo.de>
Gerrit-Comment-Date: Fri, 29 Mar 2019 08:29:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ronak Kanabar <ronak.kanabar(a)intel.com>
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Gerrit-MessageType: comment
Hello Patrick Rudolph, Subrata Banik, Maulik V Vaghela, Rizwan Qureshi, build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31928
to look at the new patch set (#5).
Change subject: soc/intel/cannonlake: enable VMX support
......................................................................
soc/intel/cannonlake: enable VMX support
implement required soc side API to enable VMX support
BUG=b:124518711
Change-Id: I33dbffa6301afabd688080751ba3b85a43e00156
Signed-off-by: Ronak Kanabar <ronak.kanabar(a)intel.com>
---
M src/soc/intel/cannonlake/Makefile.inc
M src/soc/intel/cannonlake/cpu.c
2 files changed, 28 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/31928/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/31928
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I33dbffa6301afabd688080751ba3b85a43e00156
Gerrit-Change-Number: 31928
Gerrit-PatchSet: 5
Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: RONAK KANABAR <ronak199323(a)gmail.com>
Gerrit-CC: Thomas Heijligen <src(a)posteo.de>
Gerrit-MessageType: newpatchset
Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31928 )
Change subject: soc/intel/cannonlake: enable VMX support
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31928/4/src/soc/intel/cannonlake/cpu.c
File src/soc/intel/cannonlake/cpu.c:
https://review.coreboot.org/#/c/31928/4/src/soc/intel/cannonlake/cpu.c@428
PS4, Line 428: set_vmx_and_lock
> Can this be done based on CONFIG(ENABLE_VMX) and get rid of VmxEnable from device tree?
Internally this function is checking for CONFIG(ENABLE_VMX) also so we can skip check of VmxEnable from device tree but we still need to check for VtdDisable.
I pushed a patch to remove VmxEnable from device tree CB:32117 I will change this patch accordingly.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31928
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I33dbffa6301afabd688080751ba3b85a43e00156
Gerrit-Change-Number: 31928
Gerrit-PatchSet: 4
Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: RONAK KANABAR <ronak199323(a)gmail.com>
Gerrit-CC: Thomas Heijligen <src(a)posteo.de>
Gerrit-Comment-Date: Fri, 29 Mar 2019 08:11:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Gerrit-MessageType: comment
Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32088
Change subject: lib/edid.c: Add missing break statement
......................................................................
lib/edid.c: Add missing break statement
This was flagged as CID 1229647 (MISSING_BREAK). It was
originally fixed in e211bd9, but then reverted in 1c8ee21.
Hopefully fix it for good now.
Signed-off-by: Jacob Garber <jgarber1(a)ualberta.ca>
Change-Id: Ib25b07b633ed02c466391050df15eaf9c36a3199
---
M src/lib/edid.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/32088/1
diff --git a/src/lib/edid.c b/src/lib/edid.c
index 5925759..6e8d305 100644
--- a/src/lib/edid.c
+++ b/src/lib/edid.c
@@ -1002,6 +1002,7 @@
break;
case 0xFF:
printk(BIOS_SPEW, "Manufacturer-specific extension block\n");
+ break;
default:
printk(BIOS_SPEW, "Unknown extension block\n");
break;
--
To view, visit https://review.coreboot.org/c/coreboot/+/32088
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib25b07b633ed02c466391050df15eaf9c36a3199
Gerrit-Change-Number: 32088
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber <jgarber1(a)ualberta.ca>
Gerrit-MessageType: newchange
Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32084
Change subject: lib/edid.c: Log an error if unable to find edid or header
......................................................................
lib/edid.c: Log an error if unable to find edid or header
Failure to find an EDID or header is more serious than the spew
log level and should be an error.
Signed-off-by: Jacob Garber <jgarber1(a)ualberta.ca>
Change-Id: I660218f8b5f5e7f0b01daef0739db79418941515
---
M src/lib/edid.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/32084/1
diff --git a/src/lib/edid.c b/src/lib/edid.c
index 5925759..d56099b 100644
--- a/src/lib/edid.c
+++ b/src/lib/edid.c
@@ -1141,14 +1141,14 @@
memset(out, 0, sizeof(*out));
if (!edid) {
- printk(BIOS_SPEW, "No EDID found\n");
+ printk(BIOS_ERR, "No EDID found\n");
return EDID_ABSENT;
}
dump_breakdown(edid);
if (memcmp(edid, "\x00\xFF\xFF\xFF\xFF\xFF\xFF\x00", 8)) {
- printk(BIOS_SPEW, "No header found\n");
+ printk(BIOS_ERR, "No header found\n");
return EDID_ABSENT;
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/32084
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I660218f8b5f5e7f0b01daef0739db79418941515
Gerrit-Change-Number: 32084
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber <jgarber1(a)ualberta.ca>
Gerrit-MessageType: newchange